From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F23CC25B75 for ; Wed, 29 May 2024 14:59:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 454D46B0098; Wed, 29 May 2024 10:59:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 405406B0099; Wed, 29 May 2024 10:59:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2CC506B009A; Wed, 29 May 2024 10:59:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0FA656B0098 for ; Wed, 29 May 2024 10:59:39 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7EDDC80B4A for ; Wed, 29 May 2024 14:59:38 +0000 (UTC) X-FDA: 82171742436.08.45C3199 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf05.hostedemail.com (Postfix) with ESMTP id B1FB2100013 for ; Wed, 29 May 2024 14:59:35 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of mark.rutland@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=mark.rutland@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716994776; a=rsa-sha256; cv=none; b=nKmSIeZ/eibytvg7I9Iiu45OoAyZEDTL7YYgdKNvhDIw6sW571AuNH1oQv6cy1z6+9q1Jb DQqpMiGbN8ygdM4yQuw5x7bNovkWtsQUP+cF90mQrLpxy20QENnP7a+Pi/WRaNkA1pnZXf /C1FmQFBrbchjo/DJO7L9bjBf/85wGI= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of mark.rutland@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=mark.rutland@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716994776; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=84g1txL0h/9rvruIYyGFcCMp0CByBjsxQwaFGq8T2Po=; b=6TxkB6jVeK545Yr7VsUxd5vUyC5nOFKdGgJghZnG67NG+X1D+adALEtAAGeyyeqw+sC47m C4pu3toiF3z+G3LzHtvAk3wC0tou0elAPlWTc0cZOrW2JH/Zaisbg+Vz9QAqKe7fenvaza 5OeYmyz2WCSlpSXsQwsNVr5wqi1iSWA= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7475F339; Wed, 29 May 2024 07:59:58 -0700 (PDT) Received: from J2N7QTR9R3.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BC97F3F762; Wed, 29 May 2024 07:59:31 -0700 (PDT) Date: Wed, 29 May 2024 15:59:13 +0100 From: Mark Rutland To: Barry Song <21cnbao@gmail.com> Cc: Will Deacon , akpm@linux-foundation.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Barry Song , Lance Yang , Ryan Roberts , David Hildenbrand , Jeff Xie , Kefeng Wang , Michal Hocko , Minchan Kim , Muchun Song , Peter Xu , Yang Shi , Yin Fengwei , Zach O'Keefe , Catalin Marinas Subject: Re: [PATCH] mm: arm64: Fix the out-of-bounds issue in contpte_clear_young_dirty_ptes Message-ID: References: <20240524005444.135417-1-21cnbao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B1FB2100013 X-Stat-Signature: ymokte8453kbwg4zfpaai4b51tsftk3n X-HE-Tag: 1716994775-980432 X-HE-Meta: U2FsdGVkX1+9nrsbi3b+pkS19AChFFH0YSzoV0KjF63dk1PpHrKlq0dnSmeiCcrMUTb++Cup9MuMO7AK7L+f4WlQ5WxpTPCaIX/Z1AL6QRgEuHHIFFg/n2qFlatQ2Gllv19hfbr6FhLvXET0MfFPo7mnWdM4N3QtF8IbkF287GuAfHPZHcUwcOHBE8lzf2XzQoxwi7MNzdRekebmmfpN8QBH1JLDtQHJ76LTEUIz/H43v6Ov1dHxYLI6Uunqluj5/TxjQ0NTtOvVkV+ySdJ8b2bCXk5Z2s5AobaHOp/ltyXPV0o6bIIk+Q7Px7s6X8D+j9aWZWwcmYNLn9a92J2bRjWVro7Gohzd3kPtteUiznAYvNyQxQ8WsK3M2Us4B1QtaDH7Sccb7hIDK/gcZJ9U+1qVdPwbcEQ2imcXkrlhn/EBGE//JktZg8oxErF7LyvZg0aJsCtMtkGwGPZO4vn+Gnc3U5aF22r5qZV+Ur8T4qgPfaYNzn3yQtHtiBJEGwW2dDh5Hxbl9SNoClP9qqMWQNopLfQ8hsF4KvfoClJAKV4sH8dNSoNGo8q+rKN0gyNuc3/EZsM9nymrHN88cygfCR3UxVz8E6flsavSZweAMVk/ZMX9wmxTke/fEptaLvsZLA2xOUFm46Xwdp/TqT6vil/cF77XdMYg3HUFF9DmZm9DkIWUwL8+oMQmSvFUNad637VyHcIt8QkNbQfRh7fwf6k0+XwOIWdnJ+eAViC0uyaRCighIRohZsBEOCZzd/2vbWYPrGFwCETvxzkkkmX8p1SfCsHQjJMWLPpwHoJ3oesyfcGSmrARJh0P81n63jOv3qvIfAyC1QSWi4BD126qjeE+Mext5BB3Kma7lZ2GU1WhY/zKL3sl4qVMXYru9MRHF8TEaFtD5BSYJXzaZ4DDMYgfSrvoLkBcwri0Er8NEE1vQiPLiMv7YkDBts6U4Q1jcMpAKEMH64JmzjjJZXo fYpa9SBS H2o1BlS6DkCzQiis8FvmAB/d9phuCv8mz4s6cLQoqpVfBd1GHJ7HoW1Dtzui3mqh241OWvZnfs/eOVl63kWzpA8RCSRrpesG63GOjYRqwRNrceh+DcZvPuf+//wluZVScO78wNwby9JJznzkGHyVjehDIn00SPfDahpvMmx3GBQkOMinap0rP6qdQMDyIgqNCQf2VeV/v3+IjoiZpk+0pndMkA7iVK95CQbPd39rJMDH7wDvqAj1F88pGk3ulDLn1SyaRTEu8ok/EwmEECTIC3CsEzsPcnhl78TwnsZWB+aJqiS+0d1U2/SkHLKXawYr8B/0nX18xpX6h+ZwVHj4EXtw3bs9BkdAPgapopRuK1xqRKJCo/ELkCihtXw0X0wgTwURnbVIwCg9g/lg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 28, 2024 at 08:39:55PM +1200, Barry Song wrote: > On Tue, May 28, 2024 at 8:26 PM Mark Rutland wrote: > > On Fri, May 24, 2024 at 12:54:44PM +1200, Barry Song wrote: > > > From: Barry Song > > > > > > We are passing a huge nr to __clear_young_dirty_ptes() right > > > now. While we should pass the number of pages, we are actually > > > passing CONT_PTE_SIZE. This is causing lots of crashes of > > > MADV_FREE, panic oops could vary everytime. > > > > > > Fixes: 89e86854fb0a ("mm/arm64: override clear_young_dirty_ptes() batch helper") > > > > I was seeing ths same thing on v6.10-rc1 (syzkaller splat and reproducer > > included at the end of the mail). The patch makes sense to me, and fixed the > > splat in testing, so: > > > > Reviewed-by: Mark Rutland > > Tested-by: Mark Rutland > > Thanks! > > > Since this only affects arm64 and is already in mainline, I assume the fix > > should go via the arm64 tree even though the broken commit went via mm. > > Either mm or arm64 is fine with me, but I noticed that Andrew has already > included it in mm-hotfixes-unstable. If it works, we may want to stick with > that. :-) Going via mm is also fine by me, I had just expected it'd be quicker to go via arm64 (and evidently I was wrong there!). :) Mark.