From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DCD9C25B75 for ; Wed, 29 May 2024 10:16:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C86076B00A0; Wed, 29 May 2024 06:16:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C0C216B00A6; Wed, 29 May 2024 06:16:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AAC1D6B00AE; Wed, 29 May 2024 06:16:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8B7FF6B00A0 for ; Wed, 29 May 2024 06:16:03 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5062AA298D for ; Wed, 29 May 2024 10:16:03 +0000 (UTC) X-FDA: 82171027806.13.30A458F Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by imf25.hostedemail.com (Postfix) with ESMTP id 5A4D1A000E for ; Wed, 29 May 2024 10:16:01 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=ZfPt4d8Q; spf=pass (imf25.hostedemail.com: domain of osalvador@suse.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=osalvador@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716977761; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4x27AVMz0iSl17rfIwR6hT5YsDwoPYx2gnD792TvxbI=; b=2d7Pi5XIss6BDQ6RHgb4a5aU5qL7xuvhenveaoC7Tr1cfXeB2OTyfpfxaXFwAk+QN6LtEt tHE76VJYH1/mNhw8RhT4gYhDrIDJQoH6of8cwgFKnElzbDGF48UaSmQwWeAgOhjqQV51DV UfAkxW/QEqBdj+s18vjBGHMcw8AaY8g= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=ZfPt4d8Q; spf=pass (imf25.hostedemail.com: domain of osalvador@suse.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=osalvador@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716977761; a=rsa-sha256; cv=none; b=ljaz5T6Z46sgmBQ5XX1uEhCjhl0ApFce5cfg+Itt/ZtBYaNl7/52ZNXJ8eR/kebLlMuPRJ XjatOGk7ef/7UgUAH+bRjfZdlNhcVty+5ooDmubh+l4ehC9C6JkrSLzoejlI60uUt0zaM4 7R1fe4HzhP2IMwak0HlmTAKNBeBEqe4= Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-421208c97a2so13115305e9.1 for ; Wed, 29 May 2024 03:16:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1716977760; x=1717582560; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from:from:to :cc:subject:date:message-id:reply-to; bh=4x27AVMz0iSl17rfIwR6hT5YsDwoPYx2gnD792TvxbI=; b=ZfPt4d8Qyubwj/QEMAe5NMEsUbRE+d9xZl/2u0pOa48zdy9VMO657u+WOWeGkwf22l A6ziVkqI9fNs65zvjHl0VcJuvz1fzy8toF6hhckd6wsEprM3GZ0OxtESL7oZ0gmPljb6 Zfimh/r21ekzSGfLx1dUOd4J3lTdo1wWC/L4dl3c5BVs0C6tg84Qcd7uzIWOOeNfTJUm Ow/KHzv4sUtck1dkBjTgnk3CNLZkB5Wg2QATXQM7zy9xMxv1rPg1sPCGgimBPHamlgMH Zid/dXM6KMNBuHGXHglCxrTXqWLKY0mEmzCHwMXQHnsdWhdjAElfeczw5L7GFCLMA7pN He/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716977760; x=1717582560; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4x27AVMz0iSl17rfIwR6hT5YsDwoPYx2gnD792TvxbI=; b=mavphCY6RTfbToLZSFhajQO4Bh2rb702dOEAz6x5uhVTPHc2LttseUxdW2B1V2mVY/ feBdOWpOWgnDgOMuiA2qEnTkVXA/QcyN7hzBci926y7/W+ZlB10EBN6awUJhxaB5k6bq 8S218MWGLK60W6m75651xgwPSge1LDxYqVaLqDmeLCzpCO+l5DnmqEW9pS4S+PIvChUv fuazY4+MeZoj4PFjiD7eI0z/iVRc80MlQau2WW3BbKjDOuCDSE0k9vsEmPceWUHNsH3P vos0IrNxoT2r+MbuZzhS68Asx5lsNCyzVMJnmNJCRowvcF0lJnHsKxOV5WIxYXrhpquw MWtg== X-Forwarded-Encrypted: i=1; AJvYcCWCDpUgoP5/9jxit7CqqfEy4Gl1sPIE9FcMX9ZWCdhQEOf4SPODw0Xv88vEbUAJibWj2VtmDtu93X5aqI8IaJrLLj4= X-Gm-Message-State: AOJu0YzDF+hFyzUEAjQjSfiyCnfFF4AHDH3PFBLLCmQK8Uwcw/FHjQHo XRGuDy0s931BJVHnWBxeIXlnfb6m0/FoqIYGTGKm8zerHcw2/TfDb/LJFIaY4jE= X-Google-Smtp-Source: AGHT+IHqM8vBSZQLQX11IaWlIhjemGFoCG5dMTyPcAeygvinoSDY4HDbiRu9hgo9s7sf/V/iTTF9Zw== X-Received: by 2002:a7b:cb16:0:b0:418:e04b:ee63 with SMTP id 5b1f17b1804b1-42108a21421mr117679005e9.36.1716977759946; Wed, 29 May 2024 03:15:59 -0700 (PDT) Received: from localhost.localdomain (62.83.84.125.dyn.user.ono.com. [62.83.84.125]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4211e43e8easm54635895e9.16.2024.05.29.03.15.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 May 2024 03:15:59 -0700 (PDT) From: Oscar Salvador X-Google-Original-From: Oscar Salvador Date: Wed, 29 May 2024 12:15:57 +0200 To: Christophe Leroy Cc: Oscar Salvador , Andrew Morton , Jason Gunthorpe , Peter Xu , Michael Ellerman , Nicholas Piggin , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "linuxppc-dev@lists.ozlabs.org" Subject: Re: [RFC PATCH v4 12/16] powerpc/e500: Encode hugepage size in PTE bits Message-ID: References: <10eae3c6815e3aba5f624af92321948e4684c95a.1716815901.git.christophe.leroy@csgroup.eu> <3cf95f5e-cc8b-4417-a3fa-80dc3b24ac63@csgroup.eu> <3186e950-fbf8-42c4-9eed-9564c8374019@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3186e950-fbf8-42c4-9eed-9564c8374019@csgroup.eu> X-Stat-Signature: zwirk9itmhcbqjfejam1smj1c93xp9u1 X-Rspamd-Queue-Id: 5A4D1A000E X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1716977761-538648 X-HE-Meta: U2FsdGVkX1+L07Eh+EiP3UvLo4N/zyzwy5wN/dy1gJEJIfmMt1b/nvA532inbLxjTI9FqG6Olh/v76YJvlfDHXMRcmgxARTnVkhchOHtkyKAGdxjN2KwDmWNlNdZT6x3G33kGrq52vjhI7TbJlU9gAZ+Afs+xsolHrw6U3Kz/0r6H/GXJSSZZ+nPhHkyEApeFOuMEKRHRpF/JgI42ov8J6yaT+WQd9W4mvTS8uvpSqsuiyj99v2LAVUC4kcSUwyOghVZX+QiTziTAsRbYOSAyClGTRk/l4koGR703z70GM4KGMosCQaHf8VHxHXq0my+CAYtKDmpXd2cHCv1IZm8AWVwH+ACUeu87rOsb2hcG9KsKPU4W81F6qR84Ak9bjZXrUOYJZP9PBURDRKw0xbeSja2qLhzZ8ujV5xnszNeKBs8OFMbT9jeq0UUtKHXavVeBzJjQyRm4f7x4CvFJ9WNkQOd23v+7iuArCu6KKGaDhSuOjwNId8ICQELvUTsEWU4SBHZORFuo1W4wJpWw+wdqP9VWx6xEKNnDfNBnYTDBqsYOypnvdePSFkXnugRpVOAVUNhpHgQSPq1x9x4z3ztIjRX3+ZkY/Y6Vsu2bIkuhIH71qjHg8Z+CCsu4klZNLFdc7i/vEm+HcIirpiFUbLDqurKIjmv5KbV+hJBsyahgfYOOwmo8M1Rv1XofglFwWXqBjqJsPr5VxWNLiikf3aveqBj8bKSCU7K0JyMJfZDUpvIdOWlEYWtjvYk7Q+kRTNDP/rEA0aaqW8bgOEsR0UEihg+CcMWJPsDiM+4cO3vGvlmy+6Xntiv48zAPesdJ9SU20RJk6DBnIhsjz6fLi6zjHonTfkmYf28BXNyIvxx8a6KSldh31rukNBuFCEOA/rTNG2+NwHFA9goHhj/06acurLFvDT1UyS2wjWRnuSBF4GYXcelb8lrfeutV6bPWT4CflH2W+OjOcy4x78dbvT S+AAawBq NR7JomPhWO6FZwh/Rm4l1DW2D0M1z5z/B5UufU+PKL/HcnoXZmy4nk0e7mvwpQDE5Y9fsQ1ymVS1B2OuWqCIC+YSz/4npr7d5EurEujEFuZSh4BIh5dB5hAkfCGAlRBnTKLlV8yk+ZMIJV1hJS0zFUvtvD2/TCyxvbhAI9jo5WL2XImWEnw4fJ+kZQzTDEf+0eKdOaKx4e6m/YgAXze4BDiG/w8tdJ4yv/B6Mv+wxuVsIAV0IbmzWEwhJRfQuGpRkDom6mlzmxoIjrp8ZX04xZEsUyTICvFOmpqhB42VUP4Z/jY/GtfHtjKCI4giIMP4Ps6o9XvvfnD3mb8/G12ZK07rj5fWcE3toyJ0bdHBOMFv0wNkZ04z4Lgm0yw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.001618, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 29, 2024 at 10:14:15AM +0000, Christophe Leroy wrote: > > > Le 29/05/2024 à 12:09, Oscar Salvador a écrit : > > On Wed, May 29, 2024 at 09:49:48AM +0000, Christophe Leroy wrote: > >> Doesn't really matter if it's PUD or PMD at this point. On a 32 bits > >> kernel it will be all PMD while on a 64 bits kernel it is both PMD and PUD. > >> > >> At the time being (as implemented with hugepd), Linux support 4M, 16M, > >> 64M, 256M and 1G (Shifts 22, 24, 26, 28, 30) > >> > >> The hardware supports the following page sizes, and encodes them on 4 > >> bits allthough it is not directly a shift. Maybe it would be better to > >> use that encoding after all: > > > > I think so. > > > >> > >> 0001 4 Kbytes (Shift 12) > >> 0010 16 Kbytes (Shift 14) > >> 0011 64 Kbytes (Shift 16) > >> 0100 256 Kbytes (Shift 18) > >> 0101 1 Mbyte (Shift 20) > >> 0110 4 Mbytes (Shift 22) > >> 0111 16 Mbytes (Shift 24) > >> 1000 64 Mbytes (Shift 26) > >> 1001 256 Mbytes (Shift 28) > >> 1010 1 Gbyte (e500v2 only) (Shift 30) > >> 1011 4 Gbytes (e500v2 only) (Shift 32) > > > > You say hugehages start at 2MB (shift 21), but you say that the smallest hugepage > > Linux support is 4MB (shift 22).? > > > > > > No I say PMD_SIZE is 2MB on e500 with 64 bits PTE and at the time being > Linux powerpc implementation for e500 supports sizes 4M, 16M, 64M, 256M > and 1G. Got it. I got confused. -- Oscar Salvador SUSE Labs