From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 416C2C27C44 for ; Wed, 29 May 2024 10:05:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C9EE16B0098; Wed, 29 May 2024 06:05:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C50126B00A0; Wed, 29 May 2024 06:05:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AEF046B00A1; Wed, 29 May 2024 06:05:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8B3CD6B0098 for ; Wed, 29 May 2024 06:05:28 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id F188DC0721 for ; Wed, 29 May 2024 10:05:27 +0000 (UTC) X-FDA: 82171001094.05.1A73EBB Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by imf04.hostedemail.com (Postfix) with ESMTP id 9679D40017 for ; Wed, 29 May 2024 10:05:25 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=NHyYBNiG; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf04.hostedemail.com: domain of osalvador@suse.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=osalvador@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716977125; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SjBeXRP3NZPNEtnVExWiEQg1GcbJkpp6fTKGUuZKI9Y=; b=fdpTzB6//HFwKHY4nKDj3jfPERemYQ7MSRBS8OJ/EJjblUfak4x5nyZG65pfrqTWG1knlk lxZe7LRGHBzl1ORY6cY8JpuJESXsXgrjGJ7H9oR60jDPeVBwmTMCJiAcN2PBUU27RFPcNX 3abtuus/B0IBQ8QGAtdeYHYBnVEvv9A= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=NHyYBNiG; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf04.hostedemail.com: domain of osalvador@suse.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=osalvador@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716977125; a=rsa-sha256; cv=none; b=MLzox8MTr+/4KuMtVTiAMpzOh6TTE8BLMQEstxMJCgLEeCKMHt417RysQtzegQVK1j3mfM eKMXvqsibQ7fWsGWd/JiLqtEN9CeWwMQ3SAcSFaJRtBMCR8Um+KhiYutVUbV1MhFcOw0Jk N+BZwWl1RwvBEOmeuelYv3MzwGFG/DM= Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-354e0cc9c5cso1631005f8f.0 for ; Wed, 29 May 2024 03:05:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1716977124; x=1717581924; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=SjBeXRP3NZPNEtnVExWiEQg1GcbJkpp6fTKGUuZKI9Y=; b=NHyYBNiGj/dWzcO8mwaEAU0drIm6gYzqQAQhfDILSjw7P8QBXytjrQ9MpXnI+aAc40 /+O7jUE0nN+x4rbo7AdapUpargRmZNzUIMRLa3BGt6QJaukwy9FlZPKKAg0amNOdI+Id KUCyrZjfWF+L3lQeuMUHlKS4szmMqutSYLhowh7I/WKysIP/Pj2JeeVyhZiJag4ZQn1l wEOV+7lKVJSujdp5FSlIAYBKtx15L/W3+5n9NZ/eDmKJp2aiIsT7ITx0m46OHfUZoJd8 +lm+hDfeBA0JCB6rhyK+tfeBl2wkooZt7PxMI4uEfkTNdoYocRl3lWdqo6l8/V4IL2h1 1mAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716977124; x=1717581924; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SjBeXRP3NZPNEtnVExWiEQg1GcbJkpp6fTKGUuZKI9Y=; b=vSTRWhMfcMEJfKF5WsV/iPUT24XWREkPkd8qh4uKqDejE09PWjz9GDEDRFz4tLqJc8 vjrE7JHH2/y/fUGJUMieXQeDoYNJu8C1I7kvaqgBRJFqOAOJLRKCuUNRfm9b62Q7fEAL R+Idhp/dTehAZVdfc6YeIy2BpqhhMR3wvaYypGaDyBcj6PB3Ckibvy862UUUkSK7atCD p5yTlRkr1CA3S7OF/6VvfI0LAWfwiNet1/YaOi4rdLozNMK9o/dwmWLzIrFxjKtWxCyy ZUNfgt1kIJ5XsGTCwi3ioS7YU30BL/2ELBfQREMDxo4ZFJ+CuZ4cyuWIGaV7JA3JlTg3 jTRA== X-Forwarded-Encrypted: i=1; AJvYcCWYF4GKkeXJGV1V60wDUMm2buv/Fl7oHGg37k8zWqfG8fZRBN0cMJSrVll3On/nFACaQe+3dxWFTHOwrc+EBFkaxJs= X-Gm-Message-State: AOJu0YyNMWz8VxDrPwgg5gsJRonz9r7kU9p9ntuSsFa8hXD2L81l9vVL jh2rhwT8kUueNi30dadNwXZPzecKlRavhfj+mJUQud8FOiF5RkN/t11b0/Ls6G8= X-Google-Smtp-Source: AGHT+IEJ9/f6hxMe3hU/z8uaPfO55G1vDC0ZTRYQcECOhnmYBWOWQIQjQ/blRPGbEK5l+LkpPlv2TA== X-Received: by 2002:a5d:4748:0:b0:356:a46b:7369 with SMTP id ffacd0b85a97d-356a46b766bmr8129108f8f.24.1716977123830; Wed, 29 May 2024 03:05:23 -0700 (PDT) Received: from localhost.localdomain (62.83.84.125.dyn.user.ono.com. [62.83.84.125]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35579d7db23sm14697759f8f.23.2024.05.29.03.05.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 May 2024 03:05:23 -0700 (PDT) From: Oscar Salvador X-Google-Original-From: Oscar Salvador Date: Wed, 29 May 2024 12:05:21 +0200 To: Christophe Leroy Cc: Oscar Salvador , Andrew Morton , Jason Gunthorpe , Peter Xu , Michael Ellerman , Nicholas Piggin , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "linuxppc-dev@lists.ozlabs.org" Subject: Re: [RFC PATCH v4 13/16] powerpc/e500: Use contiguous PMD instead of hugepd Message-ID: References: <56cf925576285e2b97550f4f7317183d98d596c5.1716815901.git.christophe.leroy@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 9679D40017 X-Stat-Signature: usj1ytxja4fwp9uuoarf1h9fdnrpubfp X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1716977125-37725 X-HE-Meta: U2FsdGVkX1/CEOpnSyZMaTduEUSHrrVUocd1WTdeG/s4N7brrHLJDKYOB0KshimYAs3M7QD8ZBN16WSRqhrF85f6SDbBV22zYGab7/tppTcRhAp88RIVvhxt9Mqy999db0xNMKoiDHR9eLUip4ljozhrUSR/Gs2sDTmjDzluGKWj9GBffos450D897qDRVDkSONQAnLGckOH4Rebf8s7G6T/0h3R56Kpr+GfjKtY6i1ifIOpUG/IJ9oJkjpfB8lsH8l71kgFVoSDC+N/Z0Ny9F+w9mV6gjui+L0mjbck+1FT9OeACwAnx8FBUhiPLPFlg7YC3SudFULhcbbM7HxWoTTmTZKMnqjiB19PqTnnQIgN6dn1d3AdPJ9fY6qH7z2yzX2BExM3drbwkNZkeX6wsL4HnbGSgdev6LRRxZvp4iVAZQqtYnsnQAWew4se/EKKOU2LWrPLC70RLM6EH7q39gtMDXlUVR9IPCvnWLiAlsetlzxLlA39EcAfLzzbS2P2g/pZKGHX7EKRUME/si8XuswU3aLRTOdRdpmQRpkoR5g4WCZZ/TIbFkMByRO+QkoPXKUL3o20bhyCdmLgEiqz+ix5RKjAwSC5VSat7Ll8ng+6n/Kg23IyL/3f9ImZu68pSWXsYN7UoyBZvbNrtgNH+bvrT8Y8rclOkzWHQfmXYnyD/ivKfWwYnzHkl+XzYL+7o7RCdgECQJM1kValhlRE98H2mxl81fA1Me9F7cQ3nwuPHgx91XE0AS8kh7WNkESdV1sXo8vbD+D4KMlJWH7zbGB2VJL6A7PqEizpZ8ynx3kw6HF8zk3DNX2NlU24enUtIFf/n4SREb728qqo2fZQBv8sKupXFQp2plAiZqfZb68Db4BcM+vj54FLkaGv3DqldT6uqx5Tfd3LJvQL393dU0BSGlk3IussCY//DSvrGW+0s/g258eVMaUXPRaYtIjcCKmEgS568ab437N60Z8 2SIPjNZD q+BTteRpuo+xrihT1McEblTzB138HotPEaYVOabSuP9UEKTc3S5EBC+g3wHLcv5y44tbxREGWNt1xjqs3z11Yr15naheaJKn1nh7kOs71Z6/X/LJhjHuWlmxUGn/TBZ29Rn+8gJ0GLW2HepXzvKgjgeLC2v5tUZAKVd5upX6OvI7V8Y8g+MMTFUL36MzzdLGboen9eFUa7+PRWYMJ5g4wQf+hRAN6y1sxgpa23N9Jd19Fk/cYE6lgBNyRfh6EtRDFjtLy3pLMLzV1I2MT2SS3AYnGVLTZiultCEz32iP7VZuZs8RPS40xliO/Ebp3I2G08UFZnszFcO0Y+0uy6sq+Gll3edmZfcHV8/YH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 29, 2024 at 09:58:35AM +0000, Christophe Leroy wrote: > Yes I now have : > > +#define _PAGE_HSIZE_MSK (_PAGE_U0 | _PAGE_U1 | _PAGE_U2 | _PAGE_U3) > +#define _PAGE_HSIZE_SHIFT 14 > +#define _PAGE_HSIZE_SHIFT_OFFSET 20 > > and have added a helper to avoid doing the calculation at several places: > > +static inline unsigned long pte_huge_size(pte_t pte) > +{ > + pte_basic_t val = pte_val(pte); > + > + return 1UL << (((val & _PAGE_HSIZE_MSK) >> _PAGE_HSIZE_SHIFT) + > _PAGE_HSIZE_SHIFT_OFFSET); > +} Great, this looks much better. > That's what I did before but it didn't work. The problem is that > pte_advance_pfn() takes a long not a long long: > > static inline pte_t pte_advance_pfn(pte_t pte, unsigned long nr) > { > return __pte(pte_val(pte) + (nr << PFN_PTE_SHIFT)); > } > > And when I called it with nr = PMD_SIZE / PAGE_SIZE = 2M / 4k = 512, as > we have PFN_PTE_SHIFT = 24, I got 512 << 24 = 0 Ah, I missed that trickery with the types. Thanks! -- Oscar Salvador SUSE Labs