From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BD66C25B78 for ; Tue, 28 May 2024 23:24:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C48266B009C; Tue, 28 May 2024 19:24:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF7826B00A3; Tue, 28 May 2024 19:24:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ABE7F6B00A4; Tue, 28 May 2024 19:24:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8ECE86B009C for ; Tue, 28 May 2024 19:24:44 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 10B601C11DD for ; Tue, 28 May 2024 23:24:44 +0000 (UTC) X-FDA: 82169386488.17.AA70286 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by imf07.hostedemail.com (Postfix) with ESMTP id 469C740008 for ; Tue, 28 May 2024 23:24:42 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716938682; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oNErHy54A1kjJTi2uYYepudf7mP7OyiGpa/dOsZhLcs=; b=XVlz7qX4w6VZY6EJICjOO2ntf1gVocUHeqy2ClknBpGTAtR0Kgohn0LvU6l7pE/IOVrQ24 W2AmOxcMoahCqd8eZ3wqbrJ2GOo6KMk0SfgNv1QnnN41Lw+Z91biI/56rbXwv7than226P B1vKdg1huQ+PeyOdnxZ3eZichKqvT3w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716938682; a=rsa-sha256; cv=none; b=NFp2OV0JsqLhm4Ycu9Fh1j7Lua5JwLIQ1615CYpqxVMIsWVKMI/lBWjO78hJnzT46sYcjU 30K8nkfi5rQZC6bUFNCG+b4vkIJJVcNv+Jc6xugku5c2x2fYEiqS6cdemHGZR5VhnOzTbW mwCNo6zI6BmxNlT61kxqOl0mk+C3KV4= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-6f8e98784b3so1049068b3a.1 for ; Tue, 28 May 2024 16:24:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716938681; x=1717543481; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oNErHy54A1kjJTi2uYYepudf7mP7OyiGpa/dOsZhLcs=; b=DKx1o/UHPefxPg/A0Ou11HFgm2SxWtHiF2HccgYsxo8aMXkSNsssR/FqQfaKkGLiRf HSpElGwe1K3Y5Ug7G5B1g9P2RbQ8QwWn8A3O272gusmk4v+z8m1jmdsTOF/rgJ4L181o HoM5bmQb3U7KyJx444MxfTPvVNLdyIs7AOB21al5Nl/E7DCINvIxDOYPIub3Jsp14GRP ANvnRE2xIYKTb0oNVCCJgMEAjy5oLC8a30W/R5fNWyAphxWQlcAhgWqvcOPWswDpUm8t ooIQzEA9+ZgzC0cKmewD7LCOjiiWTH0Vb5f5mo0hSgaGpwRXLWjyY2miHXNcl0GkyxL1 kd5Q== X-Forwarded-Encrypted: i=1; AJvYcCV76H8B1af3/7NnPxch+OsvHy9i5vUFHeTeGcauAATnlxyDipY2XTm0F7N5rvp3ujtobUBNnyxq4jG2TJHSVtSN9so= X-Gm-Message-State: AOJu0Yxxw2GLplEPERd5rLlSiRoLCIJJcPMqzHaAMJvkOyDi/9Heo09R T3Fn1/y7iraTjcj6v9heO+43PI/lqU1p/SlXPdN2rbZOZEXn5tDm X-Google-Smtp-Source: AGHT+IG5FFGbsYGzfoXVPflYrCi7X/CC27bTaHSjh0eS+aRDNo+4B1hhCpfDR9wLsmoWZvlCEWVHiA== X-Received: by 2002:a05:6a00:e16:b0:6eb:3d37:ce7a with SMTP id d2e1a72fcca58-6f8f392b718mr13195595b3a.21.1716938681040; Tue, 28 May 2024 16:24:41 -0700 (PDT) Received: from snowbird ([136.25.84.117]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-6822198a705sm8059634a12.36.2024.05.28.16.24.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 May 2024 16:24:40 -0700 (PDT) Date: Tue, 28 May 2024 16:24:37 -0700 From: Dennis Zhou To: Andrew Morton Cc: Mateusz Guzik , tj@kernel.org, hughd@google.com, vbabka@suse.cz, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v4] percpu_counter: add a cmpxchg-based _add_batch variant Message-ID: References: <20240528204257.434817-1-mjguzik@gmail.com> <20240528141929.ba7e59e4cae89eec01631306@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240528141929.ba7e59e4cae89eec01631306@linux-foundation.org> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 469C740008 X-Rspam-User: X-Stat-Signature: 813d9mn98r91j5cenyxr1qitu6czw4ay X-HE-Tag: 1716938682-753990 X-HE-Meta: U2FsdGVkX1+RaPqUiqhU1LDXwwLJ/Idfsfszirp8BoG3umQSLgZpOAXUha/7s5jznWh99GXqYoo0UTd/Wlz3Om298f/BTruRlxbcY+du4NH8X74lvFkGq9V1plFh3h3igDMK+PJyvoq1trA+TuGucRTPjccsEaDU2xyuC59eP3YP5bUIt68MVADcHX+cvJU4VPGnlS89Y8/Ta4fhLy20qYb2snEhlyIUGlavUNM1fgu2lUW5zRgJMLg6E7e4ia96jAX/FgMD7yiegeuWC08Jts8Pq479YgCLyIxkIzYKRCLTK1r1pCKKGDMLFF3HYOnR+Skv05uh1WfsGO8CwJmbJz2HeyHUu4WGsG7hd7n7XN8KnQdbihxPHpPYZfTMLMJXO4wvRNtVNBZPmFbR3yZDLFZhCFxutiChqsmEJDIvUNYiLU4kbeDqEYcNPuishEnyw+oea/RVmZI4r3B/d/NzKBt0JvCjSYU4bnqNIzuXUfcuK+C2yHysIY1y1G7sA7E2VgRh5ULGERbcUfAjH9/pEpmB6q+6XnvL3H9sKNW7EELuQvYgCQqqiHipanyhy82bglTRjS9iEQW2nUOZddnGSpLEDLPV6yUHFc1tzZkARG5YuVrdrca158GZErByKJ/nBCxXU/dhfDpn2uMiDdXZwXElnbBPKpn2gNLJcZ0+UzhYfnU06xXN0y0Vzy+RnG3MbZUjrqJlr/XRt0qzg+PsegTALe+C7UsqxmagtvbMShIi0vRTmsPMmhef7WL//VFujHoLgfSl5YkQLbEeBCvT45/da2b8ddc/FoX6yRqX/zYUYBDlMN2dQ2hUuRyiJmcZeBSYjOgSloNB/asuOWqsO5AIVTgn0H/SYMEFGunifb6+HSu7LLVhzGpqogUq/qPafM/QUv/keq2lHZkZrwGXBw1l7rQJ9FWO1t2DEQEDKwhmFdYZaSNJSKrJ0V0X9XEclRpQKIZsVO8+CoiASUB qLq4QHNa 7eQ1sxlnOmW3g6TKxwtq76dyFZi8/E09q0QnFnZhqiry5iCl9RhVYjhQOXPienKqfTN/J2p+oGdvcPGb00I35HF0Jk7bJPz4tk7pqnpXLqhws+Ltg71SE2lq6k2A3HpvZkW9AtTuA88j4ejPDrv5T9MldfKeKjFDert8oZzEMIFDR8diJvizi9qV3dDz2wyAKiniKeHT8WI2ObKBpwzADESY9WUxsbrvhOMjbW00MJA6hbT5W4WxIYo0+BzQP7DpiMY47QSxyOQkbSjTOOqkxVlbMPj279HjCTmqT69DGoSl6mNESA00K2o4D3skNctqudpqlXwY2+OkJstZUEsx27rwZQGNNhzVGN7o/pvrHX+gLGVfghV/yILuIEs1IErP23Mi7566ypRejiBqY7yHLp4haYukXUJC4GwXEY2gSrfOp7mFaUi2CZ2vADInR6JebAQwLAZYZkLJyQS5QRGz/l0gJkA8orYzD/zmWQdjTNM5yJhXgJ5CvCgFwmWJvL3zB6i3+2fvj+3iodRLJv4SN+wjLBvILDHoKCTrAck1pRdz2kZwaMkTFUD575TtgIplUDr1K X-Bogosity: Ham, tests=bogofilter, spamicity=0.000066, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Andrew, On Tue, May 28, 2024 at 02:19:29PM -0700, Andrew Morton wrote: > On Tue, 28 May 2024 13:56:58 -0700 Dennis Zhou wrote: > > > > EXPORT_SYMBOL(percpu_counter_add_batch); > > > > > > /* > > > -- > > > 2.39.2 > > > > > > > Andrew you picked up the __this_cpu_try_cmpxchg() patches. At this point > > you might as well pick up this too. The cpumask clean ups are likely > > going to give me trouble later this week when I rebase so I'll probably > > have to base my percpuh hotplug branch on your mm-unstable now. > > Well, if it makes more sense to carry these in a different tree, let's > do that. Regarding percpu, I've generally care for that allocator and to varying degrees corresponding libraries for the last 6 years. I usually take them in [1] if I have other stuff to run. The cpumask stuff should not roll up through me, and I think likely you. It's just a little unfortunate in timing as I was planning on respinning the percpu hotplug stuff this week (not 100% sure anything will conflict yet til I do it). Thanks, Dennis [1] https://git.kernel.org/pub/scm/linux/kernel/git/dennis/percpu.git