From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5D34C25B78 for ; Tue, 28 May 2024 22:48:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BBCC46B00BB; Tue, 28 May 2024 18:48:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B6BCF6B00BC; Tue, 28 May 2024 18:48:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A5A376B00BD; Tue, 28 May 2024 18:48:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 893AF6B00BB for ; Tue, 28 May 2024 18:48:06 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3342D14044A for ; Tue, 28 May 2024 22:48:06 +0000 (UTC) X-FDA: 82169294172.19.0E1259E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf10.hostedemail.com (Postfix) with ESMTP id 94D13C000B for ; Tue, 28 May 2024 22:48:02 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="hL2s/v1t"; dmarc=none; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716936483; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Arg3zNJfo7OaVad4zVHjBNkJznEpcaVhGh3Yi10lCXA=; b=mn6ORnQ9S3Kq+y2gsjiu0kCAsn77n69nUPXIAqs/EXP6VaHeVIZDxO8jwenhUkfpJeMrdk 08D4RL2MXgfA/fF8PHuRqWtK0Ftj79ZQ7gY1BYKdxTbuKNffRjMwGFL52trIJWX9Cy7Irl HXfyKcRrKubwMHijZJlCDyhxTmBRvqg= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="hL2s/v1t"; dmarc=none; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716936483; a=rsa-sha256; cv=none; b=mLb8DtUQLCqjP64IyvFwTzPSYMFFZdx3loMfNwo76rUfiE8qkLGbTNV7dhHmyiTZzTpetS gR5F+TI10+7Z/vf1DY/1HDJPGGUHc3hnbiBs0KOWCnb3LCStcg4q+bf37UXIy8gSf0nX32 IKustZB9puKMljFsATC593ia6TATpbU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Arg3zNJfo7OaVad4zVHjBNkJznEpcaVhGh3Yi10lCXA=; b=hL2s/v1tfAtUEo1XUaMmMp9B5B +CWhw1le8tj+XzUWpvv95xY8vyT0m7liz182rkXpnU2U38ulXRMmxaCQVc0roZn1GFBZfmG+A3qlg NuKYpuWn3MoYpjoUdfpXpZnVHNs/MJYz7m3h6+PAPjg8kzCxbLkILxrpy4xjLjwiQn8RA52L+Y683 g4BrnNv5hpAZ2esQhL7jEhcjiYTRlW+NmGXyIgItfuEuTo8usymFyeCLK9xBRBuYcB+r4IIE7Wmp8 kZXmE3HAKkfwg4ocJkKw5LmVfZyDpEq5JVUGlLnVrjveP0VXCnC3eK3C6CBJyz8rMgTqgSBY1HJRM U9M4KUCQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sC5bo-000000099bN-22l4; Tue, 28 May 2024 22:47:56 +0000 Date: Tue, 28 May 2024 23:47:56 +0100 From: Matthew Wilcox To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, vishal.moola@oracle.com, muchun.song@linux.dev, david@redhat.com, osalvador@suse.de Subject: Re: [PATCH] mm/hugetlb: mm/memory_hotplug: use a folio in scan_movable_pages() Message-ID: References: <20240528220321.144535-1-sidhartha.kumar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240528220321.144535-1-sidhartha.kumar@oracle.com> X-Rspamd-Queue-Id: 94D13C000B X-Stat-Signature: cuaczudmmycdxpj5t649m5pzoitu1t38 X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1716936482-513328 X-HE-Meta: U2FsdGVkX1+TL9TjElk20MhUw2QNHwhM861Oy42wuMfGNX/ueuVqBSXwxfYmt94KVvUdRJNxqjRpCVAPA7ezDndvghfVZ3489OwSKBrh2T8VrMhUkwnQDgOtmbPDJDQH2Rg1r9V4fv+7L5AhcH9+HK825Ytx7e8MphCZHRra6IByqFQ30dXETEaRGbjrztCJgWJi3xJtEJe9w2nGIZ08Yba2twpuSafF9manH2q6Ies/+Bzr1oW6HrSqN1wfQnW6nzzfxJ04nd17mBmUBDiqG7B2F+aA6RUDpGWcdHKU8FpKxHLzYcqOAg9XM0GsVaEL0H9Tlybv4cVqO9AAOQMiDRF8UtCYTD1TX5FEarQ7szNJvf9AS/3+ZnVsvkfmUQFuJAW/ZZ56ZkesgMpK9fMIoqFGOjUP9neNmOcwtpg1twYSwgIovrO47f1mNUI+qQAJwcYCWrHrFSnvU87l79NuJpBr8Z4+nRuXSW6kv47AaLMJhCS4bgqoodE0vFxSZ20UDPrLR/GceON+cOg9J73aLcXmoBfgoVczw2E7A9tT6cAOmvN3Eg29Gbe+X5Hi+Si1dec/EzMRy4UdmXJebjHPM1ca30FQ3FS/o/6ue4iH2eUrzVX/1MqSNLNin3IsG8T9BtZwr03KGWFn5UMXGYNvtsMhbbWF2Wkt6bajEz2S5eXJPVR71J5RTTqHl6jE3IBRwrWWsXUDRqL7ZY8XdUlAFkS4nyABYyfew+YpZzi+2tdklmNSeICZMluJcUPnFTAv/3plTL8MktUoCrDddaviualwOrLgo/3HgjD37caznMgvX0Dy2bCSWqGMr5tD0q1BiTeRsAB/15KC8ZV7ILw0Cj55i39aFyXzi5IW1qjy4F0/SiXQIKIMCvokcNP0rqWr516vUZDRWFEB6LiwpofkFL8yByQW1W9gadfDEIOvY2bQmoTt93jE9XHTmr43hYIojFYf+yLyl2zmD2VgNwy BAbWfr6t Xpx9O03ZkykMXFMjz7t8UksD+eKbEmMjTO5slcDWP+Bkx239H2AdlYVLkcTx0uArOrCJmVPY7EFUzFey5EiDAdqIBzcrnYsoj1gzGF5eeMYrKipciLSwc1fIFZ5jrsM3LJ5v9o+6fVXkN0Ek/hZQ9a2tQStoofsjgkoID3txU6tEpXGW+VuoYMJ1fJA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 28, 2024 at 03:03:21PM -0700, Sidhartha Kumar wrote: > @@ -1761,9 +1762,9 @@ static int scan_movable_pages(unsigned long start, unsigned long end, > * cases false positives and negatives are possible. Calling > * code must deal with these scenarios. > */ > - if (HPageMigratable(head)) > + if (folio_test_hugetlb_migratable(folio)) > goto found; > - skip = compound_nr(head) - (pfn - page_to_pfn(head)); > + skip = folio_nr_pages(folio) - folio_page_idx(folio, page); > pfn += skip - 1; Isn't this an unnecessarily complicated way of writing: pfn |= folio_nr_pages(folio) - 1; ?