From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B7AEC25B7C for ; Tue, 28 May 2024 20:37:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 89B096B00A9; Tue, 28 May 2024 16:37:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 84A216B00AA; Tue, 28 May 2024 16:37:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7393A6B00AB; Tue, 28 May 2024 16:37:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 573236B00A9 for ; Tue, 28 May 2024 16:37:09 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0C61540719 for ; Tue, 28 May 2024 20:37:09 +0000 (UTC) X-FDA: 82168964178.11.B495B78 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by imf14.hostedemail.com (Postfix) with ESMTP id 21C49100021 for ; Tue, 28 May 2024 20:37:06 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.216.54 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716928627; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ocGhciDIymjtV72cJYX7TD5dK3LYFKmjLW2hh9YZxCU=; b=Yade8pERlTmO2BPR3Lenzg4NqnOZ9PAyhWbKDZoAGQPJkBALRNTRhXQJ5BvvqSDoPof1aR rFHJKxgHuNhF8O8QGDPxRYhPktyUrFxoR0QXUoGbHC6qi5I/RuJddRiwf2/sIybqddHiza 6X+k0kI5usrWNkKHJnAa8+8N9r6fajM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716928627; a=rsa-sha256; cv=none; b=Sjiw4j54YGBHUOn2Hu6EKcjQ0d0N7dCbp/aFY7h2eyL/e3grHaOyLcIjV8vG8FZ4/DjpiF n6rmGq+6slgeJ0byp9ESRGNkWdVmZHqiqff3cbd1vvKje7rmEZRi8x6eNj2j7V6CuYnUR6 gvB5DAhtacyRecd9VFwSkSzVHJud3Vg= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.216.54 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-2bfc7471028so1048546a91.1 for ; Tue, 28 May 2024 13:37:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716928626; x=1717533426; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ocGhciDIymjtV72cJYX7TD5dK3LYFKmjLW2hh9YZxCU=; b=ctQ5CxQq0xtV0aVqCf7HqJJMwBnWYn1HCRfnzDF04XH6JYJkhA0jPmU6tXWncZ9+8O X49xePcahchWAxOh56qQ8vl1/trrFLliy0HW5w9BH8j6yc07/2y9isEfqO+Gt/3wQMcv jtkZpi8HTq1KX09YtnfKg9Ao4Gps0XqpdPF49aMdg0Lcn4aA5VIQgDfK38eR+eV/iHYb wLe0DuXsRpGAV4TsLV6z18bquMa2NFws4s6YEerOiRbIhchxpzLQ0VrNImzPy1hFMFV0 mxEIwajO6R+k/6ELdkIVbC1WzVNdtmGToqIJ2lzZVkQaPkRXIPocOai0XNpdmbSLiKGk rFfw== X-Forwarded-Encrypted: i=1; AJvYcCWEQk7aznuKko6ZWRYWbci88a0yIKqJZmb6r3oDY5SHpjQ//0b78wTP5g+QGuo5fLeW1bCHyodWIq9ld/Nj6tAcqho= X-Gm-Message-State: AOJu0Yzi9bPPSTKiY8fv5cYrxK5YUKYx5kBaKbZWWwaLACeWCMsjVn3g mcT5q4N8T5nOVNT1okwMfiq7J0o2RDS0D4sVfOMjiOEq4XKOvA3c X-Google-Smtp-Source: AGHT+IGkLYLgbQKRVPQzy0nbn4TlmHHj/65jHN2jLz0MG1BUJjlY4P+swh2Vt91PtfsBBifZf+g61Q== X-Received: by 2002:a17:90b:f89:b0:2bd:92e7:c305 with SMTP id 98e67ed59e1d1-2bf5f10a44bmr13066160a91.21.1716928625840; Tue, 28 May 2024 13:37:05 -0700 (PDT) Received: from snowbird ([136.25.84.117]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2bf5f50c3fdsm8267619a91.18.2024.05.28.13.37.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 May 2024 13:37:05 -0700 (PDT) Date: Tue, 28 May 2024 13:37:02 -0700 From: Dennis Zhou To: Mateusz Guzik , Andrew Morton Cc: oe-lkp@lists.linux.dev, lkp@intel.com, Vlastimil Babka , linux-mm@kvack.org, ltp@lists.linux.it Subject: Re: [dennis-percpu:for-6.11] [percpu_counter] 05dbad003f: ltp.getrusage03.fail Message-ID: References: <202405281421.127ddddf-oliver.sang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 21C49100021 X-Rspam-User: X-Stat-Signature: kxkh89a44688s6wc8ncw49w69uacqduz X-HE-Tag: 1716928626-48187 X-HE-Meta: U2FsdGVkX18KgVd2pZ9tTGdnlBsMX3rB1Mfo7J7JeBUan7GKYDidNKQN4T5MwDsBgqqncpgFUaZ06X0EemhUkQt38bREUYoSRcRePa/xjm2cdkv5d3GTF1l8Suu3JN0kHKrz+OAyJjVPE/gJKMC+YO5legKzWXUskyQpJATU+hMypTh/PjxnKimiQnjJOf8bon+FTdbG2CJslESoVtYpb/rRQIpM2f/PO3wVL+hYdOG3pvtkWDQKwg5iKA/CexDm7olDX9WeL9lpjeB/hLi5aBTKT0oC63GT82ne7ChVjNLqbXahzDqSEajtjOrkIBAqefc0yJAWLJEmwfrnCeh7NnFbCn3Z1H6I/xvK8UgAZrgichVCQLZI8KLH1oVwZJ0iYJpmyycAyelnkmVOPOI3hcjPnWqWoyYMcA7GR9nIjYW1ieaoXASkFS82PyV5a7plQJhPozXh8f4FIsZ5tELozDs6oUwXRoI/d3YMceRqfpHns/DMUP+H/4Qx4K7Fl+8B+TIuYmcxumPqjoVRdFyrwwAvTTNUuk8z3jbHRwb30F9DjcGOYbphPXVVbeUodQIxAHtzIgJGIYOY1TloY2gULT4EMzdB0+SzYcakJm+B7UTuGRZPgiWnHJ1Zq0mjoJrUim11ZK07aIj84jWt2IZfHvi67Yc+9IrLh/3Y1hOU6rhV/VW2j8Mgv7qaNv3W/NIei46RugoYZFXBazjG6te6ok3ERHrVimKtELXASH+epqmUKztvmm+FbTIj3kXCuzd7brwTFflotXNxPVMq7ANWKngb9jHcRepr/oiWDGrEF5ptpq1n6JgbM357/5U699y70FUkqrxFG/RPpXgM/2rRCaaboNhmWEkqic70G41KTPvMv8k9c7Mxap7BGLvxWatFGTryc0/xOkh7MJGBVgrErQDik8QLMnBwPrb3udYlzPppw064925P8nV5VITMjqBju0N8g1laD7Sv8eZZLkY gV2M4za4 t0WHQj2yzioV9kIJWhIt5wRWX5T1Mn/49VVpflFDDpjhjMwHoWeIvF5kaJwwijaFeVvlChMCr/GCJVM5W5To9obm0FfaEB3Fh7oH4A/EtaVCwbA5hPaeoBfSHle4H72GKdsCd68NPh+rG6InPgyMu2KqxDuoGEHHKVIbwQsgOEmfZuuYg4YbrdkhwDyNTBVMEAGWHekpt99vt6U9O383xv5x8JmNBineS+Wvjev3YIwkm0YUGMBMfYFKlNwBFJhNS01Ruqwz0rA7KLBAQuPLIVjpJiWtxZ/RQNh+XCTPOAdC45E/Jk4XYUIKGqI1z2r2VtnULex8SxjRa1DonVtKZk51nRmhTb3siwyYmr77KbATRH/8DcY1oI1GQHO1BfTysHM/ejfUxn/D4OAoDrU2uIKQKuLhHItelJoc8eg6v4AM3ti3zqfPh8FHafknlWHmMt4IJ4AgerA/CfpC74Ri1+a+M+7lthKvqcoW0MvjiVCJKITnAH7QMRn0Sd0M6AktgyYosXQffl0MT8+emz9RoFzCaKCrb6r0KygqhFZP00TmCvqJL+SHnQ2d8yFyNFehChq4nNJlTojeROBrPbKy4PkDZWw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 28, 2024 at 11:05:54AM +0200, Mateusz Guzik wrote: > On Tue, May 28, 2024 at 02:45:35PM +0800, kernel test robot wrote: > > Hello, > > > > kernel test robot noticed "ltp.getrusage03.fail" on: > > > > commit: 05dbad003f2b2ececb1cc7428bfa8f470cc34b95 ("percpu_counter: add a cmpxchg-based _add_batch variant") > > https://git.kernel.org/cgit/linux/kernel/git/dennis/percpu.git for-6.11 > > > > in testcase: ltp > > version: ltp-x86_64-14c1f76-1_20240525 > > with following parameters: > > > > disk: 1HDD > > fs: xfs > > test: syscalls-03/getrusage03 > > > > > > > > Running tests....... > > <<>> > > tag=getrusage03 stime=1716734654 > > cmdline="getrusage03" > > contacts="" > > analysis=exit > > <<>> > > tst_test.c:1733: TINFO: LTP version: 20240524-4-g22004c7db > > tst_test.c:1617: TINFO: Timeout per run is 0h 02m 30s > > getrusage03.c:43: TPASS: initial.self ~= child.self > > getrusage03.c:59: TFAIL: initial.children = 0, expected 102400 > > getrusage03.c:66: TPASS: child.children == 0 > > getrusage03.c:86: TFAIL: child.children = 0, expected 307200 > > getrusage03.c:104: TPASS: initial.children ~= pre_wait.children > > getrusage03.c:114: TFAIL: post_wait.children = 0, expected 409600 > > getrusage03.c:133: TPASS: initial.children ~= after_zombie.children > > getrusage03_child.c:57: TPASS: initial.self ~= exec.self > > getrusage03_child.c:62: TPASS: initial.children ~= exec.children > > > > I confirm this patch broke things, thanks for the report. > > Make sure to sit before you take a look at the fix: > > commit 6e8b4caf667fb6fad1c63b061e303faab6d917ef > Author: Mateusz Guzik > Date: Tue May 28 04:52:10 2024 -0400 > > lol > > diff --git a/lib/percpu_counter.c b/lib/percpu_counter.c > index c3140276bb36..51bc5246986d 100644 > --- a/lib/percpu_counter.c > +++ b/lib/percpu_counter.c > @@ -97,7 +97,7 @@ void percpu_counter_add_batch(struct percpu_counter *fbc, s64 amount, s32 batch) > > count = this_cpu_read(*fbc->counters); > do { > - if (unlikely(abs(count + amount)) >= batch) { > + if (unlikely(abs(count + amount) >= batch)) { > raw_spin_lock_irqsave(&fbc->lock, flags); > /* > * Note: by now we might have migrated to another CPU > > > Dennis, do I need to submit a v4? Given that this is a trivial one line > fixup perhaps it would be handier if you massaged the stuff on your > branch. I'm fine either way. > Well that's awkward.. Can you please send a v4? > That said this really should have been reported by something. That's fair. I think I starred at parenthesis for too long that day so I missed it too. The nice thing is these branches get longer running CI so we can track these things. Thanks, Dennis