From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74705C25B78 for ; Tue, 28 May 2024 18:36:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B6D6E6B008A; Tue, 28 May 2024 14:36:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B1ED76B0092; Tue, 28 May 2024 14:36:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E4256B0095; Tue, 28 May 2024 14:36:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 80C7D6B008A for ; Tue, 28 May 2024 14:36:08 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id ECCF11603F9 for ; Tue, 28 May 2024 18:36:07 +0000 (UTC) X-FDA: 82168659174.30.B717CEA Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by imf27.hostedemail.com (Postfix) with ESMTP id DF0F940007 for ; Tue, 28 May 2024 18:36:04 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fhiTnK2q; spf=pass (imf27.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716921365; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2Meei9ZVa20+5yNphV/wKrB9x+kwpXFk7nEopIQ+RSs=; b=TZ1dRv7IE0wFbELYc+oYYITUQzpq6iq1SuLUSP+9LsIWW4KGfa8AOb5J/1wa6nbrHsokMG C5hp612CCvRotigRR7ninBR6+ItfYYRm/nS55godWWsnFSe6vASEB4bOrGe7wHloUef74+ Qi8tvBt85GBg1TTbvZETOWzVBhViVf0= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fhiTnK2q; spf=pass (imf27.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716921365; a=rsa-sha256; cv=none; b=GST9PF/YCoXPftSqLEPm2KL1Uji36C67707n0lfsVDzFSMOsFxGRa/ug4F6gss+6uBg4yC zsLlBXENg/0XV1emtviNEvDKqUjL2C4GgFZbNxtz9+6alDVSgK4D212YDatkNJBsyRNsQL U5mYzL5h2WXA/XmKnk6rJqt0At+EKIQ= Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-5295c65d3fdso116517e87.0 for ; Tue, 28 May 2024 11:36:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716921363; x=1717526163; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=2Meei9ZVa20+5yNphV/wKrB9x+kwpXFk7nEopIQ+RSs=; b=fhiTnK2quZD65Gp1e5yKIrvOsvO+KG1A9AgOsRI2tLQeItMtv1WuH2qdfsSdiYRH1K 63Bi75XfgX9PPC5JWGClXUUDUIUk/CP+Lza1sjqVWc3lMEODQCs5X7dxGsdT0XvbgU/E JHfDw+IKQ56dngSw9Ss+mRMLxKM3fSVHu0qcca+VMjXE8mhvLZ6z3CjXcc7gFMmYHQ/R n5IjUuSbX1qcB8aXxiS4KsElClFiUQohSr8E4uhAkqadzRHKPWPLLjV7FaYjAt1RLPHS UUXgRebReXIasBdv2M66d7tvQk8thoKUfkoWwOlyEuVDzAKnjZuTBifUl0CNiU2AyCS0 eA0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716921363; x=1717526163; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2Meei9ZVa20+5yNphV/wKrB9x+kwpXFk7nEopIQ+RSs=; b=cndJuEcUjSd/mzaT1POtR3J364dMhYoI9TTin+s6iEgqjaEHlXeEykglyG+RRO73I5 mVExNreYL4M5bGqMz/Cb3NgDUrQNXbzQdT3DWKj5cAMocSLmqXyxK1O9txj8W67lhoop rXv/v0bbDwEE6bipOAYqlwg2w4eVVr/U4aSr83C3EBld1EOZWx8i2MDh+TYXl7M1M37G WTJL0pkP24nFIs86EI/w/XKjPanJzoVXteYjDk/MWujl28eq+MiUWKq+uspk0StKKeUQ hNM/WFbjO6uEk+xfWqWOO6zIlW/w7suzHQrYu7pHGDybATUte6UIa3q0RBSboAnmI6Eg mheA== X-Gm-Message-State: AOJu0Yw4M3X9X/g5AKJqm1QxUxCe372r2Dt/MKLrAdnGGfVxC3S0FQFG +0Kb1rIiEqcXuXcVbpgRZefIJNrpBBtuiv7+nyegn1YGMInD0/6c X-Google-Smtp-Source: AGHT+IFVUefm7Mk6czVp9/GpMy/YUIkaBBT9/L/RHCDAKhAAUwuSnac7GGCBChmy3RuqdnVm8VCXZw== X-Received: by 2002:ac2:4c2d:0:b0:51f:c153:c3e7 with SMTP id 2adb3069b0e04-527ef4f5c29mr5136415e87.12.1716921362881; Tue, 28 May 2024 11:36:02 -0700 (PDT) Received: from pc636 (host-95-193-70-101.mobileonline.telia.com. [95.193.70.101]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-529be969ab2sm160302e87.150.2024.05.28.11.36.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 May 2024 11:36:02 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 28 May 2024 20:36:00 +0200 To: Uros Bizjak Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Dennis Zhou , Tejun Heo , Christoph Lameter Subject: Re: [PATCH v2 2/2] mm/vmalloc: Use __this_cpu_try_cmpxchg() in preload_this_cpu_lock() Message-ID: References: <20240528144345.5980-1-ubizjak@gmail.com> <20240528144345.5980-2-ubizjak@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240528144345.5980-2-ubizjak@gmail.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: DF0F940007 X-Stat-Signature: tajt5qbkyr7dyo7pdxbhsbtqyrexj6xm X-Rspam-User: X-HE-Tag: 1716921364-864407 X-HE-Meta: U2FsdGVkX1/KEhuDefq5wFKH0rGppvFBzuRPT1qO2WKEggcvrdDXHENeAfXOqz4X1+gwacu8WTfejEnMPPVgjAbN+18DmNGpEcQMIws/wSPdJj1bXx6tkPVvs6Q2FxodLY/sDAwlHTJKedBmITYPRTeXB1DYjnZep2r3K20gPJpGsK0S0Aw8p3vWbAtVXuZpBgvQygp6ZRLsYpiFaQRPEdQtwhlcWjFux4ScU8zNRZedsIosS8GbsBjz5SXDtCvtNXHlkmsxoJZMtgJHHMxMTKS64Vq3FdfvR+x8bppuMqIwUN0OlsJyYjqHcCwV6RGqPySNlBQdFfpXW49TxOmLczKRetxkGXQARTz4toFoAJQp+cbQ0BJnzuSDfnZF1vObc1C2vr9991WeNWVEFv9oZSU3lhtq2YSmiKqKUMxTstPj88KE8NcIVPrNJ+SxfJeI5j4sy68Wr3CUvlROWNUdPqcEHKe5q7hLikwKMFnnChxY+odDCslOOhRHiWtpS84eDAZKQxG9L/p3a6Q0C5clYUKdsm8NKJbsSK9MGDjEHs7ggL7nsH1D32LvxlrrSh0s8m6HRtSz5WZTcMwk8hupzhA4pw2cJrpNLSrW3YnaSHFL7p43g6F+t/znJ85Pk2/r1NWoOa1GWc9gV1KqHp9JlzDSfgPjQU417LbyAxAbhvbJyYJqXd0WRHLrRxFHzcFTqtGxkGRDwGohXRrC3iYR5CSGD/ESPbuAo2smOzhkc0FoNEJjvWr/HsSo852c3NeBLq7Xl4+kjmP1RIsP+9+k0o5IyrtWzEqglB3Uj9Lvl6Ybt4wMkLcPkkt1O7AxlSl0t2Y0g2KhCpciczpdMWn3FSbrxgCtvm3St+Arsvunz7n4NIAmB/4ySoulbwX5y2RzFUk6pfOdTajo1Pe1f7EIeWvGu6Sdi6PN+tsjWNvvJZmdQHi4yGRC2+VyhnwqHcjgGWKE1KL5U4Zop/gLPUW jCWoOJ8l FKoLz9SKnd7Bmj216DNxzvgyXIUN7TjqAw9dCUjvDF/chGAzmkJcSGmou4Bs/Q2sutUIop5ZbGgt9fk9CytuM45K2NW3KyLniUjKY5/+SWbFuJM3FYQC7N3cCiroUID10IuLyQL1Kw6HddrdDhjt/Y8vblpO1nI/UIh3H4k/9WxSeWjhEVcsGNaVLuVsPG6aXlsNUaf7pERxje0TggvK16t5Ya+Qjs/aN6WT+6Nj+TgqgI8eZn1WMeP0ZQLIX1FxZ8hJSBSBvpM0yBskgz7/6z4yKHJWZSHMIiGCKVb63+qafhwSanPk5X6AL/X9LLnB4l3Qb2xmevZK1B/uZNuid87n4Z5RpyAYSbxvh56a05yrgyPzQ+9thsJmPZ+GU1xP1wxErCXyYucupU7qOqG7xVE94I9kx7ptCXAGkp1XN2YhjwHSnUDt6204n3EcsHlVLQkaO5fI5dq84wO1DnDCXYCGa6Wtq/ti8/Ljyhh5iahFiEf+G1JSY0ZqKoJtN4EXTgF3y24ZxS+NtZh+xNaLmLtyRFhfvuB1qmH6YvWIFqZAmZLcwfFmnzD9h5ikr6h5kCV1WfUlHb61KiIHRdENRW/AUfpfqlTMZ6w64PAy8aUT+HA88DOWv1CubRj08W1Xm1t8M3myXeL/Alwxw/a3XAVq+yvPv3NoCTwalML94zLE1JByX4iNp8XSInUx9mkO9LCMx2gT1IS7HnRlBmEeR27Zta61bU3hsPGBUiT3oasDTw84= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 28, 2024 at 04:43:14PM +0200, Uros Bizjak wrote: > Use __this_cpu_try_cmpxchg() instead of > __this_cpu_cmpxchg (*ptr, old, new) == old in > preload_this_cpu_lock(). x86 CMPXCHG instruction returns > success in ZF flag, so this change saves a compare after cmpxchg. > > The generated code improves from: > > 4bb6: 48 85 f6 test %rsi,%rsi > 4bb9: 0f 84 10 fa ff ff je 45cf <...> > 4bbf: 4c 89 e8 mov %r13,%rax > 4bc2: 65 48 0f b1 35 00 00 cmpxchg %rsi,%gs:0x0(%rip) > 4bc9: 00 00 > 4bcb: 48 85 c0 test %rax,%rax > 4bce: 0f 84 fb f9 ff ff je 45cf <...> > > to: > > 4bb6: 48 85 f6 test %rsi,%rsi > 4bb9: 0f 84 10 fa ff ff je 45cf <...> > 4bbf: 4c 89 e8 mov %r13,%rax > 4bc2: 65 48 0f b1 35 00 00 cmpxchg %rsi,%gs:0x0(%rip) > 4bc9: 00 00 > 4bcb: 0f 84 fe f9 ff ff je 45cf <...> > > No functional change intended. > > Signed-off-by: Uros Bizjak > Cc: Andrew Morton > Cc: Uladzislau Rezki > Cc: Christoph Hellwig > Cc: Lorenzo Stoakes > Cc: Dennis Zhou > Cc: Tejun Heo > Cc: Christoph Lameter > --- > v2: Show generated code improvement in the commit message. > --- > mm/vmalloc.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 5d3aa2dc88a8..4f34d935d648 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -1816,7 +1816,7 @@ static void free_vmap_area(struct vmap_area *va) > static inline void > preload_this_cpu_lock(spinlock_t *lock, gfp_t gfp_mask, int node) > { > - struct vmap_area *va = NULL; > + struct vmap_area *va = NULL, *tmp; > > /* > * Preload this CPU with one extra vmap_area object. It is used > @@ -1832,7 +1832,8 @@ preload_this_cpu_lock(spinlock_t *lock, gfp_t gfp_mask, int node) > > spin_lock(lock); > > - if (va && __this_cpu_cmpxchg(ne_fit_preload_node, NULL, va)) > + tmp = NULL; > + if (va && !__this_cpu_try_cmpxchg(ne_fit_preload_node, &tmp, va)) > kmem_cache_free(vmap_area_cachep, va); > } > > -- > 2.42.0 > Reviewed-by: Uladzislau Rezki (Sony) Thanks! -- Uladzislau Rezki