From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61B06C25B78 for ; Tue, 28 May 2024 16:50:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D43A66B009B; Tue, 28 May 2024 12:50:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF29B6B009E; Tue, 28 May 2024 12:50:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE1D76B009F; Tue, 28 May 2024 12:50:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 98BBC6B009B for ; Tue, 28 May 2024 12:50:53 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 211DFA2385 for ; Tue, 28 May 2024 16:50:53 +0000 (UTC) X-FDA: 82168393986.11.898CF16 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf16.hostedemail.com (Postfix) with ESMTP id D759E180025 for ; Tue, 28 May 2024 16:50:50 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=eXSHGh1p; dmarc=none; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716915051; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lNjknxnwxTUc0vLbaKhHCJ/HfoVv19mC8Y/io4dSkrM=; b=3MEwFpu6xI4vAa1T9yE0/pm3yjZylLVt5QZZ0VQfCqEgNkWu7G4VCgKjhpvPoyFDO1QImB taeHGBtb3Pa7UnhQ+QJbKfCz4f0KF4oDZjxOk1ZuUrXTTksInS83eFrb5fHE1QPzLg4NRF 8Yz5uCaROakHWh2wMDpc+j4yxwZx5oQ= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=eXSHGh1p; dmarc=none; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716915051; a=rsa-sha256; cv=none; b=zlnNko542YH1Kni4oMGOh+hdxS6sR0FKZNOQtP9zhnPDo2JbbEqc67xyPHDPJQ+C0IoWmi p3plQGnZlD4i9qAmQclnbF5JYekPV5ODzNSpSn5qez685wbBBYJhvgJjP1w1NypwUmdYab 4kimNNQzlhm2m4ULzZwytBgmpaPlizQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=lNjknxnwxTUc0vLbaKhHCJ/HfoVv19mC8Y/io4dSkrM=; b=eXSHGh1pu3Y0oVrjs+ehYMr+Vn 3SNZe7TkBOw8HLw2mwAHG0EhgvKhX9KaJoPbU9WPleYnq6Fl+mdPBuFCoZ4pAft4Iqc/jlUoM9kMs nZHMZIz7/tv2t4U5qe7H7jCDwFSQ6D1aTFv+PsJA0jYvE6j3aM4LK16bZ9lV69cfwgvHT0Kc0bug2 Y+AeBLKIkUZaQzSt47EOX0yicsdNlR92uWYzZjbDA4HfSZpv/xMrpKdOWTzKfu7u70+0MIcpkdRe2 wnozIUyx6q3GVNoQx4MDeGFJP4DUePcnAnDOOCHx7xi1iV3WLelNMb7CKYDEO6VoWGDiW/nrHZSBY fbwEjUXw==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sC028-00000008poX-0yzU; Tue, 28 May 2024 16:50:44 +0000 Date: Tue, 28 May 2024 17:50:44 +0100 From: Matthew Wilcox To: Daniel Gomez Cc: Christoph Hellwig , Trond Myklebust , Anna Schumaker , "linux-nfs@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" Subject: Re: [PATCH 1/2] filemap: Convert generic_perform_write() to support large folios Message-ID: References: <20240527163616.1135968-1-hch@lst.de> <20240527163616.1135968-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D759E180025 X-Stat-Signature: 5d7nehoyxfp11dbsq45pzx1t3w15othf X-HE-Tag: 1716915050-832972 X-HE-Meta: U2FsdGVkX18HT0P7CtUSkDcVBjq3J1mtDNQfyDtXyevUodvnwR9953Kl5Rmk0dw5L95w5ROnjR+V/2pK041uJPBK7PqHTjiKSEhuB2LFjKksoRwbwMSWlBERuHUM8dSM6Yh9thgcRjPD9YvXOzs4MjKJuPtLo76x0OwPvVxsIfjIhLx/7HpeCtJRrB7tz46v+cSTesWIx7XrpIOnzuUWx2ZqSASJdqdWtewk86y30yJN93OvTr5Y//XYMh+CSpC0WM3w5hh/h9puM0zwhbXL4v9G6ypNmm4BHZgiVUIZLzPxjzcAJyOsq428sVAVQi8VvIGyC8GD4YBW1oqd9fl7nlDLZ8eTqnBG/5xAdi3+2W3UoyzAXziWhElZwLmyuoL9mKFxFpTAN4S7dRDTqnTbz0usn6R/Y1wJ7zqxKSNItMJmj+UGi3mXOfP3JXkJgmUs87UXHa9aF7K80tao/TH8xWcTUX0tesZq2igx9Q36tjx1Ab6unY4+pXfH6zbIuoVTN7VNI9Lvqwhhl9xKjqJZ8MoEWlPR00Hh/Pa6SURsHrQz/a59vxy+Q2KMcvT7E1aMfVf97OIvuqnoo6Bgp742jqYwkb51CruTbNb079if4lt0450pJg7OICcJg5AH17S2GqGXW4683i70Mf5hDGR6qx9AFsgWjWnp1bz7w0WKcMKlORRS2ujZWoVkpbv8cXk1xtpCGDZnEC+k+HE/fnqeFnfySLKsaR+aZtcIKQ3P7aCcvWfThDfMITmtjEVhiWlbqLLajoPOD2ag+GEjNV59GrmyS/5v+8NT+6p8E7fIOgdTqHfvgYfPhsGUSJ+Q/+q6tPTl5dLDGuv+6x7TLWymjxLPPUx5aHbMjPL042cDCNdEi2GLjyWVPGLlQ+jMfetmXqqkQQQcAz8mdRDFJ0r2NgC8HK77TJ3wT70srbD10RN2y0FSB4TiwQOKvjMVGvGDTjThvudXycl0shmpNAT 07zbk5J3 WHdb6OdIWD0Y9vOBXOug0FVm1rVLhHVtXjMvs9+yKBQHQYWw4/y7J4Do2M2lxWciUHBxfH6WHkMUiE6KM6EGeU8PHYhdw5QeACxy9kJ5/uJcScYyNVh8l71mEX8qfNMV8h7kAqtTIDzuScBCPIN/UA0JMqG8FLNnLsLxipw1teZ/agsw6PxKNh1WJX/YdLQtdmINdZVGDOJ0MlJzjEgMCczqq7hpV+RInXv91PRXGBBMVSSARhIoRR7xY4Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 28, 2024 at 03:23:39PM +0000, Daniel Gomez wrote: > I have the same patch for shmem and large folios tree. That was the last piece > needed for getting better performance results. However, it is also needed to > support folios in the write_begin() and write_end() callbacks. I don't think it's *needed*. It's nice! But clearly not necessary since Christoph made nfs work without doing that. > In order to avoid > making them local to shmem, how should we do the transition to folios in these > 2 callbacks? I was looking into aops->read_folio approach but what do you think? See the v2 of buffer_write_operations that I just posted. I was waiting for feedback from Christoph on the revised method for passing fsdata around, but I may as well just post a v2 and see what happens.