From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D94DCC25B78 for ; Tue, 28 May 2024 16:24:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A5B36B009C; Tue, 28 May 2024 12:24:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 656BF6B009D; Tue, 28 May 2024 12:24:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51D6E6B009E; Tue, 28 May 2024 12:24:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 314C46B009C for ; Tue, 28 May 2024 12:24:25 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D9E52803C2 for ; Tue, 28 May 2024 16:24:24 +0000 (UTC) X-FDA: 82168327248.01.40F4EF6 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf13.hostedemail.com (Postfix) with ESMTP id BC4C920015 for ; Tue, 28 May 2024 16:24:22 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=P9edovFX; spf=pass (imf13.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716913463; a=rsa-sha256; cv=none; b=kP2DX6zPeIO0SGlgBsHGv3KLEzHLlpANop0WGjkiwoTeMpe3LQXnCyXU4DJFXDeFvA2jS7 Z7pM/RXXST67GLdISD9JdHz/btBsKuaAUR9yYg6BqMv4ijF2xnSxntJOxZ8zYykRSpIhd2 s6cghC2spOq300Vv1IZK3L/x1oWsd0k= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=P9edovFX; spf=pass (imf13.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716913463; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AK3WktvoE0VWm8bEKpsG3BiPJ4hvPKb9mhGoE/jw4os=; b=qEyCXIrZnRw+VKXDNWfXAM8awSAvo0INCw5GPGEM/3dCEUb0KNJ973hyIjqkgdAAgrX/aY yZG6EU1MwlGq4ODNKG+AWeGAadDPhI3x8DTMm0nrhuB7tAEK7eKwBZ/emugjUKpJYS0Eyz VZTDPJDsX1Qncs+8A5QePDoYip+0ezM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 66102CE1396; Tue, 28 May 2024 16:24:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59868C32782; Tue, 28 May 2024 16:24:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716913458; bh=WLd1fNoyV0qscNR0eATu/TrJhszfKjt5pkqMvU46p+0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P9edovFXg1O5HxxFxP/IaPwEyvndQKaY6uMgBqFBhN3ZKXPby5qkEifWAGsQcbd2H +apzK7nJHIIcWckZDrXokE/v6mX1Rw70nrO5Mg6C03i0rpYDSSUt3gYEgc8hAwLuAb YIgH4oJ772W9mPzMDpRfdZTztKWj+/z59vu/4Wz6FOnX4Ceec38RMU3t7pGWGmbmA0 XEEcVBiax+i4QBd80MGEt3Vin+m8B+maJMH6qKGOVDgV7WuwoCN2BvrtE8RSznribB rUI0nii+hcawX5ogIIhUVToklCyE0bN5oAdyyv8BGUjeHZldXd8zVgNa/5kE6xiUCm zhZBExpkKX3LA== Date: Tue, 28 May 2024 19:22:30 +0300 From: Mike Rapoport To: Cong Wang Cc: netdev@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, bpf@vger.kernel.org, Cong Wang , Luis Chamberlain Subject: Re: [Patch v2] vmalloc: check CONFIG_EXECMEM in is_vmalloc_or_module_addr() Message-ID: References: <20240528160838.102223-1-xiyou.wangcong@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240528160838.102223-1-xiyou.wangcong@gmail.com> X-Rspamd-Queue-Id: BC4C920015 X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: fpbhu77amajjgs9ix6rb5hbctnxw3cnt X-HE-Tag: 1716913462-829993 X-HE-Meta: U2FsdGVkX1/gjQlH+Nt/CHeBTYzx5NwMDgRsRe/QysPH2DYIERWt2FZkX2hYVRxRxktx8PxbPCOQN9L2dtznjQAbXm8p/bFtxRynvitDKv3pA2adMzmMYZndqEB/Op0iUOFA+SISGvPb26MKoXlwSuCB3UG/BgrKnSwhBNlCa/lhTIMzaxUlzAH/3BwK0COvi5Ynqju6+Vo63CGbvZlitYNYh1S2WPowphosWFMflzVUrOCS62le/N2WWn6FyxB8J0Ri6eRMtLGCebd1gttrvLct2gQzpGGJ9JpajdC25Ojd+PPNLcMlRCbW6Os5PcW0kBZWuVvrWbLt0AIkjvr5FNls6qkjQJlqwOLhL3zAmXfj8PuzjRKyhWUKbv8q9EStBdvXt+eu54mE9Y/LXsokQ7iQjtjfYiAbaSmVeFd13w2ydrFnC+vagrdW5+UTVz2woqf1IITPvavzVdZ6AvdfHRGbvBT8/RMlh8ZX7CO+6O7Ct4ggSiMAfT48iwb/csv929KLHECeEYOebYJ7aF0kWYoxM9yjWoZ3jl24Lwlem/qvlaajV5n+Iu/Cs8ABz8s2/U6+f/e2qXHB7Tyfk9Sq+HzuL88afIcPOOjxXaimKsimID66dNt9UwpadEHzfnEFkMCGb/A+f/1F9VWoMSdxptnEiir6N7hjQzBn01bHysFYLMvXsgfjJGQIWKlYQsKA/TjwPFxdFKUv4pimkyZpfT1vmeowTWB2Lgt2eiZ8fKlIVN78c/1iQwEDRPPBKy+tSJpGQxPz6QyDBMfLZ6Bp7g9hQD+mo+vXXEUW5bWiazw48CG/IAHgEFgnWRNawpNWtdlPp11oRo4nlB2YSVqG2Ne4lzjuad2D6Vh4/vrCtc1sd1EO6aRSzDUpGyq7jdwOsYVmVnXT8psMDSqnPjO6/nyJXy1qqV6jACb7Yv7X7rl3W4rPtBHWHmYb+xd59gHUfbw+xW4xkTlJPRXZ36j CQ+Kp07Z cUgx4jhy4BxOhXqj2vBMdWtSPyFF5RYbztT9+qA1LKFZjwEJks2gnfnzUny/tZ5ZnBmT/nxMHBycembj2QNweHMCKmf4iL6GL4UbsHAe54gDjxejSnfRNua2y/wSLfqsl6hoi9wbxdTm3Xfe4Lq4DJlzoC42icO1PtCxs+wmvMKgavoaKFT+SHcXfdUF0MEQtYV9OWv+2qBK3emcFSV/X4BU/LsUKax9bB+hapa25r3i5FhM/PYvD0lLSNZm71bI3HCcZcGbIcdjjX7Sddj8en8URjClAaiSK4EMEyDLkD53hgNlDVrxRBojcceu1CeNoW8KASao3ma3g83PdP4RW7K9520V0qjja4WBfmSfWKAdNM5vB8w7Z2djYRcLpgH0TTCjp9maRNz748blWtGaMZ/abuerfUa+e/cbl8Qtc6I6nIrQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 28, 2024 at 09:08:38AM -0700, Cong Wang wrote: > From: Cong Wang > > After commit 2c9e5d4a0082 ("bpf: remove CONFIG_BPF_JIT dependency on CONFIG_MODULES of") > CONFIG_BPF_JIT does not depend on CONFIG_MODULES any more and bpf jit > also uses the [MODULES_VADDR, MODULES_END] memory region. But > is_vmalloc_or_module_addr() still checks CONFIG_MODULES, which then > returns false for a bpf jit memory region when CONFIG_MODULES is not > defined. It leads to the following kernel BUG: ... > Fix this by checking CONFIG_EXECMEM instead. > > Fixes: 2c9e5d4a0082 ("bpf: remove CONFIG_BPF_JIT dependency on CONFIG_MODULES of") > Cc: Luis Chamberlain > Cc: Mike Rapoport (IBM) > Signed-off-by: Cong Wang Acked-by: Mike Rapoport (IBM) > --- > mm/vmalloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 6641be0ca80b..94e1d2dbdec0 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -722,7 +722,7 @@ int is_vmalloc_or_module_addr(const void *x) > * and fall back on vmalloc() if that fails. Others > * just put it in the vmalloc space. > */ > -#if defined(CONFIG_MODULES) && defined(MODULES_VADDR) > +#if defined(CONFIG_EXECMEM) && defined(MODULES_VADDR) > unsigned long addr = (unsigned long)kasan_reset_tag(x); > if (addr >= MODULES_VADDR && addr < MODULES_END) > return 1; > -- > 2.34.1 > > -- Sincerely yours, Mike.