From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D628C25B7C for ; Tue, 28 May 2024 09:45:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E01036B007B; Tue, 28 May 2024 05:45:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D8A366B0082; Tue, 28 May 2024 05:45:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C03746B0083; Tue, 28 May 2024 05:45:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A06D36B007B for ; Tue, 28 May 2024 05:45:22 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E6748120453 for ; Tue, 28 May 2024 09:45:21 +0000 (UTC) X-FDA: 82167321642.17.BF6D8F4 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by imf04.hostedemail.com (Postfix) with ESMTP id EFA0E40003 for ; Tue, 28 May 2024 09:45:19 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=A7DGTHZ2; spf=pass (imf04.hostedemail.com: domain of david@fromorbit.com designates 209.85.215.180 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716889520; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mSaikuAEE1TmRWmTPr+CsdopaGULdY/HVZMAQhbHYwc=; b=76mIM3TL0XQuONFLERzXG6LPLu0KeJCmXkWpuyFE9/pwufIshpeNKzlhT4y8UkqNVSCPSN D5hZ1bTJZNBmIbRZnd5yMIkabwM4ulA3eAq8SaNui6WXuoU+3V6CAHEp4b1fAyFgt8p6kn akpmP69lCayejtVUCCI47zzfU3R+OW8= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=A7DGTHZ2; spf=pass (imf04.hostedemail.com: domain of david@fromorbit.com designates 209.85.215.180 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716889520; a=rsa-sha256; cv=none; b=2qRCxFBqTDgJMg4ZRum2T4ztYYuZ7NRfOyM/yzwtFZzOZDIyTA8T5JjYNKn7uU9KrPBYDk /ZqvYmfKy6OQUcv5FsNg74XyiDFT1h74dcTz+FtZ3ffTT0bQO1pgWK3/cNWLYBa3QMbB2w dNLPYFyb4KKfEb1aztoDCuWS/RTJw4Y= Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-681a48efe77so482821a12.2 for ; Tue, 28 May 2024 02:45:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1716889519; x=1717494319; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mSaikuAEE1TmRWmTPr+CsdopaGULdY/HVZMAQhbHYwc=; b=A7DGTHZ2eNUVA3h7huISXl2ZuPrW3lKGj+AnRyeFgrdjpmRyGBIfMK4uwd3+6S0VUJ QR5BKTaKmQ/M9N2LHvxeUlyAq7ffR2XvZAyMrEFK6ZfZU/hsKW2h1z7p9Jrh4nWTrhlE hFSffKcpCK3yzuo2yMBngyuQ/zv2IrQ6UhZlC+HxC/ras6YVz+m+WTkVnPXqyMpP/sV+ /oZk9rPfgeDz2vLXnrh+o+sWlqeGVIlSJOca3QjsNRHk1frCSBRDjV8Zopxp4VAvz7ut qXQi96JqQOu2ZH4wrsF6jiWPQrz8ued7FgTMfeEOwOIcHfzK8x0CvcGSVtp/zCxUFbsU g7PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716889519; x=1717494319; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mSaikuAEE1TmRWmTPr+CsdopaGULdY/HVZMAQhbHYwc=; b=eBZVJeXbGATIpjK4I9nd03C1vSxEv8n4f5WJg4d5RsemPRfuM8+3g6/HqkS1vGvjQj +YzJW2/ogHkyl8PV+ViQQz2cUbfUUNsru9hS06GzH5Eq/5DhwccP0ePDEtP8uiGjZT47 Weu25NURg7MABcTW+HiTbYgP2Mmuvs1IyBKVkeoHMTz1j11XQMkCT0F3r3PHFfCm9A5G y7XKHobIbKVkGvMmagAmV4EiCzUnuYwDFTd/fQ6WZfAbaigpnad6/ON7EApqLA9ZhcBe RsHQcfkmmNHXHGT3FBzGGzM2hRYINMLNIEepH1qhIQ3G2hwa5bdDKGdaKpcvMzyguvrL UaNQ== X-Forwarded-Encrypted: i=1; AJvYcCW/+LlQSRlVH1vF+jGIOX9AsAKD0TDnG42ix0stZpBwQIqL62zKliaQzMmDFBZ60gHH2iT+x+gyyMHtNaksVirR+6c= X-Gm-Message-State: AOJu0YxZ8gvrICE+ycL9Zuhvu+wj6NU0aVHpfElYzNsfhrb5naBLcJn/ bJbgzIChZmuFlvb9kSJ5Map6CktJoDd2tgGJ/0SbOBCc+3GrxGgj5NucEd3MgYw= X-Google-Smtp-Source: AGHT+IF5RgW5VSoTNNLwvOASd+BGDj5dWiaubF8Oqrmvn2nbTRNTa88hfPX0xKeu1Haa6CBW/oCfgw== X-Received: by 2002:a05:6a20:a10c:b0:1af:d1f3:2cb5 with SMTP id adf61e73a8af0-1b212ce1f49mr14193215637.8.1716889518533; Tue, 28 May 2024 02:45:18 -0700 (PDT) Received: from dread.disaster.area (pa49-179-32-121.pa.nsw.optusnet.com.au. [49.179.32.121]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f44c9d89b3sm75760405ad.292.2024.05.28.02.45.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 May 2024 02:45:18 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1sBtON-00DKcW-0N; Tue, 28 May 2024 19:45:15 +1000 Date: Tue, 28 May 2024 19:45:15 +1000 From: Dave Chinner To: "Pankaj Raghav (Samsung)" Cc: Matthew Wilcox , akpm@linux-foundation.org, djwong@kernel.org, brauner@kernel.org, chandan.babu@oracle.com, hare@suse.de, ritesh.list@gmail.com, john.g.garry@oracle.com, ziy@nvidia.com, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, mcgrof@kernel.org Subject: Re: [PATCH v5.1] fs: Allow fine-grained control of folio sizes Message-ID: References: <20240527210125.1905586-1-willy@infradead.org> <20240527220926.3zh2rv43w7763d2y@quentin> <20240528091202.qevisz7zr6n5ouj7@quentin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240528091202.qevisz7zr6n5ouj7@quentin> X-Stat-Signature: 64y9ziodnrk1ppd9jkcxokfw6d7co94g X-Rspamd-Queue-Id: EFA0E40003 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1716889519-358379 X-HE-Meta: U2FsdGVkX19K3ep+yE6Dd3fSAwEALW16GcWGhMaDPaYCqbK1lGdNrIpxzNVuJR9qmUg2FnhdPflnxTmnCJrcnxUDhEg6RR/SYa+b6JxkZJLPcVnJjrdIY67QcD4TfWZ5wgdll/CXiFsAmeYtUzSYlUVJr80ZDrblOURqlTJvdt+6oCKf1Ou5i9qqyJ7aP+HLHNVxSqmtSdUjv1RbB1mjNlgAGh93uxRp6HuEKXK76Hz7twXpC6JrKXeSmizuMeFHdh1DN09VQ/1xJUKpv77FXA6sj6W4LlgeRZIZsjx5UFuX7t/X1vwePu86AsRZ3/u8gvVv9YQlHanu7XXtYHNzRUXJq/1tV5lJxWxhIxrkWBZyd4YBYoBIJBgIEtfWiECT4Wx09X7a1RaI2NgkpuZoaRmiBIY7iYD2sNuO4fPTITofk9W4hQYqYumYVrHbprTgb/X+ZJLVFzQFb+EA1mptxzvA5REE2G5XHWJTj2YWNrfcgvwmkm8WibxczffPOfvVrzz+2wzW1wrTc6eOe6sPcXi81/2p8BrfyZ6nlHZMpl8qydS9LfvPOiDVYOmA4ZHPnddcJBHagVqk6uOhn9ZeIq6oHz6rB7xomECTbCniCTYqblrZJ/8xX/wl6YwuPyJQbmO6cJNTCk/Qq9+bl81Xnwjb6Od/URsb+ExA2m2qf+VWrSiWuo3qHN/DbKgi1wtS9IdAB+qkXR17nuf/Dmulx88Isza+lvpx2j3K5Dyyc24quc6RAj1QWG1e7gm+cRFxt9+fdSTu2QEpd0yZR/zJA0aqVQfk+GIbXbtXffaKNby2GV5HkcX8NBC1mA4DFxIVgKs4AyEvtxoBIk45wkjhG4vygPntQo58LKAxjd1h/BEHFLSHsToCuW5MbsiRdHvukZOBqNersnKxEw7HDoufe+8dSE747E9gAvM94rfOpBHaKI1p45l33n3GS5B7p7IZ0yw4Skw7nCU760Epuqk uAoy9efA pCbW1BZiQC6TN6aeLRwHjOWnkqNSNPQax1Negrv/zyTw0FcH9RoXaZG6PsyJBU3mvp6el3PSnXAiDieAF8+b6Lp/AVKe4hkD1bTD55sYnRC3WEHMIVDJvofyyt323/SQ0FROd7lk/vb+iFYA8hZSxTbZV2/4p0Lx8i/vClpWjWlqLOTLsnkfmrkYZogUBznKuwczEjPE6xBwhqODyh6pdPm9FS2p63dOMXQM236dMX8pGOBNVFudkjiyxUX1xYeYFglyb3ZpFOhEUicUSz5M34R/J7h5nJpxHUMQtWlpkTLTCMGlz9Rkhlffxa42QiOgrKPNq8WHdiLHdnJD1wCvBOmqMNVFWOYPaYp7QpuRG2r+ibMTCUuuytADtI9lKxGSgkSbC7GMCeocyDESvGQCT5qw1p1mcfJk2INT0tZW1HATzhGhvm45g7f62pnqQQdh9f8IH+NwXSeWJfIjRIhIY7+gvVtwLK+aeOBC9As4Ynb2eyqdqajoh8DjWEH/RFQqUL8hEuFguGv/K98o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 28, 2024 at 09:12:02AM +0000, Pankaj Raghav (Samsung) wrote: > On Tue, May 28, 2024 at 09:00:00AM +1000, Dave Chinner wrote: > > On Mon, May 27, 2024 at 11:43:43PM +0100, Matthew Wilcox wrote: > > > On Mon, May 27, 2024 at 11:39:47PM +0100, Matthew Wilcox wrote: > > > > > > + AS_FOLIO_ORDER_MIN = 16, > > > > > > + AS_FOLIO_ORDER_MAX = 21, /* Bits 16-25 are used for FOLIO_ORDER */ > > > > > > }; > > > > > > > > > > > > +#define AS_FOLIO_ORDER_MIN_MASK 0x001f0000 > > > > > > +#define AS_FOLIO_ORDER_MAX_MASK 0x03e00000 > > > > > > > > > > As you changed the mapping flag offset, these masks also needs to be > > > > > changed accordingly. > > > > > > > > That's why I did change them? > > > > > > How about: > > > > > > -#define AS_FOLIO_ORDER_MIN_MASK 0x001f0000 > > > -#define AS_FOLIO_ORDER_MAX_MASK 0x03e00000 > > > +#define AS_FOLIO_ORDER_MIN_MASK (31 << AS_FOLIO_ORDER_MIN) > > > +#define AS_FOLIO_ORDER_MAX_MASK (31 << AS_FOLIO_ORDER_MAX) > > > > Lots of magic numbers based on the order having only having 5 bits > > of resolution. Removing that magic looks like this: > > > > AS_FOLIO_ORDER_BITS = 5, > > I think this needs to be defined outside of the enum as 5 is already > taken by AS_NO_WRITEBACK_TAGS? But I like the idea of making it generic > like this. Duplicate values in assigned enums are legal and fairly common. This: enum { FOO = 1, BAR = 2, BAZ = 1, }; int main(int argc, char *argv[]) { printf("foo %d, bar %d, baz %d\n", FOO, BAR, BAZ); } compiles without warnings or errors and gives the output: foo 1, bar 2, baz 1 -Dave. -- Dave Chinner david@fromorbit.com