From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 697AFC25B74 for ; Mon, 27 May 2024 23:00:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D55806B0089; Mon, 27 May 2024 19:00:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D03F66B0088; Mon, 27 May 2024 19:00:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BCC306B0089; Mon, 27 May 2024 19:00:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9FDF06B0083 for ; Mon, 27 May 2024 19:00:07 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 161AC1A1552 for ; Mon, 27 May 2024 23:00:07 +0000 (UTC) X-FDA: 82165695654.14.29CD877 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by imf07.hostedemail.com (Postfix) with ESMTP id 13B6940015 for ; Mon, 27 May 2024 23:00:04 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=JU+GI85Z; spf=pass (imf07.hostedemail.com: domain of david@fromorbit.com designates 209.85.215.180 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716850805; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mper/xMT5Q3IYA66Il/PWwArXhSI6HTMaJh9R/qoXig=; b=MRa6rw1/Z/WDW3mUdodX/GivWkQf+SzS964eat6qKcuksMVWJeY1A/PVicAvVL1GTnCd1P B7m0pZuxzTTsDSSgmXiqzyoHUW3xqc6aLtMXzsLFesU19MpnZaBmpRs1MhuRAnaBQdB4VN IDBplO7ajpWe5tJa+2sldDNqxlL5wFc= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=JU+GI85Z; spf=pass (imf07.hostedemail.com: domain of david@fromorbit.com designates 209.85.215.180 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716850805; a=rsa-sha256; cv=none; b=moSkjPV0pVS9Qirjj1tsOk9exgT1Ku23yyfPA5onIG46+s4ri4435M4iwCYBNzBUZinmLz hkQP2OiQtDo/t81oflcwe4e1NvWcY+HDf4V2eQgpGUR8gfR7nRiIM980wyM4Os2m41jT/Y 5Kfe92GFLTwKfamGHdm4z3m6dRyVGRQ= Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-681ad081695so206254a12.3 for ; Mon, 27 May 2024 16:00:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1716850804; x=1717455604; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mper/xMT5Q3IYA66Il/PWwArXhSI6HTMaJh9R/qoXig=; b=JU+GI85Z/eGGsnvrTlyd6Hn4wuPLskXoo8dqdbgJJsJ1UMCtlfuy/+I15l3hVOCm86 R0QkQFY2q3udH+6wIKqvzQq9dDgQL7vf7Wmbfcc5Nlrse7To8mExHvTe2foAycSwWRpu WuI3oITRWhJlBHl/V3kS85aGR6GwMF016n+nssUWuyZ/nOpv0KbOJ2Soz3eS+dDUZ2RO zMR9zcVOeRbzJiq17+K/p9KuUEfg84VAckq3rRprbZtCa41tor91Zw7ZpOglIE40oQM3 9lDRaoRT8pmPg5x1RmPCxdzbIFsukaHvPCOTYMJ70caDNXyS/WZL6Xb1PxiIBEadBp67 5dBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716850804; x=1717455604; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mper/xMT5Q3IYA66Il/PWwArXhSI6HTMaJh9R/qoXig=; b=hDUhNf6GlYc7SWl/vv55OWJhtgH/DoaZzJmHblHDDjw+j+qnuGW1/QtJJoKK0xErFC P4K4MrSKFvEitQ7HtF3IYUlf5sFR6cDEq8mUh3/P0THYQ8iSDd0N9iBryCJl8D9oRBjy ZX0CyAq8z6uYa5JNWww/Ke7EQiweiSrBMFvGe6p9xlK4R6f6efHjaN0UcfS+GSb0fw+X ul/UWB2AWAvtsJX388br9P3Sz1SgS2AcbnJmqsjesWwoLdeuyg/MmGWeD3jigEGxgCrP tFQom7heUDShUE36q2GFE9435amPhCKNwlnTiWdF6NjaFR6yc5NpCQ5fAfoIpHXMhF7l h5VA== X-Forwarded-Encrypted: i=1; AJvYcCVrRsQCLC5eEanlSoXpdAZMvpF2R0yw+3n16BN+/l6R6JiIuzXP/DSf05xbGMgz9yQBdXXeMMszoHp+ObBUNQLzYyg= X-Gm-Message-State: AOJu0YzRwCM3gd08TSixkS+jXeqxGwuU8xsgqSzis9pgeHbIXk7TP8lX Ye1Yu8RgHXWT2EPqVu0xj6nDBTDcv4OnvCiBDhR1xgPI6jRn7NoWelSWsP1lh90= X-Google-Smtp-Source: AGHT+IEBodEV0O3WOFxNjrc1u53pF65Ap/xAuIzuYtY1hdwU+UtlwfxMKYh27HDGJMMdTKbqi8t8ng== X-Received: by 2002:a17:90a:c586:b0:2bf:fd73:1494 with SMTP id 98e67ed59e1d1-2bffd731533mr1282947a91.14.1716850803550; Mon, 27 May 2024 16:00:03 -0700 (PDT) Received: from dread.disaster.area (pa49-179-32-121.pa.nsw.optusnet.com.au. [49.179.32.121]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2bf5f9b8144sm6337308a91.55.2024.05.27.16.00.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 May 2024 16:00:03 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1sBjJw-00CoWT-1R; Tue, 28 May 2024 09:00:00 +1000 Date: Tue, 28 May 2024 09:00:00 +1000 From: Dave Chinner To: Matthew Wilcox Cc: "Pankaj Raghav (Samsung)" , akpm@linux-foundation.org, djwong@kernel.org, brauner@kernel.org, chandan.babu@oracle.com, hare@suse.de, ritesh.list@gmail.com, john.g.garry@oracle.com, ziy@nvidia.com, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, mcgrof@kernel.org Subject: Re: [PATCH v5.1] fs: Allow fine-grained control of folio sizes Message-ID: References: <20240527210125.1905586-1-willy@infradead.org> <20240527220926.3zh2rv43w7763d2y@quentin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: bsqumw7tma6kmgdin8yrw8jee64c69yg X-Rspamd-Queue-Id: 13B6940015 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1716850804-483527 X-HE-Meta: U2FsdGVkX18G3DQFDAYoho2phsIsXWBHfP8ED5YO1ycylefP5t4D9/w8ure01LwfsoE17Nmp9aJ+OIyyaHXh8NZA1W9qh+hqpdq4au8iPtmoULymAmOHklG+6fu2Dk1CrQSttW9es/wXNY6Q7axY0ufkFNiP4qSF4wbAGKh87qqRthiTg0taB/Q9EOEZlm1qfjOgTAxxhehMclpNR2WNKNM4hlD95+w/tiXgUI82nV/n2rCC8Nyk/3mqIiwp+KaZpN5tzuC0fupQNvtMY8nxanc5Cg+MLhS2rb/vHdgmY5j0bZHeEB+OnJ3IkHyEF0J6MbELdQIkB7Pfkb71A2EKOBAUtDD5l7JTPESULSFXS02haqocgiT1A65PamCbHbgl7sw4NVzZj6zebhZNSRsdS/dfspd2lA6By6P6iK0iOzrZHqBZ+HW6V0gOSomrO6ewo+aH//O46DsH8p9ygU+jHW4EouVczHraey1xzgaZ2MCMrYWE/qXcHyjKiPi2Bj1jejVDW2LecS0lsjs/bzQemWoLAt8BIECvabV6IPmblxJC2CTGuV3h3n7OHuod5FxwGTrtwKZbDpViqO9EtObGVUTFC3AdMYdAx38sox1ZR+XoQ+/x/fqHOweg+W4yIwnOUw6Voz3Ysh/zzekOi2SrykuDlFJb7d94pP0poE77XThJdMWyghuMUKoAgh0H+7pcrCBs7t5SAUJMw8LBOiS8zHsXqUGJ6rMCD99890gNOqggrs/MCQPeARyUjmVdkxXgQk8MGDXi8s79dd/SFlBSXn3TQbnoRhnv/FGT67vXBGcg+wJvZrwKWaVibXTzSHOjbovHhQ1CcUBTrs52TD1jOVoKjgRai5VwiD8G3czYna85wyxXwwdjTcv31y1MlHpFfFPyUq1PdfseDCZ0RApzNkAURnuUXXxKJesKISAq5coFg9Quf78m35Zlu6ivhHBeEyz1G/HmFuzHysJ9Guq EC41CTcO 3S87msM+E4LrfQRfaV2zDQXNXvpTluNIjOQd5/AWAQTFCpqXRuS9Ny+mBv5RhcD8M2iZ7tp7H32MRFt5Hix5H41gDIhf0PWx1RVO1KFhRkr9hmtKN+X3PLYx7Fju1AOxMMgWJODtgoJhy8j1P0bbQYdohXdPVR+6qfwlo+nDAoCii9XtHFfdw6/4JTx2e8P21zUrUCFWjtAAm7d+rKUZ+RZ1bXnJlsTZ7y2fPuD4v62pE3cD05/VyjOZtLCccPT4yC+3yHcR60eAc8empAZZnuqXM1AgGOJmP5kJsKhkSprlpdkPyfWJhPt8pt1DGaREaS7m5TzoycsJitRW3J92GBwp+WktEGlPaIsKz/PsF0TOlJajvGRwNkyt5fvSClq+nFeEFHyjy7pLv3wF6KboIwtx05DKj7cGwLBzKQyBpOZpWUUzoO7zppOUK4ZlLvHUYyLS0vIR0jx7QER43dy7x9/AMIjA/LLGKmkIrkHq0HUDf9qrUUH5Z1tmsxr1ttgdXZ820Ib6zTGTnw1I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.013398, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 27, 2024 at 11:43:43PM +0100, Matthew Wilcox wrote: > On Mon, May 27, 2024 at 11:39:47PM +0100, Matthew Wilcox wrote: > > > > + AS_FOLIO_ORDER_MIN = 16, > > > > + AS_FOLIO_ORDER_MAX = 21, /* Bits 16-25 are used for FOLIO_ORDER */ > > > > }; > > > > > > > > +#define AS_FOLIO_ORDER_MIN_MASK 0x001f0000 > > > > +#define AS_FOLIO_ORDER_MAX_MASK 0x03e00000 > > > > > > As you changed the mapping flag offset, these masks also needs to be > > > changed accordingly. > > > > That's why I did change them? > > How about: > > -#define AS_FOLIO_ORDER_MIN_MASK 0x001f0000 > -#define AS_FOLIO_ORDER_MAX_MASK 0x03e00000 > +#define AS_FOLIO_ORDER_MIN_MASK (31 << AS_FOLIO_ORDER_MIN) > +#define AS_FOLIO_ORDER_MAX_MASK (31 << AS_FOLIO_ORDER_MAX) Lots of magic numbers based on the order having only having 5 bits of resolution. Removing that magic looks like this: AS_FOLIO_ORDER_BITS = 5, AS_FOLIO_ORDER_MIN = 16, AS_FOLIO_ORDER_MAX = AS_FOLIO_ORDER_MIN + AS_FOLIO_ORDER_BITS, }; #define AS_FOLIO_ORDER_MASK ((1u << AS_FOLIO_ORDER_BITS) - 1) #define AS_FOLIO_ORDER_MIN_MASK (AS_FOLIO_ORDER_MASK << AS_FOLIO_ORDER_MIN) #define AS_FOLIO_ORDER_MAX_MASK (AS_FOLIO_ORDER_MASK << AS_FOLIO_ORDER_MAX) This way if we want to increase the order mask, we only need to change AS_FOLIO_ORDER_BITS and everything else automatically recalculates. Doing this means We could also easily use the high bits of the flag word for the folio orders, rather than putting them in the middle of the flag space... -Dave. -- Dave Chinner david@fromorbit.com