From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B055C25B74 for ; Mon, 27 May 2024 22:43:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9EF7D6B0083; Mon, 27 May 2024 18:43:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 99F4A6B0088; Mon, 27 May 2024 18:43:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B50A6B0089; Mon, 27 May 2024 18:43:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6E0586B0083 for ; Mon, 27 May 2024 18:43:53 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D54B9121611 for ; Mon, 27 May 2024 22:43:52 +0000 (UTC) X-FDA: 82165654704.15.7F5E9F6 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf16.hostedemail.com (Postfix) with ESMTP id 3BBE8180024 for ; Mon, 27 May 2024 22:43:50 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=V0xJwy3T; dmarc=none; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716849831; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BjImrOXWpiU+qfhtgMroV+a4YBMofEiDr/E3tuD1jnY=; b=j0s+S31TXw5/V4S9x1rECPExwQfyArUX08WMajzLMOD6FPe3fuuEm0yfYkTAQCFGQKN/vs 5spKE8Ly3SJgb3uqYbFtRbsXhuWBtgJQI+wpRCNg4+4Cb6iOkrxBM7xmmeU2pKDs1rpxwW NjOoaWCvIS1LwSXatR24z12EZEmEEtI= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=V0xJwy3T; dmarc=none; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716849831; a=rsa-sha256; cv=none; b=nATxV9807y6g8zkIj63tB4gMgodATPJ41yziDYq0JRT2isVZvTgaC4RPs46fWaKHFIqsC3 7at9Ktd+gWKJwwdjOxEtQAS+fHUMwh+gyrcqM/kHAGsAemBAJ3KUCaq+36FpQL7TsleiHB vIJeYWjP9UxvcEqDgXLFbdAcE9W6MpE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=BjImrOXWpiU+qfhtgMroV+a4YBMofEiDr/E3tuD1jnY=; b=V0xJwy3TXOuogSAGXMhcWBWnjF FZs7GkipX1fnkdpZ6tE7jhjadXJTdBGEHSstp36IYKmhTUUM+5V3eRfmgAKXMz+sbo+xsBdcLz+Oa QvXQf11ZK/P9kD4O9zVTq1aoeqiwVtOyiNGGvHf9mpxghWRgdoyDK48kWYKnSOLBUxy3Yhh2JRfZ9 ACLDWAp9iHr9SrK+BreozIIgI6NfKY/keHWHTZJEBGGl8qzsgurYhMDbt7pkE6wK4V05r3UEY+LJY QzPXzo4X14bFw/FpGOVgzffvCOh7rB4SkBY7gYQw9/uH0snwkTPl0u7nQ7bPhttR2FqHjHYx9CbQD VVy+OKOg==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBj4B-0000000842A-3b3r; Mon, 27 May 2024 22:43:43 +0000 Date: Mon, 27 May 2024 23:43:43 +0100 From: Matthew Wilcox To: "Pankaj Raghav (Samsung)" Cc: akpm@linux-foundation.org, djwong@kernel.org, brauner@kernel.org, david@fromorbit.com, chandan.babu@oracle.com, hare@suse.de, ritesh.list@gmail.com, john.g.garry@oracle.com, ziy@nvidia.com, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, mcgrof@kernel.org Subject: Re: [PATCH v5.1] fs: Allow fine-grained control of folio sizes Message-ID: References: <20240527210125.1905586-1-willy@infradead.org> <20240527220926.3zh2rv43w7763d2y@quentin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 3BBE8180024 X-Stat-Signature: ephm8jjptcdjfimk46pctswbchuxj8xm X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1716849830-869536 X-HE-Meta: U2FsdGVkX1/ntuWeAf2UfRNDNZdBK/ChMH6NGSrt1e9010s9Wl3EBYEbracbbhLJyzbghL1W2rFEqsxJ3IsskgFD47JMoW220lSbyXIPkv9JMZ+YE2jOF/8Utz5uQ5uydCiBY6V8kx9hdLpFQxKkXNIuGahjQicwXWTi5HVr0YM4/eMAwoqo6McQJoXoQq9Jnk8TA4HN/j6iHnchLDv5TrRcRvCTuSzhg7H4REDIgKF5C3sOQYWUCAluMsZEc6euup2CEyaCI5WyX4AocZN6/n47fRuXCTl4ZFbWAov2KCQMY9MsbKbonjCyMGuQBnU+ZGdU2DnzfqdrMJTEow3qBLcC9xAb5n4Rk6zFEwQ92YGOQ7cEm0ypNagwtXD1vN+6pClgR1cPUPtsuUXfVVzjcDTnThMT36MMneLOX0oDPaLqax+6eaqOHzcnAfbM0YWq3CvfgZbPq9tPix66Ukmx2DIrMpdd4cpxLKxY9p/8aZDBR3vYo8EpwdS1Rg2rTcLl58lut7HdfwicCmvcnznwHat2Q6ym1k3oj6nJBQfJ1OLJhCNI8qLkfuFhQdYeRYvOVMsHuWnG8TAcZq6kM0zuU/rsrqmWhxwzpj1LTY7yhKi2nMH3KdGfUatuGlYRGBJzE8YUAo7jLo0fNEb05LXa0dMuYMnvreEWRekKZ24qSycUvB1IlGo8HSwVmC893CgqyQUy1A3JeTMNBSGItL4X3WPGVoB1cKu675zYP4nQQLxGjXULK7MQuCcgwOhEysOd7lTdAwwrMLEQnfCrQGZuKPhB9CIT46LoATkylKromIG8liuRWC6knSaL5mCPwxf7fsSkcepCpYFgsvkoMxkrUsT/p2GwMk8QrdtRCrDo8nZEwzA6XRxUQoJSDNyZu8PNPGyKELl9Stmc83jWiRPL5eSw3ZfzVYPyAGBxvpfNSkqo0MsGhoGu/vg2BBo9CRiQ7X1l8zACb3zA2lX4oXd FwhzVtfY SwLvyiiWoo092T6U9IQmlYMXC03dgMLGkezl/ba3nZIMmvbGLiLige13aBTIyAQqPFMUaJwF1tGHiHmDDOSD/Ib6UsDqtY8KDAm5rCj4ip1cNgyteHzpI7TnsKp4hy9MBThSX+V2w6OzFl1C42Q7OM2sayWhqiccrKQmBe9NLYUmhzRqQ4vbSF5ykQ8j3ba39/MqYGa3XRLNvqphgBpa2qvlwEA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 27, 2024 at 11:39:47PM +0100, Matthew Wilcox wrote: > > > + AS_FOLIO_ORDER_MIN = 16, > > > + AS_FOLIO_ORDER_MAX = 21, /* Bits 16-25 are used for FOLIO_ORDER */ > > > }; > > > > > > +#define AS_FOLIO_ORDER_MIN_MASK 0x001f0000 > > > +#define AS_FOLIO_ORDER_MAX_MASK 0x03e00000 > > > > As you changed the mapping flag offset, these masks also needs to be > > changed accordingly. > > That's why I did change them? How about: -#define AS_FOLIO_ORDER_MIN_MASK 0x001f0000 -#define AS_FOLIO_ORDER_MAX_MASK 0x03e00000 +#define AS_FOLIO_ORDER_MIN_MASK (31 << AS_FOLIO_ORDER_MIN) +#define AS_FOLIO_ORDER_MAX_MASK (31 << AS_FOLIO_ORDER_MAX)