From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 799E8C25B74 for ; Mon, 27 May 2024 22:40:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E81DE6B0082; Mon, 27 May 2024 18:40:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E31B26B0088; Mon, 27 May 2024 18:40:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D214E6B0089; Mon, 27 May 2024 18:40:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B81036B0082 for ; Mon, 27 May 2024 18:40:02 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 627B81C092A for ; Mon, 27 May 2024 22:40:02 +0000 (UTC) X-FDA: 82165645044.24.5CA3ACA Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id 8BFB940002 for ; Mon, 27 May 2024 22:39:59 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=W46aTZnF; dmarc=none; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716849600; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=q6QhU7sKR5QtsOX2F1+hAkRgqnFTKmnF+5KVWJ1Beow=; b=6h+VI/kUgDJ7PzuC7IuL2IwWES0v5zO0QifMBB58I6pzBhxVeajDYvAegR4+RMtwU6Vy6J giZx6/X7iYTDYmar/tWjNSMoFZc411wmILjbaoBnpwJsKK2Zv+sT2JxYdbg88fAUfAGakm UM6bEl5Nj4aMVDrhafBEjPR+wlwIgvg= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=W46aTZnF; dmarc=none; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716849600; a=rsa-sha256; cv=none; b=VBv0yWHTpXsU7Bsvdc+Q0+xmH93OQjNe+iOX0aGS5//l7THdJ/H/UvbvUGWilr4yUW+vrR YW1otzzovgMXiFLt+idPGIUXoOkarpiLzoNF5j5YU/uka8NLIjnhy+2LhrXwsL8xcq4B6q eaFTfNgvEVrR3z6Ph0b7KG5z25wZ47k= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=q6QhU7sKR5QtsOX2F1+hAkRgqnFTKmnF+5KVWJ1Beow=; b=W46aTZnF2g3pObfqLgHSuvvP8f PTkB0Gnh8LL1d/ksibNbD3Hi+s9DlPBRI3hlMg9tKy/Rm1x2YY01pR8ccq9dM2LwSgUC2Nz5W5NzV qNxo7hxAo0xp2CdNbB5oGK4KAORrPQigmnSMggI+PqBhZJ+FUbNoA/Q888/qI0C3DSPOqncuURwig rIVwFzNzDB5aqtcu9jV6ljhjIOugfeXGgPGGBJaV4H9kuyzIpRBLUcM8RkGWZLkIxiK7G0tRViU6u IZraOoTgTGm8Jih2FDJPoUsipqa5hNGzUItGnyr1puajL0KNRKT+1ooOXP/K86Cee2o5xX/6HZ9DR 0YZYgwcA==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBj0N-000000083ub-32ao; Mon, 27 May 2024 22:39:47 +0000 Date: Mon, 27 May 2024 23:39:47 +0100 From: Matthew Wilcox To: "Pankaj Raghav (Samsung)" Cc: akpm@linux-foundation.org, djwong@kernel.org, brauner@kernel.org, david@fromorbit.com, chandan.babu@oracle.com, hare@suse.de, ritesh.list@gmail.com, john.g.garry@oracle.com, ziy@nvidia.com, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, mcgrof@kernel.org Subject: Re: [PATCH v5.1] fs: Allow fine-grained control of folio sizes Message-ID: References: <20240527210125.1905586-1-willy@infradead.org> <20240527220926.3zh2rv43w7763d2y@quentin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240527220926.3zh2rv43w7763d2y@quentin> X-Rspamd-Queue-Id: 8BFB940002 X-Stat-Signature: setughzhuhmqwfqap1bp87dtgtu9fizs X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1716849599-944287 X-HE-Meta: U2FsdGVkX19Y5rLcCgH5NzBOau2fzX9t5M9j2NJ76vaX40/NANCmyml+y/elWTWGfkLYaCcjPHD2/Gr3Ae+AOZ+AHG+tsCp4tTkxVTBWjT1KfEJjM+8/MHDIlL3LVqeulFB5KDwl0/5Say1OdblIuFN1K8XPgJED+LmNPC0QnkKASEywcU1I+ascjVrSuvv/1HJHsGukw3FdFBf7icnaqeDf1CcPmIpr1NiAcN6Lp2fj0Vljlftn5SrNt1bkIPg8ML2wGX7FW7es1QZ7C7hlpvtD9qHvvRK8/gKtO+eRrtKHKZwkRYGeA3uMlHgvTkHt5ytNZDFgbSR0+kibAL/mknbfKYNbtSHo9bNmmeiJYIz3MG6t6tf/Gi37LUOZuYZIAPJ/PM07pOLvZcWSBdpsdq8cJ/LOHpUWFNStvLOGhzUkOJw07mOufD5fVX65kjf+8U42fbcdmP0ngbKlMcWPpTB68mAPRbgXDBavRIAs956cdWOvtRIW7KVFeIbN4GV59+97F+xun/f+iPyI09XmZFDsSjd+5wYWA3bexV+3PLYtmebmA3rea1U09rrrpe2BbfHuKQ5aGWuoQg+wWl74OStzMCRyPoXMprEnduObUvYCPb1kiKxXAYJhdu/9ZGsPpV6FDxvWr7QvAz4rakaOCvSNMepFhXD3O41nWK3XjbKFlZNjWMf2uQRy7EQ82EaogHGMgh7lilFUEqHeAlcC+vqAh+TqjNDjjGSASWa5T2hy/3YlIh8o6yEFNF2CxKldEmewoZMIIP6oYXjQJc6Z6e0SWyeeajz6De4VkolM/5DOs80Av7HmfFnn7YB8y5vKdMQt4nKCzrY45j+K6VqvjS8CrW26Qb5UGpBAYU2HcMZVo4+1jAC+gCCeYWLqttYjA9P4NfziXDwuo2L6dRodVsvhZ7VnEAe5z+/66ugGKTHM9VxWidX2jC68m9CjMkIhPQ2hN9UhRQ6Pjhl9xNB e9JPMRT8 KXo2jszxV0Z2gCwy+h0lS3VatN57TMb8XyKUZgMhkmvoD0hBMYZq9eVqJnfkRrxLMDAXjK/8b6a5OoVY6UUJ230RzR2e0F+tgoxdrndC65b3PLGYelIEBcOwafhB386UvkZ34iassI/72kvFim+uSUUwMu6WmQZEd/kly3u8FkqCnl5lwW7iLAO4YNTJoQ1ofw4KJZSBQZYJiN8LkhlXKOj0adg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 27, 2024 at 10:09:26PM +0000, Pankaj Raghav (Samsung) wrote: > > For this version, I fixed the TODO that the maximum folio size was not > > being honoured. I made some other changes too like adding const, moving > > the location of the constants, checking CONFIG_TRANSPARENT_HUGEPAGE, and > > dropping some of the functions which aren't needed until later patches. > > (They can be added in the commits that need them). Also rebased against > > current Linus tree, so MAX_PAGECACHE_ORDER no longer needs to be moved). > > Thanks for this! So I am currently running my xfstests on the new series > I am planning to send in a day or two based on next-20240523. > > I assume this patch is intended to be folded in to the next LBS series? Right, that was why I numbered it as 5.1 so as to not preempt your v6. > > diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h > > index 1ed9274a0deb..c6aaceed0de6 100644 > > --- a/include/linux/pagemap.h > > +++ b/include/linux/pagemap.h > > @@ -204,13 +204,18 @@ enum mapping_flags { > > AS_EXITING = 4, /* final truncate in progress */ > > /* writeback related tags are not used */ > > AS_NO_WRITEBACK_TAGS = 5, > > - AS_LARGE_FOLIO_SUPPORT = 6, > > - AS_RELEASE_ALWAYS, /* Call ->release_folio(), even if no private data */ > > - AS_STABLE_WRITES, /* must wait for writeback before modifying > > + AS_RELEASE_ALWAYS = 6, /* Call ->release_folio(), even if no private data */ > > + AS_STABLE_WRITES = 7, /* must wait for writeback before modifying > > folio contents */ > > - AS_UNMOVABLE, /* The mapping cannot be moved, ever */ > > + AS_UNMOVABLE = 8, /* The mapping cannot be moved, ever */ > > + AS_FOLIO_ORDER_MIN = 16, > > + AS_FOLIO_ORDER_MAX = 21, /* Bits 16-25 are used for FOLIO_ORDER */ > > }; > > > > +#define AS_FOLIO_ORDER_MIN_MASK 0x001f0000 > > +#define AS_FOLIO_ORDER_MAX_MASK 0x03e00000 > > As you changed the mapping flag offset, these masks also needs to be > changed accordingly. That's why I did change them?