From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ED72C25B74 for ; Mon, 27 May 2024 20:36:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DDBCE6B0083; Mon, 27 May 2024 16:36:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D3D506B0085; Mon, 27 May 2024 16:36:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BDDF86B0089; Mon, 27 May 2024 16:36:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9CDC96B0083 for ; Mon, 27 May 2024 16:36:16 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4E18A161234 for ; Mon, 27 May 2024 20:36:16 +0000 (UTC) X-FDA: 82165333152.16.4F0BC95 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by imf07.hostedemail.com (Postfix) with ESMTP id 6561E40009 for ; Mon, 27 May 2024 20:36:14 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=YyKp3zdn; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.45 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716842174; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aOh10dbgxM2e8Aowe5HMEmqvNcOhtnTLTtTwACrVRLU=; b=uK4pYwrBrayeNWu+/tXq7/tfeZxXTH2fhcdl9+Dr9CjQjVoOJ2yA1u/68hphHsu/LqfBmn O4Kgp9mIfqaZk0u7epP/Y9hv2LeBIxI1HD2UIkE4spyNaRapjr0saGDXcoKvRYI1D9UAHl eMoNMWdTt3pE8GTlmiSEtpD7fyS7fv0= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=YyKp3zdn; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.45 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716842174; a=rsa-sha256; cv=none; b=Q5Ai2xIedAo349pmg0LZC3gtoMvvAJJZS63bOyOtAbtn1KOfqFMKsXpYYYnfNfGBBj9opt h/qJWTW5COeTI4/BojRNdZ2YIVSs/I2eKFc6wOLnvkdBc0xK2/Wm/5bCC/riwcH+uUDTa0 pRUZlS8FJarmThRCMmlYLYcDpXUcMNo= Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-5296232e00bso157332e87.3 for ; Mon, 27 May 2024 13:36:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716842173; x=1717446973; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=aOh10dbgxM2e8Aowe5HMEmqvNcOhtnTLTtTwACrVRLU=; b=YyKp3zdnUXlHP/lPI1KaTaDCMQDIESKo+ynBJ9Ios6/b/mWyhxXjpukWTNNihbP7xt v5Wxhkj6aM6TN8XFK/QI2Tk/mlVVHRUriIJPJXN1TSGttTSYv8i3OihrGPiaxjq/+1gB IlfT51NGE8oBUDG6eXEcR+OD/yRgcYQOmasd+zis8rVcYVEv23zdippvDIkaZqPgj/a8 52qBH8ETyAOa4Xvl7FHqTf03ugKcZy/gzESpTBxlhP5hDcXZWLN6+vfuJ0lwHZSylRVe r4dSc+ClMpbgniV1H7Ag/4ZkQo5sg/CGP4tEJ89c8PXeDXbPBf+RHzYFJjMh4aNkhcnO 39Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716842173; x=1717446973; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aOh10dbgxM2e8Aowe5HMEmqvNcOhtnTLTtTwACrVRLU=; b=N0+FfCLfUknWgkYRZfQ6cjBIh1HLDCU6BQxsvjQABLwMwl9wj6I7eszNpnVtmsN4Lp rEOiWeaSStFrSFizDDp9cZ2BF4609dpZ+u7Fl9/C5JoKJPvImAYGq7XvujPbz88G1fID IoF34nzGJjA9iM4fooZP1ixVhfL2fxTyJ2sxipeXIYv/I4PfRJMINATae4MJDpgtOdq7 gdl++7+b9xxN0BtWas392SGcOVzJ57cFXTk2ldfY3XusG8AtUYu9FXC2ybPLugDJ9c7g xE2DHR+ankiXRTYEGFPStUjVkjtkhSzTqOlO/UYxyeSgUaOZmcN/B/2vSyaOSStbgIce lwYw== X-Forwarded-Encrypted: i=1; AJvYcCW1MELSd3R3QXfCXiQ90H6CDRxGmh55SrlOnSoGDynUaf7KOkw93gieAitv253NWknEunW39z4Afg/1iuJ6CfdTHcA= X-Gm-Message-State: AOJu0YzpCyOEFdyAgYtoxyLvZF39j4Mn5Hz8GRCMx52NEKHDYXG2cjjt t/+iJJkFmUIU8cKrH5XMeZnGUtdpEMBDyvpWpFR0nR/W9cLhEomS X-Google-Smtp-Source: AGHT+IGB/FJQ/RZ2ky0gMGvUT0CEQmqqoXZyi4q2+DXHYIKGo5ql9EVgn7P7wWZjfxW1kRVtS1TDCw== X-Received: by 2002:a19:f70b:0:b0:523:9493:432c with SMTP id 2adb3069b0e04-529666d6f30mr6497708e87.59.1716842172424; Mon, 27 May 2024 13:36:12 -0700 (PDT) Received: from pc636 (host-185-121-47-193.sydskane.nu. [185.121.47.193]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5297066bce1sm766062e87.169.2024.05.27.13.36.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 May 2024 13:36:12 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Mon, 27 May 2024 22:36:10 +0200 To: Julia Lawall Cc: Uladzislau Rezki , "Paul E. McKenney" , Vlastimil Babka , "linux-mm@kvack.org" , RCU , cocci@inria.fr Subject: Re: [cocci] patch idea: convert trivial call_rcu users to kfree_rcu Message-ID: References: <68b85796-c674-4691-936a-2051849f4692@suse.cz> <6b7e3ed9-d974-cb3b-6839-a6b7cf5f5a36@inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 6561E40009 X-Stat-Signature: w6ywskfooy63g56ju8m7t71nfgk93h8i X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1716842174-253808 X-HE-Meta: U2FsdGVkX1/5KT6NlY9MQH6a5UKroIQ/lDeakFRI6jzOwTryX+LKU+1wqzlLXxWr3dAvSZSYTvLvAN1atOf9s36c7JmzlPt8bI8USgtsQkC08pmHh5Xa3Fpny/obMeonBnnPLlvCqLfeKcUMKld1QJjMrlWjyrybkVPRUGrXl6UBO2i95aXbCBj6PTrQW/B5wd2jblbyTajXVWnv/QYXjYJYKg/IVaXDTQWqMgEaXq8nwuqhS8hHEGrMMbY3Y1kzvyl2hPLymTSgLtuSLsk+Q/ai7Oyw2uYS56PMy/WQaChTRFkPfO316P0FrlbyCxCrCRfMLS0DPZOXNpG/luQOOJT+d6ni00OG58c8FyiHogqBPSNV9DiwsUVad1knhMLPs1jEUkB97ykNLJmJvTIG0YrNrgx1j3Ex0FFYz0sYa2kucOHGQp9dYE/kXbYjPzFS6fdeaM7bO0uW4bOL3vcWKcMCkXk83+vzPZ2fOLWkxISvp16WVr0jgHy8zk7p4yb/+N92RwtGpvJHsgj1QfzTdEy4vgJB2vy0ra+D9veD/CnqxjF4QSo+RV+N43E2UG9lgwBOiHqy6tPuqAx9GOfvN/b2q1kFTxf2irWU0mlJ1yfCzca1RPoEE9PkQwp05Ad7c7tzG7rPOSh4rqqk+DyxIqRUDiWjAjGLr8mONloDYAkl1rhMUfAN0+Sakv0XmlF7cTdzM0SfP+5KC6BHtonFtkCJEnQB6q4A1NcVX0JpO5NudoIwrxpSUayQlLcZozKoB3HPoJqXQztWLO0ptsPmsAFMfssDZ15xJ7DoQ4bkPD0TRzmUeyR1T6NKYTaI4145rXg4x3Z9IJHaFGqmgvKWLjX+OGMrgUvZOB7Acpxe/AhXpPw0yYrEACefln8+9WOFluhPj1lErBDix0M0eeSJwU7KE+j2qYqZYuOGA4opQG9nvz97eON0fQ08owhj2k59iJGnXzMO+qJHb+CegWQ o2jnKxu6 HKDXt/YMecoMWf7gTsdgGbZdns8wBILye7YzTAsIBIq62H2madF9WlKR2NcJFEklyhppAT9EyzcIGguFc0/EyU84+M3jgedk1tCf3LPUIpLl08id3OVtCR8odNtdL4UfcIEVw8+bC9sgAqw4Qg8RxdHLMRLITxfHmlHD1GAsLzWJSjTx+aLhwp8imn73bSzp62UJyKmI4/gnPoWofBfpT3DAkZSLcqsCOvu9H+GQlizgw+ZJdEv8b47MKJCB69p4sLPod5lfRUXc4JWD4rZd6AmsaLUzDC55gd1hjy8MOxQXf5ukvSHh+41CYw1fMMpYmQdNKgdtJcuxdwg9ung/rACZxFk9lNxg96jr4f46k56z2zgzjXlQBEGpVHEUpXJ1lsIIP0Cbc2hr8k/MoxMiCrj51dhIH48H38CH+2DL+c+lCJjwRkuDrT06dFWlHe9xupnjBthiCCt1ScvyY+8PAGPV6iAd2oHsozNO8GYgRc99Pd0pS78DUvOTyfW6pLy1OAOC/Oucf2urI9J4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.002141, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 27, 2024 at 09:51:35PM +0200, Julia Lawall wrote: > > > On Mon, 27 May 2024, Uladzislau Rezki wrote: > > > On Mon, May 27, 2024 at 12:27:14PM -0700, Paul E. McKenney wrote: > > > On Mon, May 27, 2024 at 10:13:40AM +0200, Julia Lawall wrote: > > > > > > > > > > > > On Mon, 27 May 2024, Vlastimil Babka wrote: > > > > > > > > > Hi, > > > > > > > > > > one bit from LSF/MM discussions is that there might be call_rcu users with a > > > > > callback that only does a kmem_cache_free() to a specific cache. Since SLOB > > > > > was removed, it's always ok to use kfree() and thus also kfree_rcu() on > > > > > allocations from kmem_cache_alloc() in addition to kmalloc(). Thus, such > > > > > call_rcu() users might be simplified to kfree_rcu(). I found some cases > > > > > semi-manually, but I'd expect coccinelle could help here so if anyone wants > > > > > to take this task, feel free to. > > > > > > > > Thanks for the suggestion! I will try to look into it. > > > > > > Thank you both! > > > > > I wanted to take an action on it but Julia was first. So, please go ahead :) > > If you want to try, please go ahead. We can compare results. > It is appreciated if you proceed. From my side i will keep an eye and if n it. If something is missed, which i can detect, i will let you know. Thanks. -- Uladzislau Rezki