From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DDD2C25B74 for ; Mon, 27 May 2024 19:46:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 831AA6B007B; Mon, 27 May 2024 15:46:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E0AF6B0085; Mon, 27 May 2024 15:46:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A8D96B0088; Mon, 27 May 2024 15:46:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 48D116B007B for ; Mon, 27 May 2024 15:46:46 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E5D4B120D6B for ; Mon, 27 May 2024 19:46:45 +0000 (UTC) X-FDA: 82165208370.13.1FA4949 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by imf15.hostedemail.com (Postfix) with ESMTP id 06B25A0003 for ; Mon, 27 May 2024 19:46:43 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jTFLclWe; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716839204; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uk4/aJQTAd5pz4e6cqiB7ALvx+m5tyRF7o2u1p+ZhPQ=; b=Kc0tl5YjStCWq6jw2B1mHtE9nrzWNMP94zVsU3WTaN2Ucj/LmnyTHy+Pd08kjg/cZb8xUY keharAEaA8gqKRmaCAQY8dfm9ej1n0dvweSKAeKJ55WpUvgg7172IpJ8/26H7lSeZm1Kou h3DS3H4TeX+Shr5rFsNo7o1si4L/aSA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jTFLclWe; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716839204; a=rsa-sha256; cv=none; b=67l9Ze7+UkwHVfMu8ca1mXLqdNoBTFoJ3zNPV4WiO1f3Ade1iMiEM4cK7LiuGjPZUrRJEq NDseOwrZ7XR0Tg94QnadDoKu+3JKkmv7MY+LTIjct/jeIrQhCygrCXj/ywOJQswH53NNhu YDG5xANi3oGprwjcKTrD16++EKwjI1g= Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-5296935252dso120183e87.3 for ; Mon, 27 May 2024 12:46:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716839202; x=1717444002; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=uk4/aJQTAd5pz4e6cqiB7ALvx+m5tyRF7o2u1p+ZhPQ=; b=jTFLclWexDwLG+8HXANwz2k9XN1poM5ERF+ie700SStGrbll2ujaslIsltxVhV3jkS C0sUP5xSZu6gNBl5Dnz8qLSGes7sN7PONZ98a8jsIsR9YCCgZCekYfXU6U9qhYQE9dHj ZFakAzi263OftCv+XM8oSGVWRY7yzjeobnlhS4dtOok9LS83CGPI+y5bj1bIt28wlsJP 9NKt+92ydj7ObM9dLQf0NCOzDZDAbESRPUrrp/Oy3swtUWX89NG3Km5JRNDJL2AiRB2j 9OcNC6MnstxIVe+0i95EjDvLjodtqblUTjzBqJjz8TJ/gT7hfamn+WRKxAiiJ1X8/cO8 8xQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716839202; x=1717444002; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uk4/aJQTAd5pz4e6cqiB7ALvx+m5tyRF7o2u1p+ZhPQ=; b=ODAlw6XXcFYcCNUcFew/ULPlAgrXNTZeuYdjXi9ekW19hA5EW6qorkhVRiR2c1P/5m CCMppNTruIrwQACoInJkngIQL5jZDhsfjGGnKep/l11E5IxeA6zAtUUsA+dQ+BImUGBh 7hc8zIFQgbKa26LtPT7cKHUQCIJe5w9PP9DGl7J9brty93zKHRw5GkyGX2/Jl0Nz91mU wRMgLEg5rIF+gRu39htoQ1PXw6Jewnvsee7k0lu0S2fCRkacPQz2pbBAfWSViJIcp9a/ Ib3I7vIx7JPA2rFOp5rczmmP/fXGF5SANIuK0UzsV9YeFNFG8k/yF4GRYO0f0EZBh4oJ 1ipQ== X-Forwarded-Encrypted: i=1; AJvYcCUq/njtmixBNnUyG8OKaWTpbIxzESDGSueikpWOmHC2Nk4TObFTtyLLap1ZvQ17jFmSIbK5aiXEMJd6ae2R0ZEzpt4= X-Gm-Message-State: AOJu0YxGrtO4euovwTNV3yL7bsiuKgiQbVp8CpPAKoE1KRphi+OFoird U8gyxiGNchW9LQlimhSPsOncvF8jGjPBMa/pYIBBpNQMopI3sOD59PWfGg== X-Google-Smtp-Source: AGHT+IHCl6MY0a8pMw8jeqgnIPKO0XHXb2qaV39jOueMYwz8iYj7Af5QyL0+IIxWYZ6N/sXg2T3Thg== X-Received: by 2002:ac2:4acb:0:b0:51c:43de:b18c with SMTP id 2adb3069b0e04-52964eaf6e7mr6245099e87.27.1716839202093; Mon, 27 May 2024 12:46:42 -0700 (PDT) Received: from pc636 (host-185-121-47-193.sydskane.nu. [185.121.47.193]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5297066b0a0sm736285e87.177.2024.05.27.12.46.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 May 2024 12:46:41 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Mon, 27 May 2024 21:46:40 +0200 To: "Paul E. McKenney" , Julia Lawall , Vlastimil Babka Cc: Julia Lawall , Vlastimil Babka , "linux-mm@kvack.org" , RCU , cocci@inria.fr Subject: Re: [cocci] patch idea: convert trivial call_rcu users to kfree_rcu Message-ID: References: <68b85796-c674-4691-936a-2051849f4692@suse.cz> <6b7e3ed9-d974-cb3b-6839-a6b7cf5f5a36@inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 06B25A0003 X-Stat-Signature: pd4jna1as4gkhnpthwrtsx4t1fwf37ex X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1716839203-417130 X-HE-Meta: U2FsdGVkX195+e1qZaIlVZg4GyJVzvUxUWMb8nJddt49WLIBD5e4xhpHQ101sWc1ruNBOBSHjOpTGcJaOHASvTjHR6xc/G9pIzr+9u1t/TGikADqUX9AtCqZxTg4GF1cNzCE5xTygmNzZQrXmBG04Rj4nE85vGW6zsqJu9LhK5SdCEEvV5vh8w61eFj5305J9nBudLYWtLN8QvrPwzIsNDQhGKYYDJ6mX+RMJHioZGi9KeYZZ85Rj0GU7LwfYItiuWltTE3K/kpwn0x2J8WD9b/TRVZWSorqNk2vDm/mEobPOjfiPU1KmT6eUMU8jOH1u66ELizHJBRfRLvbpv70BwFp2vHINsl0RRZ+jXi6yLJujotQ9qLKVg2IcF9zb4R+9938ufjiMptjCkaEX5LrVi3VQ+YzmRJgrgykeedUEslTTuL7DgrZswhYItSd8GU35FXU0ZxRw9PxaOxQviaF7UG4+ywMP5kN1s7Q5L9vgYqexoHyZl2nqFdg4a84+RE1a9BWeQo+0ctdREYVpPVohV7mAEAHIPVtbHwA1rNLT0Evjn1Mh+25yateqqK12iuI1OnRgSJ7eeGgIotoA2mncJB3Boez0W4m3y9JluCLtb8zitaaHPDy8HAPU64eQOxkhkhNdGbxBYC3G203Br2v3xCwHocoHcUXSwgh2xdR/XEe+Y/tYv3hlfEJurkSs9So4Hoz2X7e7OgY1w8Rnk3jQBRsMOI0fojDsa3LC/EbpaCEXSBQaqWb/Rn2uus3eW68CtcBaqFzFFO/mwCoqhPBpgLA5epLXiIjTMklBEOfP03Uy65FBtQMnPNH/FHhyvQUSyaa80Aln12Ee0rNR7+uQ1OeKsGF2qRHafkajKMDXF5kmCLyPQ/LMT8oW5/u/SfV9yijVsBA5uBFR4LCojnLFgy2samuTC92MQ0kiVUrfIN+akwVfmO5DHAXSdNKMdT38mDTR3KJvRiZVKBhcRH LpccS8R6 p6LU1dMTNWFzLi3oBKMy2aEez3M8TOc5zCgHsKf2JKGJ3RmD4FhgfxNJjr2d1qD8soJf/OwmyywTK741AbMxJMtO3F77ij/v9N+0E7goB1zkfH2MX4Od9iLMllYcVKgJiRvlFKNC6hUxVrL0Q8PtitS4BRhoHr1Is6E/T1oJhSDcjuXNmoKD7XKPj8AVC9mnpAiT8oLZKqH3oOX0gHTPtwSVDNeESb0I9DolxOwvcMAMBfObDWFxl+EUsPLQgmxkCVF/3trwShe1o8FfdLE6xXBRG1uir9jnw/tsoUrBhbpngckmtMqTAAp9mKBFVJKW55K8LLd1O4X/YXv/bI7mHILqX2vRmVsjcJ1oGHPzAKtiomPEFeMCiFJ7aVyzAGaswfm8F6y2oq9PzXFOvsNPz88SSWuQZl8KkquzqsXvtJxtZNPHAynu7uQ3f2fVfoLRT6wqvWTWwMukWM3OD+qbF+O9Tlk4NeRAyDSQQBSySZW1zhIIeJpDk6FqI5uRvoa55jQu2x0u7Iq0ZUkDZX7W0RmkVb7BW0flUgPJ1r76Djnc7JVw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.132604, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 27, 2024 at 12:27:14PM -0700, Paul E. McKenney wrote: > On Mon, May 27, 2024 at 10:13:40AM +0200, Julia Lawall wrote: > > > > > > On Mon, 27 May 2024, Vlastimil Babka wrote: > > > > > Hi, > > > > > > one bit from LSF/MM discussions is that there might be call_rcu users with a > > > callback that only does a kmem_cache_free() to a specific cache. Since SLOB > > > was removed, it's always ok to use kfree() and thus also kfree_rcu() on > > > allocations from kmem_cache_alloc() in addition to kmalloc(). Thus, such > > > call_rcu() users might be simplified to kfree_rcu(). I found some cases > > > semi-manually, but I'd expect coccinelle could help here so if anyone wants > > > to take this task, feel free to. > > > > Thanks for the suggestion! I will try to look into it. > > Thank you both! > I wanted to take an action on it but Julia was first. So, please go ahead :) -- Uladzislau Rezki