From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F5A2C25B74 for ; Mon, 27 May 2024 18:17:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B1076B0088; Mon, 27 May 2024 14:17:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 860E66B0089; Mon, 27 May 2024 14:17:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7503D6B008A; Mon, 27 May 2024 14:17:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 551046B0088 for ; Mon, 27 May 2024 14:17:26 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id EA99EA13D3 for ; Mon, 27 May 2024 18:17:25 +0000 (UTC) X-FDA: 82164983250.26.19B353C Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf19.hostedemail.com (Postfix) with ESMTP id B05E81A000F for ; Mon, 27 May 2024 18:17:23 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="EBoD/Hrh"; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716833844; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yQPndnt/VKkoxE+QATcqk3pffHAGhUlkEJl1EekOfS0=; b=uSXlBIfCj0L5vn8l3R17BUFqRgyzwljd21kNes0rEZrIZvwlvcTGGkSO7Z68ZW9H+O7oaw J5hJMuhWHsLTSqS9ozglCGCHuwRzAAr+oRyEnMaMpYavZqQ9WGZfbKSLAPon+cl9WTuGGR eQ4lShAmvC01Z4AzQaJSUg6IzwXgRdQ= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="EBoD/Hrh"; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716833844; a=rsa-sha256; cv=none; b=oI3RiP6DtZHLIe32uY4KSneRRlELen8co/kKL/4gzh5o+Aa+zteVLyos5u7JuC7zzUEaTs ePEwBTSof7G2S/0oBlz/jxv1QlnVPKe48nhhj/q5o2+DLlmdxGmiRs3g42ouPKmJkPBeru 2v/5RnzpV3o+Y39gKfjMekyw9kbNUyk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=yQPndnt/VKkoxE+QATcqk3pffHAGhUlkEJl1EekOfS0=; b=EBoD/HrhhFDFz4F7sBZCAVQPZ3 UdPROiG8LxqhGX4WRjDUOkrv/AG5V/dDZE0KCq0UT1U7xc+ygKs4+n3RfQWs8xwEgBIopsRAC1BlN +pbsBC1Eqdkk7Lv06FUj8iLILqJU0qpqWZ5U0J3gRjRvqWmtfvof0zSHvb4fHqbpM5exeJeN9G3uC h8hH6miNT4tf4zY0nvd6MDPJ15+dPejJTPhb3OPZy4JGs47OgDCjbvNVsApJ+87WwHo/jarDC3uiO Nq4q6dA9H4UtVIPaE/oDcG7YAc7YUnK325Dpy7hgiSKfb0jLGQrZZWdMV9bvuI3JS1licFjcnRc7V apptAnSA==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBeuM-00000007sZU-0Y5G; Mon, 27 May 2024 18:17:18 +0000 Date: Mon, 27 May 2024 19:17:18 +0100 From: Matthew Wilcox To: Christoph Hellwig Cc: Trond Myklebust , Anna Schumaker , linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/2] filemap: Convert generic_perform_write() to support large folios Message-ID: References: <20240527163616.1135968-1-hch@lst.de> <20240527163616.1135968-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240527163616.1135968-2-hch@lst.de> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: B05E81A000F X-Stat-Signature: ekwfc4ixjd3w1aixwy6mq7x4d1hdeb7s X-HE-Tag: 1716833843-762410 X-HE-Meta: U2FsdGVkX1+8Hv5m7JnIh5owHYy58BPgww65H5K/664skKqohN6lp5uMjWhcMWD7SCOTocIMaksc86O64kXg3Fim7xZySOOnJ8iC9OL0ICI6oCfOkqz0Kwv0ZUaHhBSaUhWxwAf/QYg/K+f/TnGbCjqms7Gpj5m/2EqDbD/UjBpGH9FX0uepFVMl539YxAWkL2VbUc0VEz2NUF7+cLDnuAjOouooWQKpJLWs9Mh0gDe9NJB+SPBce8YouAhuTDWjoiTm8vW5wqWidHKqqs2ff6wyfMMJEl3vgC/poWEJBPtHCAjlQZrLC4WyCAw2uLHh90WFzVMq5K6dAJIwT1Y2B5tVqdjBPOT5lu0niUTv4giOVupWphG/VKXooakHk4ZYkatLg0+EWnhfyfIJQ1OIJXFsdCANn2k4Kk186Q91KqyyJa15Q6y3zqqAUMooLjOZM6xV56WIGlMbRNsdkTuELlSRyTgx2FB5sx0zSofmZSjNCKsK8GycQimRAV8GnOfTyeybpIZchCLqJLtAK1A6Z7GwfAqa2kSPN45wnMwY/K1JJKwbgZle270g4HIa5U33c5b3v2i6LRa/xHP35v53Pr6kc93w4VvPeab0yQotylvOtIKIrN7twmxwRtrd/fPHaTUglS2ypK+itoRbrOCUuPztIMjai0fEToJrJiKMQYVgN7iS2ZbHx/5+i1fh4VyqWlWeA3B7vMK5ZhWfG5C/5RLP3LmbYyDWzmRuovedoIV5QVMEnjy/q35cbEF7SVOl4X0RsdPFQdkEugwOhSF71k+4xcqUm9KQJeqVOns5EFTew/jz3u717bfK4wCen3mWAU/B+i/IWaFTo0hNgDaXokvDz57OdiYopAqS3Dkep9hFLf8kR8fwlnar6WNRRVdUfJb4t0bawNKmF6V8cpFS5auUCTi/gHwRSBXMmp9zKvDI6XAg1tf7xtvtYdTu2/Ffr0ZNoJlIC/bDSctCTrY PCEh/6TH PkZ+mgUgRzArYj63t1RmKrFqCoU489oEYsZNjKprSmSVL1YiD13AsVyzNzkso+GTFKXBpP1xdJeXdjHKU89v4MDLd+xkCmK9QBPEvxhHcjpt3DaLUrQSUoHo0Ewah0e8yd7rNlJWO//EZg00z5CKXAFO5XjNW5kTCT0FmtQYUoA99kxY63WAYghw0LmY58KTzCcZzbIQ/BfWq8Lq7XSOnU16CIWAxrdupxIp9kWJ7bFa+TS4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 27, 2024 at 06:36:08PM +0200, Christoph Hellwig wrote: > From: "Matthew Wilcox (Oracle)" > > Modelled after the loop in iomap_write_iter(), copy larger chunks from > userspace if the filesystem has created large folios. > > Signed-off-by: Matthew Wilcox (Oracle) > [hch: use mapping_max_folio_size to keep supporting file systems that do > not support large folios] > Signed-off-by: Christoph Hellwig Yup, this still makes sense to me. Could you remind me why we need to call flush_dcache_folio() in generic_perform_write() while we don't in iomap_write_iter()? > if (mapping_writably_mapped(mapping)) > - flush_dcache_page(page); > + flush_dcache_folio(folio); (i'm not talking about this one) > - copied = copy_page_from_iter_atomic(page, offset, bytes, i); > - flush_dcache_page(page); > + copied = copy_folio_from_iter_atomic(folio, offset, bytes, i); > + flush_dcache_folio(folio); (this one has no equivalent in iomap) > status = a_ops->write_end(file, mapping, pos, bytes, copied, > page, fsdata);