From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29398C25B74 for ; Mon, 27 May 2024 12:58:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 83DB46B0085; Mon, 27 May 2024 08:58:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C64B6B008A; Mon, 27 May 2024 08:58:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 666566B008C; Mon, 27 May 2024 08:58:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4878A6B0085 for ; Mon, 27 May 2024 08:58:57 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id AC393A0CA0 for ; Mon, 27 May 2024 12:58:56 +0000 (UTC) X-FDA: 82164180672.23.35E577F Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf09.hostedemail.com (Postfix) with ESMTP id 55C5214000F for ; Mon, 27 May 2024 12:58:53 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=xyHfZBAP; spf=none (imf09.hostedemail.com: domain of BATV+4fba24c4406d7dd25148+7582+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+4fba24c4406d7dd25148+7582+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716814735; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LizxiP53j7D2NoPkmTsvm1+adARrQRUkvK742gCLD4s=; b=qpmvdYgwGr4zIpLKFP8c0AkANWQRYI/gRNqPdbV8JQqmFdcvqHKXWKO0a0LmFUq2rIIKVO Zk3vvy7eJ2NGBQGHcEv0KpKkalgv0M30gF//u0LennAbcRdhAkbcMDq3zH3rlzEM6aB7XJ XR+AX1K9gQ8ZelCUt6UN78m+P2zpPqY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716814735; a=rsa-sha256; cv=none; b=oKD6RWaMSzkNNuy5/E2vCEIjMF/ASAEuQYBLOGh6L2ok5J/wyB8ezGKMZjuAVRAzSn3B4Y +jM3TK3BJmBNxPpbcLh15FKS7bMT0/mZfKyFhg0Q2BBxEpcQLhDIjze9mCIHvlpx39yg7c y9ZtLQTUNFWbNB4EagwZ7siAsHouxsA= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=xyHfZBAP; spf=none (imf09.hostedemail.com: domain of BATV+4fba24c4406d7dd25148+7582+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+4fba24c4406d7dd25148+7582+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=LizxiP53j7D2NoPkmTsvm1+adARrQRUkvK742gCLD4s=; b=xyHfZBAP16UcddrMhJmpJz3Jd6 5ksXFxX2gBhXrU2IeCQijkzwenNq+TDmDH9VGK7TboOMDwG6iZxIGJNrLoqEbpsomJR8y9g+jzRFg LImskVT7Q6JV9hTwFqhDDEvFt+gLbWJZ9KZ4c+Q5DSbZd3tX+TOoWMywiF6cmQKJyRlP9OlgF+jeA NGJfpZJflKTevGmnksZ4mPAPSI5L/hbzRO39rLbPts2lpLKLQjz+Bd5O8SkOWimf2xJ2yoAciiMIY O4QdhHFpiEX88VxN5edNdV+Kz88wcLesD3dKy2xO9CLfNB7pMt00b+vOgCjzEfI6VZ1xbgrdb9OUh KO6+F1kg==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBZwA-0000000EysS-0LnS; Mon, 27 May 2024 12:58:50 +0000 Date: Mon, 27 May 2024 05:58:50 -0700 From: Christoph Hellwig To: "Sukrit.Bhatnagar@sony.com" Cc: Christoph Hellwig , Pavel Machek , "Rafael J. Wysocki" , Christian Brauner , "Darrick J. Wong" , Andrew Morton , "linux-xfs@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" Subject: Re: [PATCH 0/2] Improve dmesg output for swapfile+hibernation Message-ID: References: <20240522074658.2420468-1-Sukrit.Bhatnagar@sony.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 55C5214000F X-Rspam-User: X-Stat-Signature: aqgy6wxsacy5oicctei6siiwq53d59ox X-HE-Tag: 1716814733-144882 X-HE-Meta: U2FsdGVkX18yEhQK29c9B7JLgEgghM3niesPF6gSAqBfQ/SlpvrkE4KQeqQANnRne9hMHJNc9NFQTQAd8HYA4R07nP5izzYJcBVqz0CaDcPvXsQaS1OI+Mw6ANQ5q/JjPu7gSSBo3YWmaEHvV1m0s7uj8LsqSIY2wZI+ZG61pnfN/WKIXFipC/ArygCKCCkV2jsbuIPi7OMQ/HawRv9lOMU0sqIQ3AyXpiI4e7/HNajCaiISxmDAlW/+Pdxe6ERwQHCyJ61ihWRlaNso48ArCGbMkQzRfNywPSuMqtHdKOh/87zOuL6allF/oRxGknoJT2IKtAlGJoG4BWl0yC+B4THnLoR0243t+Pw5yqomTNk8zYH6sJ9xOBiP77A45BLVSlJKM4PPBKy/eOMGyAs34A5H7SXMzzwM5dGBITkppORI6halnG2Zn1XxV1zt73wOllog5ZOpDV2jTQMB2XlfBjHwmasOjHGRZVkg4/av57B7CBs+4H3c3V8QA9PSiq5f3MtTTv5oaijWlgoWzdfDoPuao/U+GfjwXqYFl8oSfrAQN1meEm8ZihGiUs+p1pshKIt3fCWjfQ22kE4LEbCDIjzUHNW11Kgc8SsSgf1eVfy1HKxbGe7WuImgJKIloohRhOcZrhVGj2JF/lirxo0pQbNXUsVovkeicHeNoQFbRfd9FtaTOqFJRjSfHgWToB1PridnbeXst59v1PepJqv6mWXax0/sN0ST22gwSIevwtwwOVy4YMVg9VGap1yuu1yZ/LT7/0gbsCWQ3clexcWpK72OX9TG7L8FAABZ8kI6JbdTY9Vgg0ipvxKBdxORuKGrkmLj2O4fMcp3t7+Qz+m+8780LmFmaQdCm94XUlIpvU7OpYCe9WWDCQ5HUjbHBot1K/a0UGbNAXei9pIr7MLNQ0WnR4E4GKy57Npje1eMtYSjwBVd8r0et1e2ZYbpnpMyLs1jDPtPdkqYo8Lna6i CpfS0Q5n x2TmsQkn5O34JJu8MpSdzoyV1wTtHOei0hA+MlPUfkPmn19w/vNhxLW95vfRmFCvNMpv/uWLIDREv+HHcTSPzqt5+ACRYyyh8+kOtEcuSCGkbGQBBZnrVOiG/k6DGM0U2/SO5v/RjaN8mumEkFXQhyG9OqoeW2by/jWpanYFEObq6ataQJdto23JqRNVh6pTCU0VLZNWxCsc/1R06fs7l558ctSaf6wj4dxYkvSRcNEGPEm1xJnYi3LGlWvR+xsX1oPpj3KhlIiDfQWvqwgMoyCIr+9SEoq8E4oZfc/dAngeca2K8wVYeQoSidLnQclnnSnu6POi4J3DSDNMt21lVunOHuXgHX392wnwDXq++NthA5YLTGJ/OqxAh7Kr+1YHJlfXLcgvApTfkF+1hz5dOach6BC2+2oLTtAi4mGuOCqPo7XD0C/bDsBhukiBw0452bo+hZ5OX8Rswvjzt3GdNYW12LfndgDYsWewrWn5RyuMdv/8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 27, 2024 at 12:51:07PM +0000, Sukrit.Bhatnagar@sony.com wrote: > In my understanding, the resume offset in hibernate is used as follows. > > Suspend > - Hibernate looks up the swap/swapfile using the details we pass in the > sysfs entries, in the function swsusp_swap_check(): > * /sys/power/resume - path/uuid/major:minor of the swap partition (or > non-swap partition for swapfile) > * /sys/power/resume_offset - physical offset of the swapfile in that > partition > * If no resume device is specified, it just uses the first available swap! > - It then proceeds to write the image to the specified swap. > (The allocation of swap pages is done by the swapfile code internally.) Where "it" is userspace code? If so, that already seems unsafe for a swap device, but definitely is a no-go for a swapfile. > - Hibernate gets the partition and offset values from kernel command-line > parameters "resume" and "resume_offset" (which must be set from > userspace, not ideal). Or is it just for these parameters? In which case we "only" need to specify the swap file, which would then need code in the file system driver to resolve the logical to physical mapping as swap files don't need to be contiguous.