From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD304C25B7D for ; Mon, 27 May 2024 11:26:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5F8E86B0088; Mon, 27 May 2024 07:26:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5815D6B0089; Mon, 27 May 2024 07:26:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3FB626B008A; Mon, 27 May 2024 07:26:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1F9BF6B0088 for ; Mon, 27 May 2024 07:26:01 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B548C14075E for ; Mon, 27 May 2024 11:26:00 +0000 (UTC) X-FDA: 82163946480.06.5846989 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf11.hostedemail.com (Postfix) with ESMTP id 8A69C40003 for ; Mon, 27 May 2024 11:25:58 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=DDxfd5pz; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=mCZhjzJU; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=DDxfd5pz; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=mCZhjzJU; spf=pass (imf11.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716809158; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q+621Dnv2ibRxQTGa/2GbBLACpbN7ercwRBRx17FeVk=; b=kO5syH5Pno8A20VUgNA4esT1VH8QW7YXtQIfNomfeakcojAOQysbIy5Kdv6ug5XmDZbcRJ Y3xFeUpOSb1NMgPu/dnNFpEleftsTIaBj6GxTfoL5TgBkiwiUWoF9MAqxsjm8X+8PLg9JY Su1hDpdtu0OrflqU9ImbI1Q+NRfsVvQ= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=DDxfd5pz; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=mCZhjzJU; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=DDxfd5pz; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=mCZhjzJU; spf=pass (imf11.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716809158; a=rsa-sha256; cv=none; b=F+ZwYMC/JYCxzpNjnAo05hIAUbug/6hU6icsv5Qeypaa1Y924dhpXv43cez8qVJ8OxZDbP xRUyWymOBkSMZNQHX8/AjPbSR+M7sg9zh0MaJnWB9K7SvdjFcEQICaRGFh4whDZBMS/6jW H8NQHUsrXcI0Ii50nEtPXyQNHvNJbo0= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D46991FCFD; Mon, 27 May 2024 11:25:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1716809156; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Q+621Dnv2ibRxQTGa/2GbBLACpbN7ercwRBRx17FeVk=; b=DDxfd5pzRBfBiYYNnL2Fg9WCnRRkOEfeR9YBiddC+vQjA8+OJO8hoGwyqF7r6LPfktZoEt TXXtjgv6kbdyFfi60mh3Gmawr8NXtV6+05abXqHCfY3iqRgHk85G9VLUC1oaFT3PxVGdm0 NYr5Z9FL1HstWWWqHmLt1EexrqTght8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1716809156; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Q+621Dnv2ibRxQTGa/2GbBLACpbN7ercwRBRx17FeVk=; b=mCZhjzJU5PsVCkeZkYpz/vZsgq5HliEWZ+WVjS7262gZNQAi/7nY91Cltbhn/32czXAv5R D4Od0ITOC1tg/JBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1716809156; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Q+621Dnv2ibRxQTGa/2GbBLACpbN7ercwRBRx17FeVk=; b=DDxfd5pzRBfBiYYNnL2Fg9WCnRRkOEfeR9YBiddC+vQjA8+OJO8hoGwyqF7r6LPfktZoEt TXXtjgv6kbdyFfi60mh3Gmawr8NXtV6+05abXqHCfY3iqRgHk85G9VLUC1oaFT3PxVGdm0 NYr5Z9FL1HstWWWqHmLt1EexrqTght8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1716809156; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Q+621Dnv2ibRxQTGa/2GbBLACpbN7ercwRBRx17FeVk=; b=mCZhjzJU5PsVCkeZkYpz/vZsgq5HliEWZ+WVjS7262gZNQAi/7nY91Cltbhn/32czXAv5R D4Od0ITOC1tg/JBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5741413A6B; Mon, 27 May 2024 11:25:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id HXTREsRtVGbSCgAAD6G6ig (envelope-from ); Mon, 27 May 2024 11:25:56 +0000 Date: Mon, 27 May 2024 13:25:39 +0200 From: Oscar Salvador To: Christophe Leroy Cc: Andrew Morton , Jason Gunthorpe , Peter Xu , Michael Ellerman , Nicholas Piggin , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [RFC PATCH v3 05/16] powerpc/mm: Fix __find_linux_pte() on 32 bits with PMD leaf entries Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 8A69C40003 X-Stat-Signature: ne6ju1chm1c853886q9pc6w7ybyaw5o8 X-HE-Tag: 1716809158-853269 X-HE-Meta: U2FsdGVkX1+mJYZYKSBaaA6xLApOFGQUmoARDhtsHyBH3/1A7yLBgOSB+0KPugHWpglPotXqahBJqs0mnv4qo4ZLOOFZA9Tt+edrwvU+Syd0uiEqrFx0GAyLJrVI7CrG6R8lwyuzojYfVzCM3GJQfnEvxK8mvsHv2wXluCEy0YkdPE7HXsWzF0Cino0qOKxFLS9MtHkXoLRY1CwAw4c/ChBaRGHloDvlYPpbwZP+shlKeYU/qbTIJ2DXDsvL+/1ET+jPCfCLz9iIUiEfmMA9uPt+s3LaBDj2UvqphgIXLzGqsXOw3o6Qdf7A9GIp064//7MHkGpyPUDJJjbZp6+hMmLtmXCQp3kiSZlacxrIA8iLxOIcl6qy3e6hhtENf2FJ3cdzSANseMT8t03UZOJ7JY0l5Aar3uNZLEwrCwP/wepTBJUIpv7STxB/lpLkmf58vdZt2civ6tezL1kUXjWOZSaDMYTB/Kx/ufrvtHu4DoZ8LYts6MmADwXdeQh8BFqrhIvMQt/Z8i5YdnCMarlOIAT9ysjwQaDtN2uKY+3nEcEoazDdXX+PkG4imWEBXF8cKIBl9RB0v0XcRWF4SS/rznZgOPgPlPBrevfqKVLFLFJvbP687Hs7Wgu9NaastBOwYKfZKL8iWCo+NOsn4lAlzEbm3ULG+ulJFlNeoKE/ja8RzJ/BSHN0Q2y8pfniVT3A0JGTd50ma8kUh/YNmsVBuAz7IcHAPZQcorTJAT5RUf5YZ6zYq3YBPWtacCZ6hZyJbuzhclOXPlBd1x5pFph+4cmkwnqAwOc5ZFblTRViSZtll+dYeUFvBbn1BQCyUVYhf0kz8shpzsvQO0n77jE/r+1b8MHTeRIHv9qMvmZxOttvMNnnqzFzcdm3JjgA2mDQPQQXxv0BpTJM0hOIrYLecEz0TbaIMTtQLRxCMgqHAxiPiCje4rf1XBnRqG/JzIpbbDev7DrRKxgn156WKUZ rtGHu3YF I53ZuYb6m81gEecxSSERLLFPSpE5T7nmx7oxJnUoIFSEbz1Yum9BdNAN7bEgZlMNqFPDO4GrqcjjkD9zzezgHVSEIKuYAi4adXm5fKU8K2rU0Uc9Ly3JhewGMvn3xS4Ix8GX7f30+McNRodPcV8DkXfI5q2eaD+c/WZ89spjRAG3SK74YcpWvodT+16A//D2ydWfwj1S7bjCABLWPPhDDr/g3MX8UWk4xWIw2+XmyG/K8KMkTGzXijDsfVL20ju96CYC98qyBuaPGaz2L6Rgkmp1ntDuB1+IB8+AcLCYFW7OLvkc3u8bQOxXUqA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, May 26, 2024 at 11:22:25AM +0200, Christophe Leroy wrote: > Building on 32 bits with pmd_leaf() not returning always false leads > to the following error: > > CC arch/powerpc/mm/pgtable.o > arch/powerpc/mm/pgtable.c: In function '__find_linux_pte': > arch/powerpc/mm/pgtable.c:506:1: error: function may return address of local variable [-Werror=return-local-addr] > 506 | } > | ^ > arch/powerpc/mm/pgtable.c:394:15: note: declared here > 394 | pud_t pud, *pudp; > | ^~~ > arch/powerpc/mm/pgtable.c:394:15: note: declared here > > This is due to pmd_offset() being a no-op in that case. > > So rework it for powerpc/32 so that pXd_offset() are used on real > pointers and not on on-stack copies. > > Signed-off-by: Christophe Leroy Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs