From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8EA3C25B74 for ; Mon, 27 May 2024 12:10:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ECA586B0085; Mon, 27 May 2024 08:10:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E7A516B0088; Mon, 27 May 2024 08:10:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D41076B0089; Mon, 27 May 2024 08:10:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B5EFB6B0085 for ; Mon, 27 May 2024 08:10:38 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 691C1120E8F for ; Mon, 27 May 2024 12:10:38 +0000 (UTC) X-FDA: 82164058956.07.F444BCA Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf16.hostedemail.com (Postfix) with ESMTP id C30ED180025 for ; Mon, 27 May 2024 12:10:34 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=vh099PAn; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=KrIgFpoO; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=vh099PAn; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=KrIgFpoO; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf16.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716811835; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mvaI30Lc501OfGJxpLRPDdHJVdqbMySFwG1G/Pb/Fhs=; b=TkkMfv/Qrg5VQPyInJZcB+iANa8sywJcpMHUiuVUWHoS1D/xlKWr5pLbO2zfj4ilIBCxnO 8PfWG9ltqMbVqdXzDz8NCGUfSFla6Zyc03amc6pcKIXEwPJndc58RbyysVTAVwq/muYF2c 7zI5X85BCobjk2C1HJCfcw50gWuI6f8= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=vh099PAn; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=KrIgFpoO; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=vh099PAn; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=KrIgFpoO; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf16.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716811835; a=rsa-sha256; cv=none; b=sz8tzU1jSj4O2+cWaQ+RAyPPUeeF8qB8oDY6TzAFChyoIRPIFi2iwfTs6PaFfFr6F2ykB8 I+PIEmqsY80sAnuw018jYpUZ7UPFxrRjt23rFYNsmTw2yR4QznhO3P5Opgb9Ib4UcVJWUO H1V4ElhPI3fr9TFpl0a028Lp1ap4PaU= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 285A921E8D; Mon, 27 May 2024 12:10:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1716811833; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mvaI30Lc501OfGJxpLRPDdHJVdqbMySFwG1G/Pb/Fhs=; b=vh099PAndxLyEPIsy9E4zQcvEjjwomGo17E1z61rShLO1l/oy81WjLcrx6E9YBLFqcxuN1 4NJKbjtWlt3gj3LXl4MROawdJ3lmA1PecehlPSKQumw0obvCt/GfrrY1ZDa+xZTM0QWg8m CoFvcrONeO5ObJq6WjivL7O0auPCm7M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1716811833; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mvaI30Lc501OfGJxpLRPDdHJVdqbMySFwG1G/Pb/Fhs=; b=KrIgFpoO8KoA/E7A1TKrafaMlo1xGEQnE5ztSYWcl7Qbv4WAXr8pwACx+wRii1Hg3aHJRi PiXfifP6mdP/otAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1716811833; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mvaI30Lc501OfGJxpLRPDdHJVdqbMySFwG1G/Pb/Fhs=; b=vh099PAndxLyEPIsy9E4zQcvEjjwomGo17E1z61rShLO1l/oy81WjLcrx6E9YBLFqcxuN1 4NJKbjtWlt3gj3LXl4MROawdJ3lmA1PecehlPSKQumw0obvCt/GfrrY1ZDa+xZTM0QWg8m CoFvcrONeO5ObJq6WjivL7O0auPCm7M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1716811833; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mvaI30Lc501OfGJxpLRPDdHJVdqbMySFwG1G/Pb/Fhs=; b=KrIgFpoO8KoA/E7A1TKrafaMlo1xGEQnE5ztSYWcl7Qbv4WAXr8pwACx+wRii1Hg3aHJRi PiXfifP6mdP/otAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8E42613A88; Mon, 27 May 2024 12:10:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id SHkOIDh4VGYEVgAAD6G6ig (envelope-from ); Mon, 27 May 2024 12:10:32 +0000 Date: Mon, 27 May 2024 14:10:23 +0200 From: Oscar Salvador To: Christophe Leroy Cc: Andrew Morton , Jason Gunthorpe , Peter Xu , Michael Ellerman , Nicholas Piggin , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [RFC PATCH v3 08/16] powerpc/8xx: Rework support for 8M pages using contiguous PTE entries Message-ID: References: <09f4ae803da751de7741f3d6bc5d94b8acf18829.1716714720.git.christophe.leroy@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <09f4ae803da751de7741f3d6bc5d94b8acf18829.1716714720.git.christophe.leroy@csgroup.eu> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: C30ED180025 X-Stat-Signature: zxzc4go88afe4n4sgr3h8tzg6ryoep6i X-HE-Tag: 1716811834-748290 X-HE-Meta: U2FsdGVkX1/B4hyK8RcLgDKtHqVXHoQVhjSC+EpHiy7SenyDNm4V+83HUmSGeQR7xcW9CxnyKdSVMZH2Y8LAjbwIdcvoRD+UShT4kIP+v46sGyhApiIP9OdazvzjqQRmnf2GSTx+uYgUS0TzwCE8dV/ANzwAgLSdWgFrPxu0CiwYP4XUYPCaWfLT+4K8eB2ivF9zVCOojzQKWNlGGRW71Wofz8P35aCxRbQlzv15LmwXGdVjO+75YqX3QE52R+SlRXWcqZWoSaL4ckhBjqZnskJNYJ30bGKgbnDiAqmmsqHwRXdNGJqKZ9wrG7kQAYtWkcOUCyhDYY85Pt4ln1i9P+nJZK0+f1vGHvzJe0TPGm8MxgjarUHQH+eEy9hGazzd6JPB0FpMvQ6OEEsPFgnBzveWUAAavpUXQ/xnxNAJMUoVY0hAiNzr8z1pMErEMDsSM+29ivhM6lpWP8nWCK+bzRUTixy/WOyhR8sfU5AGxX0Ipl55XBogQO/Z1IYg+uq5732ZRuLZoBcIdOBUY5qsBzDlu/mHl/10DG7kaqvnRGqDV2ewulAiP+nJwebTXV8JyCEhkpR5gO5CdgeOjRG5EjR8L0+O1aVP449mr5/gUkdZwxDSPO0Lv4RThiNdKSbIkqU6Z8DC5ZImNUOqbQECQTCe81jfz5/L663lmDCkZQspcVqwLcZqTIioAFVxZBUH5Q7R12b+V4r27Ab9cpm8+doSs1mftFxgfsoRmq4lzE97BpxBSWIvWxkWJ8x7V7Avy9O70uSEV6d3G2sT2IF4jkP4CAL8qpvyXjCOnKsUFa+DNds7EvFLOvRpS69h/I+nDmImZ8Y5vA60coCSVk48vBWrvS0XGWyM+39fkiU/lZxUiN0YhbkNPsLHC2KCcD4P7bcCXeGeXfOX5EKBMRbJzEZbAn/3V+EjxiHn/aHwuoKs10OKs9jiPGO0GgPGAqQekX4WZjsXdHfVzzq5Qif TTlA7kJb 56w0FbkZqUdh6LuLwZQdR0NzRe3hXN0t0+lzy+m6j7HT7mBUyG48SkUfBKlsdFNDxrAlCug4fRA5xm5EC49GcsakH3tnh6etOAx3UXAr4ROQAliR0vzyy6U+OmpbNRVrsESWeIbUidhe3jb7aSFq5ZXfnC6Wsawud+4ilzrbTgJn1RT+UZih2s9bUAhMB59F+MnQzUjfTzLDGw1Vjt4x526E0G5XmqsGP2t0eRk4b+6xH8c0IB+7Cq+9GXdHgxqKWxwFM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, May 26, 2024 at 11:22:28AM +0200, Christophe Leroy wrote: > In order to fit better with standard Linux page tables layout, add > support for 8M pages using contiguous PTE entries in a standard > page table. Page tables will then be populated with 1024 similar > entries and two PMD entries will point to that page table. > > The PMD entries also get a flag to tell it is addressing an 8M page, > this is required for the HW tablewalk assistance. > > Signed-off-by: Christophe Leroy I did not look close into KSAN bits, and I trust you with the assembly part, but other than that looks good to me, so FWIW: Reviewed-by: Oscar Salvador Just a nit below: > +#define __HAVE_ARCH_HUGE_PTEP_GET > +static inline pte_t huge_ptep_get(struct mm_struct *mm, unsigned long addr, pte_t *ptep) > +{ > + if (ptep_is_8m_pmdp(mm, addr, ptep)) > + ptep = pte_offset_kernel((pmd_t *)ptep, 0); Would it not be more clear to use pmd_page_vaddr directly there? -- Oscar Salvador SUSE Labs