From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DC3FC25B74 for ; Mon, 27 May 2024 04:56:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D0EEF6B0093; Mon, 27 May 2024 00:56:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CBDE36B0095; Mon, 27 May 2024 00:56:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B856F6B0096; Mon, 27 May 2024 00:56:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9B7C16B0093 for ; Mon, 27 May 2024 00:56:38 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 241A1811CD for ; Mon, 27 May 2024 04:56:38 +0000 (UTC) X-FDA: 82162965276.11.130DD9B Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf11.hostedemail.com (Postfix) with ESMTP id F3EE34000A for ; Mon, 27 May 2024 04:56:35 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="HoebKqr/"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=MiO3Ekd3; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="HoebKqr/"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=MiO3Ekd3; spf=pass (imf11.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716785796; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qpjZvuybnZOPV0Sin/gwYjM8aUTQBvD2n8uPNDZdxaE=; b=VkFTY05XfKBfjTf0KJiEVBa3yggPfVljODB/P2MATFmHFc9uKHcx9ysdtPu0jiu/jlQQe7 17i6rG3Ctp5pKVZUzH13/d/enCgEpaj8gN0lkES2XBTd5sRiDIDQC5AzYiUfqcx9PgOkiG eQlS0pr3E7gEIitVBNQb8PrzqJ0Sy0c= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="HoebKqr/"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=MiO3Ekd3; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="HoebKqr/"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=MiO3Ekd3; spf=pass (imf11.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716785796; a=rsa-sha256; cv=none; b=SoUi3+e0em9HCXhZHFtGg4ZgM5hi9meq6iOb9Z0zXnVRQV0fTDGPOYoVeqXeVVOA1pBR9s lUogoB37/cZFwSMss6feMAaxKmKSgMuSwr7JuUIkJM7Q0g+WCqcHm3cZT0wSetWh48Fydo xJ5OPWoKxQ8K9HNHK7x81zTzBh2xqPY= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9492D21C20; Mon, 27 May 2024 04:56:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1716785794; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qpjZvuybnZOPV0Sin/gwYjM8aUTQBvD2n8uPNDZdxaE=; b=HoebKqr/EdRAPAXhMZWVhgMUSAbqBg9tjRfij74soQ5TGD4UfC62oEsXyBhZCpUNdKC26z +UYJzf2K/6u7oijDULZJ8A7Zx/yY2HXWyxJxvfxyr6gCfKq4oKzsyJMHSk29L/LeRylJFb xonCLLZerZd6d8jP8iVl7sWUK4ATl24= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1716785794; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qpjZvuybnZOPV0Sin/gwYjM8aUTQBvD2n8uPNDZdxaE=; b=MiO3Ekd3jJ1FR62PkwVmq3cV+yckpwZ6SOoI5/42HWPpmfD0rq+t7W2UaxMoGq6MPv4Iit AbM8aVYr4E2BBCCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1716785794; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qpjZvuybnZOPV0Sin/gwYjM8aUTQBvD2n8uPNDZdxaE=; b=HoebKqr/EdRAPAXhMZWVhgMUSAbqBg9tjRfij74soQ5TGD4UfC62oEsXyBhZCpUNdKC26z +UYJzf2K/6u7oijDULZJ8A7Zx/yY2HXWyxJxvfxyr6gCfKq4oKzsyJMHSk29L/LeRylJFb xonCLLZerZd6d8jP8iVl7sWUK4ATl24= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1716785794; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qpjZvuybnZOPV0Sin/gwYjM8aUTQBvD2n8uPNDZdxaE=; b=MiO3Ekd3jJ1FR62PkwVmq3cV+yckpwZ6SOoI5/42HWPpmfD0rq+t7W2UaxMoGq6MPv4Iit AbM8aVYr4E2BBCCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 1088813A6B; Mon, 27 May 2024 04:56:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id CFN5AYISVGY1fgAAD6G6ig (envelope-from ); Mon, 27 May 2024 04:56:34 +0000 Date: Mon, 27 May 2024 06:56:28 +0200 From: Oscar Salvador To: Christophe Leroy Cc: Andrew Morton , Jason Gunthorpe , Peter Xu , Michael Ellerman , Nicholas Piggin , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [RFC PATCH v3 07/16] powerpc/8xx: Fix size given to set_huge_pte_at() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Action: no action X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: F3EE34000A X-Stat-Signature: 9emjwahrijjgibr7rm6cido3ikfrznn9 X-Rspam-User: X-HE-Tag: 1716785795-187092 X-HE-Meta: U2FsdGVkX1/fv8ISY928RL0+RI8wBsv+aEVd4zBF2H/7DV0QDEeZfuT/8HEuNqkgd/YkzKyk1vdnAhyDOD48PvXJgDeE4fXTiNsQyWlk8kqcDg+g4af9ADuWdFeDA3O7Hxyj2cGpBdYsqe28wb+sIgERR3bpwY4yEP+7yWRlOppKUix5KVBcOZhc2ZT+klm5u1tLyjse0Yt+LJyDGx51z+yrk2wnG1eajS2c5miLTHHMC5TZzzET5A9mnhF6jZJvUSfKvE+BZnkMvYqoX8YiqDMiSWZkVly1Y7fQakZN17J273FWOF8/oZp4FaQKYRuH8lLeTQYpx14v/K+6BSqyx2nGNiUNVLEjY4jg0tGJ79Rb2dcPXqO6OwqED9/s+k+NYrGwJscgIEfeRs6N3okri43NOWS/6oMSIFYcmEeDwObVdbAIxzi1jInoNBjNGZCUHk/oGbhpuQishLuO4xKj0vFLzeq9hTwcGeh4yPcrU54CDAWMYSv2bEoPzRkyRtal/q1hVen+r34MuvPolNkQP7xrsYZpljeS+xXU2RiD6zA0psHONc/c5tMmi+JQEeiUZ3KojdEn55lwn6OxRNIBoYTTmzM8+47psRvXZyonFQRYois1UKndyy17RQxo3F8aHjGNJttwiwdBMfew8wnPllpDROjA4WjKkPGXvBf7XGK8T3j3BdbbjDfiNrjr5uqvzMOrvwQg0hJ34tKZFJXvYE4AbHueAMO/D+eu5e7m0eE2AdGnNdoaSOn5wsAQQayW7Y785Scl1eoJ6UaQ8g5SQjZIaIrEaU0TiGlSavruj6OKRmMm1Lyr8SYjQm7iH1KgRmEVzAjcvIwfypW7KZmZSeXMFLHMnvqqKyEh/DSh5Klg29N0UZUbeJbMTcbrQHG20lWucvZrf3auEb1NK71Gv9tvcWi/tsOJpD2HKIWJEFRM9fHwCIxSJaZ5AelE4bqk/7T6YBP22AHuCeQvxQp Bl1IeqQk 6plJFadsHa+9I196afD/MAv0UdDgRXUqL1CafaHaLo3GUcZ1TCETqb7vWxKqC7yuC+zVYFerKAB2EOt+OtuU6jYJXiVWQndUghTytbJIgd2UOHrJNgfe37UZ78uWJaUYOhrK97LMscDZvb+z2lQlmqbtqZFEEnCcB9DHyUKgD3HKiaCSznrVHk2siSwhEASM+SWnv6j7aqqlGSrG/AsitAS/6qAflvlMKygNqHtay3j6oBBuMKkSadO+QBDGSXYDkHndyhQieBcJJs7QIyJL8DQ9GRv7QUzPUeWyYXvk3LTbAhLiOP0m1/r8qnQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, May 26, 2024 at 11:22:27AM +0200, Christophe Leroy wrote: > set_huge_pte_at() expects the size of the hugepage as an int, not the > psize which is the index of the page definition in table mmu_psize_defs[] > > Fixes: 935d4f0c6dc8 ("mm: hugetlb: add huge page size param to set_huge_pte_at()") > Signed-off-by: Christophe Leroy Reviewed-by: Oscar Salvador > --- > arch/powerpc/mm/nohash/8xx.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/powerpc/mm/nohash/8xx.c b/arch/powerpc/mm/nohash/8xx.c > index 43d4842bb1c7..d93433e26ded 100644 > --- a/arch/powerpc/mm/nohash/8xx.c > +++ b/arch/powerpc/mm/nohash/8xx.c > @@ -94,7 +94,8 @@ static int __ref __early_map_kernel_hugepage(unsigned long va, phys_addr_t pa, > return -EINVAL; > > set_huge_pte_at(&init_mm, va, ptep, > - pte_mkhuge(pfn_pte(pa >> PAGE_SHIFT, prot)), psize); > + pte_mkhuge(pfn_pte(pa >> PAGE_SHIFT, prot)), > + 1UL << mmu_psize_to_shift(psize)); > > return 0; > } > -- > 2.44.0 > -- Oscar Salvador SUSE Labs