From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C2D9C25B74 for ; Mon, 27 May 2024 04:56:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CBF436B008C; Mon, 27 May 2024 00:56:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C6F646B0092; Mon, 27 May 2024 00:56:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B368E6B0093; Mon, 27 May 2024 00:56:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 945816B008C for ; Mon, 27 May 2024 00:56:07 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EDD02412DA for ; Mon, 27 May 2024 04:56:06 +0000 (UTC) X-FDA: 82162963932.20.5DE0B90 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf09.hostedemail.com (Postfix) with ESMTP id D322314000F for ; Mon, 27 May 2024 04:56:04 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=OFtu+AIv; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=gKgvAIJr; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=OFtu+AIv; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=gKgvAIJr; spf=pass (imf09.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716785765; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xC5zp4HlZu07QkP75GPGGYKgpdHreqvBoXt6mnZlkEs=; b=ufbDo1gMQBKlWiharDqAPFOVkFifNFqtycis9SgNMj0bpGd160eFrbEnapvvaoIY6+qPl+ b5LwLurZaqerkA2FZ1oOlasCSb29573Gf4rS96FRzhWHXCXx3TaCgkZyKV/SCCilKKTSxN q8ya+CyS7SxJF4LEdY6WBp4UTduraFc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716785765; a=rsa-sha256; cv=none; b=TuvbKACvZ5EN20O052doZTLKM2/HmH6E3vx5MDXWBqbpexqMlkKmv4dzxTFqFgN40z6xFu b4kwHWURbZZ7fKM1c+CBUeRwbXhNBjBuJOemyZuLSoy6j59yA10Ofu7PrPLey/HqS3YdKp NQP2c6JAoE4F61edz+QyCYfqwatBnYA= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=OFtu+AIv; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=gKgvAIJr; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=OFtu+AIv; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=gKgvAIJr; spf=pass (imf09.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1D5601F8BD; Mon, 27 May 2024 04:56:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1716785763; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xC5zp4HlZu07QkP75GPGGYKgpdHreqvBoXt6mnZlkEs=; b=OFtu+AIvEFBHI7CLLozC3h/eRZHm8F+B2wBXLlvWcSR+3kbPqOHglqZW6aTQ7l75/l1e4x XZfAbxQqlMCOH3ujBeCuGIFJeSUsqGMEl63asJ8IH/j6Di1uvzBemsF2ICZ4vlLm7rlzit DftKcNb86yaaxN+Mlh9ls7ix4sKsLqo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1716785763; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xC5zp4HlZu07QkP75GPGGYKgpdHreqvBoXt6mnZlkEs=; b=gKgvAIJrkIFFeoKTrAZkAnnA+2IeuOQm55UrZ0Sh6aHkWiHBHRpf5XdVO55mjjnQGk0brV ak70Quay7XyHLjAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1716785763; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xC5zp4HlZu07QkP75GPGGYKgpdHreqvBoXt6mnZlkEs=; b=OFtu+AIvEFBHI7CLLozC3h/eRZHm8F+B2wBXLlvWcSR+3kbPqOHglqZW6aTQ7l75/l1e4x XZfAbxQqlMCOH3ujBeCuGIFJeSUsqGMEl63asJ8IH/j6Di1uvzBemsF2ICZ4vlLm7rlzit DftKcNb86yaaxN+Mlh9ls7ix4sKsLqo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1716785763; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xC5zp4HlZu07QkP75GPGGYKgpdHreqvBoXt6mnZlkEs=; b=gKgvAIJrkIFFeoKTrAZkAnnA+2IeuOQm55UrZ0Sh6aHkWiHBHRpf5XdVO55mjjnQGk0brV ak70Quay7XyHLjAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9786713A6B; Mon, 27 May 2024 04:56:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 9T1yImISVGaodAAAD6G6ig (envelope-from ); Mon, 27 May 2024 04:56:02 +0000 Date: Mon, 27 May 2024 06:55:53 +0200 From: Oscar Salvador To: Christophe Leroy Cc: Andrew Morton , Jason Gunthorpe , Peter Xu , Michael Ellerman , Nicholas Piggin , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [RFC PATCH v3 05/16] powerpc/mm: Fix __find_linux_pte() on 32 bits with PMD leaf entries Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: D322314000F X-Rspam-User: X-Stat-Signature: txfwnbi6hmzrojcz7cbxny1mx3xpqw4t X-HE-Tag: 1716785764-752290 X-HE-Meta: U2FsdGVkX19LG1WTwkaZJtIXIXzWUuTl2vqwXDAwuiEKt0p2Qhn5tzwaIxgv3wgRYtghigUrIp6M1gxvjFiOXJIhuMzvgfRMetiu07U9M78t8Ll3rKNfOQVla/sDQ0cqHSnh6L0FzZIHtOmY/D1oqCtxv8LS1yFn8CwTzbtsK6vEpLfB68bSTmLWrBkT9Eu6slXRdySB5UcEQP4mQYNUXGiZgolBs8s1U0hcv+UqXzJ/RoWhsKrIdqdfw//Eg7krtUEwctxq4iu8UtDlJ8xdLXQhypPbogT+Sh4r7PK6+sQs/qVCf+/axh4Kn9C6L+MzIZmb9yr1aGlC9zzYtxQJGUO6yXsxS4lSi5UU4F5Fo2vf1MkVbpkaXMXf8T2pirYkeh4SemVBkOFTztuQisbi5p700i3k7PjQobv/JPdpHbM5ts9bpUP9TbVvAwVxuZiNh++soR8kA1enCP+bJcv7vPHnK99i3myAuOQHuQ7Xa0MGgRjBxVpnR2lyV1nII7gcrTIbXix+S8HiT9zxNdvfTjNGbw/jiHirkgmOXcJN8KES7PxqanHpLEnbbSnsI22FQfmHlC27t9FJ2aojTQgwY5y1DRkqJjSVkNciiRF6F9ZMWQVsoIRYzBS+9Qayz7GBzlTJmKJ5VTWc4VowoozgfVpCclJLQ9TeLGlEw4uCyRLyfQEqoekaJTmGcy9uLnGlKzwrw17oX9a15OwKzKKCWxmbHyEIwylOSD3OLCfVayrGk86BXbisaUUquDl99LPcFfNQ4TgH707yz8yvysF+urAeDAJKavZrSdRPFtomhyOZZAho37i7YX1GxDe/9kqbVWwW1HqT1reptXfiOxAIWIImEtT8OyiBoy786QNdGNEXx4LssDsVXFf3dRz0qQa3W8drya3qgnYlV2Han7qTf8eQv/xo+pQtkOZrWcnMvEL6KrWctKyncT7hSQhjvamM99DxiBcxLHvADmfpN7v G2+h5OFN CTtObxDnQ9Pji3ad+Ws6uLOOrHzzUxp6iTkmX2mEMKO5PROBMk19BZGfDsjRgAK6Zm49MgFwpRxk7VRGpUNBaUXw8MvCc7hEzyDZUTy/ND4mhcLV6d/YOKzT8kWP9TpO29hhAPALrI9aNrpGRFFCtikLLCJviEZTax7gGAj4giWRFeDs12OrqssB/KigzZRCl4QzSh9DU7+UsaHD/9LKWy1xMzUA0CTdl41SJju8oCtQx3AFQgoEdhkQ41SlmepPTUupUwKU5t00MveON03hSSWZVfLF0Of1RrcVn/edD2MlaeR9eTZODsB0JxA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, May 26, 2024 at 11:22:25AM +0200, Christophe Leroy wrote: > Building on 32 bits with pmd_leaf() not returning always false leads > to the following error: > > CC arch/powerpc/mm/pgtable.o > arch/powerpc/mm/pgtable.c: In function '__find_linux_pte': > arch/powerpc/mm/pgtable.c:506:1: error: function may return address of local variable [-Werror=return-local-addr] > 506 | } > | ^ > arch/powerpc/mm/pgtable.c:394:15: note: declared here > 394 | pud_t pud, *pudp; > | ^~~ > arch/powerpc/mm/pgtable.c:394:15: note: declared here > > This is due to pmd_offset() being a no-op in that case. > > So rework it for powerpc/32 so that pXd_offset() are used on real > pointers and not on on-stack copies. > > Signed-off-by: Christophe Leroy Maybe this could be folded into the patch that makes pmd_leaf() not returning always false, but no strong feelings: Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs