From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3634EC25B79 for ; Mon, 27 May 2024 04:52:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9AFCB6B0089; Mon, 27 May 2024 00:52:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 937856B008A; Mon, 27 May 2024 00:52:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B0C86B008C; Mon, 27 May 2024 00:52:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5B5AF6B0089 for ; Mon, 27 May 2024 00:52:56 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 09A92161239 for ; Mon, 27 May 2024 04:52:56 +0000 (UTC) X-FDA: 82162955952.03.848BA54 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf29.hostedemail.com (Postfix) with ESMTP id D074C12000D for ; Mon, 27 May 2024 04:52:53 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=TPmoAr1l; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Scjl48Op; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=TPmoAr1l; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Scjl48Op; spf=pass (imf29.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716785574; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=q7vYNtWXHN0koVdw3jOnpPUhzKwJD0gqc9GMNDmYMko=; b=aXnhGqp+A7aKaP8hqA1jYuyKdp6oiNjiYQuKeZYO8OKwXlLHSjFv7auwamg9tdMzPFtxyz SGXJnvIGavBMW/l04CEcxgG4YPOOXiyyh2+oj5Jyn2rtVPcmZH0nJZp/EYZ8cCmptlDrql GKvLBTiAG5WpNiSDwYrC2RA1771iGHE= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=TPmoAr1l; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Scjl48Op; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=TPmoAr1l; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Scjl48Op; spf=pass (imf29.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716785574; a=rsa-sha256; cv=none; b=H3KlHbmXhXoQoXLX+DSxYSzwbzWguPnsp3ARA7TnyEQp1fcpx7Mugl9bwCosPJAIXNQzOt TJxvE8l+uLyp0ZRVq2cPLnEWe7v4LdfRxOZN02+Cr/876hkhOQybWI2rzoRzqChjUV2JaI UBvMq00MnO23bprdc2OKVr2C/InZhYA= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 08E9221C1A; Mon, 27 May 2024 04:52:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1716785572; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q7vYNtWXHN0koVdw3jOnpPUhzKwJD0gqc9GMNDmYMko=; b=TPmoAr1lDAbCuGfjGQ25qRi+zi53ga379HbEw0aCCymei9yBEPcYHUdypqr8Ab/nvFbv7e ImZZowl2gG+o9RcUWIRHmMnfTzk3EowJlf97dYga/plmFw9q+06uhC3BG2mJ7mhnPXWXzx LC1tU38b/9UF7lqAoz/BIaW7Y2R4ksI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1716785572; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q7vYNtWXHN0koVdw3jOnpPUhzKwJD0gqc9GMNDmYMko=; b=Scjl48OpI2hWkaKl8/2sLYSiB1b27PD+WTh54BW9jwOAoBCou9NuPc4fyRzPe/wH0cW2sP Td7UF6+/HvUuPsAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1716785572; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q7vYNtWXHN0koVdw3jOnpPUhzKwJD0gqc9GMNDmYMko=; b=TPmoAr1lDAbCuGfjGQ25qRi+zi53ga379HbEw0aCCymei9yBEPcYHUdypqr8Ab/nvFbv7e ImZZowl2gG+o9RcUWIRHmMnfTzk3EowJlf97dYga/plmFw9q+06uhC3BG2mJ7mhnPXWXzx LC1tU38b/9UF7lqAoz/BIaW7Y2R4ksI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1716785572; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q7vYNtWXHN0koVdw3jOnpPUhzKwJD0gqc9GMNDmYMko=; b=Scjl48OpI2hWkaKl8/2sLYSiB1b27PD+WTh54BW9jwOAoBCou9NuPc4fyRzPe/wH0cW2sP Td7UF6+/HvUuPsAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 71D9F13A6B; Mon, 27 May 2024 04:52:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id OupCGaMRVGaZOQAAD6G6ig (envelope-from ); Mon, 27 May 2024 04:52:51 +0000 Date: Mon, 27 May 2024 06:52:45 +0200 From: Oscar Salvador To: Christophe Leroy Cc: Andrew Morton , Jason Gunthorpe , Peter Xu , Michael Ellerman , Nicholas Piggin , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [RFC PATCH v3 02/16] mm: Define __pte_leaf_size() to also take a PMD entry Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: D074C12000D X-Stat-Signature: onkizcmob9q576yd6n5nsr8juyu5ccp1 X-Rspam-User: X-HE-Tag: 1716785573-269011 X-HE-Meta: U2FsdGVkX183pHYYtQKtGMeNutCCqHc+AT/akSJTNrxrsxPqt53xiZNVVQhHXcugy0UBWlWyau2MXAdcw7MXg3gByMcS2tQ7lIWFq5N7HF3qwe+KqKzV3ATgQtSH+mH13UU0FH6VcMVD0UQ8yRbqCub0qBybmjGxwA4/SDfR7iadyacK52kJeNzynZ//Bmeo1hO2C+sI0W+Jnczye9YoNsRpT2gY7tycdmvnbHH+fkE37PbwEDnvDcO6WzCe4vmIqhZ9zFgMwxerYoFC17f660sbR/BACD8LJl/dTw/S0NGCKA7coEZfrsVYsRhfcMSTK0TRRCb7qnHhBQ+nRR++4wmNu03WbcrJXclJ6vEdmICyW0XtXhc25KVOoc63rTukH0x1B6kx3RoOWNZMhs7B9yP9W0+O1W6BIC0sLkWjij4fjl3Wnw2AO2ylymE5bBNr3FyunpJXk6zWmeuoD/xuS5a+JlXdX6bSdomx9Xcl7A5htgYCn7UFDikK8Oh9FsSbNqzdVgONKobo6UYLN4L9TaQK80PH1n3Oa0req1f60ewQN7vv91JtuP+Sbqwj/Bl2fA3y7htJVprbcLumuw8Ify0ITXiAQ/s3MdpPg1mgZW0+JJsIXeyYznRRN/wVJ9StvE+b9rD6tcK07OOAEzlfwRNxwFKIFM/81vBvb3x7RCqk1EsmOfGownWoYaAff2gtugrS11NFqE130Qalw5Q4NxPrujleSUeI16vZOPC4HJGMERF9oDLatadfYZ0ReCtQ3tRNsFXTxVF98YYqVvma78ZpFm5axpmk12RcWJpEDVZsBDNssoFyi4s5fSyHGP4K9YdYp4Bz9DLMzpKm5dQRMN+Jj/gJXvOn5Ers4ZltkMMiVReNFxVMoZQ6PRfFunCgwWc22nS962YCj8II6c7QlzbUumBpV23nvpKO8DPR50WJiLZMtPknN7KZEN1unE9o9ZTOvTE/6/q8v/IFHEH RBrcYyw3 kVU3kStF4IfjZbRS54yX9Cx5WnK2nxzsU5WOi9qoIPL0qGADqdgmRfTL7W2lSLXcAVxtiNsu24ZxfN69d3h0N81Qwz80Xfo15KIqlppsGpAF9tXEt0R2YeucKVx8XCkiQc5fc9S9kRkrD17TtHd5oARuh5k6oPnFKZW11XgnW7jAK3X5yiQfbGxqXJgx2jkOsmurv2SOnPgVl4Cf4nURCxrorW9Y9xe5/mlIqk9+w73bhP+0s2HCn2IyR2lmFpcHVzcbXQaaIVYyyMZX7HScDdBthl4Rmu6Hfuxz6qM+q8oN3Spsipgv3C3Jw6w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, May 26, 2024 at 11:22:22AM +0200, Christophe Leroy wrote: > On powerpc 8xx, when a page is 8M size, the information is in the PMD > entry. So allow architectures to provide __pte_leaf_size() instead of > pte_leaf_size() and provide the PMD entry to that function. > > When __pte_leaf_size() is not defined, define it as a pte_leaf_size() > so that architectures not interested in the PMD arguments are not > impacted. > > Only define a default pte_leaf_size() when __pte_leaf_size() is not > defined to make sure nobody adds new calls to pte_leaf_size() in the > core. > > Signed-off-by: Christophe Leroy thanks, this looks much cleaner. Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs