From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1305EC25B79 for ; Fri, 24 May 2024 08:18:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 980E36B0085; Fri, 24 May 2024 04:18:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 933EB6B008A; Fri, 24 May 2024 04:18:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81F296B008C; Fri, 24 May 2024 04:18:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5BE386B0085 for ; Fri, 24 May 2024 04:18:31 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A9C54140886 for ; Fri, 24 May 2024 08:18:30 +0000 (UTC) X-FDA: 82152587580.15.25A5F35 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id 0C5CC4000C for ; Fri, 24 May 2024 08:18:28 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tmc00zJF; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716538709; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f0gwQzmgARA+7xGLs+qq9GW9Dc6lLwFcs+/3nIK7FDM=; b=CkmwOjCHg0W0Qk+oRBl79KP6lFTrmqqEyHcpLyWqUaPCNmpK4L34CXUHsvvavb9WstSBA0 4B7GZ+ElV/8JMvJNuyeSntGXnMvzMBi2tu485db9zNjRKwAXu6aYU4nADNiSMXZ3ohy1QG w/FB5Mz5xbDGebBWE7/YcZJXbCHc1iQ= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tmc00zJF; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716538709; a=rsa-sha256; cv=none; b=wODn9d+pAoGLhcX7FeZQ+1JPXvn/h3KmcWiv92E/3jdEr5n5ylC7o4+ECISuv/wwA5CnvV cUgaXo2Nt0WRDonLpz476ER2c84mMTEBRabUWe4gs4NY0U3/+v7Y3iXidZpTzUSNaDE2Ih 2Nhjzx8+bkOPhSbKBzZNuT1JBiBqvA8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1B2266304E; Fri, 24 May 2024 08:18:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 99638C2BBFC; Fri, 24 May 2024 08:18:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716538707; bh=lgwJBOWqzRy+5aaXpuF27fWTArlpjSPAC/S1o1/PNnc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tmc00zJFA7PZE/wjfL8Dz+ubqR0LykT3RNXQUzIPGEEIEUH5pWr9KQKEGjfkNaqUf Flzd+PJaZd6jkHc6RDEGldhL/9b3BaRx8X84Ecj0MeHOZ8KauS3iTyaT1rAgppmcsv fpH1Rjbm/+HQ0euSaRfR3k9AB6vBi9+9e1mzW21SEl6lXkjbUG/+Xar5FBctoNK6wV /5U0lytpuImF6ee3zEcgs9Tb7pXiTl5YlV4RGN4X+4xkY+1aDD0MP9eZUQWLikxVuR 7qxrM5sssShwyoGKcCtKExA4ZxttjrNUFyEHkEmpMRZLIg4zKydVpl9sI/C+XQoXLy y06m7/agtMeOQ== Date: Fri, 24 May 2024 11:16:37 +0300 From: Mike Rapoport To: Wei Yang Cc: akpm@linux-foundation.org, linux-mm@kvack.org Subject: Re: [Patch v2 1/2] mm/mm_init.c: use memblock_region_memory_base_pfn() to get startpfn Message-ID: References: <20240524011914.27854-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240524011914.27854-1-richard.weiyang@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 0C5CC4000C X-Stat-Signature: qh1pn8h7z7si19iy6fi3u7djg69mecwb X-HE-Tag: 1716538708-456177 X-HE-Meta: U2FsdGVkX18kHoEbCgNDF6kDTPiAuMKKJL5Qc7PXXGhjMQG8n6w05LfpkLc8EghFgCYh5Mv3QVAsItrli8ROkeOb/7l6qAMzxoksXuqsWg1BFk4xRSDGYW5cqVqjJFQfSpg5iW3rt32yx/2s7lxutzpmBxbrG48Ua9LkGLQBfq4piDsCVw5pcW+IE0BtgibfpbUtMVyeHn49O9yKkk6n0XTWqfjrlmHAolbl9dYY2oZc5t1RYcwAjAUXsXU12DNEO1VboC9f6XChzZKkEGKaV9unVZTlfp80d6rCYZc6e3R6wFVTjG9ntVKO9lcpJGLV8Y3Sszz9nuSiIPFSoMAJgLWjI21v98aSDvXgwZWTfYLsv4IsClQBZ5SJyblGZL04TKPZKRubjD9FhP60WpAxTU+AWIsE0jyGltNIq/0DyV7xAxJllDubmsvzOnc4H4a5YkmOCu83QbtRhSyHjqcPp9AoIbmRAfZe/DJm6G0dGY9NvMSlwo671WM3Uu4Rq6v0PSyPuWgujIIzYIdfCYT9uvAt9K7ynAOPpyfjHDDhn13OBT4oOMolkL8x5AFsV2VMRsTcu4aoK9Nt9ypthSVzolrG0yyMtZNK0CAmc8gSsXE+ucFNlwIuqik+SNe68ITBU1kX92mlAeT7mKrqyw7FEfShkr4dgjnaTfEOlwJFMZ+drXNEQGPOomPozPpLM7p+Dmn5RhaDf94ux6fHSlNgWLWidcEdIC52/GMrFN4zQJlJvxYKCoqQASXPsIqcPxmrdj/P205K9+QIQUuvdtUChtbk/uETb7ctu7ns/jZk8bOrPJyJb2CFLfoBd7eOB0XKpWtRSFrzqkUfFYQHwEw3iOoiZ0SV0d85DBEv1NpZPqEvAfpRYp/DweokaTuMKNIAttetNQtIosIVHTyMsCBUyUi02BzQ79vpkbuGP1ryNhhgaimLjW5qIcNhs0Q0fET0WfBjZK5Uf1lZy1NT4tC QTEgUSjZ C8X5gj/pzMN5QA7LczwiBxjNx7lwYwGF8WAlA6NijwFX4lwWSdBywFnH+450B57SzCiG1+4glDuGHfeDSVJgEFG8r0v6H7lB08uH8tymtc/TU9828zj78V0D70jMJgFW6+O2BDP+ELvbqL7YNNxnH5V4tsmtbBfC6Rxtmt7qtxQ5HOOM95cmjKnkmf0BeSOMieIdtdVY9k7RJGNnDoE62G/UhgJnBfsTIv9ux6J2gvUfR9awvAfY2uLLKqyf8jxH2UjFQlCzkpGjJT6WI9NYNtcElPEA/xG2B31K2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 24, 2024 at 01:19:13AM +0000, Wei Yang wrote: > Just like what it does in "if (mirrored_kernelcore)", we should use > memblock_region_memory_base_pfn() to get the startpfn. > > Signed-off-by: Wei Yang > --- > include/linux/memblock.h | 2 +- > mm/mm_init.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/memblock.h b/include/linux/memblock.h > index e2082240586d..6cf18dc2b4d0 100644 > --- a/include/linux/memblock.h > +++ b/include/linux/memblock.h > @@ -565,7 +565,7 @@ static inline unsigned long memblock_region_reserved_end_pfn(const struct memblo > } > > /** > - * for_each_mem_region - itereate over memory regions > + * for_each_mem_region - iterate over memory regions Sorry I've missed this in v1, but it should be a separate patch > * @region: loop variable > */ > #define for_each_mem_region(region) \ > diff --git a/mm/mm_init.c b/mm/mm_init.c > index f72b852bd5b8..2dfb87841fdb 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -363,7 +363,7 @@ static void __init find_zone_movable_pfns_for_nodes(void) > > nid = memblock_get_region_node(r); > > - usable_startpfn = PFN_DOWN(r->base); > + usable_startpfn = memblock_region_memory_base_pfn(r); > zone_movable_pfn[nid] = zone_movable_pfn[nid] ? > min(usable_startpfn, zone_movable_pfn[nid]) : > usable_startpfn; > -- > 2.34.1 > -- Sincerely yours, Mike.