From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF038C25B78 for ; Tue, 4 Jun 2024 12:18:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44EDD6B00B6; Tue, 4 Jun 2024 08:18:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FED16B00B9; Tue, 4 Jun 2024 08:18:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 314C86B00BA; Tue, 4 Jun 2024 08:18:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 143D56B00B6 for ; Tue, 4 Jun 2024 08:18:31 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id AB75D16059D for ; Tue, 4 Jun 2024 12:18:30 +0000 (UTC) X-FDA: 82193109180.25.A251F4F Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf18.hostedemail.com (Postfix) with ESMTP id 51F651C001E for ; Tue, 4 Jun 2024 12:18:27 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=D8JcCSx2; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717503508; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WsZvmPHfN7fPNZg3H2FzpVxdFXo8damEw8Ch/6pQZpc=; b=ZOL5rwc/o9HvRFGRrXIvkKZTvuaO41xeICb8Ljv4ZFJ34o2vRvu2QzjXOTHMXqSfQwWnYq HHjv3yUM1GuWVuPLZp9fQr8LPVF38EvBKksvIGCqLRHZ4ZuTFI0K8Ruuw7ClQRyn6gpXrF fHehQzsFC5wTthXqxhJTLpl84+o8d2g= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=D8JcCSx2; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717503508; a=rsa-sha256; cv=none; b=nRJ9gIoeF+XZ3UUBO6r1YvrhfKDJKKGeQ+vPqEMB1mlhkMG73mSslCd6HWGoxlfgOPAfsr BBlOcS4oIF803z1HCa3MTx1j/Rh3GN4SqmY1PFqoHWH6pT8DRcLRaWUjdAuHffg5+CkywJ xcCmUZ41MVSdgVxWDMZtpYj0wKZzkpA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=WsZvmPHfN7fPNZg3H2FzpVxdFXo8damEw8Ch/6pQZpc=; b=D8JcCSx2q6237GVwshIIDw2PHf Flo5GVWU0AsstlVbVZfhj1nVe4WFAc+8tCIi7pRJkiM8zlT7x3a0UTtE0Ql2Ix52MRUcT5ynSGXKo NHlOrCIDu8j/fpdUe9te7kj2Or6UtaCLoMDIzX9ttNQ9fbqIb2PjfjP4dXfEvyKUIGfnLdWGrok1I y13oMWL3B/zugTcdOMvI2VnSwU+4BQ9BPIep0VWKcg7WZ90s3YkJrXxRuvQ9/is5Prd7eJMoIKX+q 19f8BDyFIaGzLOKaQBCk1FiXUt9Ko2e25pgLLjkQqV4SyzyyiT5I343JIVueIrMJ3bW0C2D2TbfgO 2RuT8UmA==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sET7O-0000000EoxQ-0f7w; Tue, 04 Jun 2024 12:18:22 +0000 Date: Tue, 4 Jun 2024 13:18:22 +0100 From: Matthew Wilcox To: Usama Arif Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, yosryahmed@google.com, nphamcs@gmail.com, chengming.zhou@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH v2 1/2] mm: clear pte for folios that are zero filled Message-ID: References: <20240604105950.1134192-1-usamaarif642@gmail.com> <20240604105950.1134192-2-usamaarif642@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240604105950.1134192-2-usamaarif642@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 51F651C001E X-Stat-Signature: orw7fkg4ie5x8wwopk1jf1eboqotejkf X-HE-Tag: 1717503507-65242 X-HE-Meta: U2FsdGVkX18aduuRurwAdNrVkVoHMV6yKVyfJo4SO5W+eSBiCPg570AAcP68o/7kXpvqwIxWmlIMDbG/P1iLHEu8LA7ppHEdWG3nilBJ7rKG4+jpqRROFc8P7SOFvz8eYjNVUcAbSbBubAuyMIQRzYDgIpjV0WkUmysupO8P32M/Byru5z+Dbs27PQ4bIwSsqqt+XU/lQ0s7OjovabjN1I7YX95tKvpHWxBZPk8vk39vWPbcuy1wXXQQX0MiQeU78eJOlo0DSfmWRH8237gk6Fn2fPmGti2Wep90b9bJnXtbYAioP/c7V2pZ/2e6qCEp5ES/chkYCrUzrXyWSSEzXypXZy0dJCAFph1nhQJhwsIwICXR5d7IVFOYr2rl4mx2Z36OkUk+nEZ2r76r/yFbDbdvTZvdyXtNB5Gg9qQ5qjVaplRWj9axrlbYJ+PJmPpnKoxiQ4OIHvHm3rMlZeZ3VcjAwuFFKOW6kmggq9su8QwnJKZM+zBVonZ5DRWACNwnXmbml3HeaUCbvjhgpZvvQsOoNb6Vc/S4MCcIrTRyQl0J3SnQvnqZwdQUQmjz41Q5ZoXSod5yKmOfp41/Bh3U4aJy6FBcUgjfOOuuBK1SPFllZfP40qNRpQligGe0Bto00zLWdD6amEtw5ZFdVTO/352XGUt1MGjoMbzNBWEPUklQsEP+SauNY9ugA/jF/TC8XwhciyK5hhPl12dPasBqC1zB9I9wxyPhWR3NfLZ1PAY4Trd0BlHgNKtEKQNE+hjpgurAps0CpE638T1BZGrdM5OzrCrXLQgMGeh+eSSM3d8tBMcigZUgRqBcIJ+98eqXsnj67v1Hf7Hwe3L/PusGvUC0MM9o+c8iFYjXvqw+oM4uo7JO1gteEL2SEx8dxlQZ+Dnxa8dobi3fYKkOyNCvifKmm0JKubNPMVZ54xAKzhj6EP3X7/GUAC/A0Nne7JJjwBi3x70YCFLzCO2ajJP 1Z8XdcCf cRaiIVmV9maZwODbtglhZfl8yjJi5r5m09+9D96cIRo8vuzRLFxyBU+XuYu0eGUd0LpnJxP/ycTDKJ+VtpI53KZ86aTYva7n3id32Zd4itTZ2kECIjPwtE9klXtGDPs8aGWbwIWfLFsqtHjc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 04, 2024 at 11:58:24AM +0100, Usama Arif wrote: > +++ b/mm/rmap.c > @@ -1819,96 +1819,101 @@ static bool try_to_unmap_one(struct folio *folio, struct vm_area_struct *vma, > */ > dec_mm_counter(mm, mm_counter(folio)); > } else if (folio_test_anon(folio)) { > - swp_entry_t entry = page_swap_entry(subpage); > - pte_t swp_pte; > - /* > - * Store the swap location in the pte. > - * See handle_pte_fault() ... > - */ > - if (unlikely(folio_test_swapbacked(folio) != > - folio_test_swapcache(folio))) { > + if (flags & TTU_ZERO_FOLIO) { > + pte_clear(mm, address, pvmw.pte); > + dec_mm_counter(mm, MM_ANONPAGES); > + } else { This is very hard to review. Is what you've done the same as: if (flags & TTU_ZERO_FOLIO) { pte_clear(mm, address, pvmw.pte); dec_mm_counter(mm, MM_ANONPAGES); goto discard; } ? I genuinely can't tell.