From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D22F5C25B74 for ; Tue, 4 Jun 2024 04:20:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 049406B0085; Tue, 4 Jun 2024 00:20:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F3B0F6B0088; Tue, 4 Jun 2024 00:20:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2A036B0089; Tue, 4 Jun 2024 00:20:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C4DBD6B0085 for ; Tue, 4 Jun 2024 00:20:18 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 22F0FC1211 for ; Tue, 4 Jun 2024 04:20:18 +0000 (UTC) X-FDA: 82191904116.04.BB68323 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf09.hostedemail.com (Postfix) with ESMTP id 73FB6140008 for ; Tue, 4 Jun 2024 04:20:16 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=N0wGy2DK; spf=none (imf09.hostedemail.com: domain of BATV+2f856a388af7b72b4029+7590+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+2f856a388af7b72b4029+7590+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717474816; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sT+cO72nxMMP/SxstIKj9+I1NsF3VgrkB0TAyIWSGKw=; b=U3hJ+Zcl9sr4obDZhLgUGEm8zh/dN/EsNtn82ewL4VrNCjpLWLIPCpY8eiEoMaPo+PRIo8 NjoUX1+a4WnU+6E3hp7GGWuilcpQ4PpLQEvc8czCSGqKaZab8VbJWE7alj1sVV5v6EdCjo nZIy17cWFtpJCyHQ8z0AbB3OwjzPG9Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717474816; a=rsa-sha256; cv=none; b=F2gh1oNumHMlWjKgkc7y5FhGVHN8oNOFzfrYRo9239wuRXsXvwafyZjG2RN2jlXN9ubLgF V6PKcuKoa9hy3B/Q0c3QWejQgGEvpSWBlsC8ulCG27O1yZQWkfDw4kTUdX4MydUL8XlmAy r/liXQ0F4KBMWx6pdmLAAobJl9FWkzY= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=N0wGy2DK; spf=none (imf09.hostedemail.com: domain of BATV+2f856a388af7b72b4029+7590+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+2f856a388af7b72b4029+7590+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=sT+cO72nxMMP/SxstIKj9+I1NsF3VgrkB0TAyIWSGKw=; b=N0wGy2DKjjGjlS+bVpn8ihFQUX BdVsOOMCwuF0fYw0GasnMa+Da7Bv+JPbb0+NQwx1P13gFAf1tGCEea3fpfROiDiYw3yuSANP6avau FaQ3sVRXZrKSL9aY+pWLfIRvVDQDBddiP0ROVnbUVy23N36cwoPMh/KAi7lFpi2RfT7EuNgDtJf99 E2q7j5p8+brL/e8R/Jy0EmPBfKoedmxMV1DLQRqz/m+YaysD9sQeFOznNnW7teuJG389Orco0UKnh IASWFPCI3qbuCu+Gj+DWESzaXQ3U7XqUdHTtJl4t2Ec1X6SPskGZ5yPE7OSvn5+YUptZ60c7jG6BG AGHEQ1eA==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sELec-000000019Y3-2MUO; Tue, 04 Jun 2024 04:20:10 +0000 Date: Mon, 3 Jun 2024 21:20:10 -0700 From: Christoph Hellwig To: Bernd Schubert Cc: Kent Overstreet , Christoph Hellwig , Miklos Szeredi , Amir Goldstein , "linux-fsdevel@vger.kernel.org" , "bernd.schubert@fastmail.fm" , Andrew Morton , "linux-mm@kvack.org" Subject: Re: [PATCH RFC v2 06/19] Add a vmalloc_node_user function Message-ID: References: <20240529-fuse-uring-for-6-9-rfc2-out-v1-0-d149476b1d65@ddn.com> <20240529-fuse-uring-for-6-9-rfc2-out-v1-6-d149476b1d65@ddn.com> <984577b6-e23d-4eec-a5da-214c5b3572ba@ddn.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <984577b6-e23d-4eec-a5da-214c5b3572ba@ddn.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Stat-Signature: f7a7r696da6gec3iqbf4p1dq7qhq4neu X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 73FB6140008 X-HE-Tag: 1717474816-846940 X-HE-Meta: U2FsdGVkX1+Ki7oq/ekHk3Pd5hDH7q3jH7B9WA84G7ww/CnOqoefJR5YvKv+oIXL2fEwCAi6xo5x1NcXDtihCmLyJJgqz8+ao1oDNYOoOgm8YTonPcsd8WbYff5OfummlMvfGKiJiGmTB7hZVBysQXpqvGxTFpM+FMoBOHO22aWuqUxbnRLGmcsUPFGUolUKGOIo2pNSyCWe7a0HgyOqMfaudSWPC+LTcccT8oQbN3pARaD3lNxCeqGSXZr96wFIo6h7Yi5fcTqwWCvuLwP3HvQJiFzjHc1PrsmO2XeNpGf7Z++LTktxYw3OjZRc1jRQ57eeettRT7fDaqgYJHYkIyY9OfrKI6lYLvAvMtaA96TyS27rxlhgN/yjQuZw8T+LPrIoeDHzeIa/aRg3BLFAHsgCbB3/rA1rJRyNGNno6W8dCHjfHSbUzYuxFqN2QWPyd/iRJ+qh5dq9frMXxk8n9kHP75oHjaCzf/HfbT5IdqDkn8uEkI0xxm/kLsTl6391kaeIlMBjeGSQfiVPjkt2mrfpPkq6Jnoq0RPtXaFGSZT7tsGQIJYtxsy8vVdQgyipc2IBKhUfMBaBKzA58j7D5fjb+8wh4ZNhHnHz/rJoC/VKXsHBn0A8ZIfaVhspVsls6+opGA3o/9x8a90thpniVvMepk+MRlpvZk+T23FNl2m7BaHb86JNvNtz+pzA0Z/K1UKULi14/yCw8m3Q7hyHzSeSflfy43LynycK1fuoLhZDG/NU4DP2MkqE7m2CR0dAdGMh74oS5AtLwXeXO+6Y+LftEdcN9nMR5gQ2evxrLxmElPOlhYudTzU/70XV27DYWeK7ARS7FACwVcg5n40VDIzS3xT24d3XT8eo6itEZeGsP7LVd28NXtnulBjhcZdUFavtTpoTxiqtRrJNi2//vhn+grPVIatT01ghtMVWT9HC2TteeYt9YoER6cPxLdTfHkCNy+hUZ3EdOKcaxES nCThFAjQ 71a2oK0uZ20EjQ1SKoKj+6UgIOGN6so0OwOaR7ViAz7b0ru8m7A8rZNzQyuVE+OOdItMqnDxU1NhHCXEuo0I3sqd5ZvC2uS2tKrsBZ+Dn8qDS/JzW0bN9k1Eh3rXrp4YE0hjKZBPNUqVX5ZH9ZyiOycR/6uXB7s4nXT7CmdVXlWlW8hHUKf55fPHjr4vqZw3yWxPl5eY38WRwmsgzytba4o5DPzMorhUYybRpoWA1IiYfrntf7xtvlWbDkKuJlMSlKcUqqDJPjAEbejXi5lT0NDQl3QhqhlDHBg2jJ4k1sapw3YIpwi1TnQzMW4qdu9d+14GXd6YS0132EIeaU2ZvlQGj6j4ZG/phbI0+20kPjXqrCLcHS8cZAS3UWM97IIFuSYeA+iL3Q3KAuTS73X2hKYwYljGEvh8npKrPBjfPLfb9pMXTokUTtaSt5/G6XdYz3rFGdR9Vq8PaO2/5/VxTHZePhMKUE/ivhnVJAgnaEmDq+ESrDoNZTOVC/A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 03, 2024 at 07:24:03PM +0000, Bernd Schubert wrote: > void *vmalloc_node(unsigned long size, int node) > { > return __vmalloc_node(size, 1, GFP_KERNEL, node, > __builtin_return_address(0)); > } > > > > > If we wanted to avoid another export, shouldn't we better rename > vmalloc_user to vmalloc_node_user, add the node argument and change > all callers? > > Anyway, I will send the current patch separately to linux-mm and will ask > if it can get merged before the fuse patches. Well, the GFP flags exist to avoid needing a gazillion of variants of everything build around the page allocator. For vmalloc we can't, as Kent rightly said, support GFP_NOFS and GFP_NOIO and need to use the scopes instead, and we should warn about that (which __vmalloc doesn't and could use some fixes for).