From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17BC5C25B74 for ; Tue, 4 Jun 2024 04:08:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 766926B0092; Tue, 4 Jun 2024 00:08:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 716696B0093; Tue, 4 Jun 2024 00:08:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 62C026B0095; Tue, 4 Jun 2024 00:08:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 44B666B0092 for ; Tue, 4 Jun 2024 00:08:30 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E0E99160B9C for ; Tue, 4 Jun 2024 04:08:29 +0000 (UTC) X-FDA: 82191874338.20.BA42739 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf10.hostedemail.com (Postfix) with ESMTP id D31E3C000C for ; Tue, 4 Jun 2024 04:08:25 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=JSQNjaS1; spf=none (imf10.hostedemail.com: domain of BATV+2f856a388af7b72b4029+7590+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+2f856a388af7b72b4029+7590+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717474107; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AmRDFRq2h+wkvcIuVopUs9+FGy5YQEUrcZGBabJNXm0=; b=zhI+H633jAyuW025ExVm3esjEZYQn1m5926mAQoqSfyBC9a71OSBNxOloykzJEmfaH5Ej9 HI5k4Ttc2zLQ6bb04CvzEiymrzngEwQtxxfmcLGLCx34RVE1kUZ/vIQo4frpB77lkfaozd IzZgEVlW1pL8KTqCZeOwN7NAKFMzjGs= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=JSQNjaS1; spf=none (imf10.hostedemail.com: domain of BATV+2f856a388af7b72b4029+7590+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+2f856a388af7b72b4029+7590+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717474107; a=rsa-sha256; cv=none; b=YjFMIL9ikjc+NZNZp4mxMrXx0ns6THTp1+/KVqrsFuN+Q+yxflVsM/1fdD2WjNZxmLPESm /3yDv8OQtm0I/fnVcygoEEeuVah+BaQ3lbX5vx9ADDHggs58fp8zEKzwnZM0qSXT2V5Rzw /P0seYvY/RjJZQAcE2Z0wyxeyDeiSAs= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=AmRDFRq2h+wkvcIuVopUs9+FGy5YQEUrcZGBabJNXm0=; b=JSQNjaS1pAcDInk6ao4C2YLd/4 Nq5dYtco79G3NfXQ/4VQBxW7Y+3YcI9MfS1Wy2l+tpPbtoSEJ63C219YRqoV2SBd9d8qaUGnGVB7P lrefRsbVGeI6sP3cEYE1DfWc+CCV9TQ0P2/1GPOeaM4245ZKL1pI6NmvRWLI1coSnjcxbEvjvpILn dhlWu7J5JQRsah/TgXlG8Dhwx3A6SlCMWqA0yTRn++0mBuvYeRF4DOj9LqrIeTPpV5+M5x6ZJkKWh entKWY48lcGLpidZ9Vvv2OaOGGW/n1bx4YJKIK3IzcJEbwdf7qkTYYhFbKFtS7RksnbiuLvpf9LcI UCcRpZYw==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sELT7-000000018kQ-0JBm; Tue, 04 Jun 2024 04:08:17 +0000 Date: Mon, 3 Jun 2024 21:08:17 -0700 From: Christoph Hellwig To: Kent Overstreet Cc: Christoph Hellwig , Bernd Schubert , Miklos Szeredi , Amir Goldstein , linux-fsdevel@vger.kernel.org, bernd.schubert@fastmail.fm, Andrew Morton , linux-mm@kvack.org Subject: Re: [PATCH RFC v2 06/19] Add a vmalloc_node_user function Message-ID: References: <20240529-fuse-uring-for-6-9-rfc2-out-v1-0-d149476b1d65@ddn.com> <20240529-fuse-uring-for-6-9-rfc2-out-v1-6-d149476b1d65@ddn.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: oja44b7o4au1uc7sp8tjdicusng5ixcc X-Rspamd-Queue-Id: D31E3C000C X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1717474105-731403 X-HE-Meta: U2FsdGVkX18hMfxPnntK1kh82GzO55CJAkJSZ6kfvDL2QNe5N/GRHfp8Ca9J3Pcbcl6Ks9/YO+1FVkHLHizzwJ9H76uVeQq988fTZdZ+nom2nFjOtFkrKyHydXQmfHUxMCvFFz+DRK3BqUwTO6B8HRJ9+9vDo5ope7mdbKMp86hlz0VrrynmJIoNSh2EEaOOXBQx4wrFs5ui6areH6kYs3/tev5+fBB02pQknLuyDEqesOHgPMUNs8vcKRJP9t8btFNFquV7xspLhXRt9p809+e3Ue+iD3uutgMGajkdLfjXW0EqdthMa2mh/RNGqD5tP/yFNXF1w/tSgpnsrmdPRc7C5m55sKUI/B6HTAXS7F8CnHgGmc4vxfZ2kVlM4V36p2AkBk5E8d6Y37UkeVxnhVClAtO9n4UHvQstTVJiRKwC5QfuBxEiFx5LMoPbtB/ZZ+QLsf/viQVuvTMDNsC2iPk1QuS3EmZfhK8hLJ7gVkX8QrRUbFeiGSq7TYJBhGadDALM5K9DxIYUAD1ezwHccZddP6HpinDuBDZXu7t5t+vCHk16wgz7cMF3KFES2S71XHWogC8dsuR0UnRVPn1Xy313vWZpPlMvYIW3py2CEOty3YCGVN9x4C50A6x6fpDhFpNAmoi4JV+WtEsxaYhzbXMfV9u88ZGcQhV/5wCxsnzZtI/9GWJVImz0G7DLOwAqL08gPREZIComjK23fl1awoEgYJlQD0INLCWVpiZPj8pS7MFsRur4Gp5hLLm4eznDHpy0xehhEDqixxPmZLZOsWoRTOS76V+Ko0YZbGvxTc5Lfl4e6liNFST+4Mhtqo0TpzIMrOOnlgOTVMce/FnFWGLLg0wjO2S4Guc0XBjUG1YF0aPCQEys4efj68ZcPtLACPT9iLvjYkN1kkfIpW3nTF+zaznyNvXdXJ6ECfyrlgdS7Z0FnC2wYApK05eAEHWG1MQ5R4fAA6pOdVvLn6m RKWXyvTx yuzFymuIYItcOcRSK00B+cuC5V3LBOBEY+D5tL/C7usUnHdQhM+UayO/9Z44JKWEUqpJPZDK86dYbx3m+LN6xvlVVNFCjKR5q2DlTFLh+dLmYu5gxfWCF9YATdm7escRJpbhDdiRPhLO0ppPfrFNPe1jgySbXYlIwWV76w/6o31E/QSKbyEFwJzBXY5vuSUfKpf8a+XcBVqm34xC1moptfsmqgVspkJTZnWlarS/TMEp+LH+CcH4vW6KpZ7IURImrqVLUky/pZhpTs51jbfFq2BtKUnytYn1DYJmUYM9NWuAGprZWztk/RqHef1p8mO6PEaY7Y58wYA5QbvspsZbW2f69PnYuUIHYQV/RDx6WbhWHfklJ+48HZT4CFaYTW4h8vOu/+z4eOqtap1f1OeZWGnz+N/WI/4dZU/Nf3CrRItlUKHLPri91U1Stiw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 03, 2024 at 11:59:01AM -0400, Kent Overstreet wrote: > On Fri, May 31, 2024 at 06:56:01AM -0700, Christoph Hellwig wrote: > > > void *vmalloc_user(unsigned long size) > > > { > > > - return __vmalloc_node_range(size, SHMLBA, VMALLOC_START, VMALLOC_END, > > > - GFP_KERNEL | __GFP_ZERO, PAGE_KERNEL, > > > - VM_USERMAP, NUMA_NO_NODE, > > > - __builtin_return_address(0)); > > > + return _vmalloc_node_user(size, NUMA_NO_NODE); > > > > But I suspect simply adding a gfp_t argument to vmalloc_node might be > > a much easier to use interface here, even if it would need a sanity > > check to only allow for actually useful to vmalloc flags. > > vmalloc doesn't properly support gfp flags due to page table allocation Which I tried to cover by the above "to only allow for actually useful to vmalloc flags". I.e. the __GFP_ZERO used here is useful, as would be a GFP_USER which we'd probably actually want here as well.