From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C22A4C25B7E for ; Tue, 4 Jun 2024 03:57:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5AD686B0088; Mon, 3 Jun 2024 23:57:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 55CC06B0089; Mon, 3 Jun 2024 23:57:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 44BD76B008A; Mon, 3 Jun 2024 23:57:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2797E6B0088 for ; Mon, 3 Jun 2024 23:57:59 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 99622160402 for ; Tue, 4 Jun 2024 03:57:58 +0000 (UTC) X-FDA: 82191847836.11.FC3AE08 Received: from out-172.mta0.migadu.com (out-172.mta0.migadu.com [91.218.175.172]) by imf22.hostedemail.com (Postfix) with ESMTP id 859B2C0002 for ; Tue, 4 Jun 2024 03:57:55 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ZOwBFQfx; spf=pass (imf22.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.172 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717473475; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=R6d6WXIvaz3gcm62V+C/H0QUwbpybzVpITkvGw7t1Mc=; b=Q410r2H5Y6dz15n/DFoSDhJ9Vso6T6Ssr7oDx+gGCbHnTIG6ueA4EEuZ/ylHIkKzQMfbpo 44gcUsx8SlRIHl6G/3du4cFCUyAv8RXbOk9RjnfBMumaUabWwNsPNLA6jOrfnTCtW33M50 R5p7GbGXzud+HeTSbIXsLMcMqqnWAq4= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ZOwBFQfx; spf=pass (imf22.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.172 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717473475; a=rsa-sha256; cv=none; b=Wi7z1lgOiqv+znUIEpPYOso29C33UKSANRk2ojWDb+lgy0VYGpO5XmNKCy4KaLuCAB3w8T nCvY7Uqq5P1AAmAXdIXj7mX3zcT/PxEVxYhjm9lr97uEC71MqkJADMx86RJ2gNubidauL0 Vo/q2wJvz06QsMXVU/tt2dNM9UV5/Bc= X-Envelope-To: shakeel.butt@linux.dev DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1717473470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=R6d6WXIvaz3gcm62V+C/H0QUwbpybzVpITkvGw7t1Mc=; b=ZOwBFQfxKJJ7/6drU8LYL33lE56csQSX+LeZrPWum+B+3BZCqRfrJxBtTTa2Eg74BPFblX K7DwFyU8aS+U+o2ViQw4UMSB7KT/OT1bg8QrTgYPWIduFsqnzHhpKm0BNbo6OBwlo2cxlE dFclKDMO0dN9g62xWaGmOTgyjrmsHfg= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: muchun.song@linux.dev X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: mhocko@kernel.org X-Envelope-To: willy@infradead.org X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org Date: Mon, 3 Jun 2024 20:57:43 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Shakeel Butt Cc: Andrew Morton , Muchun Song , Johannes Weiner , Michal Hocko , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 06/14] mm: memcg: move legacy memcg event code into memcontrol-v1.c Message-ID: References: <20240528202101.3099300-1-roman.gushchin@linux.dev> <20240528202101.3099300-7-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 859B2C0002 X-Stat-Signature: uda9cy3kyy1rkun9u5o4s6zwg7ci187c X-Rspam-User: X-HE-Tag: 1717473475-844362 X-HE-Meta: U2FsdGVkX1/S0jVJdZ9VTAMDT6FBEzyb5Pt0AylBWOtiivBihWygM+os8JpVKOMeJ9LY6LRwB5gwg+1fydIVO7Mb8jycpDsI2flGZbuk2X9XM3BR8NdT+GY0+tnqNAbEHGLLBMJ+7xPDCQJqwYK6V1HHfsSz7YlUglT9M20fHGx/2hNtRRKbfNbgHMkTSfZM75azIQICDoFABLor2jmj2D/MSjSH/HwIwR4F2k1hPkk117W3PAovPsT2PbEVTqawo8TFyDBtD+nx/w1VbTHyqNu2NsV4ZpqGeizqANEPjdKsxeJw3l+/LeuhTPN4qmNUsNtSXjT88yuaLj6sMWLAhrfzNUItaEcnHdP4QAPHWUDTexoXBqNT1QpDZwFIv6cgQ3yzhsH8/8Vlj0erVeSGGhDldq8brBFezAixoUztcUU+B3Ldk4K4YsAcG0pryzRVb2+/AtINs3nPNOdrPf9Anw66Ug7aenqeWNXFRHU4OwXnpOHUqXFhsWKL9uGxYYuidMh6eWU3Kon5RwMvolfgZhPH78JDCIAO9pzaBUCBEVc0WEsmW5JmKbOzrhFIoNID/+4qcOvxHCGW0nfMxSLkLEgklIov7yksh+y41DrAa+1W7yCnAKwhFL6Fhk7CHF7AsRJGO1E/Tzl2S9H94vKktculuO6AY8V1l0Su4bQB3Kmd9lkGCzNuhrBVPPtUSdfCQHrNOwc9BbQHyLH+9W7lQbo1G/rnrG06eNkF04z3nBSFEMhNda6fG3DwUU42CjEcQ/BO3oj1OHZvYDHKNbuVvM9O0K0YpgoEMA+2eeUYZxOOoSPpnK+qdiET2IFS87fbaTUp4bMLxnoGpX7U/u/IJ9Ji8Xh9YbUR6cMl88pN0pWONjleHul2QHI/u3HMg7EDAf8F087aqIQtPCkPkf+S187PVmr8qNu9n3O3xX4Tw/vju7Pz80DfXWRlntAjdYBSarZvQnMf7nlaZcqdfa8 EycAVNF1 BTAZWEscfEj1bXCfPK8d6xpr0lgWf1Sxp70u5q9JNcN2zht24xpR1/6iQOLdb6LEec8YB8DiRTQydygo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 31, 2024 at 11:33:46PM -0700, Shakeel Butt wrote: > On Tue, May 28, 2024 at 01:20:58PM GMT, Roman Gushchin wrote: > > Cgroup v1's memory controller contains a pretty complicated > > event notifications mechanism which is not used on cgroup v2. > > Let's move the corresponding code into memcontrol-v1.c. > > > > Please, note, that mem_cgroup_event_ratelimit() remains in > > memcontrol.c, otherwise it would require exporting too many > > details on memcg stats outside of memcontrol.c. > > In the followup work, we should decouple v1 only fields from v2 fields > and then we should be able to move mem_cgroup_event_ratelimit() to the > memcontrol-v1.c file. Right, agree, this is my plan. In the RFC version I had a lot of #ifdef's in mm/memcontrol.c and now I plan to do it in a nicer way, moving cgroup v1 - specific stuff into separate functions. Thanks!