From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF652C25B75 for ; Mon, 3 Jun 2024 19:13:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3276E6B0083; Mon, 3 Jun 2024 15:13:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D7C96B0085; Mon, 3 Jun 2024 15:13:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 19FC66B0088; Mon, 3 Jun 2024 15:13:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id F0BC56B0083 for ; Mon, 3 Jun 2024 15:13:31 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4E7981C0A05 for ; Mon, 3 Jun 2024 19:13:31 +0000 (UTC) X-FDA: 82190526222.05.3BD47DA Received: from out-187.mta0.migadu.com (out-187.mta0.migadu.com [91.218.175.187]) by imf22.hostedemail.com (Postfix) with ESMTP id 9C37BC0010 for ; Mon, 3 Jun 2024 19:13:27 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="c/TRXiwE"; spf=pass (imf22.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.187 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717442007; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0CfPycTlesiBI7O8m26mD5Nmbpxcsq3cn9s/d4zl6+c=; b=N8jnBu+IQyEbtwuI2xNgf6seTdLJcy84vG9zdVJnhO+AQvTzaL4TcH8cqQxT4hJ+vA7q9E ocOgqUrjUlk/g6avYboqi5SjQ0owexElrW8JlSGWVbtUochUmwDqVTSm7uQ1YZf60S4I/v O64QG+tjwShXwqvmIfvOwdaQnNdRhMk= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="c/TRXiwE"; spf=pass (imf22.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.187 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717442007; a=rsa-sha256; cv=none; b=HPBvjndptX6/ZZlPzTswhWaq5hdE7ErjnwFzBlF7DOqggG22lXWNdxXZF/d1T7LrFS5u3o XSdO7Q7H6cdBo/WnyRzp5Yr3nHdzhUEjhkOpV0XrYJda1WAbX4fs+giiAzp+FyaWvEu+3Y J6DPtD1FHatEYJmig+Oh6RetRKwf0+M= X-Envelope-To: ioworker0@gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1717442002; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0CfPycTlesiBI7O8m26mD5Nmbpxcsq3cn9s/d4zl6+c=; b=c/TRXiwEQ5O/B931i2eqaWnnWA17s39759N4Grg/wflQ7gTJnyH9jW3WWx0pmxjFf8X3hC fhBp7h9B9zFLBp99INlqNTdQTG/v3GRLjnLCy4Qai5gieGPkccJ07WfetG7iKvXyzdeXXI 3k9ofPrDuJEmVWM8itBv8AY4+8Vu6Uo= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: linux-mm@kvack.org X-Envelope-To: mhocko@kernel.org X-Envelope-To: muchun.song@linux.dev X-Envelope-To: shakeel.butt@linux.dev X-Envelope-To: willy@infradead.org Date: Mon, 3 Jun 2024 12:13:15 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Lance Yang Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@kernel.org, muchun.song@linux.dev, shakeel.butt@linux.dev, willy@infradead.org Subject: Re: [PATCH v1 13/14] mm: memcg: put cgroup v1-related members of task_struct under config option Message-ID: References: <20240528214435.3125304-4-roman.gushchin@linux.dev> <20240602120004.62824-1-ioworker0@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240602120004.62824-1-ioworker0@gmail.com> X-Migadu-Flow: FLOW_OUT X-Stat-Signature: fcamju9fqgq9ex44y98zz5xazd6iqg6k X-Rspamd-Queue-Id: 9C37BC0010 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1717442007-365012 X-HE-Meta: U2FsdGVkX1/P1+mBdU4Uztw1oyUsp4cLQfWUTSlRTZptGJ4NU1fbeoWN+LxNGK89o/NC5NMODo+VtVDuArqTkQtmi99a0pUzIcXz+a/LHNHsEUkqjoVfkl39kf+dABtUxEitmntnMcB5+zDCWtMccSzH/1xFe0XOSbTMTl7xx4AewZVh80sRHLjHVV0ZDUvb+7WK6TF3bu6xHCfRFg2EYVR/5htENlVbVbu65Jh4g1uaSol+XXqX72STfVa68nosorJL1efO52hzS6ylKLDZ2Ef7Q2tYmJ/5IVbzL5fHL7ko7zFJpVccWxfRXVI1SiFJEYRG8atvI8fUDrq6yuSYpVTIOgm1wjynXKhfIIOziRqtyhDe96mcv0HFKLI2Vqsgzk3TA0AI3pKp7Ej3egG5epi0qj2/n0YAl2BPkasbOs0o7JIqzLeP2S2TXwEpmTJVFpaH/KJg0yE7vXeSbxz0sjGpbJ6BWJJE8g+lFaYb/JYY3jBYtexlqS8d8hq8o3DlzRVsEreq7hddynfuEVeHoe4jaM5X57nFC/C+yc10Rdujz5cUfLfwVttYlW8gGTN/IRyq8U3NY7QlN2v3ZP24fhjnRwHTu4pkG2dKwlIl0YVq3Ug/7inpDZaLuuwMHuGJ6do9SELaHsQ7eeaF7reT9v7rkmeonp0Q26ykY+I0C82D2hPbguWHfuiTWxcWW3/v8jxrx9fm3XhsqtflkDv2O7DE3QCeH7xOW0ESLK4V8zYj+mU1fGZlJvaHqYAXly7q4eUuhNUOpxsUR9M9zk5/57iCc7pBv1HgqNPzGoa9hC6eGw4+ZO5kD+/0xXFBqOV+twtF+ELH3MdcCAr2aWdR+gSnt8aVGKnHmWYpS6bjg0XLyVM4BVvHKKu9yuRv/GLIzXvIbyDl7i2L5pQMvQg8CZhSTimruwX0SqCOfHhspI+wbPvfZWNKrLRfhLM7VF3yZgzgxUa6saQKFsu896C pu1v6wnA H5rGkmrAhgVmzDmgICRg5JFLTM2mkM5ea06JwzU3Zxf7JTJMm3jnZagM6nxUx5mYUiaqqI9aq3GjNZP6NXqFHoGCO+/YT3OU64vFY0n/VWwZh500CvmRAC48Jb9p6Ie3pwQ5X X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Jun 02, 2024 at 08:00:04PM +0800, Lance Yang wrote: > Hi Roman, > > I noticed that you changed '#ifdef CONFIG_MEMCG' to '#ifdef CONFIG_MEMCG_V1'. > However, it seems like the comments for the corresponding #else and #endif were > not updated accordingly. Hi Lance! Good catch, thank you! I gonna update the patch, if there will be another version. Otherwise I hope Andrew can pick your change as a fixlet. Thanks! > > It might be something like: > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index ba55ebd15354..796cfa842346 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -1883,7 +1883,7 @@ static inline void mem_cgroup_unlock_pages(void) > rcu_read_unlock(); > } > > -#else /* CONFIG_MEMCG */ > +#else /* CONFIG_MEMCG_V1 */ > static inline > unsigned long memcg1_soft_limit_reclaim(pg_data_t *pgdat, int order, > gfp_t gfp_mask, > @@ -1922,6 +1922,6 @@ static inline bool mem_cgroup_oom_synchronize(bool wait) > return false; > } > > -#endif /* CONFIG_MEMCG */ > +#endif /* CONFIG_MEMCG_V1 */ > > #endif /* _LINUX_MEMCONTROL_H */ > --- > > Thanks, > Lance