From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E025C25B76 for ; Mon, 3 Jun 2024 18:09:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D83586B0093; Mon, 3 Jun 2024 14:09:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D31A96B0096; Mon, 3 Jun 2024 14:09:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C20D36B0098; Mon, 3 Jun 2024 14:09:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A2ED96B0093 for ; Mon, 3 Jun 2024 14:09:28 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1B6C1140425 for ; Mon, 3 Jun 2024 18:09:27 +0000 (UTC) X-FDA: 82190364774.22.6AD5E66 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by imf09.hostedemail.com (Postfix) with ESMTP id 32F30140015 for ; Mon, 3 Jun 2024 18:09:24 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=W+EBH5Zx; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf09.hostedemail.com: domain of htejun@gmail.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=htejun@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717438165; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YXl034VbTvbkD/cq16AaCovQc9yLMytZtK7abGPdXzg=; b=q4GGGO37Ja97dcPegWeoF2xwc4JWCITD/cwrm9DI3+H3ivDkowx4kzaideSs/fk/ToNUzq ZwizIJNLh2/dn30NtavRe6/beSQwOuE5NHsXyz2uvv65wKBVdxto9ATbRVdJAR/+TZrb+l cvsU5czdosWKXdlTcNvYR1CwMkOBErE= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=W+EBH5Zx; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf09.hostedemail.com: domain of htejun@gmail.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=htejun@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717438165; a=rsa-sha256; cv=none; b=zlle/bYtHVtS15JIyJz8Ufua7ElSBNAvaMC3+h0FeTjXtEiVpQqgWZm4w7BIFY1fKRfWB3 mLVPVMbS7DWi+o5YWgc47/nHSv7uXBwX2814cn4TNpcxW82yaSzGjJO+3gYhgNoVkRUMe7 Dm/vHSP/4LyshfcRI/WXbbTRNKloojs= Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1f61f775738so33212935ad.2 for ; Mon, 03 Jun 2024 11:09:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717438164; x=1718042964; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=YXl034VbTvbkD/cq16AaCovQc9yLMytZtK7abGPdXzg=; b=W+EBH5ZxP37XJDgrgp1obZCRPewxVcTiCHdqQDLAV9bgVXi0bjWywDvlQWwmhsyUFR 2fD95jM1x12bC/OT8wlPK8XA25RCrvxEn1cZQU2KlOkbYjtrJOiZ3Sstl7FBShblx+wZ 7J3NG0Whn31v3zRSs7uFiYGtmw5Q9R/daoGJhh+++HfPTqIfPuWXGa/VwWPL4SUJUv5W ulsRxm75HVfuDtRo9E3hadfwxQkwTjGJYnnZy+MIuRdSHV5KQMs2fwoGNmojy4AJ1XUG se1fMGirqDSsj6woljLk60UaB1rV7iIhp8nMqFD1ephO34syTHyP35yLtcvmFzvdqBXg VQPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717438164; x=1718042964; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YXl034VbTvbkD/cq16AaCovQc9yLMytZtK7abGPdXzg=; b=Cq7ALQWRg7zrKQBMf85YLYN30Br2WW/H8edyyfhi80Zp2edfhj+ldRXPVPo2WExOjB ny/iV5sDiZf+8LB+lbgtMsRf+5C46ETPaDegegtFVJq/0q+1Hhv3ITyHyX70Yx2pwrfG l6rfmhLJiQzNMY5AWUi3XInuMkm5KdqUoH37M2PYDWiEEWhBq7sFSHFJcCop2fId3X/T lW5n0/71bv8sClWWdt/xDtwj+Orun7z8pN/F6jhdG75G7ioOAlhMMqzw0UaIGNV0m9+D 7HyTO9kT7PcuZdfgYSG0KmVFiPZRXOwbXfVayJG8w+g+gpVfn/HP0c1vCutKpy1SUXbH V6Lg== X-Forwarded-Encrypted: i=1; AJvYcCWfIAH1RL4IZ2ykuEpXVwSb8hPLos2y8oDbFUERxpeqSPHRPn4GXS4wyTeipPVdY4DM+LfvG+8eQar2MCHjHg9Utog= X-Gm-Message-State: AOJu0Yx3DK0JvlMNlrl7zYLO6yIu3R9zAUrebQhXvr7+LSUSHhHXBtoY b3aiV4Jj4UfqmzuIVL2XYw6O6LdSL0jnY6RZwbyWzwZsAe5sdcnv X-Google-Smtp-Source: AGHT+IHSwf3aVNsUusaergW0STCqU0itWuY9cjfQCrhrIMhWg30627T2Ovf4HIXKoM2Fm2C8sSjl7g== X-Received: by 2002:a17:902:fcc8:b0:1f4:bcef:e970 with SMTP id d9443c01a7336-1f6370cda21mr76848495ad.55.1717438163739; Mon, 03 Jun 2024 11:09:23 -0700 (PDT) Received: from localhost (dhcp-141-239-159-203.hawaiiantel.net. [141.239.159.203]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f6323e27a3sm67526665ad.180.2024.06.03.11.09.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jun 2024 11:09:23 -0700 (PDT) Date: Mon, 3 Jun 2024 08:09:22 -1000 From: Tejun Heo To: Kemeng Shi Cc: willy@infradead.org, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 8/8] writeback: factor out balance_wb_limits to remove repeated code Message-ID: References: <20240514125254.142203-1-shikemeng@huaweicloud.com> <20240514125254.142203-9-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 32F30140015 X-Stat-Signature: eepgd933cozoaz875riowc35qdr3z4rs X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1717438164-277424 X-HE-Meta: U2FsdGVkX18HyI00dA/UPAj9Y3Ng1ut12f779Bb4aTsqDNGPw68bMxfHHbNmuP/N0BHUZa8qQuwHsllm4nblZ9+UYSV4kuVSbByU7ZMnJmxlyUNVE3tnJZmVyb49V3YSuXYAM2M/9I5TmmdbErjvXUK1jRB64SLJ/Q1QD55aB4YZ8l8bU/NK2eH2vTds7l0tr1elc0PaX6yY+2pdLN0cvBpJZ16Wx968qk7d5wddjNhGwIKEFMQc+Pw7ODIM55N7EgyF+QqzvlI5QR6QepL/LweST9xhS8EoGQETXcp600nqnL5BDZpW5XLq2iJ+DqCJ8SHk9F+Ia4yAImY/8WuypAEfqcr/vyyIGqPtnhGPHgQlYxzOHRNYUWMml3sOixNVI8wTdudjKxteu7VxxLz5BWIqm89tPNKACsy2mRoE++HSfnZ6xNvYOuTvI/JZuiW6vKzkqJBXCrI9XSObDpxC+cefLzvgLQhGwY0fBWa8LR8qi8OmeH83ylAln5elex0SBO05+v5Jcnc19C9g40dnnodufA1IcH+zqTsqGhfAvOJJ1sGa1wFS/5gKcuol/3Vjg6X4s4+Q/Lt5RWuDu3dIXBteVDrxTBdBcD6Mz4IvHpZUcvoKpbXLQZ4mhylPi7hJikUdlaegCDpQad/QZGwVqQgM5KPlxtQlFmRuvtN242MABhhdyCpoCJb3csCgMUsZlSg1hqSrXvtz2ZOI7kPdn7GRTRAOQifAceYCJ/liVXjczfAqpsL2sYjD9a9U/WvXUo5tIUXhiMUeryVsB4WHL+Ax9xnZYugCuEQSU1c1wr4iVwNsADOLhtVYPryUz74/xrOxMv+u7Zsw1AiounSFxvXKRWi9/Fr88PgYr6NnWmYBaU4145jaLV3hahIa+4gHheHQcnutXocosZErcCqUb6OSnkIucRV8Jgd3Yh1A8ImPV3/tnPfcj6kd+nfaoLy1x7jEhB+XKfDt+H4/y5Y ovLOWUWD 8hdJq0qCnFNC2z0CegmifmBszkRWdQY282K6LIWrOq1+4EVhFcUGk3c0nmqR1VdGWPpfrOcSIT3P/Flz0+9RmpIu8H5OowpRFzAe5AQyrdFi9+NlnY/lgqW5Y374PYJ4Kis6VPnISmi+VCq9c4pWclLWqgcjH3Ig4Q0NlYiQCJZ2UbSheSlEiYyZ5UuoceclalQq4/b3CB9q5fbYvSJObChYgQQeW9oBpjvRsZjTbkS2uxomlXdwNzu3p8cpSXViHhPzNdx+PbdB/xCLRE9yMq0Gnfj8hXOWRYyIla2JmQj6hbbRwcXxAkCktOlT6oodxGmDWg4LsPepBBGOS01ErXfqBFOsrF9tofk2MShig0kpr7bnpqWuZC7IZxSPmpRjkbd/aJ3zCZVT/31d/Bcf+LHo/CZW8gDzz+ABK7XQnOf8fU7S3gX9RYy1r85RrtC8KEpkU2VkZAmfa3v0uesTdSlezCgiP26HWiZ1Bd40zX3HQ05eICKZSZDhUvmvsHZnNhGBmxUjpdWQG/Bg3adqsFIl7wUkZ4Ufs3TB3GIPtg2Gi7wI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.016935, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello, On Mon, Jun 03, 2024 at 02:39:18PM +0800, Kemeng Shi wrote: > > Isn't this a bit nasty? The helper skips updating states because it knows > > the caller is not going to use them? I'm not sure the slight code reduction > > justifies the added subtlety. > > It's a general rule that wb should not be limited if the wb is in freerun state. > So I think it's intuitive to obey the rule in both balance_wb_limits and it's > caller in which case balance_wb_limits and it's caller should stop to do anything > when freerun state of wb is first seen. > But no insistant on this... Hmm... can you at least add comments pointing out that if freerun, the limits fields are invalid? Thanks. -- tejun