From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 495BCC25B76 for ; Mon, 3 Jun 2024 17:54:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D4FDD6B008A; Mon, 3 Jun 2024 13:54:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D2FB86B008C; Mon, 3 Jun 2024 13:54:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C15A56B0092; Mon, 3 Jun 2024 13:54:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A1C136B008A for ; Mon, 3 Jun 2024 13:54:02 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 23310160B9A for ; Mon, 3 Jun 2024 17:54:02 +0000 (UTC) X-FDA: 82190325924.20.39327A7 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by imf16.hostedemail.com (Postfix) with ESMTP id 2A40A180025 for ; Mon, 3 Jun 2024 17:53:58 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=EBdS7b4V; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf16.hostedemail.com: domain of osalvador@suse.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=osalvador@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717437239; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ft7tNHscoXl71RZTa7m0RTk6n8v1oKLgnbYLQ9YMW9I=; b=srtUaLrVPxRSM99hQE7ZhWJpaWqX73MjWizNGzYgmPGB3GX3IpQGzf8w5BVkWGIX2wI+Dy pfdYuxCqdzs96X7edxm0crS8xxkvWlS8GFfHVthBbsPQcWByr5ExdOttht2Xli3l/uHuDv gF7Pif1XSiL+fZecD+LOuRu0yJgQLkE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717437239; a=rsa-sha256; cv=none; b=vnfauNxqV7T7vxWwMTBZr8ylOKYxd8nbQN6LcHEsRbiCo2ojvtrMSvof0dlL8RsZmZyKxr DnCDN6XQU0nzrTHYSG0EVbRu52YSiHPi/AIwuEjMWen6Xd7rDJW9nWFSlnRc5PC7sA32bq 6OpNvuz0PQVmyHnhQyHlDy4167jgNdU= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=EBdS7b4V; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf16.hostedemail.com: domain of osalvador@suse.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=osalvador@suse.com Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-42120fc8d1dso1112685e9.2 for ; Mon, 03 Jun 2024 10:53:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1717437237; x=1718042037; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=Ft7tNHscoXl71RZTa7m0RTk6n8v1oKLgnbYLQ9YMW9I=; b=EBdS7b4VPBwt/ITQAGxIYMZ449GGIkKCnZR52Tywn5RW39p8ubPERMXHqICUNRJrrc RS/E0+4plPOFsu5xyvZfTit2f+XpMBCJKNkqCTPDt2pmXXcdTUkRaRti5D80TGSHaekk x2FgP+gBvBobRfvoLPgaxFPEb348Jpd5ntEeKywgT181n1TAwjf6EipwOU18ad73yO91 LhRgrHTFayjVaDj8dsdb1SZKHt7OA73aF/W5RirI2wn8/EX0uAADzpcirkbdloJiCGol qLoxAr1T8T2BcWrtDWkwbIJqQATPWZZXta4okrW5Z+rI/7inXsAzphype3NJb74LwLpm sfdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717437237; x=1718042037; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ft7tNHscoXl71RZTa7m0RTk6n8v1oKLgnbYLQ9YMW9I=; b=n4ii8HAuy53i8JJmbv2GSVmnRZJaySAOWmFUSdHiSjORs1F9xoGaPGcPzvmDqNiwwf QphQHf84+7vhA/bXweHfLJ7+JyKcns+i4gDDHj/um+k3cV045RDpV6exw4VTp6lT4VGZ oZpco/XMqQqSoglL3Xd0ToSq3XKKe+fZ2vb5jz6WqlhxWKOisCclWfAF/eK+IYXkHJPs 3e6XKesjz7QpSlIeK1jG31oAWC1R+JkSirYHoYah/nmq19TSrqTZOjLgIx+XFJvNQhqT QmKD5Wd9pZd9huu6tUOLJAA6Q1l1jwyu7cOdYYeGt7UPmRsl1jDAErjJ+gFuz54Aqpeq jYVg== X-Forwarded-Encrypted: i=1; AJvYcCW0lPBAfEABzhegoIu4Hq+KTZ6yyJYEfCb8O/MUncMoVm4R4vRbIDio+SrFqBsUq7zaOnTAhjHzZDwV6SZW4MhTvLo= X-Gm-Message-State: AOJu0YzJ/yAJOSufenzN/AaxvHjNGx9m7ZMD62kDRelbOIkiuRX9fyTU puY3Pu8B2Amm5q+buE78fhGe7xwHp6O4mfL+znUxTUgLz1RIbPrJD3nYTCnPHTbUV+vGeLMUJYN 3 X-Google-Smtp-Source: AGHT+IG/H9Qs/IQSRYkfHhZIy7FRz5dfSL/NilC/N/VMOrexy95bJJ1qqyY3QrxSqfHBmEWupdHOGw== X-Received: by 2002:a05:600c:1c82:b0:41c:1434:f571 with SMTP id 5b1f17b1804b1-4212e0b092dmr74491145e9.37.1717437237527; Mon, 03 Jun 2024 10:53:57 -0700 (PDT) Received: from localhost.localdomain (62.83.84.125.dyn.user.ono.com. [62.83.84.125]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42133e66ce0sm103144095e9.23.2024.06.03.10.53.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jun 2024 10:53:57 -0700 (PDT) From: Oscar Salvador X-Google-Original-From: Oscar Salvador Date: Mon, 3 Jun 2024 19:53:55 +0200 To: David Hildenbrand Cc: Anastasia Belova , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: Re: [PATCH] mm/memory_hotplug: prevent accessing by index=-1 Message-ID: References: <20240603112830.7432-1-abelova@astralinux.ru> <3c2b1b1e-c9b3-442e-8f7b-5c7518d3fbdb@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3c2b1b1e-c9b3-442e-8f7b-5c7518d3fbdb@redhat.com> X-Stat-Signature: g3yp35od3x6igsns6ar73mzzju1k4eqr X-Rspamd-Queue-Id: 2A40A180025 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1717437238-323096 X-HE-Meta: U2FsdGVkX1/Q+N7i5HTFnZzbM+VYRpwS3RjgGnWwXAvU9rgJY9Olj+0uPPd9bmBji5RMS1Y4ndWCnRxLr/fd60hnlGjSM7LgRczpFybaizGkTOy5UUcSxMeN5K/EIZkyIQtuH46QP3u3GxBasuhrFgoKTr3UqXiOUqIZIa4QiRipiYJeMv13JNZxT3/cFpa9W6k8ThcfgEeWRJFVR5FYKCG33imrYj24ZIezgXMpTbtfFiQdFVJE6DUq8vdbowExIdY1FNRpzHlYaiReq4df3wlW0lBXstUpE1Hwh7tLSozh1v9Fqmm78zQGeQwTyayU3jU4kM+kSDj5x2U7tcZHIf4XWolM51QU8+E+6wS3KNkQSjxlV/jts4N3TMrBqDh7bTj1zFJQ+W6UwvFVWK8byBZnPzxrT9mXGXXmLgn+ty0BPUz82DNC/1n6CJoG4qakA9PKeBRzgqIAZQlciHVOtFeoGjAOQ9shR2TEq4ajgdPqgFw85U3C1sBJqJnH5tRd9rbyiJaVgMiAVF6hqWp40imSjQDhJNpQ0N1/0iLaeF6QtapgnhSgmxXfY2yfhc5BidIOV5Hj5y3rLwPdc+u51TeJ6oF6gBwaevLP4jM2qK/fgr8R4OI9iDpqHUj3mzJaUAyTsxknkbsdqCwTAKHhX5owtRRAa+Ih1P6fNszlQ//WppGgbLGCzZj1qV9PKf0tkY0bCtaAhs74LyP/WXNPP7SYjSYyqu3FANvrhp0Q/lm8mS4GKAF7mdYenozPkRFC52y4VNe56XWXAZLb7FL8qtQ+thROx0LLop8lwg7EkTJP5RtbM4liWSYbkZVjr56BK/V2BBeuOhu79QJf/iJz8Cm37goobLjKiBPZazA0s3Zb81ZLVdZ43PeCVa1A5f/OK9lF9NIdPVrUc2i/dYBYAw/orFl3aNpdpgtQXcTIkMC37gf6YBTwI1pXQ+ZxA1HZ22ogQXk7Ing2sDcxqRd 8/zSGbvU gEFHJ7LPrQFTlAHy3UpIiZ1nsaiGsaxh111HvgSF0aqzreZYL3v3YYiPf8TS4msZmmWp31ccY7LXEHaNxaS74thpw67nrXO3EA8Mr4XXIXt6lDlUdp9klnJPOJkKMXQUGNbH5mhAVt8KL7la6SkPCjKjAPaWWuRNV2x18764z1J8pRJ9q7wOXAys3cOTG6QSk/qzESRq6EJsm0gVjFJ5PVimAxVrVVVcqtznZsVPOAkfuogtfl8zNwTcb5QpRUno1PfLmUVGL7NR6sB2SQRQ5uMXq2ZB6EHGTJW65WnZYDrhrZia7pxoSOa1w1vG1Zlnb1sDbxSmmh/LWxfaHvOUTRceaBWQrJjCE1KlP X-Bogosity: Ham, tests=bogofilter, spamicity=0.023787, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 03, 2024 at 06:07:39PM +0200, David Hildenbrand wrote: > pgdat is never dereferenced when "nid == NUMA_NO_NODE". Right. > NODE_DATA is defined as > > arch/arm64/include/asm/mmzone.h:#define NODE_DATA(nid) (node_data[(nid)]) > arch/loongarch/include/asm/mmzone.h:#define NODE_DATA(nid) (node_data[(nid)]) > arch/mips/include/asm/mach-ip27/mmzone.h:#define NODE_DATA(n) (&__node_data[(n)]->pglist) All look fine, but mips. Is it not dangerous to try to derefence &__node_data[-1]->pglist? -- Oscar Salvador SUSE Labs