From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2205C27C52 for ; Mon, 3 Jun 2024 13:52:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 655B46B0088; Mon, 3 Jun 2024 09:52:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 605BB6B0089; Mon, 3 Jun 2024 09:52:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CD396B008A; Mon, 3 Jun 2024 09:52:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2FE786B0088 for ; Mon, 3 Jun 2024 09:52:39 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B21A216105F for ; Mon, 3 Jun 2024 13:52:38 +0000 (UTC) X-FDA: 82189717596.07.F8E31FF Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf04.hostedemail.com (Postfix) with ESMTP id 66C144000F for ; Mon, 3 Jun 2024 13:52:36 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=kOjAT6NL; dmarc=none; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717422757; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2WoGTDTDlIhk96e2gtrr9oRMnWxD0GTiKrPTYhXDtqA=; b=KND0aK8bzFCyawg4qZiBGojycArUFdjLdck/DYnVzdyBsD56XRCdpOOoKZYMBy86hLgNXE 6cbHNLf0Zm5GwwuVV1TFS7F2srSAGjUhiEWxrkeHPWSlRFZMBZSLrMDJoqFDdGP1d7RoVt OMlZv2rsTPYQcXi85L7LkP7a2mzQRlY= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=kOjAT6NL; dmarc=none; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717422757; a=rsa-sha256; cv=none; b=rA5yULjPm4N1sFCu09nf3bxFAcXOmw+sB0wb4IbTR9PKKRCRfkY49SXZ9A6EaKGNQ7SYKx kQq4ACd2LGPI9hmTa0k1maGE1RgZspxWwY1fJ4DRliWeEgN5zc3oGXikSnhIbt+67ZBD0V zhHd6E6drIfGKoNG2nMxb9rkJijcuPI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2WoGTDTDlIhk96e2gtrr9oRMnWxD0GTiKrPTYhXDtqA=; b=kOjAT6NLs8wlRmEz9XbT+ulX+3 jFhcvpiFSf2R85R9ES/zwCmqSfM6zji4AJdy/qI3IVpPP2krL/ywYPsl9gVQIaSgVuQ7bIWoR7myc ct1OR5B30DArtpgGP7i3XhpagUIybx6fUbvTtjx06mGHKG6NUXIzT5ck1P/K0X1TF7eGiMSWMQPSa sXjsolo6ubITZlu8fhugmF4q41+pZkMBt9Da/f1fXQsKAd2qmFPjKhC3LuOqIX/PDqVPFr/y1QT+G RQDkYcz/fk7FN79xRHN/2b/I3Fo/Av1tFIXRk8yek7NYp6P0mWYuXiORv+hNyKC6B+To3YpOScQ0F OqAIdCGw==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sE86y-0000000E8t1-26jG; Mon, 03 Jun 2024 13:52:32 +0000 Date: Mon, 3 Jun 2024 14:52:32 +0100 From: Matthew Wilcox To: Yajun Deng Cc: akpm@linux-foundation.org, rppt@kernel.org, hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: pass the pfn to set_pageblock_migratetype Message-ID: References: <20240603124100.2834-1-yajun.deng@linux.dev> <1bb60f7db3a11e86e6f48c1eefe7f27d7d23019c@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1bb60f7db3a11e86e6f48c1eefe7f27d7d23019c@linux.dev> X-Rspamd-Queue-Id: 66C144000F X-Stat-Signature: zszobckm1t76s6gpij14ih4b9e16tc1y X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1717422756-455171 X-HE-Meta: U2FsdGVkX1/iqDcmJ3Su1TnI18rqgWwtr73eCqkwRZAo1grXQoxfKj6sl/o98SxDNXiGEstmzJWWKDNg1kTWm72TpXdrDyCt/9rZZBNbaIQSS5RByk2Bdu8ihO6Jnh2WKTUSgrbfkaHvQuVi8/hg7OYMTjuLfAvuDVpxoCnZrITURXeKEBYCh2sEBKgDTeANQNOISid+/a8icSDzQU9qc+bWSlm9j5aOADtmPDvDwhgbMNqmPmaxAqW+IKbfSGPmdTWgKp7s9QByQEZCEFQWb/UXt0M10cBjFX8gj9fM9iUOSRjn/TH5hHuOaLvvAaA/2eguqu6YEFxTq8ZDOTSi4yik1SSNhQzm3kPX+YkrbQ3ej3J39PXbXVQhU/+B4NgZ5MMnhaY6+Qs0hO+iyY1wMndKSlFNMx6vo06XzO3P/i3bx19vSrtr+awQbOsgQbdfXHbKo2+OEIya/7zWzb+ohHt80iPq5uhcKuPyrg2n5ZSomQQngIkInStfvbBmxe1fJ+kDtHd5TbI47SyE0+yYKwkoP/p+I6URpoxgHRmOHpgUmgMC+Pfh/rzmYeS+BYl8x3GmUxSHUBXHd/yFlxtAjgOXjvXP37XvVOsbL00y7cIC8I21VqozPPgyDj1VQtfq2JE20tR6LlmXMPy06IZx1YGzkuqQhC2q1lM3MI+CDN29ULZOnnTdkic2NRRkduDFSzb9u6I24s5hXLA0G+RLH8+LsNGKz4FCgH9Y/nJZ/yK/njqMtf2F7dp8JLqsI6PvLIeZpMM8/HFD7gZtVQjS42FHg1lxLeUw3TqErCP0DvfdnYbzSaRM41ej7jaPKukEzSIJq3uf7twptyYMfqa38hDrlsspFM2x7xWOJhpGHVZr3CUesxraAHjfCu7+kivuek733gDtCvIxPP6SWXwIcuDXfNBdFvWBWAh7bTHyXX7gChoUfGoYTV2rD2smCC46XphpCCHRbPUs3c7Ww6j NEWxqlqy CFSSsxUpC9LgdZ4jUvxroQppZG8yt8tpDygRDSFJlnMGoCxMHJiwFaN8NHWp8yDo/dtk0ejiq/PfbuIhr4pWpRUtQVy7mXXNAAkHDd5bsFTk+OufODeUccx8YZA+tgEztSx684SO77wpq4Njd4rxvaCm8oKcliJlcmkbuOjOJVLX9s5Ch/Kk4ojk+8ZJQhWB8BPKW+3+FY6ZCZJiMCu/HzR8Rql2+eO1onHEXkeR29z2uc0w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001182, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 03, 2024 at 01:48:50PM +0000, Yajun Deng wrote: > June 3, 2024 at 9:03 PM, "Matthew Wilcox" wrote: > > On Mon, Jun 03, 2024 at 08:41:00PM +0800, Yajun Deng wrote: > > > It is necessary to calculate the pfn in the set_pageblock_migratetype(), > > > but most of the callers already have the pfn. > > > > It's not exactly a hard computation though. Have you done any > > > > measurements that show this patch is an improvement? > > No, just view the code. But some callers are in a for loop. All the more reason to MEASURE. There is a cost to marshalling function arguments which must be weighed against the cost of recalculating the PFN. Since you haven't done that, NAK.