From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7FB4C25B76 for ; Mon, 3 Jun 2024 13:03:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 51D8A6B008C; Mon, 3 Jun 2024 09:03:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4CBC16B0092; Mon, 3 Jun 2024 09:03:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3BADC6B0098; Mon, 3 Jun 2024 09:03:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1BFFF6B008C for ; Mon, 3 Jun 2024 09:03:58 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C0D8F160A79 for ; Mon, 3 Jun 2024 13:03:57 +0000 (UTC) X-FDA: 82189594914.15.71B407F Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf10.hostedemail.com (Postfix) with ESMTP id 4ECC5C002F for ; Mon, 3 Jun 2024 13:03:54 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=R5fGs8Ih; dmarc=none; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717419836; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UMPvBERLQPjIU5/i9ydiF+mg7YA0ahjPIQIB0SOC99k=; b=utNBTrJr2AbVucBzzeSqgdOlyubNfFRisktkB++yG4mwyCR4748swZ3ukaFXpGmh5V2FKK L4QyiYv6l68X5uYYexfFiCi4sboWMcdmLHfgldltUUTA/0EIt6imU9XpYqpm6s6c/7WOCh 1b7Y5EkFm7dOHv4EckBnHPOQlyicXyU= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=R5fGs8Ih; dmarc=none; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717419836; a=rsa-sha256; cv=none; b=1GA4xYT62JRyDzqSFTErdmSN0vyrEAoL2aE18qIZ1xcLcMwiImounJYCHM1GuHbQ3JBksB l8Vx2uVGeQRM8Fxdobh5+ZQ74gsyNmN3b1qnHir8QjRD+HgVwLGwXrRge6leK5XA6/GjAQ Box6iffgozwHyn2jPNA84fP9ZtsF21c= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=UMPvBERLQPjIU5/i9ydiF+mg7YA0ahjPIQIB0SOC99k=; b=R5fGs8IhNsEY+p5V5XpfsaHuM+ sWR/GRjtMKk0iSHLv0te9NyIn9Vm9vpLgmPD8Q3v1Uiro5kPWEryZwooKyDLtd/O6NkHHUS41mocj LWLPc1NfOHYOzJ40COgCBAsXO26ByP2feypflB7maa3U5VPRpLy7OMP9TbQiQBwKS8DUam72Nehx3 688tOeZJwBMzOqoPBGma+W2B/m1elkUz0sCLHFacP9m0jzCLR7Wkx8sC0fkDlia+WDkEn+sX+u19f C+I59OW+ZtB9UO50/xU9wOm4p1Qmrp8Gu9U7lYMgjasKjaKQ/d3wdsl1N8CtgukzqRfAn8xRtTwRV RdiXpwNg==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sE7Lr-0000000E7RL-3aOQ; Mon, 03 Jun 2024 13:03:51 +0000 Date: Mon, 3 Jun 2024 14:03:51 +0100 From: Matthew Wilcox To: Yajun Deng Cc: akpm@linux-foundation.org, rppt@kernel.org, hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: pass the pfn to set_pageblock_migratetype Message-ID: References: <20240603124100.2834-1-yajun.deng@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240603124100.2834-1-yajun.deng@linux.dev> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 4ECC5C002F X-Stat-Signature: hc3j6ka3u55bsb4fnpgutphdo7fem6yy X-HE-Tag: 1717419834-622961 X-HE-Meta: U2FsdGVkX18Cgv6+kSafBGkBndiL5mXqaFzQamULOqGTx2KDygQvcw19yTz0FgL1eCWkk+ttNCFKbCgg2INN9CqG12sUus18Pd4T20wkneUDA9/MAyPaLCIfGEuZhNdPbKfx6UJ3LFEyq5AnSJ54rw3/i9A+6yRpk/SWaB5CxOIZDSlvtvnst/beWeWMENJjfroN9JrwJNxC7AFVjE6EPV4xJZWMcyjjfabQ/Lps+KAAe9AdOTxC4G5jB6GVbgA4f72c96XxwuNDO1a+px9KVQ3KvoANQ7PJLU3MVUe4u2PM2RiSrA7M+M++UiD8ayCYmH0MAO/A12mbWJocp2HQFqUohzond5YyYO6sCNylmWqen4dmKBMwxKKcD+zo/616zM3/oEEaH+OoNQaONrr2GRY4su2JvULzB6IdlvE5coG0YGX7Pt1vSq8b23Qp+bLZTUMnO+P1AN4Q3WNz0AJ1KVxKUDr3j6S7SDG3zVRJmlhiGpQV72sm8dTZ52EdkHA5SN8nfyF5nqeScgU3uvOo4G2iFCRdA4GAZDtyzdm1vHkd6Tlg7Bwy+0yU75cSkk28jIB08zTbRYc14HQ3dYqpPWXkUrcdXQ7QNKKEUcOHpE4amCyRsx91ddJya70vrtgnOqSFMiTxBVPBvsD61RyOdsUQTFP/7+L/hIHQJanSQDpkAJhPw1cQUDYc+w2gDXSKMn08uKEGT9uTiEwD3AJtf/3OO3DVhkhSLWnU0/3pQDJsTRdRV+J4YG5MSRysDNGvlXLLnIiQy1e/2ebKKx0CVgzIcGuwysU9eStPqFOpf/8oVqfDHoqhgJJPGaVpjU+A89WqHq9PbkU+wfjBJHgSywIFiCSQL/iRG2pCD3fJeWrv/Mmi7FK5l/2QuTLTOIqM80r14ulDzLhYf8Fm54IoY6dA11xlf7W+dqkRrWGVrC+nZyIWM42sfgXFkAm5FLJ/WizzxkveEw1VFQstUzG mNaNxsE3 exo9cPlosKP8aDlBPwvA2gyZzud3wuMI0rQY5/UqYqwGqqiHBsUHV4o8XCo2wJRqvfpwl3UDZyLOIl13SfvLbyzHrvB0FY+40DSxjUYkHSDBIsmBd41o+gW0YkiZwoj53X69TW2MXwBYkLuktQO0yFFWq522bc+FJK9nefEesKPSF456F3jsgpElTTw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.011889, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 03, 2024 at 08:41:00PM +0800, Yajun Deng wrote: > It is necessary to calculate the pfn in the set_pageblock_migratetype(), > but most of the callers already have the pfn. > > To reduce the calculation, pass the pfn to set_pageblock_migratetype(). It's not exactly a hard computation though. Have you done any measurements that show this patch is an improvement?