From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15282C25B75 for ; Mon, 3 Jun 2024 12:19:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8CE286B0089; Mon, 3 Jun 2024 08:19:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8570B6B0095; Mon, 3 Jun 2024 08:19:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 71D4D6B0096; Mon, 3 Jun 2024 08:19:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 53B496B0089 for ; Mon, 3 Jun 2024 08:19:02 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0340B1A06F9 for ; Mon, 3 Jun 2024 12:19:01 +0000 (UTC) X-FDA: 82189481724.26.DF20A06 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id 9B02F4000B for ; Mon, 3 Jun 2024 12:18:59 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Ry9W5eVA; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717417140; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mrfTYsS95Bd6Q8FrjNuVkMUgYtvqhZBTbPKZbn4NM34=; b=JfXKhfaowm2P/gQCRbTSEmcvvhpP1+bmDxQjiEeEMfr7OB3dhLeRIFJxeJuGDAlWN+rmr2 ezZYaFsEvvjMrWulUX7DAeY7LQ1lHJtuao1/qlY0QYVOMOdT+JxsNKNm+jj8rrlG9CyEl4 4JRvg+omG3xfDXtlWFX65a3xI3G94sg= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Ry9W5eVA; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717417140; a=rsa-sha256; cv=none; b=xjxkgZYPwlDGgfHF3zJythlHrZWn9Mc62z/F5f7dFvcdoBAVjCanxjbpaY2GyUppeLgWxP f9uv9coXu+ywHWMCkea+b0BQhBLJvQBjasGeFLyrow78gU9VMgp1uJfRyB7k2eMGj3CPuZ RSeVpyqacBvjgqKL73JhBgBorVVjpBg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mrfTYsS95Bd6Q8FrjNuVkMUgYtvqhZBTbPKZbn4NM34=; b=Ry9W5eVAbnuZbmAmEuVatNnp7E avF4x+DHl4hmbrVAwR0JkcjbUZ9HuSfEhT3zuP1STtRBWQMcunmG1tvrNmrdZCnk7P1l/Ly207nqV SD+e1kKqPT87SvKDGwQPMViwPW2QjQSiSY3cfSZjxsrdRb9Dm80IiLAJoALooeDiXwANgDog07QMf ZpY3EVbPqj/Tcc7dvDOTAicfFngN06h1XcM4FYumQm8ALEzkLxRh+yoRK1v/PYkK12PcVN8w4wrY3 vId7mCgf2xWpMh/1r6WFg/+ez3HcqBiGmAzKE4u7rTi+Gm1yGWnJva5TuxqSAz7HBv1xfLiMSX2tI F/17n6fg==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sE6eD-0000000E5Yz-1yAV; Mon, 03 Jun 2024 12:18:45 +0000 Date: Mon, 3 Jun 2024 13:18:45 +0100 From: Matthew Wilcox To: "Pankaj Raghav (Samsung)" Cc: david@fromorbit.com, chandan.babu@oracle.com, akpm@linux-foundation.org, brauner@kernel.org, djwong@kernel.org, linux-kernel@vger.kernel.org, hare@suse.de, john.g.garry@oracle.com, gost.dev@samsung.com, yang@os.amperecomputing.com, p.raghav@samsung.com, cl@os.amperecomputing.com, linux-xfs@vger.kernel.org, hch@lst.de, mcgrof@kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v6 03/11] filemap: allocate mapping_min_order folios in the page cache Message-ID: References: <20240529134509.120826-1-kernel@pankajraghav.com> <20240529134509.120826-4-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240529134509.120826-4-kernel@pankajraghav.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 9B02F4000B X-Stat-Signature: 1j74hea4b4ygt1551p3frqouzw55ojwj X-Rspam-User: X-HE-Tag: 1717417139-939748 X-HE-Meta: U2FsdGVkX1/9v8gCjcNXz82MakJNmst8aQKlRGSs1Nb3lyvv8d09S/o2hcJqhsQuCznif+3Y7WR1eUL9mlDBN5YTAhs9qp49Hb/nNhs1kTN1XJ3zhJnfXRvp1z+B1XleuIGcVIIrmRyq8HNcBGOhqV0vmZYd7AoqNRCXlwympLRQmu7QiPV0KI5/3bRXrv3B0oXa9vKkL3yT849zhT630BgqjEDZ6q9sPIOsbBsrdnyCFjdyI9qsy07qNXJtbnr4xbKurkr1NSCrY0fw9eykZvh5sl+r54tSMvZ9jv/HsDfB/Bv1Cw32ToiY5CHe3oNNWM77qqlRC0cIYRIbZ52Pd4HlCnMidpt/u1lzuYySM3BlyHZXI6pGutWH3NMrhISSpYHOkHjRwzZ9AXnEAWWZIi2JjgNzk9aoKdCIyVaL8A/zPue22hmIhR1+tqKO1hMZRdWaD3eU6SnEL46hn/b9ZAKsdI2iSNROllQDIhdQy06QbFMGcnoSP4aPrB2dxtyavJmFUiizVsf+F5wA5ntHVtvIBr3sWVQVIq56qEvb6I5FJh8q2gif8Zmtvr2e99cOObMxjKxQeN4Zb0U/Cn02VW3Y75BQv4X0TZTnCNWUEcwxqijYLlU4RQ73ADiDvehJ81w7sx2wqKJG0XnKE0PRnvq++2Epxun8fVheJo/bKVayO/Q+E3/vV+WRos/gr0F7VamrAWBD2XIKsxrzWfWBRGOxHfHVJwlTlmVu64S1oJQs2b970qCRJEDZt6/F8VLH8hZKV0SFi1bTCkanD8X8FOFoEDlZkZqE1IpkRUICTVmE/DBsvct2g9EvogEn2NGkOqBeb2veQLA248KMmesu1isdVfU2heFNoC5HShbWWhjBSeAYUnVS491sVwGPqHArOolE+1cpK1Q4tMiIH1FzE2cLiAOgJkeg/4JE+09c5X6rJ+QzyiBXQ4WJGzZ2k/PSCC2I4P4b5+sfbGH/a3/ jPiQQ6nq ZIYVsi40Nz2FGWM4+6jx0oz1ePzb2nKeAVHH3Jyr42qAfe4dPU7G/U0dGnvDOHadzmpXbFMvPE3HmdHe2GX7DTwcAMbTJ8EGelk/mtP2emMV+bdfsjndzyl/GKxGc1H7Hc25HrLqi2cWBsIpUfBQZgG/vctpMb1rrwLRk0XlO8h07yOIgx3s09BzrPw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 29, 2024 at 03:45:01PM +0200, Pankaj Raghav (Samsung) wrote: > @@ -1919,8 +1921,10 @@ struct folio *__filemap_get_folio(struct address_space *mapping, pgoff_t index, > folio_wait_stable(folio); > no_page: > if (!folio && (fgp_flags & FGP_CREAT)) { > - unsigned order = FGF_GET_ORDER(fgp_flags); > + unsigned int min_order = mapping_min_folio_order(mapping); > + unsigned int order = max(min_order, FGF_GET_ORDER(fgp_flags)); > int err; > + index = mapping_align_start_index(mapping, index); > > if ((fgp_flags & FGP_WRITE) && mapping_can_writeback(mapping)) > gfp |= __GFP_WRITE; > @@ -1958,7 +1962,7 @@ struct folio *__filemap_get_folio(struct address_space *mapping, pgoff_t index, > break; > folio_put(folio); > folio = NULL; > - } while (order-- > 0); > + } while (order-- > min_order); I'd argue you also need to change: - if (order > 0) + if (order > min_order) alloc_gfp |= __GFP_NORETRY | __GFP_NOWARN; since that is the last point at which we can fall back. If we can't immediately allocate a min_order folio, we want to retry, and we want to warn if we can't get it.