From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E5B9C25B75 for ; Mon, 3 Jun 2024 06:24:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA1BC6B009E; Mon, 3 Jun 2024 02:24:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A50716B00A0; Mon, 3 Jun 2024 02:24:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 918416B00A1; Mon, 3 Jun 2024 02:24:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 713C46B009E for ; Mon, 3 Jun 2024 02:24:00 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 3C2421A0796 for ; Mon, 3 Jun 2024 06:24:00 +0000 (UTC) X-FDA: 82188587040.04.096F7CE Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf29.hostedemail.com (Postfix) with ESMTP id 3A85C120002 for ; Mon, 3 Jun 2024 06:23:56 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=RW8iixUI; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717395837; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bXgx6mpIvi9R2EaHMM/ptrzaZAEpFoo8su4cKhowVyE=; b=2uqrqAqHXgPiWf1HTGyPR3Slqg8pBWX6fQTO2y9ZwBTyybj+nQJPNsbUu54+jtkuHU1123 iduDI8tIbSB5QBwlwu5T3utN9JafgyoR31xcP8GgtI7Du/8CiFEJuLnF7aFkXIjPDy/UHP PrsdlxvWS4neY7NwVomZf+60JPpYBKc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717395837; a=rsa-sha256; cv=none; b=k4OvgKey/XkjPF87sxvFZ5XMCw7E0jq3Q18ig8hshnix7tS4tFmasERQ2vXtnqnGCfWpF3 M8y6QASsB9g/wWckGXKoeK6nOCM89uzUtiqjb0w73Q6pEJPYpX5HZTb7knba0EElQqlrUr Z/I8OkocT7i8LMMpzN0vKruQokeIcOM= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=RW8iixUI; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 97B37CE068E; Mon, 3 Jun 2024 06:23:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A67EC2BD10; Mon, 3 Jun 2024 06:23:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717395831; bh=jauKdQJsuCaEFobBqKcXG6Lf/Vg6pgimeNbLLqWA+xk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RW8iixUI4z6fgChF5WOI8UNpXmJwKo4JRBjon59W0qn+asV1cQoa3UsxuyykmQVvs NXYeR0z1KS6CoSpmzzp1hG3+x6uONe0IRWNQQ+AjU6Ed/m4UaCLvOe14T0ZTLKSWVG fE0BlLt733HcKG+MefDj1CpS8l18Rja4bVDZarEog6Qh4XBVrr29yPvwc+9I0lH+Hq GRBN+wvX79WC1S6mrsRheZ4kW09+uFFeek8tVz1gAn9f6Xsnszir+TWZejZnsHwpW8 tUIpMJmN28avXvL9vRaaq1EDWdF33+o9K1RxiVKyejiIEhya5qRfErXBk+3JbThGQs bKHK9tAEpLFdQ== Date: Mon, 3 Jun 2024 09:21:57 +0300 From: Mike Rapoport To: Wei Yang Cc: akpm@linux-foundation.org, linux-mm@kvack.org Subject: Re: [PATCH 1/3] mm/mm_init.c: get the highest zone directly Message-ID: References: <20240531002613.5231-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240531002613.5231-1-richard.weiyang@gmail.com> X-Stat-Signature: es45xqjfc939k1e3qpgs9ffdiecre74b X-Rspamd-Queue-Id: 3A85C120002 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1717395836-427067 X-HE-Meta: U2FsdGVkX1/zhlzWXByOPlKvMt2/NZ0yElUDfTqcPVYvfARwLUGXA1rMNSJ/EWwwyE3xyF8zFvEqPEpP/y+yPCbLJJjFLGEjkd9iq0AKMt5EzJ5Zm0P1BdjZx6rfkfnh+fZd3PsuFmrrHcW48bP+q7bGVqsBaoM7ie2LdbelejTefAp+c75meMiQ2bEEaKqwrB273z2PVNhaHPfpDrObSjGmJNb8tuSG7QcSd01TzgmwWxx2WvpRz2ZpnAneO8R3clb7kcOYztkAHcmDcJ6TX7+YjpzKI967K2KbqUeNNVBm3V6r3o9lppE6o8Sb18Y/2Mbyi5HZo7zb9MEO3PMBi4fUbBdy2Qxx9Mfu/RyeCU/Qw5XLXssWnzkKlkgfZkAkeVX/XzVVNiArK74gfkqQYNkNg2wXFSreW7gZBceMZwUc6bL46PzvgOY9cEkKUT3PY4orFql31DfM/MKYFrDB0kf6e4WYUn1aMMIi7UO/rhI6aM8IX3rdoparBw5CjIGjuwgP511QjUEN8wBHaZrA4m3p3SwVG14xxE+MT/9oed9Gc3qU2MnqaC6dAYcQc6Gyhbv8R76/b6y+vrKUUFTLd67+bGGWLIiTjkhekZEcwEF8WSTYtbMXK8Hmva4BEotkJjYtzeJZS/sW0po0NWPkbSL0aZMc+jZL2j1lWWcpdNpGHfSb4xNL/rKtc/XmqAOIJthrx1HKNZQIPrmZslnZMcpUmiE6cl4oodG6TrMPD3KREgVgnROjFeRW4B+let7+NuGaEpnhon3zr9/jj0b8Z0mRppYVuR6ZKQveXkgyGN9wqjtr1mbAKTLEb/KjQTGk8I2IpVSU7GkVEf9CmiZtsQ7yLSTarGi07GTpnY7Rn2tWLuyt9Hwplj7uw0tXLy7QRMxadFcAxIuvAD6VpToSId8+QoJjrRFGdMfKL4AwTSyEFpGF0KNLl/3AYzXp4gTa60IuzhpyHKS4o2T39BY r9mln4U9 ksvbeZlphImKIk9O9JIILEsF3+liFPDD7h05prAetCtf0dcRhv2u6KARY7PYfxMVpk58z/B/7AviPpgnCrZV4AgDKpy7K6ChuyCqsHhxXrBx57aRtlTkVHuhtnz9ScLW6YNSnB5U+g6C7SjWmo+5kuRZVAztv2/Ylie21NpVgmP1/Fsh8Z28HsXLsfkzjYYIJ5nVmXMWaCeWINcqeee3UjRKI0lncwXuN1V0dJQtu8shFu35GFhn/Usp7oVeklWofgLknE8Hbyi3M/lAtKsQOs0/5jhPy0L+javftrkeZnV5s/XfBPmyHqRmjaej5EDqTKvK0KaEKgLOia6uoy9/y7vG3mNa8wfOYaXwb X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 31, 2024 at 12:26:11AM +0000, Wei Yang wrote: > We have recorded nr_zones in pgdat, just get it directly. > > Signed-off-by: Wei Yang Reviewed-by: Mike Rapoport (IBM) > --- > mm/mm_init.c | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index aa83105b3a1b..2bcf87eab0c6 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -2136,7 +2136,7 @@ static int __init deferred_init_memmap(void *data) > unsigned long first_init_pfn, flags; > unsigned long start = jiffies; > struct zone *zone; > - int zid, max_threads; > + int max_threads; > u64 i; > > /* Bind memory initialisation thread to a local node if possible */ > @@ -2163,12 +2163,8 @@ static int __init deferred_init_memmap(void *data) > */ > pgdat_resize_unlock(pgdat, &flags); > > - /* Only the highest zone is deferred so find it */ > - for (zid = 0; zid < MAX_NR_ZONES; zid++) { > - zone = pgdat->node_zones + zid; > - if (first_init_pfn < zone_end_pfn(zone)) > - break; > - } > + /* Only the highest zone is deferred */ > + zone = pgdat->node_zones + pgdat->nr_zones - 1; > > /* If the zone is empty somebody else may have cleared out the zone */ > if (!deferred_init_mem_pfn_range_in_zone(&i, zone, &spfn, &epfn, > @@ -2196,7 +2192,7 @@ static int __init deferred_init_memmap(void *data) > } > zone_empty: > /* Sanity check that the next zone really is unpopulated */ > - WARN_ON(++zid < MAX_NR_ZONES && populated_zone(++zone)); > + WARN_ON(pgdat->nr_zones < MAX_NR_ZONES && populated_zone(++zone)); > > pr_info("node %d deferred pages initialised in %ums\n", > pgdat->node_id, jiffies_to_msecs(jiffies - start)); > -- > 2.34.1 > -- Sincerely yours, Mike.