From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C79FC25B75 for ; Mon, 3 Jun 2024 03:36:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F32E96B009E; Sun, 2 Jun 2024 23:36:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE29E6B00A0; Sun, 2 Jun 2024 23:36:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD20A6B00A1; Sun, 2 Jun 2024 23:36:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BD4C46B009E for ; Sun, 2 Jun 2024 23:36:47 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 26CF680627 for ; Mon, 3 Jun 2024 03:36:47 +0000 (UTC) X-FDA: 82188165654.15.A00B179 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf10.hostedemail.com (Postfix) with ESMTP id 012C4C0014 for ; Mon, 3 Jun 2024 03:36:44 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=a1zXJSxO; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717385805; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ECUDepRIy736K/Vh5Dkt+vDYxIgaP6kH7QsAiqgBifw=; b=CEPTmjNYZjkWqezMSXAbZ6xCgUewV7bDWtUoS+P5Bmh3EnmIMM1AD8XD2U5cBS1zJzgktl gIxJmWDouNDsLhlcz1MK+LZAFUUOQbumPsiMEJh4HLXHidjWAmdheVj9MvE2awnUe3Kvmb do3dolqwT1PPjdu4TzPCYj9ElkrgQw8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717385805; a=rsa-sha256; cv=none; b=bC5uSA85GN7TtwlnVZR+TC2XW8DgqASPG/A3o37QQYjX/RHVn6Cra4zWjEalbGixXd93/z rxYVXo5Btn4OU8cUee4L6irjItU1S8UdHlWaJQGLw65X22XqXG0JKT0UBKEXtdBZrVRlBe JgdKDwOb5qqXKvxN5TGDkzbQfDiLnb8= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=a1zXJSxO; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ECUDepRIy736K/Vh5Dkt+vDYxIgaP6kH7QsAiqgBifw=; b=a1zXJSxO3qG+nRJGpA7LRxR5zK qe+abRm9vlX5iWt4hlIWQLhGWtfj24qy5r71KtqOy8VEbF8TIpU5jt351JPj37z5Z8jYwvOXWJR8A olP6+mus0VFz9kRXAaqDWWBfwtFt6qK+3bepnKgWdzCvV3gLPN8DpmMg4pdTEwGgIgbELYyGPp90w KbyCWaEPUjm3X0Vj0VP4+qgyMrjYlIO1NChDmb4IujUMP98TMl3tEaDUjGG63dGto6VmDMh43zF2N DGiB0t3XS5/HGylnEFUbgN6aeIFrUteuleOexHdleKJqYfwJNIYRvWaBBG5ZJEAt59Pu0Onud/Rxz eUR7ImpQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sDyUq-0000000DoO2-0Bih; Mon, 03 Jun 2024 03:36:32 +0000 Date: Mon, 3 Jun 2024 04:36:31 +0100 From: Matthew Wilcox To: Lance Yang Cc: akpm@linux-foundation.org, ryan.roberts@arm.com, david@redhat.com, 21cnbao@gmail.com, baolin.wang@linux.alibaba.com, ziy@nvidia.com, fengwei.yin@intel.com, ying.huang@intel.com, libang.li@antgroup.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] mm/mlock: implement folio_mlock_step() using folio_pte_batch() Message-ID: References: <20240603033118.76457-1-ioworker0@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240603033118.76457-1-ioworker0@gmail.com> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 012C4C0014 X-Rspam-User: X-Stat-Signature: ygdyb8783eca5w6kxhkfqng9oy36pkug X-HE-Tag: 1717385804-83933 X-HE-Meta: U2FsdGVkX18Rp2TzeOKR0bf+NoVrYa+ShePcMfXekSpitdSGeK2Hp2ATcJiodxrZ5wtAWlYv5ZXB1XyCgiWsl0JHYAo5uxNCJNikJLBUsLvuIYFOHuK9N4BEZyRmNTELSHdyNkUq3h+7qSRgKZ5RmkQpR+cSF5FwDtQHIiRKn0f3noNSjfEPXqrisnLAH8yCVJ9mth5E5Ca0FXK4M2hqet8ZNtfpVklOACqA6jwz83wOf7SchNQ5W2CnNzVz8OYxNWEiK1LZluFSazdH+7oQebxdpvYsruCx5YkOoDB42ARYYJqeLJxGVvl6J73SnM/3cV8JumTNDLoYZSXD16AN+8DhykgL/5ym5cE0UJIV4wnpe1TBSO8Ubt829qlnJJ9FKLjWGAxT+lL7xULHHlLDHqAK7cGKGmWsHgyaE9pBKshmGLeM4b0SS4cfijtj4tLMtcAkCsxetObSrmXwy7TDI1WEMd0vzWx9BXAoEXF2UE1tfeN4RkehGJY2EXCqWuLyBU6ZzPD8tO7oc+ZVsFXZcqpuhJ0VAwIqSVAl9X/jDqNUU0aWqSxSUkzmQl6xNpS+U2GAMWjB53jFoO621aXhodi4HeSn4CnOdLbPnVVOQ+zxzi5M/ixzSZT9JlHXe3FFlD9oD/TFkAcAJmJMwbKhRWyXPqGQYVJ1SRpMTwlAwbJD8UPu5IwgOS/bMq4rSjyE4d/ijYE1GRz/5Q+0FJIKXWhG3IvBjJhWpY3AtacmrW6CkV9qrAgfSQgCHrWb2KhljmNOjWf6SmM7Q4zXxdQcit77bvUTpwHzZA5ydbnd3xoEgN+7Xc8GAjVLWCUriveTTc1bgVnvE6gSB06JvJXGraraKEuqL5oOyZoeN3B8fWgnfRXg2cM8NLLzd1d4Z+p6iJnpXHAwbr6PwfDKu19wptT6hu6uetOcveY6PCdJmepcBx7Rmnwn4sjzhsm0MT5QiGMZ3T2RmAsQux8Yj7z lHL0QvWq kvLzMx3F+b+yc+ybyOcqKugiejjPAVlterFe6baLU72+DFPIVRjnw/VZX460YUXaYx2lYRfgK6QPc7vC7dXEMXrtwh8VnF8Irr+7Ftq3VG76snOHQKcLHjf5d3Q8IxA5oXFmlJKFbRS/qgV8QrWrUJA7c8KJSxempFxiDiYbKUABNyGLXDJDyBQYobg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 03, 2024 at 11:31:17AM +0800, Lance Yang wrote: > { > - unsigned int count, i, nr = folio_nr_pages(folio); > - unsigned long pfn = folio_pfn(folio); > - pte_t ptent = ptep_get(pte); Please don't move type declarations later in the function. Just because you can doesn't mean you should. > - if (!folio_test_large(folio)) > + if (likely(!folio_test_large(folio))) > return 1; How likely is this now? How likely will it be in two years time? Does this actually make any difference in either code generation or performance?