From: Matthew Wilcox <willy@infradead.org>
To: Lance Yang <ioworker0@gmail.com>
Cc: akpm@linux-foundation.org, ryan.roberts@arm.com,
david@redhat.com, 21cnbao@gmail.com,
baolin.wang@linux.alibaba.com, ziy@nvidia.com,
fengwei.yin@intel.com, ying.huang@intel.com,
libang.li@antgroup.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] mm/mlock: implement folio_mlock_step() using folio_pte_batch()
Date: Mon, 3 Jun 2024 04:36:31 +0100 [thread overview]
Message-ID: <Zl06P-qdpca2V9aJ@casper.infradead.org> (raw)
In-Reply-To: <20240603033118.76457-1-ioworker0@gmail.com>
On Mon, Jun 03, 2024 at 11:31:17AM +0800, Lance Yang wrote:
> {
> - unsigned int count, i, nr = folio_nr_pages(folio);
> - unsigned long pfn = folio_pfn(folio);
> - pte_t ptent = ptep_get(pte);
Please don't move type declarations later in the function. Just because
you can doesn't mean you should.
> - if (!folio_test_large(folio))
> + if (likely(!folio_test_large(folio)))
> return 1;
How likely is this now? How likely will it be in two years time?
Does this actually make any difference in either code generation or
performance?
next prev parent reply other threads:[~2024-06-03 3:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 3:31 Lance Yang
2024-06-03 3:36 ` Matthew Wilcox [this message]
2024-06-03 4:13 ` Lance Yang
2024-06-03 4:14 ` Barry Song
2024-06-03 4:27 ` Lance Yang
2024-06-03 8:58 ` Baolin Wang
2024-06-03 9:03 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zl06P-qdpca2V9aJ@casper.infradead.org \
--to=willy@infradead.org \
--cc=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=fengwei.yin@intel.com \
--cc=ioworker0@gmail.com \
--cc=libang.li@antgroup.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ryan.roberts@arm.com \
--cc=ying.huang@intel.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox