From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52387C27C55 for ; Tue, 4 Jun 2024 22:13:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F7866B0088; Tue, 4 Jun 2024 18:13:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A7306B008A; Tue, 4 Jun 2024 18:13:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 720C66B008C; Tue, 4 Jun 2024 18:13:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 541C16B0088 for ; Tue, 4 Jun 2024 18:13:45 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DBC1514110F for ; Tue, 4 Jun 2024 22:13:44 +0000 (UTC) X-FDA: 82194609168.27.D9E155D Received: from flow1-smtp.messagingengine.com (flow1-smtp.messagingengine.com [103.168.172.136]) by imf09.hostedemail.com (Postfix) with ESMTP id 89BD614000D for ; Tue, 4 Jun 2024 22:13:41 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=tycho.pizza header.s=fm3 header.b=IMrQfajn; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=MFeTNtxF; dmarc=none; spf=pass (imf09.hostedemail.com: domain of tycho@tycho.pizza designates 103.168.172.136 as permitted sender) smtp.mailfrom=tycho@tycho.pizza ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717539221; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=muU5qJkRVrc/WJXrwBT0sJpUEwClb+SER/+HMwaSXbE=; b=Wg6fPukXut9HLG/ubwRLg063+G5Xwe3fw3wL/J/3ChMWjUE89siaIx5hAq45P9pba/p41r Fft8iTT754Rw1CIfON8ldrpvcKb8ho6tQrOY/kOD6mOW1eSKjk06p/Kdri2RoFLJOGRzRB gjP/lsR6IzK1P5KP785x2fMBe1l8YnA= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=tycho.pizza header.s=fm3 header.b=IMrQfajn; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=MFeTNtxF; dmarc=none; spf=pass (imf09.hostedemail.com: domain of tycho@tycho.pizza designates 103.168.172.136 as permitted sender) smtp.mailfrom=tycho@tycho.pizza ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717539221; a=rsa-sha256; cv=none; b=a9TI5zYke6sQEoPI9OFcbaogsy3YJ6DG72zG0oRU1PfR2KQle8LIWOOrfldCx4fG/1GlQ+ iqs33eNO6mlxZfHHAafYm518F7FJio+aGqAbQOLfzCC/dtoVu2rgwxb/b6GNHA0ncsroIp TVwddvZVsSn7PbmuEdse/xUN0kldT68= Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailflow.nyi.internal (Postfix) with ESMTP id 33B85200178; Tue, 4 Jun 2024 18:13:39 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 04 Jun 2024 18:13:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tycho.pizza; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1717539219; x=1717546419; bh=muU5qJkRVr c/WJXrwBT0sJpUEwClb+SER/+HMwaSXbE=; b=IMrQfajnu+GoDRKlk7ICyJN2RB df07iUJTJhJdTdXsskFVN2YBYUA0ThPeeOJem8mlAf9L/GG0pOaXA/mfnqMtNioG Qg3eRDQefaetISlfIU3LvnYBFS+0WfChDyq/P0xWTWF51tbK50H/wqxB/DhcA16S ESVlf1iBwEBLJtPI18jyJFnVr5yiVI4at14G7PWsafABea8ghLtpKp3bfz8cO6/t O0WKTNLW57ZU36nkLt573ORKn1AUo/KT70eGo6mN4Y2LxhgmjlaNFtA0ZP9f2HmQ UxyyOOm10AqNUBs8MGdFCAnMfEjrdZfoimbLr5GfyIa537l6G6SLZuOKapuQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1717539219; x=1717546419; bh=muU5qJkRVrc/WJXrwBT0sJpUEwCl b+SER/+HMwaSXbE=; b=MFeTNtxFI2QMwDPKwN42XQzf9AsNmhYWklo3WTFDkq+5 O30Ex0pMTHobmgDJZPvk60WZp0Y9jCn6VNa9vEgyiOSzlNHUpOQDbOogCzi4Uu7Z LBpp7nP4M9ACiqmwIWUnhzCxldVtsnGoId+TKQAYhl3S+zgxq+Wuss+OlxQoEyI/ cLsXZYNpL/7MFJ6/vrwp+JsjJrekEHgVZ7hbSAwqRFbaVkDYbUkLvGIAYafIRftJ B6BtvThMJSEW4ZgPFzrmcDcEl36/UVQkZt1E0yaIPJO9pbgwusQ/npmm4pG/wEml ssfZc73DIRmqIheoviOdqsABd1gYrWz1kn1tRms8og== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdelhedgtdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepvfihtghh ohcutehnuggvrhhsvghnuceothihtghhohesthihtghhohdrphhiiiiirgeqnecuggftrf grthhtvghrnhepueettdetgfejfeffheffffekjeeuveeifeduleegjedutdefffetkeel hfelleetnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epthihtghhohesthihtghhohdrphhiiiiirg X-ME-Proxy: Feedback-ID: i21f147d5:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 4 Jun 2024 18:13:35 -0400 (EDT) Date: Tue, 4 Jun 2024 16:13:32 -0600 From: Tycho Andersen To: Simon Horman Cc: Kees Cook , Vlastimil Babka , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , jvoisin , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, "GONG, Ruiqi" , Xiu Jianfeng , Suren Baghdasaryan , Kent Overstreet , Jann Horn , Matteo Rizzo , Thomas Graf , Herbert Xu , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v4 4/6] mm/slab: Introduce kmem_buckets_create() and family Message-ID: References: <20240531191304.it.853-kees@kernel.org> <20240531191458.987345-4-kees@kernel.org> <20240604150228.GS491852@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240604150228.GS491852@kernel.org> X-Rspamd-Queue-Id: 89BD614000D X-Stat-Signature: ezjuy8qjpn7fyup1ez1jzs7td3zr7fkb X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1717539221-723638 X-HE-Meta: U2FsdGVkX1/I1G0CU3btDSyWeLe4aEyR0frDvHrAE+RrZ0yQ9dnS+aYy18hSZiDnie3BAMQpj0Hvdpjd8RC6FxsIQMS4ENd3aUrGxTE1eZXHnHm/Fs0D6JoG7mL35L5eelyNuVyWSo1So7V7X7Fn7Bc8Gip9NWWlCzmeFMvN7DOQ6MLK3wft5F8xw4gMkHM1NAZj1zdyBtscp8iXgP1OfYeSHSWU5eI/GrePmwpvz36IbUfohGIGXtERuqGX9xjQiu6Lds69V9fMNLrxVzpZDMEK9b3p9947XGI790cpdO5c56Nxgk2LlxxiS/HhikzMv3v3ozbeWqsiaG/r2zzDzwnY009Cnzqv8LWyFSrsimMOrad6XKVRgU4AnCgCxxYQQnE3jgefX9H1TuKviIBrvAHE1XrbnFg3jYMTTyl7iuPVqu2E5ZzYImbb3uNV3zxhW+FuEEenGB/sGKID61cUCbW1RYRYqxlbN/fQhMeSjQL9G70Zxs3miDgs0n6TOq/XDFrIqp5MGYtUZVyuKJ3yGwLufXg9E/kAYH8DDbLGI6NgFoQxUyRchXjsQFzb8yJHueQxpvg/Mzn1bRgXdCZjKUsdYLl8rv4GetsSZQ5jtJD32gXKknHLtgUxo8eAesCzznKRdr1uFeGK2a/r2jkBZ7PBmda21Xwg2ke4jmN1grMznor9CBOIOC0zqTjzxQXhHCghSOLa/JlHR5fMRYZ4ozsjFxplRS5oiXBx4kGuWXN+OAJcQYNF2e2Fer1QNtY6KGDjGY8a8EkJs7zJinWkTwqhySRTc3e/Kjwg/eDJa62Ixwr0JcHVzDCLvVMIV1XVdDMxbw+NqJp8MC6ngrtXW9IhUIOQ2VO4pDgU8Ha1xAr/+W2cbGNLzMzukDkePJL5jpAFR0jU8ruPX3vCsivhyW5IA/aYVsKxe3sg6LVIor5kKiSmfQNuqRs6hc1fTN2ZisxT6R38GEdbvcRl8mf jTlgR0p+ Yln/aiYaRz/sicneNAMltB0bmG3WhM7wI9xW1ugSVWoWFgX2x63tFW69eHJ/s+vDl0DwgwjvpwljNcL7CZ4HydpQXDReL3thvKotm+F1x3GLYovSX38U34Ab9FPCskJg7bc6/Z+ORQKKQYBJg9sm+tp6pNbOjqSzUr0xZtzV3dgOx/nxMtzno+6QUWJzrn5TE81IAnQZlqxa/AJsH7lp6Mw49Jd5uzyxZtQeDC53vLGK1GFL0ovhu6wW5k+fzixIyiA0baUqXt20xVGo81jB/e/X3Mz6Q7kKP8siGNRQVhbXcLJ2YA6cVI7ofvtISqVIFy58g9zuv8qb3jmrKP7mWq143MQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 04, 2024 at 04:02:28PM +0100, Simon Horman wrote: > On Fri, May 31, 2024 at 12:14:56PM -0700, Kees Cook wrote: > > + for (idx = 0; idx < ARRAY_SIZE(kmalloc_caches[KMALLOC_NORMAL]); idx++) { > > + char *short_size, *cache_name; > > + unsigned int cache_useroffset, cache_usersize; > > + unsigned int size; > > + > > + if (!kmalloc_caches[KMALLOC_NORMAL][idx]) > > + continue; > > + > > + size = kmalloc_caches[KMALLOC_NORMAL][idx]->object_size; > > + if (!size) > > + continue; > > + > > + short_size = strchr(kmalloc_caches[KMALLOC_NORMAL][idx]->name, '-'); > > + if (WARN_ON(!short_size)) > > + goto fail; > > + > > + cache_name = kasprintf(GFP_KERNEL, "%s-%s", name, short_size + 1); > > + if (WARN_ON(!cache_name)) > > + goto fail; > > + > > + if (useroffset >= size) { > > + cache_useroffset = 0; > > + cache_usersize = 0; > > + } else { > > + cache_useroffset = useroffset; > > + cache_usersize = min(size - cache_useroffset, usersize); > > + } > > + (*b)[idx] = kmem_cache_create_usercopy(cache_name, size, > > + align, flags, cache_useroffset, > > + cache_usersize, ctor); > > + kfree(cache_name); > > + if (WARN_ON(!(*b)[idx])) > > + goto fail; > > + } > > + > > + return b; > > + > > +fail: > > + for (idx = 0; idx < ARRAY_SIZE(kmalloc_caches[KMALLOC_NORMAL]); idx++) { > > + if ((*b)[idx]) > > + kmem_cache_destroy((*b)[idx]); > > nit: I don't think it is necessary to guard this with a check for NULL. Isn't it? What if a kasprintf() fails halfway through the loop? Tycho