From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA03AC25B78 for ; Tue, 21 May 2024 16:03:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 56C626B0085; Tue, 21 May 2024 12:03:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 51C696B0092; Tue, 21 May 2024 12:03:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E3DC6B0093; Tue, 21 May 2024 12:03:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1DD436B0085 for ; Tue, 21 May 2024 12:03:56 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8D8A914130B for ; Tue, 21 May 2024 16:03:55 +0000 (UTC) X-FDA: 82142874030.15.A31006B Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf22.hostedemail.com (Postfix) with ESMTP id 63EA1C0003 for ; Tue, 21 May 2024 16:03:53 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=bJvYEzXj; dkim=pass header.d=suse.com header.s=susede1 header.b=bJvYEzXj; spf=pass (imf22.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716307433; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6xNgyl+2IoOjYGw//Y70hdG7G3C0dBJQyHPBEOEcFK8=; b=prw+m/vv0V4wNpLrj3o7dJniiW0VuQSLy+3vw0MRdhAws+0H4Q/DfjKtkOjI+l5uW5vhcR VMPUnthLJSOcU90zhkvAszWpVTHeI088pxwR9O+0S0Y667r9GriDH7xyav9S1BahdWOzPy /8l9UjQQpAd6dgrZ5nEcLiaUP+O8nAM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716307433; a=rsa-sha256; cv=none; b=8bgZm6iSIuviBjj1qZQ8VxK4JZfQrVX2wdJ3HY7rgz5n4npDc+gdp/ojuzloLXrK+UCE80 lzoxJ2e57ubEoKbpjnyEvEU8twfFE+OcZ/CQZwEgcKlaMR4q22djCobTcu54GCYKwJCCDs obu422be3lGhxjqZVCn2PG0FsRz1CvQ= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=bJvYEzXj; dkim=pass header.d=suse.com header.s=susede1 header.b=bJvYEzXj; spf=pass (imf22.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A21EF34850; Tue, 21 May 2024 16:03:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1716307431; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6xNgyl+2IoOjYGw//Y70hdG7G3C0dBJQyHPBEOEcFK8=; b=bJvYEzXjz4m666AkTXA36SaU0UA2YQtttseafJhAcNhoPNVipM8Vr0D6dgtMKSHII26ehz 1PvyB96VjO3C8NjggOqS/98RulKsT1YigHNM4mLXNZGrBn7Mjl2S7szOonfYISPonRwd1V tL0SNaWTK5ydko0vdiCxGkwf5guCXLg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1716307431; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6xNgyl+2IoOjYGw//Y70hdG7G3C0dBJQyHPBEOEcFK8=; b=bJvYEzXjz4m666AkTXA36SaU0UA2YQtttseafJhAcNhoPNVipM8Vr0D6dgtMKSHII26ehz 1PvyB96VjO3C8NjggOqS/98RulKsT1YigHNM4mLXNZGrBn7Mjl2S7szOonfYISPonRwd1V tL0SNaWTK5ydko0vdiCxGkwf5guCXLg= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8926713A1E; Tue, 21 May 2024 16:03:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id yUypHufFTGaaJQAAD6G6ig (envelope-from ); Tue, 21 May 2024 16:03:51 +0000 Date: Tue, 21 May 2024 18:03:45 +0200 From: Michal Hocko To: Matthew Wilcox Cc: Kefeng Wang , Andrew Morton , Johannes Weiner , Roman Gushchin , Shakeel Butt , Muchun Song , linux-mm@kvack.org, cgroups@vger.kernel.org, Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes Subject: Re: [PATCH] mm: memcontrol: remove page_memcg() Message-ID: References: <20240521131556.142176-1-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Action: no action X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 63EA1C0003 X-Rspam-User: X-Stat-Signature: s17unwzdajijnt8madha8n9usiyjtrim X-HE-Tag: 1716307433-546665 X-HE-Meta: U2FsdGVkX1+dhd6hwYpR+TKTx96rUTTKH6bVyiyOEeM6wEMm8yqTVuCXyKRo7+WXX3zmjN2J/Aal2NoRmfKgyn2E1a/LoB2wbdSZMkEK9vazAGTPCjIXh7lMRd1P61vlwQWS9Csv4BLNIv2eNtlqGNx6zo1i+vEr5EIelgejDQI9t6u9CjoqSlroY9NxXYinVtx8agyxF62ovtfv8LutUT170/ydLfTCvsFuGj+I9+wNs621f1ij9doz1rqqr5yUOPVB7LMHZEBzpq2qwpvbgs8JQKiHhhbolICg9G1ECD8EBVPyteKwNGo9+QQGKVe/mcSrfeGGdQNjbPOECeayZRVxhiBZmNNIQTzOKZY+Q69Lwbdbbxu5HKD3l4GVMl6ice+1ktAmkkQiauvGAeX9iZXMA5K/0V2d6YMAcLux/PmoQP+lxL2doOpbuiAym+YYMcWv0EyTX0bHBWvvT/Ofwl4z3VdcFuxK/InA+SbJunG60aT4sP09aOrl058onFuBme1hWrTc8t9Q8jHT90ZuTOjkaU5jKxnWqrT7EFzj0mJG1mngMASqlV/9whTaRoT68k0XMo2zF6CyOed4baBNnJ9sBCtgz8yUcsk0e8DUunrVbsSya6Bs6cKhPqsKbW6dXOKQVuBtjczgUuQEewLl4yCzquVGB4nNk2cBC/z93zRwS+ZoABsE3zDVdMRG2uniGmAKbIEGYMFqRA8FhyopgDYoLOfwBjCzWLU6DsTwY41yyDt46RYboPtERKiCnXkl2PqLArGMxCXXWlHQi1qLXnpkOZqZsbOei2PAs1tMc96wDHhKVowurHAqJ2gx/QMfzZ1Vp17u9Oo3cVF7IpMbJw5ox8f8/9gl1PRrXs/DwUWiLN/IdZxHy4Gwck5KLrFGbSTYtBOaUjG/sU6IS5kuFYz+fCPZAZQ02hz4kEsLV/H8mbQf3r0v+RAy/kCaJFSL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue 21-05-24 15:44:21, Matthew Wilcox wrote: > On Tue, May 21, 2024 at 09:15:56PM +0800, Kefeng Wang wrote: > > The page_memcg() only called by mod_memcg_page_state(), so squash it to > > cleanup page_memcg(). > > This isn't wrong, except that the entire usage of memcg is wrong in the > only two callers of mod_memcg_page_state(): > > $ git grep mod_memcg_page_state > include/linux/memcontrol.h:static inline void mod_memcg_page_state(struct page *page, > include/linux/memcontrol.h:static inline void mod_memcg_page_state(struct page *page, > mm/vmalloc.c: mod_memcg_page_state(page, MEMCG_VMALLOC, -1); > mm/vmalloc.c: mod_memcg_page_state(area->pages[i], MEMCG_VMALLOC, 1); > > The memcg should not be attached to the individual pages that make up a > vmalloc allocation. Rather, it should be managed by the vmalloc > allocation itself. I don't have the knowledge to poke around inside > vmalloc right now, but maybe somebody else could take that on. This would make sense as a follow up. -- Michal Hocko SUSE Labs