From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9B57C25B74 for ; Tue, 21 May 2024 14:20:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A0026B0098; Tue, 21 May 2024 10:20:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 629016B0099; Tue, 21 May 2024 10:20:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 47C2F6B009A; Tue, 21 May 2024 10:20:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 253C96B0098 for ; Tue, 21 May 2024 10:20:40 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C786DC0CC5 for ; Tue, 21 May 2024 14:20:39 +0000 (UTC) X-FDA: 82142613798.05.6373632 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf10.hostedemail.com (Postfix) with ESMTP id 5B180C0022 for ; Tue, 21 May 2024 14:20:37 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=rO2eJGX2; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=RLmDzPRI; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=rO2eJGX2; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=RLmDzPRI; spf=pass (imf10.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716301237; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D2gl6IIKZoaIcIf/VQk1wtsxiVEKAJnwFVp8xEUBBLc=; b=25Wyr7EXl7HeNO/7MZdleM8XLm+ywAswTnr1f3OAe8Cx8lAEwtZavUSIIpm/7BidLVjiHS jUGjlG/lO9I0yJdpIJI6LWsmGNCozJ8cU//Z6PdgFnR+W5/W3GKAJztJoQFDrQ9J8rK5R9 uFhfx6171O/SzBpXCRE9tONVregQVN0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716301237; a=rsa-sha256; cv=none; b=Z9aeuI7bi94n40a9NV9cUSZyo2XHUpI6F3/ALTKrvOLjKyqvZlvAZBxtYcxgPj2WvH6AB4 Lq2MohPN9C77t2w9fTIxKHQVUkc6M5CCGToD5QgobRft0fqRr6Xd7hshF2U6r2F0N3zvxj xlu2jpU1gnW6PL4xy4aHVHho5wpS5Qo= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=rO2eJGX2; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=RLmDzPRI; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=rO2eJGX2; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=RLmDzPRI; spf=pass (imf10.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 38F19342D8; Tue, 21 May 2024 14:20:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1716301234; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D2gl6IIKZoaIcIf/VQk1wtsxiVEKAJnwFVp8xEUBBLc=; b=rO2eJGX2DCJrhuV+yZ3rMgnlKH+er2PdvSaY9aJKC/k8tQiX0sB1kwl5fRblWX1Lpm2Nlf grAAgFgARm88tcvB9VMdVY52e5DDA07n+cAxv6yUz9gShNiBcXKpDbotyF/HMvfjt9EXvl fBq/X2Kyo2xaVnUhaLJq1R6MyAbqgKM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1716301234; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D2gl6IIKZoaIcIf/VQk1wtsxiVEKAJnwFVp8xEUBBLc=; b=RLmDzPRIx+fhV+XYlKEzah51idE+LCMoIzIxbs59YgHiyMR7BXn6s/ds/Ll/ivLWuobT4k UGFf0v2KQ4F3SXBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1716301234; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D2gl6IIKZoaIcIf/VQk1wtsxiVEKAJnwFVp8xEUBBLc=; b=rO2eJGX2DCJrhuV+yZ3rMgnlKH+er2PdvSaY9aJKC/k8tQiX0sB1kwl5fRblWX1Lpm2Nlf grAAgFgARm88tcvB9VMdVY52e5DDA07n+cAxv6yUz9gShNiBcXKpDbotyF/HMvfjt9EXvl fBq/X2Kyo2xaVnUhaLJq1R6MyAbqgKM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1716301234; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D2gl6IIKZoaIcIf/VQk1wtsxiVEKAJnwFVp8xEUBBLc=; b=RLmDzPRIx+fhV+XYlKEzah51idE+LCMoIzIxbs59YgHiyMR7BXn6s/ds/Ll/ivLWuobT4k UGFf0v2KQ4F3SXBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4D5DE13A1E; Tue, 21 May 2024 14:20:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id yy4lELGtTGaZAQAAD6G6ig (envelope-from ); Tue, 21 May 2024 14:20:33 +0000 Date: Tue, 21 May 2024 16:20:31 +0200 From: Oscar Salvador To: Alexandre Ghiti Cc: =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Albert Ou , David Hildenbrand , Palmer Dabbelt , Paul Walmsley , linux-riscv@lists.infradead.org, =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Andrew Bresticker , Chethan Seshadri , Lorenzo Stoakes , Santosh Mamila , Sivakumar Munnangi , Sunil V L , linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v3 5/9] riscv: mm: Add memory hotplugging support Message-ID: References: <20240521114830.841660-1-bjorn@kernel.org> <20240521114830.841660-6-bjorn@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Action: no action X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 5B180C0022 X-Rspam-User: X-Stat-Signature: ybbauot9qir39zn5pcm4krq1z331x8fw X-HE-Tag: 1716301237-665929 X-HE-Meta: U2FsdGVkX1/E14Fg7eJsAtlr5c2JDLXFAOZ9b16EX0/F20gTYAMsDmU4m98U4RuF99IsLS+GPeaYVANdto5TlYdY2bHszaJdB0BVFTqm0sIKl1w7NaYiAC7u8nxsH4jQc+YHeW8spUr3pA7pbaqN19c8IokOSqV3IXnIAPS/HmaP3p7SC5d6oA5GmFuKyc1vRHoLMykiKpvI5bnAZeUixMun4ADqiqjlMesrlbFdnlPpNEadwsUrrjkvm52nENq9y3vF6E0XdWIAT3QncjVqLqfTDmNOQYGGWYztnX1mLsoIHLQx0hoVs/pzcQjFmnVKbAssXvoD/5VqiFsjvG23MGxavcxcVQ+vWkNclbzmVw+0zN5S1oA3VLH7IrubPaxyU/xsvgaTt91YOAxukZTp47/WFFYCqJE8A8lezOYrYnKRfZJN3RswAtZAjO7KqeLuXA92lP4dvOdMWRqiH34+iSk0xyGltDIaNRRXZsK4spb+O/SCJHxtgG5cWasmivWk6qA1hCMdSejG8kpA4PAX7LEl/MDtIS3OKLu2q5r2BbG6vtP09yafFFmrDucL6B4/FGF9rc4C+Y2Vc044zVZjlTz2M5P5e8//0pUnu0cnVW1P1qnwvS1gAsJGF93DmSy8qQtUAG02ekUWNcK4r2VTB3JukYjVFOyED32xVDP9SVU1GFko9qX7RifrG3k3Euj2qtd1qpNE/mrVW655I4Uh/dhwDD5YoLj3eEtYo75vUMlnPe/vla5wi6rCBoRrBpDW2NWtRg0HsCbCtH6zi+Xdtt3O9Zc3SEGfJtEptT0ZYmpMMO5PDojsA8JWaRW5BySYwMysSpCtZ4icvAmZ2cRS2U9hp6ghzyfJo5jh2KHN23GZufzJAjLCUD+nMl82hf+zD0rxjHSHXcxexL6QmQ1fXT45AqlblSaix31fgBWrfDtofbu7Yvq6BZzkk0Ttvsf8GeX1fNzz74qcuBxAvCb UrlMuEx0 VQ/fvyZ0NSZk3Rejb9uZF/nKJWE6YqgWIK1lA+wbU9YpOXHIzIgZ/EkpLnQxPWbnpUTtMv33VCPPOwhMWXQWXYUmJemEDZ6PdjdcSvd+y101FgTALIvg48mh2M/iQZN7CPB3uPg8ZJaoTSlD8pBx6z2uTFTPtIv9TxaRKLBuRtEOlLq2PoMjTaJQEijRrnmUtA3sx2S09NiUvBrmV1We4MYmpZ9GplRCY6l938EkBUImaBxprICirJbffU2H71Jokn39WAT9xS+T3zYJzCCZSZeba2Gy3C+BgshVq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 21, 2024 at 03:19:37PM +0200, Alexandre Ghiti wrote: > On Tue, May 21, 2024 at 1:49 PM Björn Töpel wrote: > > + if (PageReserved(page)) { > > + __ClearPageReserved(page); > > What's the difference between __ClearPageReserved() and > ClearPageReserved()? Because it seems like free_reserved_page() calls > the latter already, so why would you need to call > __ClearPageReserved() on the first page? __{Set,Clear}Page are the non-atomic version. Usually used when you know that no one else can fiddle with the page, which should be the case here since we are removing the memory. As to why we have __ClearPageReserved and then having free_reserved_page() call ClearPageReserved I do not really know. Looking at the history, it has always been like this. I remember I looked at this a few years ago but I cannot remember the outcome of that. Maybe David remembers better, but I think we could remove that __ClearPageReserved. Looking at powerpc implementation code, it does not do the __ClearPageReserved and relies only on free_reserved_page(). I will have a look. -- Oscar Salvador SUSE Labs