From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26E52C25B74 for ; Tue, 21 May 2024 07:23:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0FF2D6B0082; Tue, 21 May 2024 03:23:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0AF216B0083; Tue, 21 May 2024 03:23:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE0746B0085; Tue, 21 May 2024 03:23:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D021A6B0082 for ; Tue, 21 May 2024 03:23:45 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3C3C9810AA for ; Tue, 21 May 2024 07:23:45 +0000 (UTC) X-FDA: 82141563210.01.DDB86A6 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id 9634840002 for ; Tue, 21 May 2024 07:23:43 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tIQ5nB50; spf=pass (imf07.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716276223; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J+rPY1ML3X1lUPrHmixDWdkjBMvL2k8mOJWV6AHs1l0=; b=HUhTuXffFSRtdx7Jx3av5CIszBgzgeJiQPsHpQC+ikQOsIwGbGtqKivnanfjBfOeGhrKw3 0yFnBM/mzL+aeBlX7m4We34FRlv2olJEwV0vqWz63FMjDBOUxvrgoSnV70VHFibPJg8H5k n9PPHvNaQlgvqvQKddJ2FplcvWbDfSk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716276223; a=rsa-sha256; cv=none; b=EQtAW9xH0Bvyo5ynVI34+R191hngCUQybXh+z6H9McnkD5qwzxyE8CtbuZoycfpdv2i1BA lzwCktN+97xiqQj7Uy0ceXt6QWNXt8xkbMDJxZCMf+kAbz+FSJN/qFE9UCQZBeGZaebetH 4xsIxdf4G35B/kovYzq79FdOqTKf/BM= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tIQ5nB50; spf=pass (imf07.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id AAA666201F; Tue, 21 May 2024 07:23:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C6168C2BD11; Tue, 21 May 2024 07:23:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716276222; bh=g5ad6h6fsS1VZMljbHFZQxtWXnD0wuSkOgJPO8o+IWs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tIQ5nB50A9fzy5aGKXStqGdhlcNXWJDoGm3vdmlYmeIA0Exsw9AAftpoIq0V5PD7P ojLOwe2a0aIn3HYTZAuur0MT4qKOMLOcd6jotkYJ0sQSqEYpAqlDmyr+SvVgkd5VhH rm/o95/zodJ0qYY9z3yHKKhiWK3ASNm4xAF+A1AlLnqSdMK+6s43pbz4z5SvtTkcu0 h8T3JC1arzq5w1Mdp03m4Tm+hSzqdcmo78juAHHutycjkQPjPjIQVhXQA+XzfoVfax b+eNncCUyc5BnkclrrbRVUmS6V6egan9JUCPSrp9exOdPg5hKAsKFbcqZbvrwBLfX4 s74zLa4/EuRKg== Date: Tue, 21 May 2024 10:21:52 +0300 From: Mike Rapoport To: Wei Yang Cc: mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, aneesh.kumar@kernel.org, naveen.n.rao@linux.ibm.com, arnd@arndb.de, anshuman.khandual@arm.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org Subject: Re: [Patch v2] mm/memblock: discard .text/.data if CONFIG_ARCH_KEEP_MEMBLOCK not set Message-ID: References: <20240510020422.8038-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240510020422.8038-1-richard.weiyang@gmail.com> X-Rspam-User: X-Stat-Signature: het43k9e9th5bfbxbmsma8r1cqn6ybwd X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9634840002 X-HE-Tag: 1716276223-289179 X-HE-Meta: U2FsdGVkX18wm5bKrbCOCQdZkaNaK5g8Yxzy+cdJvTBM6jskj3PPAKNfS7gVcRSVmzO6dSqrUoNUPzqS5pHbYrjXV4Oz/QIuuXvbOs3giv4xnjKIyU2t+8tUr35Ar1+dY+ZeIzbXHEg+h/SLojZV0N2awET5B1Y1x96J9G8WdBWE6qO0s+CEOEeKCTZwnfE2dqX+R4F/UpFEsur65LMX90TjB00x5kBo/qZ0XbSPbaYFJpIjN40stzerjVKO4OwLbTkz5Bcp6LNES09Fwva1siiUNG9yPaYp4NV3CpO8dj34A/wRGiAZNdurEJtCuiqPaqfeXyrSuvkDdONt47OtnDNotnK8idZQCmII1WfFyC0KbMeeHaYDFDnEuMgXTQ9Ef2BvuezJ7EzyI168S3Ozrj6BzKl7jg1IHURBKCMZFSdXuwPVyRk/iucWvaCvDFnfYfNxiKLVNs+L+VtTpY7RIKJhTe50toC2A0rHADguCghbt+HC/6Bxez8wcMnXc+S/8VePFhpykqwYcfzrPItNR5CRFDpwgS/xbcaaAwWeUWIdvgfvisZV88cuAiYdzdg8phGjnFz6nh0SSCZ8qDcNYlTWjD/scc5shgXHUXUUtMWN0c8J9jqiVTnih7xpUwr4zdFgCG6C6Xf7TPdfrErR+V5XcjnpNOLgxa6HLLIDvYmJeNHfFo4Oy7TH2sCetF9kWdnYfZYMknDDpU06l4kuYT0+bqH4DrUOuolBimaN4AhhpYGSx+3oJC8fBYq1L04lP3WdWZrAvG2yZjm2MrgWD6blI5kHTl8bnWlADHoYW8lBXUh3xAZPIk07MhChPxthijrojffz3S9Ly+PRkdM+hvvajyoU7a7D8D88v43UuV6XZcH2MeA+/t0qO2HnefQb2N0IdMQWmWotk//RNqBivGmhgKJhg3IA/5Ve0Rclnt+8dlKuFzFWm87UWoLy+vJIUuvv7y9ddOS+lx1Z87d pEajVr8k DwkU4/SRFQXOGT3+QO3aS76Xei3hgF/79iXfyEeRrqwEAXuuaEvrR7JvR9wU4yMttmT13Dc5609fu0Hjl2mVv//d2tvt1rUgK2vZ5pbsi1E/5x7cB9ERr+LHDR9CorLVj9dypoI3y5w7VnxHBONEUgvOOB90qP7Ds4EwJZVpxvWIr+XB6wuzxjxaSV026wdWCFNDxMgobwWwNI9ebKO33eXwCEqclzpnx/AFRs4DETVxbehWPibsOaVVVEflVGnItxW9A5t4UT2gMmX25tgA2wD7DbINPneneJc2IcA5E3r5aqeicYAYgfCoIqBM4c1aTqyWOfIzUcLf7mRY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On Fri, May 10, 2024 at 02:04:22AM +0000, Wei Yang wrote: > When CONFIG_ARCH_KEEP_MEMBLOCK not set, we expect to discard related > code and data. But it doesn't until CONFIG_MEMORY_HOTPLUG not set > neither. > > This patch puts memblock's .text/.data into its own section, so that it > only depends on CONFIG_ARCH_KEEP_MEMBLOCK to discard related code and > data. > > After this, from the log message in mem_init_print_info(), init size > increase from 2420K to 2432K on arch x86. > > Signed-off-by: Wei Yang > > --- > v2: fix orphan section for powerpc > --- > arch/powerpc/kernel/vmlinux.lds.S | 1 + > include/asm-generic/vmlinux.lds.h | 14 +++++++++++++- > include/linux/memblock.h | 8 ++++---- > 3 files changed, 18 insertions(+), 5 deletions(-) > > +#define __init_memblock __section(".mbinit.text") __cold notrace \ > + __latent_entropy > +#define __initdata_memblock __section(".mbinit.data") > + The new .mbinit.* sections should be added to scripts/mod/modpost.c alongside .meminit.* sections and then I expect modpost to report a bunch of section mismatches because many memblock functions are called on memory hotplug even on architectures that don't select ARCH_KEEP_MEMBLOCK. > #ifndef CONFIG_ARCH_KEEP_MEMBLOCK > -#define __init_memblock __meminit > -#define __initdata_memblock __meminitdata > void memblock_discard(void); > #else > -#define __init_memblock > -#define __initdata_memblock > static inline void memblock_discard(void) {} > #endif > > -- > 2.34.1 > > -- Sincerely yours, Mike.