From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9D24C25B77 for ; Mon, 20 May 2024 21:46:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 56BC96B0082; Mon, 20 May 2024 17:46:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 51CF46B0083; Mon, 20 May 2024 17:46:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 40B0B6B0085; Mon, 20 May 2024 17:46:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 259E66B0082 for ; Mon, 20 May 2024 17:46:28 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8D276140735 for ; Mon, 20 May 2024 21:46:27 +0000 (UTC) X-FDA: 82140108414.25.3596CF4 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id 47BA91C0003 for ; Mon, 20 May 2024 21:46:25 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=A1JjLReq; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716241586; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9eZPpYZJ8iy/NNjYCCupfftHLCCO8p5oJKHb/HLE+Lg=; b=zFcK6MJiAK61uYiADjnvYE9nqECIs1bXS3Q6HkvOYBwN09yfo4B54r8xopbSDva/wjdOIP qB1rvO/E4Z5VWV14if50RXuHeVHi8j6wGt6hYTHD9btPxFQwUVxY4aAXjB2aaWkSFQD8D8 gkjMXjbAgUt8arYS8NWFLQnZbC5MQIk= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=A1JjLReq; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716241586; a=rsa-sha256; cv=none; b=LYh8jGTiNL6sdJdJbq9kaMjmtB7f3QKgJdDHJpB5cDAVcifoUQI6JViHQhYFsdXjNzXkFm +DY+7+upluyx1MT4HcfTj6ENZxlcJY/xKur7VymJiXe3H/gr+xJGkn23pNDc5UxCYLjTJ1 WsGTeA/a7UbMKFW8KQlf42S64vY48AE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=9eZPpYZJ8iy/NNjYCCupfftHLCCO8p5oJKHb/HLE+Lg=; b=A1JjLReqArNhLPm0IIoqbg9xfF AAobZTEtxfDYYQiD2EQ3E8+dbyajyX1LHfqBclnDgPJ5Ev9fv9I2QFGk6c/vjb4as08937mjvgbcQ 9SmFqFA9k50XRg+mId9dCmHRGStY4WTiWfiMNME1E5QMMXoANXUzdCKjFs68ssglKRnYjmyJNrpSc TQMQbTY6wdj7JPGDfnlj/JbbZUMIx0RW9sd0GgYPUvuwuNcdYJGRB+jZgMq9niLtSu6Jyw8GBRPqt r2HmQWuHeWgbZzn281FWOIM2S5AC1+2/lxxqsRoDYKQPm6VReigPeMZvaemAf7vdeGvV0OYehp/S0 JaLGg3mA==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s9Apo-0000000GPNJ-40T3; Mon, 20 May 2024 21:46:20 +0000 Date: Mon, 20 May 2024 22:46:20 +0100 From: Matthew Wilcox To: "Vishal Moola (Oracle)" Cc: linux-mm@kvack.org, akpm@linux-foundation.org, muchun.song@linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Convert __unmap_hugepage_range() to folios Message-ID: References: <20240520194749.334896-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240520194749.334896-1-vishal.moola@gmail.com> X-Stat-Signature: i9awpkt677rqhy3g9xtitbosihgr46xd X-Rspamd-Queue-Id: 47BA91C0003 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1716241585-79338 X-HE-Meta: U2FsdGVkX1+s/6sX/2ZQ0mH8QgaF5PUV9ul8yc/VQaoiXyhcWSxMGEisTcPv6atcmGjmfaBoX0v6CJ6BRawnggiFCJlJljaPVO5wXlqm0Jw9fh+Ub1MYzOplolvyomcDn6S3aUfowVagGj7jXkvDzPZoYNgQ2PI/YIblRGrL+JWBOnTbv6Y+s1OjHy9CPuCLlncAdeiNqjqLX0JQmqnLsGdYy4wWQPM3/UX8RElOvqs5w2FXogV2HHfmDEhHBOO6hLDGrQg9AKmRNx/QmEhHL3OJgQiLNfV5XqN1Up/fr+i8b0icTvFmyYqCmeZnmTmhcVKbd1qLWvhGWOk3a86+NrNSvr4rY0wrcY2ehj2M3KRMuZQCzoVMG+lT2Xs5828j4rNImdogGazSRYWS+AcTxJqkCpygffWvYYz2dSgncXtN9KotPNB+nxC9VxkWhGpr4dsMWKeEhdDCtx0C7k6D/amBBl3ASarBPfns6tGgaoxUR1LddPz5apUHAAYZS/5vTjm8pYdajQsl/rJaTwlVQAW562m00PKADex1baT360V0EtPS/j2IFJZp9sw1a1WGjFaP9xi9LLrWIRAXxzMbuSG15hJcxKOAjBRRbWog3CIVnSGAtYB28zeM2ABuQxs6XdnOMI9lQhzyvUb4NbEjFLzX4lfUgH0Y5zyhddW6wreMyCN6fvlQ48Ksmffva4lVG+3mO8+E2IOqcYwAc3Ss+nKk//CRop2GSE2HaHnePul40s1biQS/gwKvIQldmN33x5gGYolq5K0tskLkQB1lK4lueE4n4fm07YC19Kqcd+ctbJSK/TkKlPfTxsWKM9+wEAMm7QeM3lLgGBwIhjpdbY1cJ+hGoo66SU3R0hsnYX83wTJg3DhXu0tzxzQ1nSlImkjSFviFxjx+4dZWs2cyD6ckX/g4GBgsQql3I7JSqUdTbJOfwggUyaziyXQAxLf1wTKGrqw4Y9vedCyMkvu gXBBTvwS tjlTt8k2jbuZ07b9BjCPosqXnvqIkhRudiQKwPVD37N8zxpz2S77Dl4pimrj9mi2nTMiziVDI5rwNzndV+zlZRAaoJh3vNGjvyxA96/3X2D8QnmaA3y8eWuF1oyg3qgrlXUn0lOinPhBZxB0Mi5IlGSG5zAJi1kw9XY0+G7iyy5j9ACPle5F4xv2VNpqZE3m9hPX++3yNLGuAEcxYASQOJz0m3BVL4ovrQg5dolTkcWj34l4ahcNyAa0V8nFd8TauZ1Su X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 20, 2024 at 12:47:49PM -0700, Vishal Moola (Oracle) wrote: > Replaces 4 calls to compound_head() with one. Also converts > unmap_hugepage_range() and unmap_ref_private() to take in folios. This is great! > void __unmap_hugepage_range(struct mmu_gather *tlb, struct vm_area_struct *vma, > unsigned long start, unsigned long end, > - struct page *ref_page, zap_flags_t zap_flags) > + struct folio *ref_folio, zap_flags_t zap_flags) > { > struct mm_struct *mm = vma->vm_mm; > unsigned long address; > pte_t *ptep; > pte_t pte; > spinlock_t *ptl; > - struct page *page; > + struct folio *folio; > struct hstate *h = hstate_vma(vma); > unsigned long sz = huge_page_size(h); I would appreciate some further cleanup ... size_t sz = folio_size(folio); I think there are further cleanups along those lines, eg pages_per_huge_page(), hugetlb_mask_last_page(), huge_page_mask().