From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0E8FC25B77 for ; Mon, 20 May 2024 17:35:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 044E66B0083; Mon, 20 May 2024 13:35:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F0F6A6B0085; Mon, 20 May 2024 13:35:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD7636B0088; Mon, 20 May 2024 13:35:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BC9026B0083 for ; Mon, 20 May 2024 13:35:28 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7646B1C1BE6 for ; Mon, 20 May 2024 17:35:28 +0000 (UTC) X-FDA: 82139475936.03.94A8FCF Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) by imf20.hostedemail.com (Postfix) with ESMTP id 97D861C001C for ; Mon, 20 May 2024 17:35:26 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=CexH9eB6; spf=pass (imf20.hostedemail.com: domain of 33YlLZgYKCFgI40D926EE6B4.2ECB8DKN-CCAL02A.EH6@flex--seanjc.bounces.google.com designates 209.85.214.202 as permitted sender) smtp.mailfrom=33YlLZgYKCFgI40D926EE6B4.2ECB8DKN-CCAL02A.EH6@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716226526; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KaUIcbCxnT+V1tXho+s6VK2LQCpbrcFbVlZAjQNTw9w=; b=GdFHp1edR59EG6p/IOU8swlQEm/W9kCV4muO5c6+uM8m5JGepUTzAvT4vous6udwkIEEwC nSnG9sRZ30Y1kEkOIBhqgI/po6A35yZ6O5tP6b0GW1RbXodnGhtdtKjnsKjWIxQh0+Fkho uxHSiaKjPg6CMdal4BGn27XFVNwItKY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716226526; a=rsa-sha256; cv=none; b=ZmTcENp4iz4bqCaI6ZllxCRlzQ7FMbvBz0gzWLuY+j50eMCI03JswaQ/QZfCtP4vIPDYB3 MN43hK8el/AQMcGiPTvLDkOe3nujCPTWz1N1fsPa6GshffZClJVZ4wHlMHmH7TihXJwobY BAB0RvqYW7uDfJZCVHeO90Pcx9mPQsE= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=CexH9eB6; spf=pass (imf20.hostedemail.com: domain of 33YlLZgYKCFgI40D926EE6B4.2ECB8DKN-CCAL02A.EH6@flex--seanjc.bounces.google.com designates 209.85.214.202 as permitted sender) smtp.mailfrom=33YlLZgYKCFgI40D926EE6B4.2ECB8DKN-CCAL02A.EH6@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-1edf507b9e4so135438225ad.1 for ; Mon, 20 May 2024 10:35:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1716226525; x=1716831325; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=KaUIcbCxnT+V1tXho+s6VK2LQCpbrcFbVlZAjQNTw9w=; b=CexH9eB6kGxwOdPN8AawHJ/FMOYKRgesS8HtK4JkgjxLnCD+2efzTN/7owyTisvgzr WzU58z8w4X6JbpEx9zIjePTZLgkxoxWAZcdutk560h5JJdNGOqladCOAPbqe92b2V1wF 2mjW9Vw4liAttzGq9Mo8dshWiL83sSqYC1g/xdbu32w5SLy4mS04+obMg2/rXQi217BU EVI77T/sR63WFL4BfFvF2FtDEMvOJKkJaEns9SY9eY1tP/lv74+tM752mGUuIMW9rZAK IXeSS25uHJ9psd0bzuj0R5ZYOMyknFreW2Sz+uqMtdq6osi4bCuLdrsyR8KXno+FXRGZ i1NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716226525; x=1716831325; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KaUIcbCxnT+V1tXho+s6VK2LQCpbrcFbVlZAjQNTw9w=; b=fOwDVK1z16Fc79r9948dPQQCT3fgTEUnI8vpZRY6aa0LQ6O5sPFTJSBaRDWy9YEqaX aTft/kBqusB9M8yQUq+by/ko/dzZAfmB3rZ2MIZiVSpwTZ01ow5Qu5Ohwur0dzBok1U4 9yV8KyiJLC+Ve2nUrpfZjNxisqsSu8MDd/O40swPF74dC4mzDLKWcGgmWIbn+g8LZsK8 XV8b86ahRWDe++KcMy+k7DtfInTvDHhv0Sn39FAk9ZhdJr7JpMbOBt8/LAaGn0pPyyjx 5COOdzRmpwXXrFEY4NXYElWpGuw9MHvbqreVf8a0ZVO5mYnTWvXT4ZWJjrICdHQ0tG2G Zxlg== X-Forwarded-Encrypted: i=1; AJvYcCXIGWt/xzQnC1vWXtHZ7MirAP1NiPqVy56S4Sq8lOxZ018hh09jfZxXXsl0eqlfD7epy3pDKkBhl7Ua+pKeqkBGp3A= X-Gm-Message-State: AOJu0YxqPqWUeHqoU7KQCyVTPLFbCG1oj7TwejEF9J2jtnlPf5P8nOk9 /G1EC7tvb1ipy/fiW+DCdIDenYsQtoxhsuu3bUXb33RF1B2KeWE838PImOvpNc5ZknWBfM2L8oh O+Q== X-Google-Smtp-Source: AGHT+IF1taDRJctSSVr2IasIIziXIfKJNIigxZpYaoBlxwyY2AZlY80I/q2z0jdfLZJ5lT9JqTpQH1/QQSk= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:902:e749:b0:1f3:95f:ba6d with SMTP id d9443c01a7336-1f3095fc09fmr1015685ad.5.1716226525207; Mon, 20 May 2024 10:35:25 -0700 (PDT) Date: Mon, 20 May 2024 10:35:23 -0700 In-Reply-To: <41d8ba3a48d33de82baa67ef5ee88e5f8995aea8.camel@intel.com> Mime-Version: 1.0 References: <20240501085210.2213060-1-michael.roth@amd.com> <20240501085210.2213060-14-michael.roth@amd.com> <41d8ba3a48d33de82baa67ef5ee88e5f8995aea8.camel@intel.com> Message-ID: Subject: Re: [PATCH v15 13/20] KVM: SEV: Implement gmem hook for initializing private pages From: Sean Christopherson To: Kai Huang Cc: "isaku.yamahata@gmail.com" , "kvm@vger.kernel.org" , Rick P Edgecombe , "michael.roth@amd.com" , "pankaj.gupta@amd.com" , "tglx@linutronix.de" , "tobin@ibm.com" , "liam.merwick@oracle.com" , "alpergun@google.com" , Tony Luck , "jmattson@google.com" , "luto@kernel.org" , "ak@linux.intel.com" , "pbonzini@redhat.com" , "pgonda@google.com" , "srinivas.pandruvada@linux.intel.com" , "slp@redhat.com" , "rientjes@google.com" , "peterz@infradead.org" , "linux-kernel@vger.kernel.org" , "dovmurik@linux.ibm.com" , "thomas.lendacky@amd.com" , "x86@kernel.org" , "bp@alien8.de" , "vkuznets@redhat.com" , "vbabka@suse.cz" , "ashish.kalra@amd.com" , "linux-coco@lists.linux.dev" , "nikunj.dadhania@amd.com" , Jorg Rodel , "mingo@redhat.com" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "hpa@zytor.com" , "kirill@shutemov.name" , "jarkko@kernel.org" , "ardb@kernel.org" , "linux-crypto@vger.kernel.org" , "linux-mm@kvack.org" , "dave.hansen@linux.intel.com" Content-Type: text/plain; charset="us-ascii" X-Rspam-User: X-Stat-Signature: 8by8y7ifucqjwyj5qdzjmic3wmpz9nih X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 97D861C001C X-HE-Tag: 1716226526-151537 X-HE-Meta: U2FsdGVkX19Mxm037iGT4AHKNFQhVSDF5gntYRjwr7UqBeMKjjNpqN3g4m4oYEfJZpq6ScDslFn0j0tlwlBgWwFoy36bfCb8T9hnkb7KGQmcd9xUjbj11drrAMHPyvpAQInCf64zfFH1+vUpGpmF+Rb29zywfe/AgiiSSwk0pyF8jfP2DIkzrmFxXC01CQquv/p8usxEiqgTVmxFaLmZ+24c42EFgrVOCcOLuWEsP3u60wnwc61LMQ61I96AD9vZx5llUorkKflPIJc1oIbgxVoCsYU0MlwUYs+NPMr2dDjMEBH2QK4mpLnUVFU7z2HFmuV9TDOhY3eZPnPvY3iJjch3hFo5PCP+w9RN1m6qgEV2Nx2TCHzLawdj+qc3fj31ME63CP/qDKjM8fo6MQY7BMHIOu1yKl70aoqHhyKi2ud7a5HEsKaZaClNp9GkF0dwVJxIbJYi+C/Gpfs6geXO8v3NHlc7vmn8m2TF6yP0BN7xk6ls4zaC607YVRklEs8N8XZ69+N8cCCjDOUgckM8dPm499gqvTNYRCB1T/YHvaGGAITov9vHb/pRA2ORiM0TEC3lBwWh3cT9SPZh4HG+JrdSQQJtV7xt2FihGFRSL4DRVIvXuWZ6Uz67LcrbZEkXhC6vn6nRbf9ovIUt/l4ng6GC5RW7FwS+lhMwVjw+msn/KEZuioeE6R2Zm74iREry48jwrHoMsSr8YMcWE/ljlVMakCxoR9FUzT7LAgePdb4QEcVNVohvuzIvTMewts5VAdOAjNFMkvcpJ8VYb/fnS20j8qK1Y2LpMT4ZwXD5FTU6W9mmkQ38UmjkPSD0aslZGwi77KOgcikSqcQnUd6v3rUMJkfw4PHVBWqoynhdPWJxKiTknNBbJu2G8IIj2DQZ5ZZSEMgAmdb7sNfMfHjtw0txdl/e0TNYG7IdfyLGR+i1jN8LJhlf9Wxb3P7YZtr77munz8yyeBdCPmI79Uy /BlZDQb/ /gwJ6IxjR2g8fWMrOdMOPQb/OazDTImozcq2sUQlGWsXw1VPeRWdyKWDFUFVo8bkTrPyL3E2SwFBV8H1zxk/5OMK2wk1ZcN891tTmlcCkysykY84XbUW4VTmSIBndjmH9G5wJ6Q///qVeCso7/C0pVdOtq60/qSGW+2gavnb9NezanuG+YhQBA2I2+mTQUnlVrxwW6VT0yJ4R3bEGXcnCNA2LuCwTv4aDQwjRaD9/hFiYIXF9nCSSWW7VMUtZp0SsGy9lasWNxLy+yntE3DeLGiDnQBv4T/050ZSkIQZUpHf9gZHO2AGLca3qoXfzg6ec+ul2ksVRt2iHBxhiHjAW22FFK5K5lQ7ef38I/GebRdLGeYnmcjTIAioDGkqRAifr6SJef02LiIK4Pvefczj5nl+d4MLzB8uuDzfL9ATTsP1SvgcrzqUhwqekGSqe0D0t4Q2K3aZxN4kq9wT86xEaGxcdCe96W34MwWc/EFR42xvDfhI7iMbTW46jViCMa4sHRMuiTxsX4wwl2KvJkXxXYsDxuaOzRBhdMN+RaP9LArz2WZzaiViBqL3e9LPdRqfC7PaFfR3sOqe5dB5JpoVSnP1gOBGrBkmf20J4hgqNnXVnDJPZm8UwZS+PIK3EGDThg3waWX0QD40Ra7JQWJsMhAEOFllziFlMH8KhevjoBJkHcR8Vq0AeatPcu/HFZUMcU0bF X-Bogosity: Ham, tests=bogofilter, spamicity=0.080459, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 20, 2024, Kai Huang wrote: > On Wed, 2024-05-01 at 03:52 -0500, Michael Roth wrote: > > This will handle the RMP table updates needed to put a page into a > > private state before mapping it into an SEV-SNP guest. > > > > > > [...] > > > +int sev_gmem_prepare(struct kvm *kvm, kvm_pfn_t pfn, gfn_t gfn, int max_order) ... > +Rick, Isaku, > > I am wondering whether this can be done in the KVM page fault handler? No, because the state of a pfn in the RMP is tied to the guest_memfd inode, not to the file descriptor, i.e. not to an individual VM. And the NPT page tables are treated as ephemeral for SNP.