From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E531C25B77 for ; Mon, 20 May 2024 09:14:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E2EEE6B0085; Mon, 20 May 2024 05:14:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D91436B0088; Mon, 20 May 2024 05:14:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C0ACB6B0089; Mon, 20 May 2024 05:14:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A237B6B0085 for ; Mon, 20 May 2024 05:14:58 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2132D80CBA for ; Mon, 20 May 2024 09:14:58 +0000 (UTC) X-FDA: 82138214676.28.FECAE31 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf04.hostedemail.com (Postfix) with ESMTP id CCE974000C for ; Mon, 20 May 2024 09:14:54 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="SQ/+LTtN"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=QC8SRNpp; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="SQ/+LTtN"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=QC8SRNpp; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf04.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716196495; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DQpaWqEk14kmnZcRhdQPeYIN4UAv14SG3VVppGhfDQw=; b=ewW2fBwy6TK19qx+mvLI2HbO3TAzKJ6igVMp5B/bn/fIeyugcPPBHbTzllpgzDhy7vBOTv qeUtqznqHQNkcHXZKK3zIl5fYXHrhn5yA05AowmTeO38m+0iuallCLcDZZqrzPwA9F2wmo jmIdvv49Gt0o1YJZPXqWcXexykSytb0= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="SQ/+LTtN"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=QC8SRNpp; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="SQ/+LTtN"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=QC8SRNpp; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf04.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716196495; a=rsa-sha256; cv=none; b=eWI40m3BYcBy0S8DuUtHvxwEbfNgzQkAjpWEkKYo0e1axj22QO3nI9qwHDrmJb5phOl2Te qR3URRadfRe6GHxOsxOrbty+65JkaikMd2r2DlXB1EuMnGfUEFMUYsOBcHv9tN54k+JrRz i5Nw3nvzmkBitCIOJHbeV7ZD8jM+1js= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1D19C2230F; Mon, 20 May 2024 09:14:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1716196493; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DQpaWqEk14kmnZcRhdQPeYIN4UAv14SG3VVppGhfDQw=; b=SQ/+LTtNmqQ5lsOk1oA9qLfIIOqAFGFL5m4YmwHs8Is7y9FKQNJjmip74l+Uwc9gzozVUg hzCz6cM5ClUd/phVVLgFDDCk/Kfg96Hc+VF/LRatpnCuQSvX6wyl1yY3fIim5HyPYfktSg ZV1ZlLdrh0DVbh9jVSxoeUKLRsrsQso= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1716196493; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DQpaWqEk14kmnZcRhdQPeYIN4UAv14SG3VVppGhfDQw=; b=QC8SRNppEITCa/rAX9pRgj9rB/ERaebOnt5nW39BmxGgevybxtNyCzt9dMQXYCSQARYQkq nU2/g80JI8Uw2LBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1716196493; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DQpaWqEk14kmnZcRhdQPeYIN4UAv14SG3VVppGhfDQw=; b=SQ/+LTtNmqQ5lsOk1oA9qLfIIOqAFGFL5m4YmwHs8Is7y9FKQNJjmip74l+Uwc9gzozVUg hzCz6cM5ClUd/phVVLgFDDCk/Kfg96Hc+VF/LRatpnCuQSvX6wyl1yY3fIim5HyPYfktSg ZV1ZlLdrh0DVbh9jVSxoeUKLRsrsQso= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1716196493; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DQpaWqEk14kmnZcRhdQPeYIN4UAv14SG3VVppGhfDQw=; b=QC8SRNppEITCa/rAX9pRgj9rB/ERaebOnt5nW39BmxGgevybxtNyCzt9dMQXYCSQARYQkq nU2/g80JI8Uw2LBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8475713A6B; Mon, 20 May 2024 09:14:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id C18sHYwUS2ZSYQAAD6G6ig (envelope-from ); Mon, 20 May 2024 09:14:52 +0000 Date: Mon, 20 May 2024 11:14:51 +0200 From: Oscar Salvador To: Christophe Leroy Cc: Andrew Morton , Jason Gunthorpe , Peter Xu , Michael Ellerman , Nicholas Piggin , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [RFC PATCH v2 06/20] powerpc/8xx: Fix size given to set_huge_pte_at() Message-ID: References: <04f4e737608ea0b177b88057db138fbf0d6ab138.1715971869.git.christophe.leroy@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <04f4e737608ea0b177b88057db138fbf0d6ab138.1715971869.git.christophe.leroy@csgroup.eu> X-Rspamd-Queue-Id: CCE974000C X-Stat-Signature: motn9iu9z6ba3xicftwnwmewd85dpf35 X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1716196494-577796 X-HE-Meta: U2FsdGVkX1+QKaVh0QSg1i6TFHzMFF4DVZKs9PNT8P78oS3JO8B39GBeq7gkXb9Xuq7BdrB/F5NC32A15cDKU1oWAfoOwg2r119JoIcHc0kcSOBJS+sd6s4wRSqoZdgqfF97OkaLqsHXQPxo2MfwXzRW9v7J1LfvJ334IPA8/treXI2uHwrEke2pgtaOZ60hiqv7VYQm8xNhXBNbwAs/RI6+sC7A6aoeteScvuKgGYqa5JaXSg9HDAqz44jTHw1Osyeds18IrOLb0BybPXFmnDAmaUashNMvp2SZDOWs9cLjE1O+eKHOMvjDYFdqbqTrxIeEdAiRxLgxTG2E5D+j9Ua/Bfty4mWSQubx+z36ZcsAOadZMW5GVDQbxCzAZAjdBMJWqpUoChkgNEliMWpzIK8GYR6hmPriKwdRfDdE5o2FRSZrWBs8ndmZ5ea3aVFYmdzMIvmQV2CYt+HRk2HA9BRNUVkyXfkQ7XHrNZAflcA/2wDJR4AjSoD99h49DEvG/YVHkoISEnhTtpiqSrVUizX5LOQCp9Tu9luKMfNq6jDPr15LfndwTT3QUnF/XimRHZa3YMFLAnqk6YqtgmYEnjnlIKaJSnJFymRVFEZ/IL4ybaSGHbq6VQI9O0Ncbu1asX1Eb50K+TzkUu4gwaxR/i21ss0VESN1r5bXuaN0Sbgu8NVu7aHL2NMvC3qcjcR7dgFOmB8Lax3b86+sIivq1iVrvI876xNIb2JfOfiP8TsoZBKxui6DEBQP+XNVdmH3r+FqF0dQdOO6h+Gp4RlWqCARRonGDDZP261BiSGjrWiVFHTMwI1i9VCX+f2uBB+JZZ2OcESQ0ymXv+olKbqpfkgrt2/tb1FrjSJgilF1vjHpHZRU7StPoqcz7nYARqpUniNyqejSjvCzqj3dCLNvsrSmD1nbW6/EGPPxTRBToDwPIVtQRzfnpViObBxxmvmmlCAMiIL6HAp+1f0gzxr W1rx7Z0T A/OtKFja8IFItonEq+G8qXUHkpsLH6zfVZlR+gV9KBcLnkjMGleibeEO+daMJdvMJe3V22z1eXtXSku2N5xxBq3T0i1GlE4n5NE1cLaq/eA6b0VD77QXGdHt/aqCB3Sx9UvN1eU39KJgkljLRNLNs44UYJInKRzF5kMxZAkgt129RbpQeovyGYb0i1Qloi4c0WlP/fsqcz1IIJI3YZfnl4sAvjs8EXiDgg97375eBH+JmFwONvCNiApTaZGEnXSwet7MfpizjM+l6QAejNjLeQa2nb7R3gPREsJRigS1NRpA55S4dQx1PBxtqKw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 17, 2024 at 09:00:00PM +0200, Christophe Leroy wrote: > set_huge_pte_at() expects the real page size, not the psize which is "expects the size of the huge page" sounds bettter? > the index of the page definition in table mmu_psize_defs[] > > Fixes: 935d4f0c6dc8 ("mm: hugetlb: add huge page size param to set_huge_pte_at()") > Signed-off-by: Christophe Leroy Reviewed-by: Oscar Salvador AFAICS, this fixup is not related to the series, right? (yes, you will the parameter later) I would have it at the very beginning of the series. > --- > arch/powerpc/mm/nohash/8xx.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/powerpc/mm/nohash/8xx.c b/arch/powerpc/mm/nohash/8xx.c > index 43d4842bb1c7..d93433e26ded 100644 > --- a/arch/powerpc/mm/nohash/8xx.c > +++ b/arch/powerpc/mm/nohash/8xx.c > @@ -94,7 +94,8 @@ static int __ref __early_map_kernel_hugepage(unsigned long va, phys_addr_t pa, > return -EINVAL; > > set_huge_pte_at(&init_mm, va, ptep, > - pte_mkhuge(pfn_pte(pa >> PAGE_SHIFT, prot)), psize); > + pte_mkhuge(pfn_pte(pa >> PAGE_SHIFT, prot)), > + 1UL << mmu_psize_to_shift(psize)); > > return 0; > } > -- > 2.44.0 > -- Oscar Salvador SUSE Labs