From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1B75C25B79 for ; Thu, 23 May 2024 23:07:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 77F156B0093; Thu, 23 May 2024 19:07:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7304E6B0096; Thu, 23 May 2024 19:07:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F6356B0098; Thu, 23 May 2024 19:07:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 420B76B0093 for ; Thu, 23 May 2024 19:07:17 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B8583C0410 for ; Thu, 23 May 2024 23:07:16 +0000 (UTC) X-FDA: 82151198472.26.40E38B7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf16.hostedemail.com (Postfix) with ESMTP id AB7BF18000D for ; Thu, 23 May 2024 23:07:13 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TKOYZL+L; spf=pass (imf16.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716505634; a=rsa-sha256; cv=none; b=iBUwJlI6SlU+bS6NXubTKCEdfoCadlHSgfABbHMz+QE2D9pqgjryTifDfxqrk+w/7N9RAJ hO6rFl8gekvaDz7IaY6qfX3D4K7w3gymZ3a5clSrqaYEH5e5GPNGtYZAFo3Xcc7rmgjq8Q HG3yW1ZK7O6CD2A5RuLev4CuiSkDbjg= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TKOYZL+L; spf=pass (imf16.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716505634; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9qOKzlr6EnmYdUBbeyGsYX+lnRnuf7tx0Aba9aPBtzo=; b=sTL7zWYMydFMcwOHu+7f/NZXyDmwJkr3khXP7PIISXyFZY78LOo/PgGLmt4PpGZEfg3qob +q9Jq+LS+jFGwTXZZ6RgQ+GUcw6J2BwfaVHa82ovhWY5TUsBIXJCc6l10d6yok+n3JbeMg 5IohmCT7X8Ep2txMEkwV1FZ56CdpSls= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1716505633; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9qOKzlr6EnmYdUBbeyGsYX+lnRnuf7tx0Aba9aPBtzo=; b=TKOYZL+LOEh/5NHOi3PA38DFsQtWX+/h5lT1IAD/6EoXZ3VsEs/k6RsZeFK2MxNJsmKocZ giacGBajqRh8NBN8pEBdD6kkys0TKPJs3uXBE10ahLC0jhvOMVSXpnk6m1RvGAZWBdkOmy z7uchTXEJaYOc5rqIf9eyydIqpAvxV8= Received: from mail-oo1-f70.google.com (mail-oo1-f70.google.com [209.85.161.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-367-_7Du3dErO1aACG9Cj1YdOw-1; Thu, 23 May 2024 19:07:11 -0400 X-MC-Unique: _7Du3dErO1aACG9Cj1YdOw-1 Received: by mail-oo1-f70.google.com with SMTP id 006d021491bc7-5b96af36cfaso56202eaf.2 for ; Thu, 23 May 2024 16:07:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716505631; x=1717110431; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9qOKzlr6EnmYdUBbeyGsYX+lnRnuf7tx0Aba9aPBtzo=; b=DXpX4trnowACpVgD+/tiJC75khiuy0tKRDwBy91+iElvEzoQcAV7Mu4cc6Rj+vqObw 0//UcyWOn87Y5rXkBVSDmo2D434DEX0Q2PwLzbClSY/K3LwcodsicyiX0COioBurhjNM 6ng52gRNHypdVR/nnBJ0uLDSNz09hqy55OIVjhjWG0n0zKORszAhdqA60oOgMtzJKwXx r/9VAQ8Ih2hZ0AGS+1Bq5rvcFHKwodzWG7OQnbvo2SuoInO7fbSdD3oyPc+/jsJ+tI1N 3XSV+I+/ZdzHNN8a58AJrlRSYN3CeQAX6lRHS5NMbJSiazGTHwut+k4UqR+kx0uc4zQg GksA== X-Gm-Message-State: AOJu0YyXEvBetGSE2GNyCQHgtjvMBi+fMkFqRrYeVWimAc8vsRefZKHK aGC+whX74GW2Ny9e0+sVUBPpmXyI5a6yHrsUXILGCYZnQkbpyUxLYWsF1mK/aBR6WAzg7vpMNAW gj//uQ2BhduB50U0wVH02l4DPXPbK19SXVroCdHjPL8OLIx/2 X-Received: by 2002:a05:6358:895:b0:191:f9d:3468 with SMTP id e5c5f4694b2df-197e4844d1cmr101528455d.0.1716505630326; Thu, 23 May 2024 16:07:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHkP8dUkBKBmrDPjNCP4ODSid8uay1YJsaPr84UgiuUBd25LP9SzmvCs1fRe5ULhTEy/LrP7Q== X-Received: by 2002:a05:6358:895:b0:191:f9d:3468 with SMTP id e5c5f4694b2df-197e4844d1cmr101525455d.0.1716505629618; Thu, 23 May 2024 16:07:09 -0700 (PDT) Received: from x1n (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6ac070f3298sm1303906d6.66.2024.05.23.16.07.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 May 2024 16:07:09 -0700 (PDT) Date: Thu, 23 May 2024 19:07:06 -0400 From: Peter Xu To: Dave Hansen Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Jason Gunthorpe , Andrew Morton , Al Viro , Dave Hansen , Andy Lutomirski , Matthew Wilcox , Dan Williams , "Kirill A . Shutemov" , Mike Rapoport , Ingo Molnar , Michal Hocko , Alex Williamson , Peter Zijlstra , Suren Baghdasaryan , Borislav Petkov , x86@kernel.org Subject: Re: [PATCH RFC 2/2] mm/x86/pat: Do proper PAT bit shift for large mappings Message-ID: References: <20240523223745.395337-1-peterx@redhat.com> <20240523223745.395337-3-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: AB7BF18000D X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: 73j19593tnb1gyhpmo76zhe7ie4rmrrm X-HE-Tag: 1716505633-492893 X-HE-Meta: U2FsdGVkX18sY0E2gmUhT48IrsGQ38bgTdGQr+5XffxzjfUEKRWH/TiVZe42XvJ/CrOnwxT7h8kyCzuvT6Qqf/SfwJRnCqyorJDCyebuuQrr27cQIi/ME7ADI5r0TOvDS1gEvxnzPuhjOIpCnaf15Jfmp32Gv1iwQKq01OB6wX99rUsGuWMjOekobic/sOnhxgcvOe2BtthFb0ywc0tvI+knoTDrlQKxE7EcC80npQMxpFtZ4SOcUzI/PkItTTzk0da6RH8Qi7FYdUUm3q0kKeNF1+fBArtkfrKoybv0/5he9Xxk9oWsOPTNbGfNMz8GQYj5ntSGYJr1LXuVoBv1RZoHXi8/3RldACYzNfSQe7fLu4XGh2UHdKFgcyMLFBpUAg3SvhK/m5tSsoutKTVCmO2nW/wO27T3xNzKUoAqmkruI5PHIKMHz4G3QRU9fTBdtQysLikFGiJ2lzZsS6vk6pA03NQWGtpLOddsb+gagbbe58bGy4Ca9BbeI0B9Tl5svAjnaOSrTmDh7nKSNVoqLxPFhEirGGGVlPenXZzdKeeruboUW3IChBavRElS0Fu135qh6x6QjWo/pj+TK/WqWF8FSje8YAYE/sCjmMnS5fcwoDhxicgRssB9FWKqbOBUEBCEWrrtXQFfJX7wkqz5aDABiT0HcvXAblWqDfjEoS6XfXagX+cgdbKZ+gozYO9dkjE0OLcXIql1qqYDg41FHEm2S5Tysdr/wGOuaenFFG17HYZefEwgoHTpyt2WzyCAp6WZkK4UztVVsWsDBvcWmW3D8kKeCL/7g5V+qMazWaDvS3v5DY+TJ4qcIS1dZopCtLBoU8I0WZEvUhVCmXknGH6FPOp1SqoQwRzhRTbMHNjrkOYpyXMN8Xz56WeBY02igcLkoRnxAVxlUlchlBYRZoL/i5XvHbHu5Scj06eJAnem+Vf/863nNcjWI+DobfB3ir27ffgXa75cDcAJdeJ ul6ti29Q qNXSjN0B0KQ8rTBuOl+MvTg4ohvO/Jc1vfhdmsx15iGTuQxhKbYLFTukpG4vOVcthWQbyml97Zx08mtMIn1KEv9uCMan7f4ignyJcU624CJRj4KFMHaqIoSWVCWBbFfMtVpCZu6xW4RWtQBb8VqAfQCoedT/l7cFpjtPgd8QA9XjeH7iBICa1tSOi1ACI7m8oSou2GvoGGSNHBtt8XJamM+HkznGlF3o+D7MCINgVVUQcw4hQdVn99LRYjE9bzRGJlp5y9YR8kqxWOmBF3ZcMwKL42DZDh3qVP5x7f5M7qEKH+0JT88aVkfzzbLtpMAJ6Q46hA/BxakCdvvO7GgpUTr4qIj1BHhn/3jdP1YIj7AGqjNHLZD5lJoKp4oknvGP//2o40st6vB8KO6TJVFMkBb8mPeREtB56lZ/b/ijp3WdTtr8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 23, 2024 at 03:48:22PM -0700, Dave Hansen wrote: > On 5/23/24 15:37, Peter Xu wrote: > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > > index 317de2afd371..c4a2356b1a54 100644 > > --- a/mm/huge_memory.c > > +++ b/mm/huge_memory.c > > @@ -1135,7 +1135,7 @@ static void insert_pfn_pmd(struct vm_area_struct *vma, unsigned long addr, > > goto out_unlock; > > } > > > > - entry = pmd_mkhuge(pfn_t_pmd(pfn, prot)); > > + entry = pmd_mkhuge(pfn_t_pmd(pfn, pgprot_4k_2_large(prot))); > > if (pfn_t_devmap(pfn)) > > entry = pmd_mkdevmap(entry); > > if (write) { > > Does this even compile on non-x86 architectures? Probably not.. I think I can define a pgprot_to_large() globally, pointing that to pgprot_4k_2_large() on x86 and make the fallback to be noop. And if there's a new version I'll guarantee to run over my cross compilers. Any comments on the idea itself? Do we have a problem, or maybe I overlooked something? Thanks, -- Peter Xu