From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71813C25B78 for ; Thu, 16 May 2024 17:45:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CBA9F6B0082; Thu, 16 May 2024 13:45:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C440A6B0085; Thu, 16 May 2024 13:45:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A97226B0089; Thu, 16 May 2024 13:45:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 839DF6B0082 for ; Thu, 16 May 2024 13:45:41 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 02FE4A0BA3 for ; Thu, 16 May 2024 17:45:40 +0000 (UTC) X-FDA: 82124986482.18.77CA565 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by imf07.hostedemail.com (Postfix) with ESMTP id 1EE7B4001E for ; Thu, 16 May 2024 17:45:38 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CvsWxptz; spf=pass (imf07.hostedemail.com: domain of htejun@gmail.com designates 209.85.215.182 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715881539; a=rsa-sha256; cv=none; b=b1pSwDpZGdcz047qBx5flIEBGq7+ucODrFJtZrpMBuQ9N/mfP1nwMisYjACO7JhwTTEvKj 0yIZ5PpLR44K8IGsKaj2uLfvG/ynIHQLZb/eZKqDikl20JYj2zuv5tatLF7+Qi+iX4jK9r TZBKEfwHDN62Nc+fP5+xc4gmwOW3emE= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CvsWxptz; spf=pass (imf07.hostedemail.com: domain of htejun@gmail.com designates 209.85.215.182 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715881539; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3OKXT2yQV18smkMXEV71PWPVmMK2iX3mlxflAHtbH2E=; b=aOlIkmUT9XrmdyscBJSxy+wN9BGrUG4qlmj7PWl9ITnYlVGcprPmt9RY/KQW9K8ZDAQlVL CI60yEwYGEIn9+fioNE47vHvS/eVlpz1iiGvZ07lq2qzacCRNv5SXEO2b245z8SiRH6Jrw lCtA8qVFYAjv107ohZrNLUUxQP03FgU= Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-6123726725eso397996a12.3 for ; Thu, 16 May 2024 10:45:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715881538; x=1716486338; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=3OKXT2yQV18smkMXEV71PWPVmMK2iX3mlxflAHtbH2E=; b=CvsWxptztEI+tIIhcPsPKdVBF4u88IP1Jzbedd/x3cksN3C+Q2oNm6tN4CkVLJQG+B 4j/lptq9kc26p0i9y5Ocio18wA++ZRpMrDcvbLX3ppcTKIp0tIP76zI+nUcgWpXhSpxV cA1bbvwoj1GSQNZtyaFexXV8hr2uOC1u3bSDtF6YFyK9hLB1xiVlPv/gu6e1LvJ5V869 ZUbPwJosuaXUfYULmkMCjw4fa9TqkboUzew4lC4L4sGNSrEDoFhUKETv81+cutJPhUcE uDzZQBy8oookicXXvzKF2f03w8AkGplVHVWwAtuhLjdfDEUWlNanAOM+bkImM3DSaCvH +vbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715881538; x=1716486338; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3OKXT2yQV18smkMXEV71PWPVmMK2iX3mlxflAHtbH2E=; b=K7uHSVMW54y5U5/1badHvy4xD2g8ORgzPUJ/4RvjjzmWd+Vru9JDzQlNiwDBtPsbKn C1Guyg1qozaCDKhMrHlhV4ZX/31XqkNBUYpcHPlhdm4k0FvCzC1Oaj3bpS9/qiTlMjTl u4Ah0eusCMJu+5gy8wRemvSgYCu96hlagCfe0XCkVhgotQy8oUNM5SBcOkoEWuAuke2S 8lUkS4A67Y8Aa0gqawN0jbsBy1c3Sqpd6AyThrg6BVSZqyYq5ca4W6LoO6/QOi+B59yp dJsd0ubl3X+P8XtoIj7/7oiewDjFZtD8sCUjivstJ5mpaeAwCV13Efuct0xuWW4gFXB8 eERQ== X-Forwarded-Encrypted: i=1; AJvYcCUdPTf9JgbhqSriONQunb44LumeW1pgXJod4H5YgSigQ+qzRmNhPyo3CpRrp6vdfbskGYBA3w7zaeMVeIQR/XKvYro= X-Gm-Message-State: AOJu0YxespOp+FE3JSO8Bzo3g/aYgucg2+4ru6143GqXztd2CQLzGFGy vCMhoP9tX+wIYpri0ZwKrYF2mm7nfSInhkmTur7YOFNTXXrIwY4N X-Google-Smtp-Source: AGHT+IFlZdXQSAQjhwGSUSzAdvLTZnp4jX0Virj/NxOh9XLSYQQ0tW9XIzm5+SdWPO+zhn0VKlQUZA== X-Received: by 2002:a05:6a21:3d85:b0:1ad:746:3f61 with SMTP id adf61e73a8af0-1afde1159f2mr17942555637.28.1715881537769; Thu, 16 May 2024 10:45:37 -0700 (PDT) Received: from localhost (dhcp-141-239-159-203.hawaiiantel.net. [141.239.159.203]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-6f4f2f0b6absm10208151b3a.76.2024.05.16.10.45.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 May 2024 10:45:37 -0700 (PDT) Date: Thu, 16 May 2024 07:45:35 -1000 From: Tejun Heo To: Shuah Khan Cc: Edward Liaw , shuah@kernel.org, =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , =?iso-8859-1?Q?G=FCnther?= Noack , Christian Brauner , Richard Cochran , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexei Starovoitov , Daniel Borkmann , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , Zefan Li , Johannes Weiner , Muchun Song , Michal Hocko , Roman Gushchin , Shakeel Butt , Yosry Ahmed , Nhat Pham , Chengming Zhou , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-security-module@vger.kernel.org, netdev@vger.kernel.org, linux-riscv@lists.infradead.org, bpf@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Linus Torvalds Subject: Re: [PATCH v4 08/66] selftests/cgroup: Drop define _GNU_SOURCE Message-ID: References: <20240510000842.410729-1-edliaw@google.com> <20240510000842.410729-9-edliaw@google.com> <9e72d97a-9a04-4423-a711-0c21c1c8b161@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9e72d97a-9a04-4423-a711-0c21c1c8b161@linuxfoundation.org> X-Rspamd-Queue-Id: 1EE7B4001E X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: ydxy336tdi4wcu39prsyqdix9qz5i9xe X-HE-Tag: 1715881538-992926 X-HE-Meta: U2FsdGVkX1+u3sROdSrsnl64osIvDhHSgiHjedliaezlDmKpm0ziwQVyhDMD6RPOexZv7YsE3SSLJ9ChMS8Obi8d33hs0qh76yqik4n74gFZE+KBm7D9G8nI3Q50Ksr+flVe09DfLtUxhwkQ7/LxfZyAKx9625H/hyxiJ6bHwavvzxAmq9trH8F7x6BJB7dA67Xlbq8UzPGyQ4rRJL49u6Mr6dDGL7E1YaaRkePP/X0yqjWcXi8lmAdSJD4HsKd8DoNaQnCbgVlDYbT7K8rpcTDWYiD3l5xPIIyYfJoVwFH44tTds3cSXPFWX8qXk4Zj7NLYmwQg5VI8rKLS1oD9HkcagQ49LKl6j/VaNLZ1oDQaNvPwcUpnSnAwkrUOTbKCryr+smg0xlsQsCgdxLzPJ+22e7mlfpY2gjClkss/cwjSMn3y6Te8V802cWmfxbD+Oc4tc8fqTLFC4CM0PEoWzUrfn+/njtfy36kEjf0MnUS/7NxLppzT18vT3yAWFG33/80New6Qo4Re0A18aGtk8W4YRkm+muWGUVjPku4UlfooLRxjlbmJVUTGhRc1Gyiq7S8Cv03IdjFD/wcV8mtHViWBROhhSSZnEsMJ8rtxPGz7nx06bYW0c9QRE0TMCGgIs8WERwWE8HKwh5V/NZMGRGcCQr0VdRiWuoXAiEKTxQ2GAjcfnnrzkStKOYRKeviM7m6vXDvrGaPsiWuswsxsgS4M3qlJTjp1TGVa1FR7xORb7AlKp7Zpg9n+Vo/giStIjtJUX7GUHzV1bajeQvSc+tkgqnutoT7B/yNXYy5bs9kt0ybwGiCCEyY24kpYtkJg1kwwlaiUM91urr0FfIKC+UyM8pVjOOz7/RcE3Cy9l5gK+A81nHbIJWZ/duDJGc93BwLny7tePl2OqKJe16vgLA7BQHtEEzlKqnUjpE/LYUH1pP3YW6Cocc/rTJ3msNxK6hkSyOtERTi5fLM24E5 be5M5rJZ 80FN3oNJHkXEOChWue30t9DWzsomm6y8GC7QwMn4vjXQLiBMxgq7qpznSsGzuqcy8MfdFWtcWTb7V8HfWdFnhyqnRyudobI7huqhKk3wxAbXqjj2CWNT4I2It1J3dQjXFiejV5DAYW8lVbBghoc0TJoccbsq/cKQVfTxwxR6nZgCDXsjyFypMEQ6NIyWTaVDgH6JvhlOye6sann7v61d1dzStWHoUUMxpFMC8o7QLwwJc2et4myx3dwk02r4ZKoJTEe490ExYS3IUzKFDC3NTPAZ346UqtSLhoFreRdeTP1ndNUCw09uIc7wh52ICMyaXEIxPm+VnkS2l7rp/KFMoV/ZZYHMS07cX8Vy7cxMWls3vzuGQyMv9pbsjNKit9F3iaOFuAIIrORVGV3H9K5efCDk7hCGoQzr+9k/1uqwCkfaplQyExompDYLmcWBPR4cZgpBv6h6IUdBEVKKBcMmdrp8aS9q1KjjIl4Xbm9UuLiEHH/99hX2Hwte9Tht0OflP7seA/tvfy6Av3+VjY10QiTJghhqVUHuxV0WQvtN1f19f8hBtEgoxPgp79j3C+oj9YtgKCHXMnXMP2vbgxM/co/Nd83f0aoolFHNx82E+35jJOjnCGTfJF+gRbQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello, On Thu, May 16, 2024 at 10:31:13AM -0600, Shuah Khan wrote: > I am exploring options and leaning towards reverting the patch > > daef47b89efd ("selftests: Compile kselftest headers with -D_GNU_SOURCE") > > Your amending the PR helps me if I have to send revert. I am sorry > for the trouble. > > I can all of them together in a second update or after the merge window > closes. The cgroup commit is already pulled in unfortunately. Can you please handle the revert and whatever's necessary to fix up the situation? I'll ask you what to do with selftest patches from now on. Thank you. -- tejun