From: Tejun Heo <tj@kernel.org>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: "Edward Liaw" <edliaw@google.com>,
shuah@kernel.org, "Mickaël Salaün" <mic@digikod.net>,
"Günther Noack" <gnoack@google.com>,
"Christian Brauner" <brauner@kernel.org>,
"Richard Cochran" <richardcochran@gmail.com>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"John Fastabend" <john.fastabend@gmail.com>,
"Zefan Li" <lizefan.x@bytedance.com>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Muchun Song" <muchun.song@linux.dev>,
"Michal Hocko" <mhocko@kernel.org>,
"Roman Gushchin" <roman.gushchin@linux.dev>,
"Shakeel Butt" <shakeel.butt@linux.dev>,
"Yosry Ahmed" <yosryahmed@google.com>,
"Nhat Pham" <nphamcs@gmail.com>,
"Chengming Zhou" <chengming.zhou@linux.dev>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
kernel-team@android.com, linux-security-module@vger.kernel.org,
netdev@vger.kernel.org, linux-riscv@lists.infradead.org,
bpf@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org,
"Linus Torvalds" <torvalds@linux-foundation.org>
Subject: Re: [PATCH v4 08/66] selftests/cgroup: Drop define _GNU_SOURCE
Date: Thu, 16 May 2024 06:21:44 -1000 [thread overview]
Message-ID: <ZkYymMDd690uufZy@slm.duckdns.org> (raw)
In-Reply-To: <bec3f30e-fc9a-45e2-b6ea-d739b2a2d019@linuxfoundation.org>
On Thu, May 16, 2024 at 09:50:06AM -0600, Shuah Khan wrote:
> On 5/13/24 11:02, Tejun Heo wrote:
> > On Fri, May 10, 2024 at 12:06:25AM +0000, Edward Liaw wrote:
> > > _GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
> > > redefinition warnings.
> > >
> > > Signed-off-by: Edward Liaw <edliaw@google.com>
> >
> > Applied to cgroup/for-6.10.
> >
> > Thanks.
> >
>
> Hi Tejun,
>
> Please don't include this in your PR to Linus. This patch series needs
> to go together as it is causing several build warns and some errors.
I'm afraid it's too late. The PR is too late. Do you want me to send an
amended PR with the commit reverted? If it's just temporary issues in
selftests, maybe we can just wait it out?
Thanks.
--
tejun
next prev parent reply other threads:[~2024-05-16 16:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240510000842.410729-1-edliaw@google.com>
2024-05-10 0:06 ` [PATCH v4 06/66] selftests/cachestat: " Edward Liaw
2024-05-10 0:06 ` [PATCH v4 08/66] selftests/cgroup: " Edward Liaw
2024-05-13 17:02 ` Tejun Heo
2024-05-16 15:50 ` Shuah Khan
2024-05-16 16:21 ` Tejun Heo [this message]
2024-05-16 16:31 ` Shuah Khan
2024-05-16 17:45 ` Tejun Heo
2024-05-16 18:05 ` Shuah Khan
2024-05-17 3:47 ` Shuah Khan
2024-05-10 0:06 ` [PATCH v4 11/66] selftests/damon: " Edward Liaw
2024-05-10 0:06 ` [PATCH v4 13/66] selftests/exec: Drop duplicate -D_GNU_SOURCE Edward Liaw
2024-05-10 17:44 ` Kees Cook
2024-05-10 0:06 ` [PATCH v4 30/66] selftests/mm: Drop define _GNU_SOURCE Edward Liaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZkYymMDd690uufZy@slm.duckdns.org \
--to=tj@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=chengming.zhou@linux.dev \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edliaw@google.com \
--cc=gnoack@google.com \
--cc=hannes@cmpxchg.org \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kernel-team@android.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-security-module@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=mhocko@kernel.org \
--cc=mic@digikod.net \
--cc=muchun.song@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=nphamcs@gmail.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=richardcochran@gmail.com \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=torvalds@linux-foundation.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox