From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B991C25B74 for ; Thu, 16 May 2024 15:54:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 92CBC6B0093; Thu, 16 May 2024 11:54:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8DCDE6B0095; Thu, 16 May 2024 11:54:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A3E76B0096; Thu, 16 May 2024 11:54:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5BB6B6B0093 for ; Thu, 16 May 2024 11:54:13 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0092B121B51 for ; Thu, 16 May 2024 15:54:12 +0000 (UTC) X-FDA: 82124705586.03.647A5F9 Received: from mail-oo1-f49.google.com (mail-oo1-f49.google.com [209.85.161.49]) by imf20.hostedemail.com (Postfix) with ESMTP id 354301C0019 for ; Thu, 16 May 2024 15:54:10 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jFIDyBfY; spf=pass (imf20.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.161.49 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715874851; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3efPanVPVvy9a8ugtO7keacGf4mLa2qwu/GFSKjX8eQ=; b=ahsf7NYsGr5LQZIJqPIVyet5JrrDU7P0/BdLQGv5/2fE8sE/MwrvyVIvNrQzSjxyYSnB5e an3ANnDTUAOCoHwTlAjTqPxZRgfBbtv86npTOAIC2MY8opWvhXL2RVUhn9cH5baT6A84P9 Qc6txAL+WakOWi0Ikga8DYrtyBy6m8E= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jFIDyBfY; spf=pass (imf20.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.161.49 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715874851; a=rsa-sha256; cv=none; b=FD+TaOD41vSIurFhY2MuA+1XfrPPoZ3bYjptXmh/0jDbePFGo8R3IM0PXk8TkilQ5m1miv BDtjBdRjM/0wH8m5pfcsD/YCIUCtn68zbODpidcR1IayX4sQX469HOIQvgKO6jACsDY/l9 L9Uyavd1mM415dyjAgEyV5stCj8S4u8= Received: by mail-oo1-f49.google.com with SMTP id 006d021491bc7-5b27d9fe710so211690eaf.3 for ; Thu, 16 May 2024 08:54:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715874850; x=1716479650; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3efPanVPVvy9a8ugtO7keacGf4mLa2qwu/GFSKjX8eQ=; b=jFIDyBfYk/JTbL2Fwm9PBCi8UmTHDU6dRRF8M/1IZJphOzJKL6e0DnQDCxPut5wkWI Et3akArPMW/DogrWG6ykqFi5VJpnYo1kakjVJG9JDcpXsaDHGiUBhk7V98In+fUthlG0 yr7YsJiJk9fZRGnclu/tZzCxuntGh6oaPhy9mIxcTNmxmeJefk0j0Lc01KL38CDAT2Cg yYuxBNEsZ856V0F0+eMGygdLBzAXEcg8bE7qVDMzU03j94GZnF4YJNHbX9kYKbaJrHXE 0u48sQwQKY9jHxPOgyuAEfHTpnbc0HJkJ08NwdiN2zXNaSNFNTxMuqJMXkBjRw5DJCP3 GNOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715874850; x=1716479650; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3efPanVPVvy9a8ugtO7keacGf4mLa2qwu/GFSKjX8eQ=; b=vAMcN/xt8BJxSREIzADP+pIJgpCkLnzuWNtKzjZ/y6M8ddyMRWbyTskYP55qTUPJJD gfj19idmSmNWodOPqq1VpqhAxG1u5FjniYnAIXyvE6IS3EpZS0d8s5qrs/NawISOa5FF Cmed3+dt0oWIRLVRg+Je1G4gUBw4qXQPHQBoWKabvu7rkQBtPcTcMGTErRgVA4c9sxck LJK62jGoKeG5iflHGIMGLgRiOcOQS9KIH9LPzaWtaZRlvPiNZwiWlIl5nsD+YRqY9Fg8 eCeh0mmzNlBPWwh71XsV1fZFt79mDBTxeQ0ci4Oa84bm6g7hZ3pF0Zq/iGtZxObWvk/6 6Tmg== X-Forwarded-Encrypted: i=1; AJvYcCWWl95G7JypTLys5wEn8FKRCX0djgTRwOEjqr8bQFlIupeNG8tYfrTj1/10s4+LgkpCCrlpj32WNQZhmxnq6mlsJWI= X-Gm-Message-State: AOJu0YwZOQEYTm3HaRf7+aNCuykyRAPlB+Uk4k79iCP2vSTkDjleTudP 5sqTuMJo4Tq87ewwGnYWqyoxoR//PeiXSWkTSbtoagYQdrFPqJzQ X-Google-Smtp-Source: AGHT+IG6sPQnQSjBtA+/JGi9I85v+E4piwx72kKSt8k5SDJ7g0qqLBaaA+X5rkjc4nQhF3uwU33Rpw== X-Received: by 2002:a05:6358:c015:b0:17e:2943:c75e with SMTP id e5c5f4694b2df-193bb5197b7mr1810402555d.12.1715874849991; Thu, 16 May 2024 08:54:09 -0700 (PDT) Received: from fedora ([50.204.89.30]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-63411904351sm13437425a12.91.2024.05.16.08.54.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 May 2024 08:54:09 -0700 (PDT) Date: Thu, 16 May 2024 08:54:08 -0700 From: Vishal Moola To: Kefeng Wang Cc: Matthew Wilcox , David Hildenbrand , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , linux-mm@kvack.org Subject: Re: [PATCH] mm: refactor folio_undo_large_rmappable() Message-ID: References: <20240515064506.72253-1-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240515064506.72253-1-wangkefeng.wang@huawei.com> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 354301C0019 X-Stat-Signature: g4nfaemgn7hk4gpbhyn5nz6k8qurnidk X-HE-Tag: 1715874850-799399 X-HE-Meta: U2FsdGVkX1/OJDodrQcQX3YgLZ+rnAktykg/NgEzVFJQU5osaZyDKaic7O//ZSQBsWt6bNmSc8uFENx7C13mjVtxLVJiygSQLi4kzB/LeZ3P+vDO2Zt+g7jKTRFeR2QtCKdOrOaICupwzx4OZAsGRG2tg+fUc+a08rakPS5Z5tk9jZbAkYkqlPTnuFPHfxnti6yDvPFJBWREwfH3Kq6gsCw2lu3He9alp2ZSzu8r3Jr/JEx6Znvfsdjgy1g1YEeLpNxyMsz06W4f25L8HpffpwFYS1+tX88TUOszczs97qPwH7hj3t/F/utImio7qE+60UeOURGsEoKxpZO7/zvfybUh8K/SRZcfNIj+smiLXgNCyjsAx3+oRGcCBXrfzpj0TpDUBLqmVaxgGPHyKRaU1HHBr9KAcmukQj3jgT8Y897wIj8ShXyMKklGTsbRxwGzhh092xlTUgg0S1wqFWyyxBQ1jiduDbJL3keq3dGuM5/eJsZ1tvrkOKysdUEApHSkWhdP4SQSIDW5vSBitF3D2In1oOwLKhQ1oa9OA7siyzOzTbVO/71WWBv+c0K+iF6+NC0svZjS5Lpv1UGvt2JiLWmfuyAMuZpEE6F6O0asz7RlTTWFC9eHkzRWgxFzOuxNca8w9rJeGspwYF7XfZ50avqBVwYZRmYRspnfHT0yOMiJf5cAyakWrGNZGxYDU8ENNwKMbrmzYE8v2ixZCiMTWMMoP6AJvifU+JcjuTEboaLF2bZZvCN0Hx5ZeyCOYI4oMnM2CCL/35Rrh7AAw4+YZEUkQIzhg2VVAuBek/n5YLcNiwVdNXW0Hi+jtuLcvXcmx0ScbIRtKzhK6p3Btirfb0XqiH/9QpgvX9mHCcaoksD/vWHvCx7SXWzgIhFPPiCaRBYRTL5xYX2U6BZQxGIeWcdgd018XUrVvzSUxhiABBaFRHp76s/h6t+2DCIyvyj1K65p3PYYU1Ojeuzv+hh xzzN5j7h Jg1ZRa4AuYVQWClucAsX2mLCI4r9gsJSQxJq1LuJRQItJrH/8Hw0q0ZhUI5qa9+WQsOgT3l2GAwfIGUFY7tuf17IitNI8yhfs9xGNNLWlqJ8o1F6uY9hoU8uZoCRZuIGUxm4hXlspJo9p1UtDmxYxUH45hG/D1nV7PnZWUCAG9Cn3eQG5vxlu5HMzCAM2CgG1W0fX1YsRrLC6yhdeIi+QA9iihROAsSfY4PMkCDwxBfs85OBAaOO8mtSQavCXA2pgB8u56wEiXQ21Bd2/aCb7ybr6n+KGKWEJHlx40Ru6ReYo4K+Su18yPiIQNJTTFEQACQI6BssnZypJDRCRNigAD8sme1JLyYBSC0u3p49iDh6tpkpKfFOrhBXZ2KoWUU7a+U/P7MQleRIiG0aXMjWxi8WsVW4SVEd/zy5Dp2O7FwE3jmh0jiNjryqsItCekmHCxMVq5ZQrVuHDoUslG+06TqH1q32VwClADKMhOirIvcaq7wtlAspCBGMcciH+r/q938de X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 15, 2024 at 02:45:06PM +0800, Kefeng Wang wrote: > All folio_undo_large_rmappable() callers will check folio_test_large() > which already checked by folio_order(), so only add the check This commit message is a little misleading. The folio_order() check in folio_undo_large_rmappable() is primarily for catching order-1 folios, not to check folio_test_large(). You can read more about it in commit: 8897277acfef7f70fdecc. Aside from that, I like the patch. It should make this code easier to maintain.