From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 261AFC25B74 for ; Thu, 16 May 2024 08:26:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 95C9B6B038C; Thu, 16 May 2024 04:26:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 909E06B038D; Thu, 16 May 2024 04:26:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D1AF6B038E; Thu, 16 May 2024 04:26:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5DCFC6B038C for ; Thu, 16 May 2024 04:26:57 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E05231A07AC for ; Thu, 16 May 2024 08:26:56 +0000 (UTC) X-FDA: 82123578432.09.EFC6C43 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf12.hostedemail.com (Postfix) with ESMTP id A36D940022 for ; Thu, 16 May 2024 08:26:54 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=tekL+mXF; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=f2K2rcLM; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=YMf5zKyk; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=eqjn0Nqy; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf12.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715848015; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=88ImWpY7VkoQko/tSvrYsTjEj80P+5Y5W9boRDo+w58=; b=0VNcprrkeBGV6RiMwEIzGVEBYoK0wtpDvUXjdk18YbpDSTjxpn0OC2gkjH0AlT5Vkvbmur YJWBaN4z0aku6Tgf5Rk6MJndQWUHbNX1pz9KLwrKvNB5xncR+c1UmvktArBpYcXCpphQeG igSPyVGL3wXXNfNz0gchR1slMXmafYk= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=tekL+mXF; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=f2K2rcLM; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=YMf5zKyk; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=eqjn0Nqy; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf12.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715848015; a=rsa-sha256; cv=none; b=Has4hMusymOg9Pm+7eg9ooqlCwckrSH8NMeS8OagQ7MIPJcBL4EYtm0J4cUd+WC24XP2gK QcupOcjRCiM8O7svAwI80CGi58Y8oLrC68ZB0a+M32bUCsv7eIvwV1CPBkeiFWPmpL2Trd m7gD2wLFvCpyyfs4nR9GObA21E40x6o= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id F0C825BF89; Thu, 16 May 2024 08:26:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1715848013; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=88ImWpY7VkoQko/tSvrYsTjEj80P+5Y5W9boRDo+w58=; b=tekL+mXFxayesuXP5qToh9CjvJxWl8RhxtUk5xuGYsX6+HniKsq4J6seOZRd82nFomzjIt 5JJs3YYRPXhhv2HVg4G5sBPYc/DimCWNjDH71fbtNJ2oNvXYJS+kp955fMUsiNOC7DHn6H VKRhRT6DjmuLKZZgxZhFMTP81ETHu+8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1715848013; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=88ImWpY7VkoQko/tSvrYsTjEj80P+5Y5W9boRDo+w58=; b=f2K2rcLMTcGrKqnvHVwEbFMFDeMG28XGzq4K1lvmxGHhNvcrzl997Ib5yEOi6vwl1cXlvi aOE4gdjubGjRquAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1715848012; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=88ImWpY7VkoQko/tSvrYsTjEj80P+5Y5W9boRDo+w58=; b=YMf5zKykrMHV/ZWMo8u3c69dOQcWTy481/aJlNDPx9d91YG+unI/aCdy8ClUiLwUDXjDBP p1Ys5dItRpmK2rtpFSKNQNUOjENNNXuRFSIA+Otqf624eamAJgJJCHe7nOh1ZxccC+tU8K Ei9iwIhC4TNrDMAMeoYqcPw8YylEMdo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1715848012; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=88ImWpY7VkoQko/tSvrYsTjEj80P+5Y5W9boRDo+w58=; b=eqjn0NqyTRaaXRFcZvRIcL9JN1J3JIJa9vYOujZhWZWKDMnQ3BbAw4HsAtzTkheqHNM0LL ZJlFjbkBMYo20aBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7EE8C137C3; Thu, 16 May 2024 08:26:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id XexSHEzDRWYaEQAAD6G6ig (envelope-from ); Thu, 16 May 2024 08:26:52 +0000 Date: Thu, 16 May 2024 10:26:51 +0200 From: Oscar Salvador To: David Hildenbrand Cc: Miaohe Lin , akpm@linux-foundation.org, shy828301@gmail.com, nao.horiguchi@gmail.com, xuyu@linux.alibaba.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm/huge_memory: don't unpoison huge_zero_folio Message-ID: References: <20240515023607.870022-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Action: no action X-Rspamd-Queue-Id: A36D940022 X-Stat-Signature: yu4hffdyixdrp45k7o4mzti91je13mxf X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1715848014-592431 X-HE-Meta: U2FsdGVkX18HDjA6B6humKUhw1btVokUmthML2aTsJYvp6ULyCbgrLVhK8rTq0EW0RMHcUr10wO5e9HFSS6Pz71iLcJ0oszJ6jQsZ0Losd8huVwu1lwiYfr/+832VJmSEhRK8R/aA/bHYs9P9be5NnbFPDhLP7EJDvBotrABiLVp3iEqmklAaSahQIQEmkdyk9RGnKOsTAgtvcSIJHXncpZ3+O/ry2tvpcb3SlC/xFAftUpAGz3DjY1T18m9yV6eZ+wRiqcLRqZSbykO4fcvdQnDDbGO7l2VBviAwBz4qF+7PKjVdJpfcGa/qhFvB5eccbNlfzrgUiHzulETb+vlascs4LsS/JJJPRtMg3I5N8MhsmEh0usB+7fkCk3jgni/ERp+vv052fKrH3EoSxrkgtUSicsFwqtGEed52jNGb/mn19YU9AakJxI93oLWcH29qANauXniq68NGolT1YPcMG1YlcQDKY+PU/j1Ytf5WzxXpSzlx9h49Nqgia6R4ycYdQMvbkOGfGYmNeR5FUTxWV7jDCq3A+2FlYBbGMqTzo6E1No3FuCpRleOSwO0mL6ktoSz3QQAGt+8cbsyd/77i6WFHTaXg332U5OeJ1YenmnA35xvwep5zQIUvB4jvcs1gnbTtor1lMTSZjrTRQRzms+063L5sn/Y1n41j83jPXxBSj+evVw+6HYC6tHUHyhNrpjTy4ieSf1yoLzkSaMdWHSaZhkOjbyERbeA/Je/xPD4UZErDlaTFk3Gktm2NsZqzqXSdNShrKaEz91KfhWQfKWwwQ16jrT57+CMVSwdXch9aOE+qBCM1S/Oo3u7pZvZhWCET8PDDbZ50/I6nDwwowceUiVFMP+8nytJq5wO1nlXndNG8X/Y82qKUEiaTCVs7ZVf4A0acO34Lek/ZiVWXZW6kP56805MS23bQ96qOf1V2uhnRVTEraWQORpIy8j+n+WZ+SGO5FVu5WgNNG2 O2XEhcQg rjn5PNZGf1B9sK4pyKtqAwGdqgVfwYp61qchmvu5YE1GolWBvudUMQBJHj+d9I/znXKigGMDI47TOAH2XworB2RJKNKUmIdhZjA+bWSkGK5KdFWRS22nU4ji3KZSBbBvrPEtZU0ZjwLDkQoO2mM05Z4HV2RB/VAC1VUTsLeO2WN2Av5KTpdW2H8TjjK268H6N4GTQ+YE1FulEmdjsKfPWT8rQBHbZdbH3prqzM9NVSeLK7IgCbbIHqyG6dAOGpn+/1XE8nu8oCW7tNPc9vGRTSVqRO7gAWeIm46lgxabuhxVB2urdpe0pvJghcBKTkDEb8jII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 15, 2024 at 05:55:39PM +0200, David Hildenbrand wrote: > > + if (is_huge_zero_folio(folio)) { > > + unpoison_pr_info("Unpoison: huge zero page is not supported %#lx\n", > > + pfn, &unpoison_rs); > > + goto unlock_mutex; > > + } > > + Sorry for spamming your reply David, but for some unknown reason I am not able to find the original patch in my mailbox, in none of the two accountes I am subscribed, so I guess I will have to reply here. Just two things 1) We do not care if someone grabs a refcount for huge_zero_folio, because since it is not supported anyway the outcome will not change. Also, AFAIK, there is no chance we can unpoison that folio. Therefore, I would just lift the check two blocks and place it right after the hw_memory_failure check. 2) The whole thing is unsupported, but you will return -EBUSY while you should be returning -EOPNOTSUPP AFAICS. with that you can add: Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs