From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FC7CC25B75 for ; Wed, 15 May 2024 11:44:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2154A6B0284; Wed, 15 May 2024 07:44:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C7906B0371; Wed, 15 May 2024 07:44:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03E9C6B0284; Wed, 15 May 2024 07:44:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DA2F46B0280 for ; Wed, 15 May 2024 07:44:37 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 58A201A1477 for ; Wed, 15 May 2024 11:44:37 +0000 (UTC) X-FDA: 82120447794.27.4EBC57C Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf27.hostedemail.com (Postfix) with ESMTP id EEFE540013 for ; Wed, 15 May 2024 11:44:33 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Aj3EiNwR; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=4MiX9VHs; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Aj3EiNwR; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=4MiX9VHs; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf27.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715773474; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OvF3X7BK8jjfa9pXaL7JCD3/i65vNNFCv8JmHw1RPiA=; b=S/jwVop9fu4KbbdY46Qlv8V7FdAiwXb8KGNM7eqQ7uJBIwtfY0X9F5cyHpdPdMDMCA3A26 lt43uVECq41Wmdol3bNPwNceWmcoTQr2ltJFbo+RnaI+R1eGN0tJuECSJQd+BgfvC/TnuF aat2Hqx+0/lgPWS8GV0siorIX6ueYv8= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Aj3EiNwR; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=4MiX9VHs; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Aj3EiNwR; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=4MiX9VHs; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf27.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715773474; a=rsa-sha256; cv=none; b=bYuqPZnktIFCtQq5dyZFnfMWnb6Ax8O88MnMxy59qnI33sgWkNKcmtTtt0HQj5da9i128v o24F+JC7011l4GLgGPSj3W80Z3L298DHjmNK66LKxeMjlI337MTJsBB2ydVajcoEujMnj6 wFUWyW4JciJDNzz8OhqqTUT5WNu8SHY= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4003C205F8; Wed, 15 May 2024 11:44:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1715773472; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OvF3X7BK8jjfa9pXaL7JCD3/i65vNNFCv8JmHw1RPiA=; b=Aj3EiNwRUat0YbUUj2HQeKL3aFcwJqn1ATr7v1H5TO1SiEQRvC12Jr2oHxQAdCYbvTljMQ 1rmZmpY5baO8z6ve4mF0uMiSsDs5LnC2mxJvU1jnMD7mvxAqyU8UhstErShNq/8ZYhGAJ9 W+F9E9+5kqa7nLxsqntppZpJCK52rM0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1715773472; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OvF3X7BK8jjfa9pXaL7JCD3/i65vNNFCv8JmHw1RPiA=; b=4MiX9VHsXvPyLHNxq+aft6FyPSKpS1COMx9+Jch7CtZm3aEFLztVAolUaMw6LEP61Qs+ny BrN6ni8+EapFKFAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1715773472; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OvF3X7BK8jjfa9pXaL7JCD3/i65vNNFCv8JmHw1RPiA=; b=Aj3EiNwRUat0YbUUj2HQeKL3aFcwJqn1ATr7v1H5TO1SiEQRvC12Jr2oHxQAdCYbvTljMQ 1rmZmpY5baO8z6ve4mF0uMiSsDs5LnC2mxJvU1jnMD7mvxAqyU8UhstErShNq/8ZYhGAJ9 W+F9E9+5kqa7nLxsqntppZpJCK52rM0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1715773472; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OvF3X7BK8jjfa9pXaL7JCD3/i65vNNFCv8JmHw1RPiA=; b=4MiX9VHsXvPyLHNxq+aft6FyPSKpS1COMx9+Jch7CtZm3aEFLztVAolUaMw6LEP61Qs+ny BrN6ni8+EapFKFAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id CDA8D1372E; Wed, 15 May 2024 11:44:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id OPVuLx+gRGY+AQAAD6G6ig (envelope-from ); Wed, 15 May 2024 11:44:31 +0000 Date: Wed, 15 May 2024 13:44:22 +0200 From: Oscar Salvador To: Jane Chu Cc: linmiaohe@huawei.com, nao.horiguchi@gmail.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/5] mm/madvise: Add MF_ACTION_REQUIRED to madvise(MADV_HWPOISON) Message-ID: References: <20240510062602.901510-1-jane.chu@oracle.com> <20240510062602.901510-3-jane.chu@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240510062602.901510-3-jane.chu@oracle.com> X-Rspamd-Queue-Id: EEFE540013 X-Stat-Signature: 58oqhbowixmiac6np7ef1pgnodufzatx X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1715773473-102504 X-HE-Meta: U2FsdGVkX18UjYuKbQdAIbkAjpr/+fgKPdgYd+44LIMSI/sdzhDu4ByqWnIZWPATYPxpbLgF2FvS3vfLaT5ugYiznhm5ek1OIhtSMvl+k9r2kHJhqIdssNh/8PHVjSrSD9juepui7MJoxRUjAWHjR85F8Rw74ZQqn9B7Mzp5apCl7/y4sdR/aSyRU3ZDMyQb5qFv6OF2XwdMeHi/IOeocWllosPkmgOAaEHbeEIbp+V7etpov4pCsUEcUMV/g/DncdhoZ3fSqp1wYcPvhhVhO8UvJlm+o4p8TtsPtR8+mSQK54ZlMWOuMg8WpV6+6/1UuFAsbb6SKQ8Xa5vTy70dMGn+UbEIpxlkkBNwhe3YvpfbFJuwwjs4ksshHQ538nTDOVeoMaVHbobMCljs8jazt+kwy3d2bgJJg3/T6ZLjZJSHKBZvsB/phKGzju3n4tcjTv3mOtztjhDF8UNhHEeM3FIRGhcq5FDKjOJaK0t9/Zk/oQQRzqCfrYXryOygCK5uyB3MRAVm71ioOIwgefE4zipYugurxX2EeX2bib8OLXHO/BX6fHdoTKmWl80QA2JyxYvwkqQeMCwQ6Ms4WJSuU6gJTZ8z5mupSWFjqwQfW1149IyB7oRpr6qhj4TVTWnsfO7QEF38op5bXQubfT3JrXaOLRlP/YmccvI4Z/BaVEs07CeQHIGxJ7JxynZIAxIH2hcE2lj0okQcDh4rr76d1AjEtdYdf7fvL3JkmzkrUTCkFU36SPhfefgXohXE4tcd0yIYHeWEXl5f+/g9CBcZ4gZ45s3Tpa5zLmiyPeGsWTdhZF9+j4A5Rg/XsXT+Y0EB78exJW+5++nTa2oCzxuFNpX6DykA7ZeX9k3SvUPhSvx4v/Co4HcqoZyIs++xpRb/K3dXxp9WWgWt11kvLk8Lrg/g15CiBn4EeHvsgLLCFiEJIODgFRRq7qHr9TFVC9pSDREVLvDcShpkWp6NVVn cyoIBCce kcx0iZIPjgE1WBlUR+eYnvQrRgxOdGppw8TtUNvUZz8TJFYPDHTn7ghAu6L51WfMngzsK9gZz/KvH+ptT52gr8d2GdOBt63lS5KPAkTf7jOpZGaEuVTK5+2CRP0rHNIOywxORt21+jKLZ0vBplVYnoT/2qRbcHZCv2OTgdH2wJYEGSar+7Gz9Cu/6Hm6W4tQ5MJfQtmpCYXXwcXl1zNmqm8uGDhNE0xzoyqTPHZeQ/MNXxGt+EbPhDMWPjA90+mENQfJ5dui2yasO+OIy5/xTmwo9irXD2ZFBAsCUk9eokcEWQpv/4IH8kjiUdRXeGNq1c5nVz90q+MpQtUBlSW0LevteHQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 10, 2024 at 12:25:59AM -0600, Jane Chu wrote: > The soft hwpoison injector via madvise(MADV_HWPOISON) operates in > a synchrous way in a sense, the injector is also a process under > test, and should it have the poisoned page mapped in its address > space, it should legitimately get killed as much as in a real UE > situation. > > Signed-off-by: Jane Chu You should also mention that this aligns with what the madvise man page mentions: "... This operation may result in the calling process receiving a SIGBUS and the page being unmapped..." Reviewed-by: Oscar Salvador > --- > mm/madvise.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/madvise.c b/mm/madvise.c > index c8ba3f3eb54d..d8a01d7b2860 100644 > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -1147,7 +1147,7 @@ static int madvise_inject_error(int behavior, > } else { > pr_info("Injecting memory failure for pfn %#lx at process virtual address %#lx\n", > pfn, start); > - ret = memory_failure(pfn, MF_COUNT_INCREASED | MF_SW_SIMULATED); > + ret = memory_failure(pfn, MF_ACTION_REQUIRED | MF_COUNT_INCREASED | MF_SW_SIMULATED); > if (ret == -EOPNOTSUPP) > ret = 0; > } > -- > 2.39.3 > -- Oscar Salvador SUSE Labs