From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EE9AC25B78 for ; Wed, 15 May 2024 10:54:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A07B36B00F5; Wed, 15 May 2024 06:54:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B8746B00F7; Wed, 15 May 2024 06:54:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8580A6B00FD; Wed, 15 May 2024 06:54:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 697AB6B00F5 for ; Wed, 15 May 2024 06:54:40 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 02DCAA0221 for ; Wed, 15 May 2024 10:54:39 +0000 (UTC) X-FDA: 82120321920.27.DF37D1F Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf27.hostedemail.com (Postfix) with ESMTP id CC4CF4000F for ; Wed, 15 May 2024 10:54:37 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=wghMJcAX; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=adNbIuSh; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=wghMJcAX; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=adNbIuSh; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf27.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715770478; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6jv9xWgEcYiTZtZfk0F4GwA5Qmgsj9Sim5edw+In6xE=; b=PyQkuGZ4mIuSZbE8aPIL2nRObVOta4eI4MA65SGefkxSR00RGqMGBTUuI652EI+0h0EdYE I1QCLPbNV6j7b2azont+octXSs2FrriaWx+ifLGuVKg2fGGI0tjEVmlTyHaXFNav48vTiD yzbt5WG/q5H8qbS0YbkkUtWS2Fnmc/8= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=wghMJcAX; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=adNbIuSh; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=wghMJcAX; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=adNbIuSh; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf27.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715770478; a=rsa-sha256; cv=none; b=aJGEKs6qrKvCgR4YS5XXePjCC9PTqCUiwTSDlX9hBW+vy18KIYRfCjqSxDKA/QC4sE06MA Uv0TIHPAqRIsvKPjLgNLqin6SAoCw6d/g2tKMuQTHGZOGZxyqs3MdRervUdly8CrEyvVLD w81aJ8nklBYrmvPKWX46U1G8MfVMlNw= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 10EB721FEC; Wed, 15 May 2024 10:54:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1715770476; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6jv9xWgEcYiTZtZfk0F4GwA5Qmgsj9Sim5edw+In6xE=; b=wghMJcAX1wHVTVEJ1QoIFPZ0piA5e1uAq6rd4zr0RvXLe47i8WOcZLRMKa6sDG9du9370A z0v4gplJD4re2RH6KD95ZbJF5/mdF1AGFIl8xlIMptY3WoNO2DAqZ1LaA+yRXIGqPRhLjz 696eY0ewpYovgoKTq1sXOTQVpuNeyhk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1715770476; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6jv9xWgEcYiTZtZfk0F4GwA5Qmgsj9Sim5edw+In6xE=; b=adNbIuShkFQwATA7ZymPl5DsSsG4uMUOfJXP6evMuVG0F2gCwQVnvirSvt7wOMeW8SRAQa C6aNNNl/uwLKy3CA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1715770476; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6jv9xWgEcYiTZtZfk0F4GwA5Qmgsj9Sim5edw+In6xE=; b=wghMJcAX1wHVTVEJ1QoIFPZ0piA5e1uAq6rd4zr0RvXLe47i8WOcZLRMKa6sDG9du9370A z0v4gplJD4re2RH6KD95ZbJF5/mdF1AGFIl8xlIMptY3WoNO2DAqZ1LaA+yRXIGqPRhLjz 696eY0ewpYovgoKTq1sXOTQVpuNeyhk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1715770476; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6jv9xWgEcYiTZtZfk0F4GwA5Qmgsj9Sim5edw+In6xE=; b=adNbIuShkFQwATA7ZymPl5DsSsG4uMUOfJXP6evMuVG0F2gCwQVnvirSvt7wOMeW8SRAQa C6aNNNl/uwLKy3CA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7CCF7139B3; Wed, 15 May 2024 10:54:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id UPO9G2qURGZLSgAAD6G6ig (envelope-from ); Wed, 15 May 2024 10:54:34 +0000 Date: Wed, 15 May 2024 12:54:33 +0200 From: Oscar Salvador To: Borislav Petkov Cc: Axel Rasmussen , Andrew Morton , Andy Lutomirski , "Aneesh Kumar K.V" , Christophe Leroy , Dave Hansen , David Hildenbrand , "H. Peter Anvin" , Helge Deller , Ingo Molnar , "James E.J. Bottomley" , John Hubbard , Liu Shixin , "Matthew Wilcox (Oracle)" , Michael Ellerman , Muchun Song , "Naveen N. Rao" , Nicholas Piggin , Peter Xu , Peter Zijlstra , Suren Baghdasaryan , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org Subject: Re: [PATCH v2 1/1] arch/fault: don't print logs for pte marker poison errors Message-ID: References: <20240510182926.763131-1-axelrasmussen@google.com> <20240510182926.763131-2-axelrasmussen@google.com> <20240515104142.GBZkSRZsa3cxJ3DKVy@fat_crate.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240515104142.GBZkSRZsa3cxJ3DKVy@fat_crate.local> X-Rspamd-Queue-Id: CC4CF4000F X-Stat-Signature: yph7kuyxw865ozh3tt13bcoqobxornbm X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1715770477-791215 X-HE-Meta: U2FsdGVkX1+xPqVG1TGaPNqTeAyJztICKetNLl0PvgRPw/v3IeYNwqVkH9ZXA1WZ0ImuQqGPTBMMPY6vn5e1lHROAiuO02ZgM4r2pqHDJXbbKm0xzheLjnY1NDOUk+tBVQfp+hBjDTNH7F0GaUxhetUZEQgXnrGSn4TYXmBeX1q4wERTcXjRbRuIi0Qk/kFw1yfXa1rnoi9swMY51h1sZujL0V6V/NA/aiXwJOWOHsE+mFv49esA4EvzS5jNYpmlEuf0e9WujihRP9VIWKZj+qTY1I7i2Mr+Emf02r41xS5A8/qqefLADVUYM2y/FrdFQx9bDpfjIuVk0sg5ya+VwuqcZWBkZfin1txPE+T8FOi3e2JfvApJkA0c6704JN5VKlkhQqUW4QCdyD7AKvvi7qX5sG6880dyFyAl96BkLWpXTRQiVkIob4+lMe3K3ms/rXp916b/pjQeWCcT3/Kvr/uw9lgOC5vSZV8eH1Wk1IxKKH9KOOMIVVX0mfc0k8pP6e6dedkjDzYegAadCnUBxwTONLS5rdZm5w/XzoHS7/DxWNV4I4pp8YekIXIzi6RpwE5e6LngwSUBXrZQHsEDmvDUkN3oJVEoBmkYsamoNGryACqRAwQMu/mXmxsyC/2NOWDWL7eaga4kxXcCM98aKdulBocf1IknB6i8219L9jdaqOtpCQCtB+/wTOtKHf+ukINwnJInilJaKFjEC4NPRibz+JyLhZSglPkqu8P3z6A7ztObihK0eNoQ976gHucxg9KR9bt4kR+PRiXDGhrLMsxG0uoyaaVAw6z/DwF4GJsCKgBYyb4/gmMx4s6a5MxpuF6S11ru0If6EIDfLNsVT++ET0AIvt7fAceA11p82ol6kzoaytbqLNtFglEplMWVmo8SVRaNPdRacAj2fnUsLbzWkBVH1MeKTBHsJFWhpjK5RoubT+JVcUomNlus/QWlTqLi6DY41yPddZvbpyQ Sm7+AuxE g/jOed+fbtb/aUKxIepZSsQeICYR9AB99d3ySZ4ALq/upzQmurRUWY9xcOPJ4baKdUpYEF8T5sYq8QzJ7YGi2B2Zoa8yZZqt6a3dHUaDDLzdGiHn5V1JDozSIsimSPAqAYAnfhGeBc9N3hfZdZRIBo2gsyUkT1BOMOX16kism3vY8Eq6YA9b082t7BKHQC7oJU60/NPYOSoXubN8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 15, 2024 at 12:41:42PM +0200, Borislav Petkov wrote: > On Fri, May 10, 2024 at 11:29:26AM -0700, Axel Rasmussen wrote: > > @@ -3938,7 +3938,7 @@ static vm_fault_t handle_pte_marker(struct vm_fault *vmf) > > > > /* Higher priority than uffd-wp when data corrupted */ > > if (marker & PTE_MARKER_POISONED) > > - return VM_FAULT_HWPOISON; > > + return VM_FAULT_HWPOISON | VM_FAULT_HWPOISON_SILENT; > > If you know here that this poisoning should be silent, why do you have > to make it all complicated and propagate it into arch code, waste > a separate VM_FAULT flag just for that instead of simply returning here > a VM_FAULT_COMPLETED or some other innocuous value which would stop > processing the fault? AFAIK, He only wants it to be silent wrt. the arch fault handler not screaming, but he still wants to be able to trigger force_sig_mceerr(). -- Oscar Salvador SUSE Labs